Thursday, 2024-04-11

*** ChanServ sets mode: +o sailbot06:42
*** rainemak__ is now known as rainemak06:54
rainemakgood morning06:55
ExTechOpGood Morning, everyone!06:57
rainemak#startmeeting Sailfish OS, open source, collaboration -- 11th April 202407:00
sailbotMeeting started Thu Apr 11 07:00:19 2024 UTC. The chair is rainemak. Information about MeetBot at http://wiki.debian.org/MeetBot.07:00
sailbotUseful Commands: #action #agreed #help #info #idea #link #topic.07:00
*** sailbot changes topic to " (Meeting topic: Sailfish OS, open source, collaboration -- 11th April 2024)"07:00
rainemak#info Meeting information and agenda can be found here:07:00
rainemak#link https://forum.sailfishos.org/t/community-meeting-on-11th-april-2024/1835907:00
rainemakI am the meeting's chairperson today, and will be doing my best to keep time and order. Please respect the timings and bee-hive.07:00
rainemak#topic Brief introduction (5 min). Please prefix your name/handle with #info07:00
*** sailbot changes topic to "Brief introduction (5 min). Please prefix your name/handle with #info (Meeting topic: Sailfish OS, open source, collaboration -- 11th April 2024)"07:00
flypig#info David Llewellyn-Jones, community07:02
rainemak#info Raine Mäkeläinen, sailor @ Jolla, chairperson today07:02
Thaodan#info Björn b07:03
Thaodan#info Björn Bidar , sailor @ Jolla07:03
pvuorela#info Pekka Vuorela, Jolla07:03
rainemakJolla sailors leading still :-)07:04
abr#info Andrew Branson, sailing by07:04
sebix[m]#info Sebix, community07:04
rainemakNo topic proposals for today's meeting.07:05
rainemakOnly bug discussion07:05
dcaliste#info Damien Caliste, community07:05
rainemak#topic Open PR discussion (5 mins -- asked by Jolla)07:05
*** sailbot changes topic to "Open PR discussion (5 mins -- asked by Jolla) (Meeting topic: Sailfish OS, open source, collaboration -- 11th April 2024)"07:05
rainemak#info <Jolla> Any open PRs to discuss?07:06
ExTechOp#info Otto Mäkelä, community07:06
rainemakdcaliste, flypig : do you have some?07:07
rainemakmaybe pvuorela knows?07:07
flypigNot from me today.07:07
dcalisteHello rainemak, I've some open PRs at the moment, but pvuorela is already taking care of them, thank you !07:07
rainemakalright, let's move on07:08
rainemak#topic Untracked bug reports (5 min -- asked by thigg)07:08
*** sailbot changes topic to "Untracked bug reports (5 min -- asked by thigg) (Meeting topic: Sailfish OS, open source, collaboration -- 11th April 2024)"07:08
rainemak#info <thigg> Untracked bug reports07:08
rainemak#link https://forum.sailfishos.org/t/community-meeting-on-11th-april-2024/18359/207:08
rainemak#info <Jolla> The Community Bug Coordination Team is back from well deserved back.07:08
rainemak#info <Jolla> As a result of their work, we now have:07:08
rainemak#info <Jolla> 8 high quality bug reports which are mostly recorded internally07:08
rainemakthere's no substitute option... well deserved break07:09
rainemakGood to see you back as well!07:10
flypigGreat work, and great to see the bugs being classified nicely again.07:10
rainemakOne was an opinion / thought / idea07:11
rainemakflypig, +107:11
flypigWhich one was the suggestion?07:12
rainemakthis one https://forum.sailfishos.org/t/4-character-security-code-is-partially-possible/1827907:12
rainemakit's not a bug per se07:13
flypigAh, yes, the last in the list.07:13
rainemakAny objections if we move forward already07:15
ExTechOp(I noted that the last SFOS update to 4.5.0.25 made the security code entry fully alphanumeric)07:15
rainemak.25 was only eula07:15
ThaodanI assume he means 4.5.0.x07:15
ExTechOp(ok, so it happened already before this)07:15
flypigAre you using it ExTechOp?07:16
flypigIt's really nice functionality and I'm curious to know how many people are using it (I don't expect there's any way to find out definitively).07:16
ExTechOpI still have a numeric security code from updating from an earlier version where it could only be numbers. It's fun finding reuse for old phone numbers permanently etched into your mind.07:17
flypig:D07:17
rainemakI'll steal some time from this... let's move to general discussion07:18
rainemak#topic General discussion (20 min)07:18
*** sailbot changes topic to "General discussion (20 min) (Meeting topic: Sailfish OS, open source, collaboration -- 11th April 2024)"07:18
rainemakI don't have any topic for this but I'd like to hear esr91 update from flypig07:19
rainemakHow's the webview looking like? (haven't read blog yesterday)07:20
flypigOh, I'd be happy to give one. I'm currently still stuck on offscreen rendering. I've narrowed down the problem to the fact that although the site is being rendered to the surface, the surface isn't being rendered to the screen.07:20
flypigSo I'm still trying to figure out why not. I think all the pieces are there, but like the original rendering, just one faulty flag can blow everything else up.07:21
rainemakAnd you have right glcontext created and bound07:21
rainemakright == only one07:21
flypigI believe so, yes. But there is obviously some break in the link that I'm missing.07:21
flypigSorry, some break in the *chain*.07:21
flypigBut I'll try to double check that the bind is happening correctly tonight.07:22
rainemakit has to be so that create gl context creates glcontext properly (that I saw in earlier blogs already)07:23
dcalisteAwesome dedication flypig, to make it work after such a long time !07:23
flypigThe glContext definitly works, in that I can see the rendering is happening to the texture. But I'm not sure how that ends up on the screen :(07:23
ExTechOpDoes anyone use the Danske Bank mobile application? It used to work, but I recently noticed that it just exits without doing anything. Dunno why, I've installed MicroG (because of MobilePay) and some other changes.07:23
rainemakI'm referring that CompositorOGL method that create gl context07:23
flypigThanks dcaliste, there are some parts I wish I could have tackled more quickly :)07:23
kamiltuxwhen will we get 4.6 image for 10 V?07:24
thilo[m]#info thigg, community07:24
thilo[m]Flypig: you have a milestone in gecko after which you have a big party planned? ;)07:24
rainemakExTechOp, next sauna release candidate has some banking app fixes07:24
ThaodanExTechOp: Maybe some kind of "protection" function against tampering? The s-pankki used to do something similar07:24
flypigrainemak, in CompositorOGL::Initialize()? "mGLContext = CreateContext()"?07:25
rainemakflypig, don't recall by heart but that sounds familiar07:26
flypigthilo[m], once the offscreen render is working, I'll generate patches, and then it will be time to celebrate (for me at least!).07:26
thilo[m]Cool, i'll prepare pictures ;)07:26
flypigrainemak, I'll check that part out carefully tonight. Thanks for the suggestion, appreciated!07:26
rainemak:-)07:26
flypigthilo[m], yes please!07:27
rainemakflypig, I doubt it's there07:27
flypigrainemak, every piece is worth checking.07:27
ExTechOpAlso, any of the developers here feel like making a mosh package? https://forum.sailfishos.org/t/easy-mosh-installation-on-sfos/1411807:28
rainemakflypig, and you got that front and backbuffer thingie sorted out07:28
flypigrainemak, I'm hesitant to say anything is sorted out until it's rendering properly, but I *think* so.07:29
rainemakflypig, I feel you07:29
flypigEvery time I do another pass of it I find something that's not quite right :O07:29
flypigIt keeps me out of trouble :)07:29
flypigExTechOp, I've never used mosh, but heard such good things about it.07:30
rainemakflypig, and you see that rasterizing step takes place07:30
flypigrainemak, yes, when I check the texture (e.g. using fReadPixels) I can see that the rendering is happening. That's going to be in the blog tonight.07:31
flypigSo I think most of it is working.07:32
rainemakflypig, fReadPixels is good07:32
flypigIndeed! Wish I'd done that earlier! (although earlier I might not have had happy results).07:32
rainemakfReadPixels is the way how qmozembed grabs to pixels as well07:33
rainemakflypig, sounds like something wrong in the swap07:33
rainemakflypig, have you tried to change gl clear color?07:34
flypigOkay, maybe I should take a look at the join between qmozembed and gecko then?07:34
flypigYes, I tried glClearColor (that's in the blog tonight as well). The change shows up with fReadPixels, but no on screen.07:34
flypig* but *not* on screen.07:35
rainemakhas to be that off screen is not there07:35
flypigCould you elaborate?07:35
flypigSorry for everyone else in the meeting. I don't want to monopolise the discussion, but this is super helpful for me :)07:36
rainemakwe didn't have any other topics07:36
rainemakI'd say... don't worry07:36
dcalisteNo problem flypig, that's an interesting discussion, I think.07:36
flypigThank you dcaliste :)07:37
abri'd be happy to see a whole meeting dedicated you helping you with your gecko effort :)07:37
flypigabr, be careful what you wish for, I've not got to video rendering properly yet ;)07:38
rainemakflypig, one thing worth looking is that gecko doesn't create any headless things in addition to what you're expecting it create07:39
flypigrainemak, how would that manifest itself? I've been careful to ensure there's only one display value created. Is there anything else to check for this you can think of?07:40
rainemakflypig, also gl makeCurrent and swap I'd check07:40
abrwow I know it was a large task but when you see one person tackle it in their spare time you really get the scale of it. So impressive that you're still at it. I hope you're still enjoying it!07:40
rainemakDeclarativeWebContainer::clearWindowSurface07:40
rainemak^ is that being called properly07:40
flypigabr, it's only big because I'm incompetent haha! If I was competent it would have been a much quicker task :D07:40
rainemakflypig, no you're not imcompotent! It's just a bug task.07:41
dcalisteDon't blame yourself flypig, "you're our only hope" ;op07:41
flypigHaha :)07:41
abrWhile the rest of us are just reading your blogs looking for words we might know07:42
flypigThat's in sailfish-browser rainemak? I've not checked that; I'll do so.07:42
rainemakflypig, I've done it once alone and once with you... and you know, it's a big task07:42
flypig(I didn't really change anything in sailfish-browser, but maybe there is a link missing somewhere in between).07:42
flypigThe fact you're reading is very motivating.07:43
abrit seems like this one needs more changes in the layers above than usual too07:43
flypigabr, specifically for offscreen rendering, it seems so. They completely removed the normal flow we use.07:43
abryes that sort of thing is rewrite time07:44
rainemakflypig, I guess you have tried it so that you have been pushing foreground app (browser) to background and raising something else to foreground and then browser back to foreground07:45
abrsorry don't mean to interrupt. please carry on! just wanted to agree that this is a meeting well spent if it's all on browser upgrade.07:45
flypigrainemak, I have, since that was causing hangs before, so I've been doing that a lot.07:45
flypigAlright, I'm going to check on the clearWindowSurface side of things and everything between that and CompositorOGL::EndFrame().07:45
rainemakabr, +1 for that07:45
rainemakflypig, that's at least scheduling glclear07:46
flypigOkay, that's useful to know. Then maybe I can put lots of readPixels in between the two to find out exactly which step is failing.07:46
flypigThis is really helpful. Thanks so much!07:47
rainemakalright, I guess that is about it07:47
rainemaknext meeting scheduling?07:47
flypigThank you for the great help and for indulging me.07:48
rainemak#topic Next meeting time and date (2 mins)07:49
*** sailbot changes topic to "Next meeting time and date (2 mins) (Meeting topic: Sailfish OS, open source, collaboration -- 11th April 2024)"07:49
rainemakProposing Thursday 25th April at 07:00am UTC07:49
flypigWorks for me!07:49
ExTechOpSame here.07:49
rainemakflypig, sorry for poking still07:52
flypigNot at all.07:52
rainemakit has to be before https://www.khronos.org/opengl/wiki/Framebuffer#Blitting as you're not even seeing clear color07:53
rainemak#info Next meeting will be held on Thursday 25th April 2024 at 07:00am UTC: 2024-04-25T0700Z07:53
rainemakthank you everybody07:55
ExTechOpThank you, everybody! Please feel free to continue your development discussion.07:55
flypigThank you rainemak and all!07:55
rainemakI'll do so07:55
rainemak#endmeeting07:55
sailbotMeeting ended Thu Apr 11 07:55:36 2024 UTC.07:55
sailbot Minutes: https://irclogs.sailfishos.org/meetings/sailfishos-meeting/2024/sailfishos-meeting.2024-04-11-07.00.html07:55
sailbot Minutes (text): https://irclogs.sailfishos.org/meetings/sailfishos-meeting/2024/sailfishos-meeting.2024-04-11-07.00.txt07:55
sailbot Log: https://irclogs.sailfishos.org/meetings/sailfishos-meeting/2024/sailfishos-meeting.2024-04-11-07.00.log.html07:55
*** sailbot changes topic to "Next meeting will be held on Thursday 11th April 2024 at 07:00am UTC: 2024-04-11T0700Z"07:55
dcalisteHave a nice day !07:55
xenial-userthanks07:56
rainemakflypig, and draw underlay is getting called properly as well? that call makeCurrent07:56
rainemakthat calls makeCurrent07:56
flypigOne second, let me check.07:57
rainemaklet me thing07:57
flypigThat's called in EmbedLiteCompositorBridgeParent::CompositeToDefaultTarget() ?07:57
rainemakit starts around there07:58
rainemakdid we remove on esr78 DrawUnderlay like methon ( there's still QMozWindowPrivate::DrawOverlay )07:59
rainemakhmm07:59
rainemakI'm not seeing that makeCurrent07:59
flypigThere is this?08:03
flypighttps://github.com/llewelld/gecko-dev/blob/9f64ce35a1875491ce9c9bc9ef3041f1f05ef3a7/embedding/embedlite/embedthread/EmbedLiteCompositorBridgeParent.cpp#L14808:03
flypigMy dev phone ran out of juice, so I'm just booting it up to check if this gets called.08:04
flypigAh, sorry rainemak, I have to drop off for work! But this is all useful stuff for me to follow up. I'll find out where MakeCurrent is happening and check that it's being called properly.08:07
rainemakflypig, I think that it nowadays09:09
rainemakflypig, QuickMozView::updatePaintNode I'd check this one as browser rendering works11:22
rainemaki.e. does getPlatform and MozMaterialNode::preprocess work as expected11:25
rainemakthinking if there's something wrong now with previous scenegraph integration11:26

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!