Monday, 2018-09-17

T4<RainSlide> 😶00:27
T4Varun (MISSING @USERNAME! was added by: Varun (MISSING @USERNAME!
*** ChanServ sets mode: +v T405:45
T4<adampigg> Abranson, if you could knock me.up a function that does i420 semiplanar > planar conversion thatd be great ;)07:02
abransonadampigg: the second one for the sony does packed semiplanar doesn't it? shouldn't be too different. but it'd be better to fix the blob - these manual conversions are slow07:04
piggzabranson: would that mean looking for a new blob from the vendor?07:21
piggzabranson: btw, that lib is gone in the los-15 branch ... only appears in the 14.1 branch07:23
abransonpiggz: i don't think a new blob would be possible. but maybe we need to use it differently in later devices07:24
T4<meierrom> @adampigg [Abranson, if you could knock me.up a function …], Is there no way to find the source of the problem? To start coding new functions sounds like worst case scenario.😉07:25
abransonmeierrom: the source of the problem is that the android apis we're using are not designed to do what we're doing with them :)07:31
piggzabranson: i did a quick test, the 2 versions in the 14.1 branch fail the same way07:31
abransonhmm, so they work but the colours are wrong?07:31
T4<meierrom> @abranson [meierrom: the source of the problem is that th …], I thought this problem is not general occuring on 2 phones only so far.07:37
r0kk3rz@meierrom: 3 phones that we happen to be porting to07:38
r0kk3rzthats more than a simple coincidence07:38
r0kk3rzbut yes, a lot of this os porting stuff is hacks upon hack upon hacks :D07:39
abransonmeierrom: these codecs don't use standard colour formats. they use device specific weird HAL formats that don't map onto standard gstreamer formats such as i420. that's fine when we're just displaying the format on a native surface, such as when you use the gallery app, but the browser doesn't support that so we have to present a colour format that it supports, and it doesn't do these.07:40
abransonusually you get a blob to convert these opaque formats to i420. you don't see what the internal format is, you just get i420 buffers out that the browser is happy with07:41
abransonbut recently we've had devices that either don't have that blob for foss reasons, or the blob doesn't work07:42
abransonso we've had to add extra handling to convert these buffers07:42
T4<meierrom> @abranson [so we've had to add extra handling to convert …], Thanks for explaining! 👍07:48
T4<meierrom> @r0kk3rz [thats more than a simple coincidence], OK. You have a point there.07:49
r0kk3rz@meierrom: also, this is all in our droidmedia/gst-droid framework, so its not that surprising that we need to write code for it07:51
abransonit could be that there's another colour conversion utility in android that we should be using, provided that it'll give us buffers that the browser can use07:53
abransonbut I think if these blobs are present then they should work, so we must be using them incorrectly somehow07:53
T4<adampigg> abranson: I did find a google patent on semi > planar conversion08:03
T4<meierrom> @r0kk3rz [@meierrom: also, this is all in our droidmedia …], I'm a bit worried these extra codes will lead to a poor experience on slower devices.08:20
Mister_Magistermal: ye seems like update went smooth af08:26
r0kk3rz@meierrom: don't be. sfos works pretty well on slow devices08:28
T4<meierrom> @r0kk3rz [@meierrom: don't be. sfos works pretty well on …], Generally that may be true but this issue is related to video displayed inside a browser. That's very tough.08:45
r0kk3rzif you've got a better way, im sure the jolla guys would love it hear it :P08:46
T4<meierrom> @r0kk3rz [if you've got a better way, im sure the jolla …], I wish I could but that's way above me :)08:49
r0kk3rz@meierrom: also, can you stop using the reply function in this channel?08:52
r0kk3rzits annoying to read in the IRC channel08:52
T4<meierrom> Oh sorry! I wasn't aware.08:57
elros1anybody tired this patch with omap: I am trying to adapt it for sunxi but udev events are still generated10:23
merbotLaunchpad bug 1234743 in systemd "omapfb module floods system with udev events on samsung galaxy nexus" [High,Fix released]10:23
malpiggz: it would be interesting to know how 15.1 base works for you, is that lineage-15.1 as good as 14.1 i.e. all features work?10:25
T4<abhishek_0> maybe i can try that too, that lib is also removed for me in 15.110:26
T4<abhishek_0> are all the 15.1 pr for hybris merged ?10:30
malno, libhybris is not, neither are the gps changes, not sure if something else is missing10:44
piggzmal: never used the los-15 .... but afaik, its good, i think many use it ... there is also a kerenl with treble support11:09
piggzmal: cant face the thought of rebasing everything....but, maybe its worth doing....11:24
piggzis a particular release/date of 15.1 recomended?11:24
malpiggz: I have been planning on rebasing 15.111:25
T4<adampigg> Mal, well, if you want me to work on it just say11:30
malI think ghosalmartin did it already at least partially11:31
ghosalmartinmal: its done, wanna attempt to merge it in? :P11:31
malghosalmartin: have you used it?11:32
malkrnlyng: ^11:32
ghosalmartinmal, well no, i cant get any devices to work11:32
ghosalmartinbut thats due to other reasons11:32
malbut it builds at least?11:32
ghosalmartinoh yeah11:32
ghosalmartini guess an example pr is here
ghosalmartinor here
ghosalmartinmal: yeah they defo build, i checked my manifest and they point to my org and not mer-hybris11:51
T4<abhishek_0> i syncing trees for 15.1 tho11:55
T4<abhishek_0> *i am11:58
piggzmal: abranson: was just looking at droidmedia, and I noticed I have a hack in mine to load AudioPolicyService ... does anyone else do that?13:45
malpiggz: I do13:48
malkimmoli also13:48
malI was planning on testing if it's still needed13:48
T4<BirdZhang> me too13:48
kimmoliits my hak13:50
kimmolias the usual "comment shutter sounds" is not helping13:53
malkrnlyng: you mean with audioflingerglue we don't need to comment out the shutter sound loading in frameworks/av?13:53
T4<abhishek_0> mal what are the gps changes ? i mean what repository ?14:11
T4<abhishek_0> for (hybris-15.1)14:12
piggzabranson: mall: would libI420colorconverter::convertDecoderOutputToI420 expect data in a particular format, and perhaps we are not supplying that format, if we have format 21?14:12
abransonpiggz: that blob is usually expecting the native output format of the codec iirc14:13
abransonso it should be implemented for that particular device14:14
piggzi found
mal@abhishek_0 you haven't learned yet what provides gps support? that is needed if device is using new gnss interface14:14
piggzso, i dont see how implementing it in software in gst-droid would be any slower :)14:14
malthe PR in that repo14:14
krnlyngmal, i think so14:20
malkrnlyng: hmm, I'll need to test that then14:21
krnlyngmal, i thought about it hard back then at least14:21
abransonpiggz: yeah, I don't think the device specific implementations are closed source because they use special fast code. most probably just because of the closed nature of the source colour formats14:21
T4gischpelino was added by: gischpelino14:26
T4<adampigg> Abranson, difficult to see how the interface could be misused....14:28
abransonadampigg: it's has some querying capability to see what format it's expecting14:29
T4<adampigg> I might just try and do it in sw....cant be too difficult to move bits around in an array correctly </famouslastwords>14:30
T4<adampigg> Abranson,  yeah, i saw that...ill see what my lib returns14:31
r0kk3rz@adampigg: twiddle the bits until it looks right ;)14:33
piggzabranson ... i added a log function that outputs this:15:38
piggz    ALOGE("PGZ decoder output format is %d", convert->getDecoderOutputFormat());15:38
piggzresult is 214139187515:38
piggzwhich is 0x7FA30C0315:38
piggzwhich is in
piggzand is OMX_QCOM_COLOR_FormatYUV420PackedSemiPlanar64x32Tile2m8ka15:39
piggzsome stuff here
piggznot sure if any of that helps!15:41
T4<abhishek_0> lol what
T4Donieck was added by: Donieck15:55
mal@abhishek_0 what is the problem, it clearly says what you have to do, or did that start to happen unexpectedly?16:15
T4<abhishek_0> Actually this is unexpected, I know the solution. Since device trees are all arm it was weird to see that message16:19
malit seems lineage-15.1 is different16:22
piggzabranson: some more info on that format
piggzincludes a conversion routine17:02
malpiggz: wow, that's a huge function17:06
piggzmal: i know!17:07
piggzit must be a friggin complex format17:07
piggzi probably wasnt gonna work that out :D17:07
piggzmal: looks like it outputs to 3 seperate buffers, gst-droid expects 1...17:10
r0kk3rzdude needs to learn what a function is17:10
r0kk3rzits probably converting to a different format than the one you need17:14
T4<abhishek_0> mal seems like script is not smart17:17
piggzit converts to regulat yuv420planar, which i think cab be used17:17
mal@abhishek_0 that's one of the reasons why the PR is not merged17:17
T4<abhishek_0> it should have taken this
*** ChanServ sets mode: +v T417:39
mal@abhishek_0 it uses grep, it doesn't check for that other value17:44
T4<abhishek_0> or we can just tell it not look at common trees at all , they contain code for all other devices too17:47
T4<abhishek_0> okay nvm ,, not a good solution17:48
malthat is the reason why it has the option for override17:48
T4<abhishek_0> didnt knew about that tho18:25
T4<abhishek_0> here libhybris fails to build18:25
malas mentioned before here, add back the removed nfc lines to spec18:28
T4<abhishek_0> not sure which nfc line you are mentioning here ,18:29
T4<abhishek_0> havent removed anything18:29
malthe android8-initial branch has some stuff removed from spec compared to master branch18:33
T4<abhishek_0> let me check18:36
T4<abhishek_0> oh .. nfc stuff was removed tho18:36
T4<abhishek_0> not sure why it is commented out ?18:37
malbecause aosp builds didn't provide the needed headers18:39
T4<abhishek_0> so de-commenting the commented stuff is the solution ?18:50
T4<VeryOriginalUsername> Check if it doesn't break anything18:54
T4<VeryOriginalUsername> Or does it even work 🤔18:54
T4<abhishek_0> well device doesnt even have nfc so :shrug:18:59
T4<VeryOriginalUsername> That's a good point too19:02
T4<VeryOriginalUsername> (Document)
piggzmal: well, so far, my attempt to implement that function has given me a purple and green screen20:44
piggzr0kk3rz: commenting out the asserts that were failing probably didnt help it render correctly :D20:50

Generated by 2.17.1 by Marius Gedminas - find it at!