| vknecht | wonder why when the image is first opened in jolla-gallery from h-a-c, the "info" and "edit" button are missing... https://pastebin.com/2pDyQ0bw | 10:08 |
|---|---|---|
| vknecht | but have greater problem to solve first, like generating a scaled down version to display in h-a-c slideshow/gallery and cache this so it doesn't lag on opening | 10:11 |
| vknecht | guess I'd need a https://doc.qt.io/qt-5/qquickimageprovider.html ? | 10:12 |
| vknecht | or a proper model... | 10:12 |
| vknecht | thought I could (re)use "id: photo" Image but doesn't work, slideshow shows the latest one for all images XD | 10:14 |
| vknecht | sorry for the sunday morning ugly-code drop :-P | 10:23 |
| Mister_Magister | mal: ping nothing provides pkgconfig(systemsettings) >= 0.5.5 in geoclue-providers-hybris | 12:17 |
| vknecht | gotta use a bit older revision iirc | 12:18 |
| Mister_Magister | 2018? kek | 12:18 |
| vknecht | 38ef0f1d8a56b56db5bfe99fdb88b9a0e684ca6d ? | 12:19 |
| Mister_Magister | ed5e33178ae5af4e03c4c13a0d4e5bc7c0ed7349 | 12:19 |
| * vknecht 's source : https://build.merproject.org/package/view_file/nemo:testing:hw:fairphone:fp2-sibon/geoclue-providers-hybris/_service?expand=1 ;-) | 12:20 | |
| Mister_Magister | vknecht: well i will try my one it's a bit newer | 12:20 |
| vknecht | there's FAQ line 700, too, depending on the base | 12:23 |
| vknecht | a little start... https://github.com/piggz/harbour-advanced-camera/pull/8 | 15:38 |
| mal | vknecht: I'm doing some major refactoring of the code, separating settings to separate files, one for UI and one for backend | 15:44 |
| vknecht | no problemo, I'll see to redo after the change | 15:46 |
| mal | vknecht: based on quick look your code should mostly work | 15:47 |
| mal | vknecht: with my changes that is | 15:48 |
| vknecht | cool :) | 15:48 |
| mal | vknecht: maybe your code should be merged first | 15:48 |
| mal | vknecht: I'll test it after I have eaten something first | 15:49 |
| * vknecht should eat too | 15:49 | |
| vknecht | bon apétit :) | 15:49 |
| mal | vknecht: some comments added | 17:21 |
| vknecht | mal, thanks ; handled most of those, have to read about the margins | 18:51 |
| vknecht | sorry if I shouldn't have clicked "resolved" but just "comment", 1st time using this iirc | 18:53 |
| mal | vknecht: margins and paddings are defined in Theme https://sailfishos.org/develop/docs/silica/qml-sailfishsilica-sailfish-silica-theme.html/ | 19:10 |
| vknecht | just sent a mod using Theme.paddingMedium | 19:11 |
| mal | vknecht: a tiny suggestion from here https://doc.qt.io/archives/qt-4.8/qml-coding-conventions.html#grouped-properties | 19:17 |
| mal | for anchors for example | 19:18 |
| mal | although we probably have many places where that is "wrong" already, I can cleanup those later | 19:18 |
| mal | vknecht: I'll test your code again and if it works nicely then it can be merged | 19:19 |
| vknecht | thanks :) | 19:20 |
| mal | vknecht: my settings changes are getting out of hand :) | 19:20 |
| mal | vknecht: a small thing I noticed, would it be more logical that the gallery view would open with the last taken image? | 19:24 |
| mal | so it would open at the end and then user can go back in history by swiping | 19:25 |
| vknecht | ah yes | 19:25 |
| mal | otherwise seems good | 19:26 |
| vknecht | a sort of pitfall is that after opening a shot in jolla-gallery by clicking, if one removes it, it doesn't disappear in h-a-c slideshow | 19:27 |
| vknecht | but handling that is over my head for now | 19:28 |
| kimmoli | doesn't tracker have dbus? | 19:28 |
| mal | vknecht: not sure if we even should keep a separate log of pictures, maybe just opening the Pictures/Camera and Videos/Camera in that would maybe make more sense? | 19:29 |
| vknecht | you mean, clicking any pic in h-a-c slideshow open general jolla-gallery view ? | 19:31 |
| vknecht | or rather, yes, the picture or video part, depending on the (future) current photo/cam mode ? | 19:32 |
| mal | vknecht: not general jolla-gallery view, a limited one to only pictures and videos taken with camera, the same way in official camera app | 19:33 |
| vknecht | ok ; well yes, but that's not something I can do shortly... and have to get this 3.0.1.11 release out before the next one comes ;-) | 19:34 |
| mal | vknecht: sure | 19:34 |
| vknecht | let's see about "last take pic first"... | 19:35 |
| vknecht | *taken | 19:35 |
| mal | vknecht: slideshowview is based on https://doc.qt.io/qt-5/qml-qtquick-pathview.html so check that | 19:55 |
| vknecht | thanks, looks like "currentIndex: count - 1" does it | 20:01 |
| mal | vknecht: could you squash the commits in the PR to one? i.e. interactive rebase and force push | 20:11 |
| * vknecht reads https://help.github.com/en/articles/about-pull-request-merges | 20:13 | |
| mal | vknecht: are you editing in website and not via normal git commandline tool? | 20:14 |
| mal | vknecht: it seems I could also squash it then | 20:14 |
| vknecht | I edited the files locally then pushed with git | 20:15 |
| mal | ok, then git rebase -i hash_before_your_first_new_commit and then the view will tell how to do it | 20:16 |
| mal | vknecht: git rebase -i is the best way and very simple | 20:17 |
| vknecht | squash, not fixup ? | 20:23 |
| mal | vknecht: fixup is better in this case since you don't need the latter commit messages | 20:23 |
| vknecht | mal, I think it's ok, force pushed that | 20:25 |
| vknecht | thanks for learning me yet another thing :) | 20:25 |
| mal | vknecht: oops, piggz just merged his PR and now you have to rebase again, sorry | 20:28 |
| mal | vknecht: at least this is good practice for git use | 20:29 |
| kimmoli | working on branches makes life a bit easier if master is living | 20:31 |
| mal | kimmoli: yep | 20:31 |
| mal | kimmoli: in this case a feature branch is used | 20:32 |
| vknecht | just have to "rebase -i" like beforre, keeping pick on the first and only line, then force push again ? | 20:34 |
| vknecht | or have to fetch or pull something first ? | 20:35 |
| mal | vknecht: no, do git fetch origin (or upstream or what ever is the piggz remote) then git rebase origin/master | 20:35 |
| mal | if you don't have piggz github as remote then do git remote add upstream https://github.com/piggz/harbour-advanced-camera.git and then use upstream as remote in the previous commands I gave | 20:38 |
| mal | git remote -v lists remotes | 20:39 |
| vknecht | alright, I'm getting to the conflict, let's see... | 20:39 |
| piggz | @eugenio_g7 hows things | 20:55 |
| vknecht | strange, tapping for focus sometimes takes a shot (or at least plays the anim) | 20:56 |
| piggz | shouldnt ... but lets see what happens after mas big merge | 20:57 |
| mal | piggz: I need to limit what I change in next PR so it won't be too big | 20:57 |
| T4 | <eugenio_g7> piggz: changed battery but haven't messed up yet with the SW | 21:00 |
| T4 | <eugenio_g7> will probably do so later in the night once the football match ends :P | 21:00 |
| T4 | <eugenio_g7> some news from your front? | 21:00 |
| piggz | @eugenio_g7 no, apart from i built a greenhouse today :D | 21:01 |
| piggz | i was holding off releasing until you were happy with the sensors | 21:01 |
| T4 | <eugenio_g7> cool :D | 21:01 |
| piggz | the afater that we can work on next stage stuff | 21:01 |
| T4 | <eugenio_g7> yea hope to fix things up on the sensors side tonight :) | 21:02 |
| piggz | gr8 | 21:02 |
| mal | vknecht: any problems with rebase? | 21:10 |
| vknecht | mal, seems ok, conflict was simple enough, and confirmed the behaviour is the same than with current master CameraUI.qml | 21:11 |
| mal | looks like you just pushed it | 21:11 |
| mal | ok | 21:11 |
| vknecht | maybe was just surprised that search and lock uses flash | 21:12 |
| vknecht | or something, which make it look like it takes a shot | 21:12 |
| mal | vknecht: yes, I noticed that also, in automatic flash mode it uses flash to get lock | 21:13 |
| mal | vknecht: just made a quick test with your rebased code and still works fine, merging | 21:14 |
| vknecht | thank you | 21:14 |
| piggz | vknecht: thx, nice addition | 21:35 |
| piggz | mal: if you are fixing, did you fix imageProcessing.colorFilter: ? | 21:35 |
| vknecht | yw :) | 21:36 |
| mal | piggz: which part of it? | 21:42 |
| piggz | mal: should be ColorfilterNone | 21:42 |
| piggz | Normal doesnt exist | 21:42 |
| piggz | i was gonna pushut didnt want to make a conflict for u | 21:43 |
| mal | piggz: yes, I fixed that in my new code | 21:43 |
| piggz | k | 21:43 |
| mal | piggz: if you have some changes you want to push go ahead, I can always rebase | 21:43 |
| piggz | mal: vknecht: push some icons for focus modes | 22:12 |
| piggz | s/pushed | 22:12 |
| mal | piggz: nice | 22:21 |
| piggz | mal: well, i didnt think the hyperfocs one was very adventusous, but i couldnt find what other camera apps use! | 22:23 |
| piggz | mal: it would be nice if they worked with your changes for themes | 22:25 |
| mal | piggz: I'll test | 22:25 |
| mal | piggz: I broke menus in my latest code :P | 22:25 |
| piggz | odd, my phone claims to no longer suppoer hDR :D | 22:29 |
| piggz | its back after going back to regular qt version | 22:32 |
| piggz | off now, later ppl! | 22:35 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!