| T4 | austenite was added by: austenite | 05:35 |
|---|---|---|
| vknecht | Mal, Piggz: hello :-) I didn't give up on adding other buttons like eg. "Share", so that's why there's rowBottom | 06:06 |
| sledges | PSA: SFOS community collab. disucussion in #mer-meeting in just under half-hour | 08:34 |
| heroic_1 | Hey, is there an agreed-upon folder location for the hybris parts? For the HABUILD_SDK, there is ANDROID_ROOT="$HOME/hadk", but where are the "rpm/", "rpm/dhd/", "hybris", "hybris/mw/*" etc folders supposed to be? | 11:56 |
| heroic_1 | Reason I'm asking is that I'd like to reference a shared helper script from d-h-d in hybris-boot, but I guess I'll have to put the helper script into hybris-boot for now | 11:57 |
| T4 | vvreddy was added by: vvreddy | 13:36 |
| *** OhYash1 is now known as ohyash | 15:08 | |
| heroic_1 | I have a proposal for pushing the mountpoint info for the fixup-mountpoints operation to the device repos instead: https://github.com/marina-bay/droid-hal-device/commits/generalized-fixup-mountpoints , then add the mapping in the droid-hal-$DEVICE folder like this: https://github.com/marina-bay/droid-hal-sony-tone/commit/d76f63e3e9b21dd7a0c74154627ebab2aa0edf63 , then switch hybris-boot to it as well: https://github | 19:58 |
| heroic_1 | .com/marina-bay/hybris-boot/commit/97e322c65e55873b15f97c58073fe69c4054a964 | 19:58 |
| heroic_1 | It's more of a mockup at this point, but I think it's not sustainable to keep the mountpoint info in one unwieldy bash script in hybris-boot, especially considering no one seems to feel responsible for merging new fixup PRs(thus forcing everyone to use forks) | 20:00 |
| mal | heroic_1: you know you can use the existing hybris-boot repo as submodule to add custom fixup? | 20:02 |
| mal | so no need to fork it really | 20:03 |
| heroic_1 | mal: I did not know that(although I see it in Android.mk now with the ../fixup-mountpoints inclusion) but I'm not seeing anyone do it | 20:17 |
| mal | it's not widely know feature | 20:18 |
| mal | *known | 20:18 |
| heroic_1 | Can we nevertheless add some logic to HABUILD_SDK to let it know about the PLATFORM_SDK side of things? | 20:18 |
| heroic_1 | Just advise people to set e.g. PLATFORM_SDK_ROOT or sth | 20:18 |
| mal | ? | 20:18 |
| heroic_1 | Although that may clash with the location of /srv/mer | 20:19 |
| mal | not sure what you mean | 20:19 |
| heroic_1 | mal: When droid-hal-* stuff references Android stuff, we can depend on $ANDROID_ROOT being available | 20:19 |
| heroic_1 | But no such thing exists(that I know of) to do it in the other direction | 20:20 |
| mal | that is available both in HABUILD and PLATFORM_SDK | 20:20 |
| mal | what is the exact problem? | 20:20 |
| heroic_1 | Say you structure the sailfish/mer side of things in /home/user/sailfish. Let's say that is $PLATFORM_SDK_ROOT | 20:21 |
| heroic_1 | And have the HABUILD_SDK stuff in /home/user/hadk | 20:21 |
| heroic_1 | Following so far? | 20:21 |
| mal | no | 20:21 |
| heroic_1 | Ok, where do you put your sailfish stuff when you build locally then? I mean any location will do | 20:22 |
| mal | $ANDROID_ROOT | 20:22 |
| heroic_1 | That's what I personally do too, but there is nothing in the HADK or anywhere that mandates this | 20:22 |
| mal | you are probably overthinking this | 20:23 |
| heroic_1 | Can we either have a variable or mandate it | 20:23 |
| mal | I really cannot understand what the problem is | 20:23 |
| mal | you can use platform sdk to build anywhere if you want to build some random packages | 20:23 |
| heroic_1 | mal, every time I have some suggestion to improve the horribly hack-ish way stuff is done in mer/sailfish, you say stuff is fine as it is | 20:24 |
| mal | but for actual porting stuff you anyway use build_packages.sh | 20:24 |
| heroic_1 | Can I convince you that some stuff could be improved, if only we changed a few basic things | 20:24 |
| mal | heroic_1: you need to give some problem you want to solve | 20:24 |
| mal | we also need to take into account OBS builds | 20:25 |
| heroic_1 | I know OBS complicates stuff, yes | 20:25 |
| mal | also we cannot break compatibility too much | 20:26 |
| heroic_1 | There are some other things that I'd like to improve that depend on knowing the root of the PLATFORM_SDK and droid-*-* repos being in certain places | 20:27 |
| heroic_1 | But without having such a mechanism I don't really know how to even approach them without lots of "if [ -d ...]" stuff | 20:28 |
| mal | I cannot understand why you want something to depend on root of platform_sdk, I mean there is no root in there, ANDROID_ROOT is the only thing | 20:28 |
| heroic_1 | Yeah, then let's mandate that people start any sailfish stuff at $ANDROID_ROOT | 20:29 |
| mal | what do you mean, I'm still completely missing the point | 20:29 |
| mal | during ehat build do you want to change something? | 20:30 |
| mal | *what | 20:30 |
| heroic_1 | during the sailfish build process | 20:30 |
| mal | which step of it? | 20:30 |
| heroic_1 | e.g. d-h-d | 20:30 |
| heroic_1 | But I get that you'd want stuff separated | 20:31 |
| mal | so what is wrong with the current way of having dhd in ANDROID_ROOT | 20:31 |
| mal | I'm probably missing some fundamental part of information | 20:31 |
| heroic_1 | My wish would be that for any sailfish build you do, you can depend on droid-config-$DEVICE, droid-hal-$DEVICE and droid-hal-version-$DEVICE being available | 20:31 |
| heroic_1 | So you do not have to specify things in every repo again | 20:32 |
| heroic_1 | one rpm_device | 20:32 |
| heroic_1 | one straggler_files | 20:32 |
| heroic_1 | etc etc | 20:32 |
| heroic_1 | *available in a static location | 20:32 |
| mal | what repo? | 20:32 |
| heroic_1 | every repo | 20:32 |
| heroic_1 | d-h-c defines rpm_device | 20:33 |
| heroic_1 | d-h-d defines rpm_device, etc | 20:33 |
| mal | you do know that those are built separately on OBS? | 20:33 |
| heroic_1 | I know, but for obs you could still sync the repos to an agreed-upon locatoin | 20:33 |
| heroic_1 | *location. The're a few kilobytes max each | 20:34 |
| heroic_1 | ok megs but you get the point | 20:34 |
| mal | I really don't get it | 20:34 |
| mal | those repos are device specific so obviously you need to define which device it is | 20:35 |
| heroic_1 | you wouldn't need to though if you had already defined e.g. rpm_device in droid-config-$DEVICE | 20:36 |
| heroic_1 | let your mind run wild with the possibilites | 20:37 |
| heroic_1 | not only reduced code duplication, think further | 20:37 |
| mal | so then droid-hal would depend on droid-config | 20:38 |
| heroic_1 | yes | 20:38 |
| heroic_1 | in a way | 20:38 |
| heroic_1 | at build time at least | 20:38 |
| heroic_1 | and tbh most droid-* stuff is already highly interdependent already | 20:39 |
| heroic_1 | e.g. you cannot build droid-hal-img-boot-$DEVICE without first having built droid-hal-$DEVICE-kernel | 20:40 |
| mal | that would probable require a lot of changes to .inc files probably | 20:40 |
| heroic_1 | mal: I guess our philosophical differences come from your background in linux and rpm packaging, whereas I'm used to Android monolithm | 20:41 |
| heroic_1 | The latter is more suitable to building device configs imo | 20:41 |
| heroic_1 | And yes, we'd have to think of backward compatibility | 20:41 |
| heroic_1 | I would write very clear transition guides | 20:41 |
| mal | pretty sure we don't want to break official devices | 20:42 |
| heroic_1 | The first step would only be to even define some kind of boundaries | 20:42 |
| mal | I still find it odd to do so much work because we duplicate few lines | 20:42 |
| heroic_1 | would you agree that my change to the fixup-mountpoints is more elagant and declarative? | 20:44 |
| heroic_1 | *elegant | 20:44 |
| mal | does it handle this https://github.com/mer-hybris/hybris-boot/blob/master/fixup-mountpoints#L527 | 20:52 |
| heroic_1 | we can change the syntax, e.g. "block" "" | 20:54 |
| heroic_1 | or "/block" "/" | 20:54 |
| heroic_1 | it's a matter of changing the awk statements | 20:55 |
| heroic_1 | hmm you don't even need the quotes, just: | 20:56 |
| heroic_1 | /block/ / | 20:57 |
| heroic_1 | And I have a wish for sledges or whoever creates packages for the jolla repos: add "initrd-helpers", "hw-ramdisk" and "yamui" packages | 21:04 |
| heroic_1 | I made a PR to build them automatically https://github.com/mer-hybris/droid-hal-device/pull/206 but I think it would be better if they were available in the repos already | 21:05 |
| vknecht | hmmm, https://openrepos.net/content/olf/sfos-upgrade | 23:00 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!