| mal | I was reviewing and testing some stuff | 00:00 |
|---|---|---|
| Thaodan | changes in middlewhere like those that were merged to droidmedia? | 00:01 |
| mal | that also, and some of those droid-hal-device changes also | 00:02 |
| mal | those will make local builds a bit easier | 00:03 |
| Thaodan | which ones do you mean? | 00:03 |
| Thaodan | ah you mean the one from sledges ? | 00:04 |
| mal | yes, in hybris-boot and droid-hal-device | 00:06 |
| Thaodan | ah great makes sense. | 00:09 |
| Thaodan | I've updated the android pr with the last errors that I've got. I'm still guessing which has changes brought the error | 00:43 |
| rinigus | I am trying to setup rndis connection during a boot (device sony/xz2, aosp9 based). right now its all limited to hybris-boot. as stock android has rndis support which works, I am trying to reproduce its configfs configuration. | 11:32 |
| rinigus | here is a summary of changed init script, dmesg in hybris with failure to start rndis, and section of dmesg that's missing in hybris, but available in aosp9: https://pastebin.com/RePZNCEi | 11:33 |
| mal | check channel logs for RNDIS | 11:33 |
| rinigus | mal: where are those? | 11:34 |
| rinigus | (mal sorry, figured out) | 11:34 |
| rinigus | mal: I did look into channel logs, but it doesn't seem to work for me. I probably haven't tested all possible forms over here, but quite a few. | 11:35 |
| rinigus | ... so, I was thinking that as it works on aosp9, it should be possible to reproduce its config | 11:36 |
| rinigus | mal: essentially, I followed your advice as in https://piggz.co.uk/sailfishos-porters-archive/index.php?log=2019-08-17.txt#line119 (found the way its initialized in aosp9, corresponding function name for configfs, but still no success) | 11:45 |
| mal | rinigus: at which point of boot are you now? | 11:58 |
| rinigus | mal: same as before - failing on the initial one. I am now having aosp9 installed and working on setting up rndis using aosp9/userdata for dumping the logs. idea is to setup network during boot, so I can properly see what's missing when I boot sfos | 12:00 |
| rinigus | in this respect - at https://github.com/sailfishos-sony-tama/hybris-boot/blob/tama-akari/init-script#L270 | 12:01 |
| mal | did you do the kernel usb changes mentioned in logs? | 12:02 |
| rinigus | mal: those I did before, now I started to retest them again. | 12:02 |
| rinigus | CONFIG_USB_CONFIGFS_QCRNDIS=y CONFIG_USB_CONFIGFS_RMNET_BAM=y CONFIG_IPA=y | 12:03 |
| rinigus | just added | 12:03 |
| mal | https://piggz.co.uk/sailfishos-porters-archive/index.php?log=2019-02-16.txt#line70 | 12:05 |
| mal | that has a bit different ones | 12:05 |
| rinigus | mal: I'll try those. but then its not really clear what's going to be used for starting rndis via configfs | 12:08 |
| rinigus | mal: test with options that I mentioned above didn't work either | 12:09 |
| rinigus | ... fails with the same "id0:gsi_bind: ipa ready timeout \n configfs-gadget a600000.dwc3: failed to start g1: -110" | 12:09 |
| T42 | <elros34> looks like ipastart_sh triggers loading ipa firmware which will be not available in hybris-boot so gsi will not work | 12:14 |
| mal | rinigus: that is needed only for early development, after you have sfos running then you can revert that and configure usb-moded correctly | 12:16 |
| rinigus | elros34: indeed, looks like that way. | 12:16 |
| rinigus | mal: its true. maybe then I will see if I can setup logging of init troubles somewhere else, like sdcard. | 12:17 |
| mal | rinigus: so look in logs for RNDIS and surrounding lines and see if you find something | 12:17 |
| rinigus | mal: if I use recommended settings, I get https://pastebin.com/FyMbj9HN | 12:18 |
| rinigus | at the same time, mkdir: can't create directory '/config/usb_gadget/g1/functions/rndis.usb0': | 12:19 |
| rinigus | recommended are the ones which I mentioned above (CONFIG_USB_CONFIGFS_QCRNDIS=y CONFIG_USB_CONFIGFS_RMNET_BAM=y CONFIG_IPA=y) | 12:19 |
| rinigus | haven't tried with your ones | 12:19 |
| mal | so try with the ones I gave, those must have been in logs for a reason | 12:20 |
| mal | like my testing on some devices | 12:20 |
| rinigus | mal: that fails with compilation of kernel - https://pastebin.com/E6TRvD3X . | 12:23 |
| mal | fix it | 12:25 |
| rinigus | :) | 12:25 |
| rinigus | ok | 12:25 |
| rinigus | mal: its actually fails all over the place with rndis.o - https://pastebin.com/5e70iKJn | 12:59 |
| rinigus | looks like some kernel option is missing ... | 13:00 |
| T42 | <elros34> have you disabled GSI in defconfig? | 13:01 |
| T42 | <elros34> at least these USB*_GSI | 13:03 |
| rinigus | elros34: no, will ltry | 13:03 |
| rinigus | elros34: #CONFIG_USB_CONFIGFS_F_GSI=y helped to compile the kernel. let's see if that helps with rndis | 13:07 |
| rinigus | mal & elrso34: and I have rndis!!! | 13:09 |
| rinigus | ... and I can even login. thank you! | 13:10 |
| mal | good | 13:11 |
| mal | I will try to add the new hadk faq online soon so we can add such things there | 13:12 |
| T42 | <elros34> mal: can't we use https://wiki.merproject.org/wiki/Adaptations/faq-hadk? | 13:13 |
| mal | @elros34 we decided to add a faq repo to mer-hybris github which can have nice formatting also, in addition to that more people have github account than mer account | 13:14 |
| T42 | <elros34> ah great | 13:15 |
| T42 | <DylanVanAssche> mal: Can I have access to native-common on OBS? I want to trigger a build for `geoclue-provider-gpsd3`.. | 13:15 |
| rinigus | mal: great idea regarding github | 13:15 |
| mal | @DylanVanAssche done | 13:16 |
| T42 | <DylanVanAssche> mal: Thanks! And good idea for the FAQ repo, it will be more visible too :D | 13:16 |
| mal | I still have some parts of faq to cleanup before pushing it there | 13:16 |
| mal | also git log is nice for seeing what has been changed | 13:16 |
| T42 | <DylanVanAssche> Indeed! | 13:17 |
| mal | also we can even review changes nicely | 13:17 |
| Thaodan | Is there a good why to get where a file was recursively included in c++ headers? | 13:45 |
| Thaodan | I think camera headers now include stagefright | 13:45 |
| T42 | SauravDharwadkar was added by: SauravDharwadkar | 14:42 |
| Thaodan | I found out ICameraService.h pulls in stagefright | 14:48 |
| mal | rinigus: @elros34 @DylanVanAssche comments welcome https://github.com/mer-hybris/hadk-faq | 15:32 |
| deathmist | would the new dhd submodule updates allow me to define pre-downgraded packages such as ofono-ril-binder-plugin & nfcd-binder-plugin in my manifest files (e.g. ".repo/local_manifests/middleware.xml") and when are they built anyway? I'm assuming at the end of build_packages | 15:43 |
| vknecht | 👍 looks beautiful and well organized :-) | 15:43 |
| deathmist | currently I have a rather crappy solution https://git.io/JeEi8 and modify the entire script with the ones I need :p | 15:44 |
| mal | deathmist: the new dhd submodule doesn't pull repo updates automatically unless you add --pull (or -p) switch to build_packages.sh, so if you do git reset to older version in some package and don't use --pull then you can just use build_packages.sh and no need to skip anything | 15:45 |
| mal | vknecht: there may be parts that could do some more formatting but that was just a quick formatting I did | 15:45 |
| deathmist | mal: looks very neat, but I saw my sources linked there for disabled_services.rc xD I need to clean that up as I import some vendor init.rc script after disabling qti & time_daemon (thinking of utilizing the brand new service override-disable method introduced in Pie instead) | 15:47 |
| mal | deathmist: oh, ok | 15:47 |
| rinigus | mal: looking good! | 15:48 |
| rinigus | ^ hadk-faq | 15:48 |
| rinigus | mal, hadk-faq: does hybris-16 require source code patches as well? that seem to be missing in 3.3 | 15:49 |
| vknecht | iirc one of the latest addition to faq not in backups was a spreadtrum/mediatek entry, any way to recover that ? | 15:50 |
| * vknecht dug all his caches for some trace of faq, but failed | 15:50 | |
| mal | rinigus: 16.0 part needs fixing, it's also missing ldconfig fix | 15:53 |
| mal | vknecht: too bad there was no newer version available | 15:53 |
| mal | pull requests welcome | 15:54 |
| rinigus | mal: now we just have to point url at room topic to it | 15:57 |
| mal | rinigus: not sure who has permissions for that | 16:02 |
| rinigus | mal: probably room admins, but don't know how it works for irc | 16:14 |
| mal | on IRC ops can do that | 16:14 |
| mal | vknecht: I tried your cam snapshot PR, it doesn't work, I get "FrameGrabber::emitVideoFrameProbed:57 - Unable to save" and then a path that looks ok | 16:55 |
| T42 | <DylanVanAssche> mal: Looks nice! Much more structured than the previous version! | 16:56 |
| vknecht | oh ? | 17:01 |
| vknecht | will check | 17:01 |
| mal | vknecht: also, if I have video player page open in cam app and then swipe the app to background and bring back to front video cannot be played anymore until I close the gallery part of the app and go back from camera view to that | 17:03 |
| mal | that happens at least if I had already played the video | 17:04 |
| vknecht | this probably has to do with https://github.com/piggz/harbour-advanced-camera/pull/85 | 17:04 |
| mal | probably | 17:05 |
| vknecht | camera.start()/cam running breaks mediaplayer, for some reason | 17:06 |
| mal | seems to fix the issue | 17:08 |
| mal | vknecht: in the future could you capitalize the first letter of the commit message (after the tag obviously), I like good looking commit messages, in that PR you could add the clarification another line (in git message the main commit message is in first line, then after an empty line you can add more lines if needed for additional info) | 17:10 |
| vknecht | no problemo | 17:12 |
| mal | vknecht: in that message you can see that the first line is a bit long and is clipped in the github view | 17:13 |
| vknecht | yes, d*mn github doesn't respect 79 char column convention :-P | 17:15 |
| mal | vknecht: some sites suggest using 50/72 rule for commit message, first line max 50 chars and others 72 | 17:19 |
| vknecht | ok, working on one at 48 ([videoplayer] Fix playing after regaining focus) | 17:21 |
| mal | looks ok, I think it should not be a strict rule but as a guideline, the parenthesis you had we not needed on first line anyway | 17:23 |
| vknecht | thanks :-) | 17:28 |
| T42 | <DylanVanAssche> mal: Indeed, compass apps don't work... Needs a virtual sensor that combines the 3 hardware sensors | 17:28 |
| mal | @DylanVanAssche I have partial code for that but it wasn't finished | 17:32 |
| T42 | <DylanVanAssche> mal: Neochapay told me that he's handeling the modem stuff. So I can focus on other things. | 17:33 |
| T42 | <DylanVanAssche> The V4L camera stuff or the compass. I guess the V4L stuff is more important. However, if you have the code, feel free to push them somewhere :) | 17:33 |
| mal | @DylanVanAssche v4l is more important for you now | 17:37 |
| piggz | mal: resolution switch can be merged? | 17:48 |
| mal | piggz: were you supposed to fix the enums? | 17:49 |
| piggz | mal: i did, u just didnt notice it was 30 seconds ago ;) | 17:49 |
| mal | piggz: heh, I checked a few minutes ago :) | 17:49 |
| mal | piggz: looks ok, please squash the fix commits away | 17:53 |
| mal | before merging | 17:53 |
| piggz | i intended to | 17:53 |
| piggz | vknecht: SD card is still WIP? | 17:55 |
| vknecht | yes | 17:55 |
| piggz | what about video snapshots? | 17:56 |
| vknecht | currently adding a model, and moving to a dockedview, hopefuly will help with refreshing the list | 17:56 |
| mal | piggz: video snapshots didn't work for me anymore after the latest changes | 17:56 |
| vknecht | for snapshot, just checked out the branch to investigate | 17:57 |
| vknecht | not sure I'll do much tonight, if that's your question ;-) | 17:57 |
| piggz | note, when you commit in github, the summary line becomes the first line of the commit message, so no need to duplicate it it. I just force pushed to cleanup the last message | 17:57 |
| piggz | vknecht: no, im just wondering if i should do an interim release, as the current fixes are worthwhile | 17:58 |
| piggz | i think i will | 17:58 |
| vknecht | yes, sensed you'd want to release now :-) | 17:58 |
| piggz | i wonder if i h ca time to fix the 'dont sleep while recording' | 17:59 |
| mal | piggz: that is easy now with Nemo keepalive | 17:59 |
| mal | piggz: I can do it now | 18:00 |
| piggz | so can i, but feel free as im also cooking ;) | 18:01 |
| mal | piggz: do we need it also to video player? | 18:04 |
| piggz | probably yes | 18:04 |
| deathmist | does "- audiosystem-passthrough" need to be added to patterns now after pulseaudio-modules-droid-hidl got split into 2? device is on hybris-16.0 and a QCOM one as well | 18:10 |
| mal | https://github.com/mer-hybris/pulseaudio-modules-droid-hidl/blob/master/rpm/pulseaudio-modules-droid-hidl.spec#L15 | 18:10 |
| piggz | https://github.com/mer-hybris/pulseaudio-modules-droid-hidl/blob/master/rpm/pulseaudio-modules-droid-hidl.spec#L23 | 18:11 |
| piggz | heh | 18:11 |
| deathmist | I assume I'll have to add it to dcd patterns as it won't get "packaged in" the hidl module or is it only required during build-time? I'm not very experienced in RPM packaging :/ | 18:14 |
| piggz | its in the common repo, so it should get pulled in automatically | 18:15 |
| mal | piggz: https://github.com/piggz/harbour-advanced-camera/pull/90 | 18:15 |
| mal | deathmist: no need to edit patterns | 18:16 |
| T42 | <DylanVanAssche> mal: `===` https://github.com/piggz/harbour-advanced-camera/pull/90/files#diff-e0e51c0ad041af066d9d5f0ed8c8ece4R19 :) | 18:16 |
| mal | oops, copy paste mistake | 18:17 |
| mal | fixed | 18:17 |
| T42 | <DylanVanAssche> mal: Awesome! | 18:17 |
| T42 | <Akatsu %lastname%> if i have init file and interpretation will fail on one line will init stop interpreting it in place of crash or not? | 18:18 |
| mal | piggz: that new import needs some rather new sfos version, not sure if it was 3.1.0 or something like that | 18:20 |
| rinigus | as I have now access to logs, I'd like to give it a go and continue with xperia10/aosp9 based approach applied to xperia xz2. after fixing find-mmc-bypartlabel (xz2 has sdaXX disks not mmc...), I have the first boot with journal log. | 18:20 |
| rinigus | log at https://pastebin.com/Dfhd1kyi | 18:21 |
| rinigus | it doesnt boot to gui. initialized led | 18:21 |
| rinigus | when pressing power button after some time, shutdown was done (red led as well) | 18:21 |
| rinigus | as there are many errors in the logs, what is the recommended one to start with? | 18:22 |
| rinigus | btw, should I enable back kernel settings that got disabled for rndis (now its CONFIG_USB_CONFIGFS_F_GSI=n) ? | 18:23 |
| piggz | mal: well, rpm validatr like it, so its fine | 18:23 |
| piggz | we need 3.1 anyway for the modes | 18:23 |
| mal | piggz: just add the correct version on store if there was some way to prevent using on older versions | 18:25 |
| piggz | mal: i dont think 3.1 is an option in the store, it seems to be lagging behind. i already have latest available selected | 18:27 |
| mal | rinigus: remove this file https://github.com/mer-hybris/droid-config-sony-ganges-pie/blob/master/sparse/usr/lib/systemd/user/lipstick.service.d/50-vendor.hwcomposer-2-1.conf | 18:27 |
| mal | that prevents lipstick from starting | 18:28 |
| rinigus | mal: thank you! | 18:28 |
| rinigus | ... will test | 18:28 |
| mal | piggz: ok, need to tell about that internally | 18:29 |
| piggz | openrepos done.... | 18:29 |
| mal | piggz: I was just about to rebase my cleanup | 18:30 |
| vknecht | productive saturday evening :-) | 18:31 |
| piggz | mal: as soon as any cleanups are done, i will update :) | 18:38 |
| vknecht | strange, snapshots work here... | 18:42 |
| piggz | oh crap, did we break something | 18:45 |
| piggz | yes :( | 18:46 |
| piggz | i need to pull that | 18:46 |
| piggz | its getting stuck in a loop | 18:46 |
| piggz | when selecting manual focus mode | 18:48 |
| rinigus | mal: removed - now lipstick killed, status=6/ABRT | 18:54 |
| rinigus | https://pastebin.com/Dj8JPcRb | 18:55 |
| mal | vknecht: https://github.com/piggz/harbour-advanced-camera/pull/91 | 18:57 |
| vknecht | mal, you mean it's with this cleanup integrated that snapshots break ? | 18:59 |
| mal | vknecht: no, completely unrelated, that was something I did earlier | 19:00 |
| mal | vknecht: I tested your clean branch, need to test on some other device | 19:00 |
| vknecht | ok | 19:01 |
| rinigus | mal: should I drop https://github.com/sailfishos-sony-tama/droid-config-sony-tama-pie/blob/master/sparse/etc/mce/60-hybris-features-tama.ini as well? | 19:01 |
| T42 | <DylanVanAssche> Oh search is broken on OBS :( | 19:01 |
| mal | not sure, there might be some things in repos that require newer middleware | 19:01 |
| rinigus | mal: I guess I should go once more and delete as much as possible from droid-config and later build it up again, as needed. (like I can drop /opt mounting, for example). hopefully, will not remove too much :) | 19:13 |
| piggz | mal: vknecht: 0.6.6 on openrepos with small fix, feel free to post review! | 19:27 |
| piggz | mal: big question .... you removed all eol ; .... i thought they wre preferred in JS? i know they are implied, but i thought it was better style to have them | 19:43 |
| mal | hmm | 19:45 |
| mal | I wad pretty sure I read somewhere that it's not but need to recheck now | 19:45 |
| piggz | mal: https://flaviocopes.com/javascript-automatic-semicolon-insertion/ | 19:48 |
| mal | piggz: no idea where I read it but it seems I was wrong, fixing | 19:48 |
| mal | https://doc.qt.io/qt-5/qml-codingconventions.html | 19:48 |
| piggz | mal: even that page is inconsistent! | 19:49 |
| piggz | https://stackoverflow.com/questions/444080/do-you-recommend-using-semicolons-after-every-statement-in-javascript | 19:49 |
| piggz | the mousaarea onCLicked at the bottom uses ; | 19:50 |
| piggz | other places dont | 19:50 |
| mal | piggz: it's the qtcreator auto formatter that removes those | 19:51 |
| mal | piggz: https://sailfishos.org/wiki/Coding_Conventions#Omit_.22.3B.22_behind_JavaScript_function_lines | 19:52 |
| piggz | mal: ok, but be aware of the the cases in the first link i sent where it can be ambiguous | 19:53 |
| piggz | so, we need to be sure u didnt break anything ;) | 19:54 |
| mal | @adampigg ok, not sure why it was selected like that | 20:15 |
| mal | @adampigg what is your opinion, the sfos qml style guide tells it's ok to have onSomething: foo = bar instead of having curly brackets, should I also change those? | 20:18 |
| T42 | <adampigg> I kinda like having braces everywhere for explicitness | 20:22 |
| mal | @adampigg I think the cleanup PR should be tested well, although it's just cosmetic changes mostly there is still some small chance of issues | 20:29 |
| deathmist | mal: HOLY CRAP hybris-16.0 booted on my phone to UI!!! | 22:14 |
| mal | deathmist: nice | 22:21 |
| mal | what was the fix? | 22:21 |
| deathmist | mal: I honestly have no clue sadly, I updated the init files (https://git.io/Je4oj), used a kernel with linux-stable merged instead (ver 4.4.197, https://git.io/JeESQ, possible cause for currently no Wi-Fi, audio, LTE network etc) and just hard copied patched ld.config.28.txt to /system | 22:24 |
| deathmist | after a reboot lipstick and jolla setup came up :D | 22:26 |
| mal | ok, maybe the ld.config fix wasn't used before? | 22:27 |
| mal | or something was wrong in .rc files | 22:27 |
| mal | are you sure the qti service should be disabled? that seems like something that should be running | 22:28 |
| deathmist | I really don't know, I got to UI now on 16.0 with it disabled too and everything functioned fine on 15.1 before with it disabled, oh I also removed all local sources & resynced everything and started fresh with 16.0 patches etc | 22:29 |
| deathmist | https://i.imgur.com/Px3JWHp.png :p | 22:30 |
| mal | ok, wondering what the qti service then does | 22:35 |
| T42 | <BusterBg_18> deathmist: nice c: | 23:21 |
| deathmist | mal: it seems to be a direct match with "vendor.dataqti" while "qti" used to be it's old name for me on 15.1, still behaves the same: just keeps on failing and restarting every 10s | 23:41 |
| deathmist | it's late now tho, think I'll look into the proper .mount unit for ld.config.28.txt from logs and do same for the vendor init file I now don't touch / import in libexec init scripts to fix-up cpusets which just need a simple path change | 23:44 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
