Tuesday, 2019-10-29

T42<Lukapanio> hi again06:30
T42<Lukapanio> i have built06:30
T42<Lukapanio> i have: https://bpaste.net/show/O62DI06:31
T42<Lukapanio> in dmesgon mu pc06:31
T42<Lukapanio> so how to debug?06:31
T42<Lukapanio> usb net disappear fast06:31
T42<Lukapanio> I can telnet if I do touch /data/.stowaways/sailfishos/init_enter_debug207:02
T42<Lukapanio> ok enabled journal ctl07:06
T42<Lukapanio> will left it for some time07:06
T42<Lukapanio> ok07:08
T42<Lukapanio> will reboot07:08
T42<Lukapanio> https://bpaste.net/show/WZ6CG07:12
T42<Lukapanio> any idea what is wrong?07:18
r0kk3rzyou skipped the first boot phase07:26
r0kk3rzthats whats wrong07:26
T42<Lukapanio> @r0kk3rz where can i get that, this is full output of journalctl07:30
T42<Lukapanio> why there is no usb after intramfs07:39
T42<Lukapanio> may be somw int breakes it?07:40
r0kk3rzdouble check your fixup mountpoints07:47
T42<elros34> @Lukapanio Are you sure you disabled selinux? Confirm via zcat /proc/config.gz | grep -i selinux and cat /proc/cmdline. Also you need straggler files because droid-hal-init fails08:18
T42<Lukapanio> i will add all partitions to fixup-mountpoints08:20
T42<Lukapanio> and yes i have selinux=0 in cmdline08:20
*** OhYash1 is now known as ohyash08:31
T42<Lukapanio> for fix-mountpoints mod can i rebuild onlyhybris-boot?08:33
T42<Lukapanio> or all system08:33
T42<Lukapanio> ?08:36
T42<elros34> you need to make hybris-hal and package droid-hal but that's not your issue08:36
T42<elros34> check in dmesg about selinux08:37
T42<Lukapanio> sh-3.2# dmesg | grep selinux08:38
T42<Lukapanio> sh-3.2#08:38
T42<elros34> by default grep is case sensitive, also I told you to check config.gz also to make sure bootparam is enable as usually people forget about it08:40
*** OhYash1 is now known as ohyash08:41
T42<Lukapanio> sh-3.2# zcat /proc/config.gz | grep  -i selinux08:58
T42<Lukapanio> sh-3.2#08:58
T42<Lukapanio> @elros3408:58
T42<Lukapanio> it is empty08:58
T42<elros34> check 9.3.1 and make sure your generated out/*/.config is correct09:02
T42<Lukapanio> hmmm CONFIG_SECURITY_SELINUX=y is comented in my defconig09:04
T42<Lukapanio> so @elros34  must i uncoment and disable wia bootparam09:11
T42<Lukapanio> or comented selinux is ok too?09:11
T42<Lukapanio> droid-hal-init: Failed to initialize property area09:11
T42<Lukapanio> looks bad09:11
T42<Lukapanio> and then droid-hal-init.service: Main process exited, code=exited, status=1/FAILURE09:12
T42<elros34> you need to follow 9.3.1 so selinux is disabled via bootparam, next is droid-hal-init09:12
T42<Lukapanio> ok09:15
T42<Lukapanio> rebuilding09:15
T42<Lukapanio> sh-3.2# zcat /proc/config.gz | grep -i selinux09:25
T42<Lukapanio> # CONFIG_SECURITY_SELINUX_DISABLE is not set09:25
T42<Lukapanio> CONFIG_DEFAULT_SECURITY="selinux"09:25
T42<Lukapanio> sh-3.2#09:25
T42<Lukapanio> @elros3409:25
malis CONFIG_AUDIT=y?09:26
T42<elros34> now it must be09:26
maltrue, that was from device09:26
T42<Lukapanio> yep ONFIG_AUDIT=y09:28
T42<Lukapanio> so @elros34  whats next?09:32
T42<elros34> not the best instruction but should be enough: https://wiki.merproject.org/wiki/Adaptations/faq-hadk#droid-hal-init:_Failed_to_initialize_property_area09:40
T42<Lukapanio> @elros34 [not the best instruction but should be enough: …], can it be done from initram fs?09:59
T42<adampigg> from what i understand, modern android needs twrp delivered as an initramfs, loaded from the regular kernel.  has anyone tried booting a twrp initramfs from a sailfish bootimg, making it selectable by holding a key?10:03
T42<Lukapanio> @elros34  prolem is no usb after running echo "continue" >/init-ctl/stdin10:04
T42<elros34> it might fix automagically when droid-hal-init will work10:08
T42<Lukapanio> but how can i execute mask droid-hal-init: ln -s /dev/null /etc/systemd/system/droid-hal-init.service, reboot and then strace -f /sbin/droid-hal-init10:09
T42<Lukapanio> in intramfs?10:09
T42<elros34> skip it, for sure you need straggler files. Btw you are not in initframfs but in init-debug script in sfos rootfs10:10
T42<Lukapanio> ouch yep10:10
T42<Lukapanio> so @elros34  i must add all files in out/target/product/cedric or files and folders10:16
T42<Lukapanio> like:10:16
T42<Lukapanio> %define straggler_files\/init.mmi.boot.sh\/init.mmi.touch.sh\/init.qcom.ssr.sh\/selinux_version\/service_contexts\%{nil}10:16
T42<Lukapanio> like /file1 file2 file3 or like /file1 /folder1 /file210:18
T42<Lukapanio> or may be /file1 /folder1/file110:18
T42<Lukapanio> ?10:18
T42<elros34> I don't think folders are needed maybe simlinks like /vendor and for sure init*sh and *context* files10:20
T42<Lukapanio> problem is there is no context files @elros3410:22
T42<hacker12455> You sure?10:22
T42<hacker12455> I think I had some context files, not sure10:22
T42<Lukapanio> yep @hacker12455  check on server10:22
T42<hacker12455> Later10:24
T42<Lukapanio> @elros3410:37
T42<Lukapanio> HABUILD_SDK [cedric] hello@Strangers-In-My-Network:~/hadk/out/target/product/cedric/root$ grep -r context10:37
T42<Lukapanio> Binary file sbin/charger matches10:37
T42<Lukapanio> init.rc:    # Set the security context of /adb_keys if present.10:37
T42<Lukapanio> init.rc:    # Set the security context of /postinstall if present.10:37
T42<Lukapanio> init.rc:    # Set SELinux security contexts on upgrade or policy update.10:37
T42<Lukapanio> Binary file init matches10:37
T42<Lukapanio> add init file?10:39
T42<elros34> if you mean /init then no10:40
T42<Lukapanio> yep i mean /init10:40
T42<Lukapanio> but where are contexts?10:41
T42<elros34> I thought instruction is clear but looks like no. If there are not such a files then move on. You can always strace droid-hal-init if it will still fail10:42
T42<Lukapanio> so next is add droid-hal-$DEVICE-detritus package to patterns10:44
T42<Lukapanio> ?10:44
T42<elros34> sure but you can manually copy (sdcard or via twrp) and install this package before creating whole new image10:45
T42<adampigg> mal, lbt, abranson, 3.2 isnt on obs yet!!11:51
T42<eugenio_g7> :D11:51
abransonthis is really turning into a telegram channel :D11:52
mal@adampigg :D11:53
malabranson: it's a bit sad in my opinion :)11:53
abransonwell, it does make it easier for people to follow long term. but we should never drop irc if there's no better open standard.11:54
T42<eugenio_g7> Sorry about that, I should take the plunge and move everything over matrix with real bridges :D11:54
T42<adampigg> irc is convenient when im at home on a pc, telegram more convenient when away to keep up with the conversation11:56
mal@adampigg screen+irssi and ssh ftw11:58
r0kk3rzrip irc12:00
T42<adampigg> mal: and there you have summarised in 5 words why telegram is more convenient ;)12:01
mal@adampigg https://xkcd.com/1782/12:02
T42<adampigg> ha, ive seen that......12:04
T42<adampigg> perhaps we should/ all move to slack, or teams!12:05
T42<adampigg> i wonder if the BT improvements allow starfish to be used now?12:05
mal@adampigg was that the asteroid client? we were thinking about that also12:09
T42<adampigg> yes12:09
T42<Lukapanio> @elros34  repo problem: nothing provides droid-hal-cedric-detritus needed by pattern:jolla-hw-adaptation-cedric-1-1.noarch,12:43
T42<elros34> have you built it?12:46
T42<Lukapanio> i have run build_packages.sh12:46
T42<elros34> so make sure package exists12:47
T42<Lukapanio> sorry for stupid question but how?12:48
T42<elros34> in your local repo: droid-local-repo/$DEVICE/droid-hal-$DEVICE/12:49
T42<Lukapanio> hmmm it is not there12:50
T42<Lukapanio> how must it build @elros34 ?12:58
T42<elros34> are you sure you have followed 7.2.2 first dot carefully?12:59
T42<Lukapanio> шрфму - droid-hal-cedric-detritus13:02
T42<Lukapanio> in Jolla-hw-adaptation-cedric.yaml13:03
T42<elros34> hmm I think I found why straggler files are not auto detected. It's because busybox's diff use diffrent output format "-"  instead "< "13:03
T42<Lukapanio> but i have no %define straggler_files\13:04
T42<Lukapanio> becouse i cant finde that files13:04
T42<Lukapanio> that files seems to be packed13:04
T42<Lukapanio> and no context files13:05
T42<elros34> show your rpm/droid-hal-13:05
T42<elros34> $DEVICE.spec13:05
T42<Lukapanio> @elros34 [show your rpm/droid-hal-13:07
T42<Lukapanio> $DEVICE.spec], https://bpaste.net/show/RENK613:07
T42<elros34> @Lukapanio could you test something? sb2 -t $VENDOR-$DEVICE-armv7hl -m sdk-build -R. install some editor: zypper install vim; then edit /usr/lib/rpm/check-files according to https://pastebin.com/Jy6Jz3pc13:13
T42<elros34> then run rpm/dhd/helpers/build_packages.sh —droid-hal13:14
T42<Lukapanio> @elros34 [then run rpm/dhd/helpers/build_packages.sh —dr …], rpm/dhd/helpers/build_packages.sh —droid-hal13:17
T42<Lukapanio> unknown option(s): —droid-hal13:17
T42<Lukapanio> ouch13:18
T42<Lukapanio> iknow13:18
T42<Lukapanio> not - but --13:18
T42<Lukapanio> yay13:20
T42<Lukapanio> error: Installed (but unpackaged) file(s) found:13:20
T42<Lukapanio>    /bugreports13:20
T42<Lukapanio>    /d13:20
T42<Lukapanio>    /sdcard13:20
T42<elros34> yes finally, that is good!13:20
T42<Lukapanio> thanks13:20
T42<Lukapanio> will add them now13:20
T42<elros34> but i expected different output, these files are not critical so grab new journalctl13:22
T42<Lukapanio> after rebuilding or now?13:22
T42<Lukapanio> with old rootfs13:23
T42<elros34> mal: lack of "Installed (but unpackaged) file(s) found" is caused by busybox's grep which use different output format. Not sure how to fix it properly: https://pastebin.com/Jy6Jz3pc13:23
T42<elros34> @Lukapanio you can make on device ln -s /sys/kernel/debug /d but I doubt it change anything13:25
T42<Lukapanio> thanks @elros34  finalyi have droid-hal-cedric-detritus-0.0.6-201910291322.armv7hl.rpm13:25
T42<Lukapanio> must i rebuild rootfs or just install droid-hal-cedric-detritus-0.0.6-201910291322.armv7hl.rpm13:25
T42<Lukapanio> ?13:25
T42<elros34> like I said these 3 symlinks doesn't looks important13:26
T42<Lukapanio> but what is problem then?13:27
rinigushi! as I have android's KeyMasterHalDevice crashing on boot: is it of any importance for sfos?13:27
T42<elros34> @Lukapanio imposible to know without logs, debugging13:28
T42<Lukapanio> @elros34 [@Lukapanio imposible to know without logs, deb …], journalctl?13:29
mal@elros34 ok, needs some testing13:29
T42<Lukapanio> ok will shut down and send logs13:30
T42<elros34> There many patches in rpm sources so maybe just adding one more13:31
rinigusI can see some discussion regarding keymaster, but not really sure whats up with it.13:32
T42<Lukapanio> https://pastebin.com/Kdbw8B8r13:32
T42<elros34> Missed 291 kernel messages: provide dmesg13:34
vknechtrinigus, seems it had to be disabled in oreo based ports, dunno about pie ( https://github.com/mer-hybris/droid-config-sony-nile/blob/master/sparse/usr/libexec/droid-hybris/system/etc/init/android.hardware.keymaster%403.0-service-qti.rc )13:35
T42<Lukapanio> @elros34 [Missed 291 kernel messages: provide dmesg], https://pastebin.com/7GAZCEA913:37
rinigusvknecht: according to Mister_Magister (https://piggz.co.uk/sailfishos-porters-archive/index.php?log=2019-08-17.txt#line178), he managed to get gui working with that starting.13:37
rinigus... on Pie13:37
T42<Lukapanio> but after debug shell no usb13:39
Mister_Magisterrinigus: what i13:39
Mister_Magisterrinigus: no that was just coincidence13:39
Mister_Magistergui was starting weirdly after 30 minutes of boot for whatever reason13:39
T42<elros34> @Lukapanio still dmesg  missing initial logs so it's useless13:40
rinigusMister_Magister: ok, I see. do you have that service enabled or disabled13:40
T42<Lukapanio> @elros34 [@Lukapanio still dmesg  missing initial logs s …], ouch seems so but why?13:40
Mister_Magisterrinigus: phone is dead but enabled13:40
Mister_Magisterdoes keymaster not work for you?13:40
rinigusMister_Magister: it has the same android.hardware.keymaster@3.0-impl: Configure failed in logcat as it was for you13:41
Mister_Magisterrinigus: ah yes you need to set android and SPL in kernel13:41
Mister_Magistermost likely13:41
Mister_Magisternot sure but most likely13:41
Mister_Magistercause you are on 15.1 right?13:41
rinigusnope, its aosp9. what's 'set android and SPL in kernel'?13:42
Mister_Magisterrinigus: what was initial android version on that phone13:42
rinigusMister_Magister: according to tech specs, should be android 813:43
Mister_Magisterit's sony?13:43
Mister_Magisteranother lazy ass devs?13:43
rinigus... its sony xperia xz213:44
rinigus... with lovely bugs in bootloader of all people13:44
Mister_Magisterrinigus: but be careful i got my bootloader blocked and phone bricked due to that lol. gimme some time i will find you link k?13:44
rinigusMister_Magister: thanks13:44
Mister_Magisterfirst grab hex editor13:45
Mister_Magisterhere you go13:46
Mister_Magisteryou need to reverse that and set android and SPL version in kernel13:46
Mister_MagisterSPL aka Security Patch Level of vendor and boot has to match13:47
Mister_Magisterthat requirements was in 15.1 but was removed an 16.0 and lazy ass devs didn't remove it. also sfos bootimage doesn't add those13:47
rinigusMister_Magister: and I don't follow - how would that help me? right now its booting, just without gui :)13:48
T42<Lukapanio> why dmesg is not full?13:49
rinigusvknecht: but that service doesn't seem to be disabled in https://github.com/mer-hybris/droid-config-sony-ganges-pie/blob/master/sparse/usr/libexec/droid-hybris/system/etc/init/disabled_services.rc13:49
Mister_Magisterrinigus: it will make keymaster working13:49
Mister_Magistergui requires keymaster working13:49
Mister_Magisteri almost got gui but when i added spl manually to kernel it broke bootloader and it now freezes before fastboot and i ran out of 5 boots and now i have brick13:50
rinigusMister_Magister: ok , rather weird though. let me read up a bit on that.13:50
Mister_Magisterrinigus: you can either try my advice or not lol nobody is forcing you13:51
Mister_Magistertho that's what happened13:51
Mister_Magistersony and asus devs are lazy13:51
rinigusMister_Magister: on sony, after you run out of these 5 boots, you do get corrupt device warning, but can still get to fastboot13:51
Mister_Magisterrinigus:  not if your bootloader is frozen due to your bootimage13:52
rinigusno forcing perceived either :)13:52
Mister_Magisterofcourse on asus fastboot is there too13:52
T42<Lukapanio> if device is brick may be flash bootloader with edl13:52
Mister_Magisteronly if it wasn't blocked due to my bootimage13:52
Mister_Magisteryes i know @Lukapanio13:52
Mister_Magistertho i need to remove back to get to it13:52
Mister_Magisterwhich is glass13:52
T42<Lukapanio> ouch13:53
T42<Lukapanio> buy new back13:53
Mister_Magisteri read that some pepopl made xiaomi edl cable and it worked13:53
Mister_Magisteri need to have device charged and turned off13:53
Mister_Magisterand if it's charged i can't turn it off without unplugging battery13:53
T42<Lukapanio> idk i can reboot to edl from twrp with adb reboot edl13:53
Mister_Magisterimagine i can't get into twrp because i can't flash it because kernel is freezed before fastboot?13:54
T42<Lukapanio> before fastboot it is not even linux i think it must be lk13:54
Mister_Magisteri've went through this topic completely13:55
Mister_Magisterrinigus: so if you try watchout13:55
T42<Lukapanio> but why is it frozen?13:56
rinigusMister_Magister: I will, surely. maybe first read up on keymaster and see if I can make it work differently. somehow its working on aosp9, isn't it?13:56
Mister_Magisterrinigus: it is working because versions match13:56
Mister_Magisterlike i told you13:56
T42<Lukapanio> but why dmesg is not full @elros34 ?13:57
Mister_Magisterrinigus: phh-treble has script to fix SPL version. you can either modify kernel image for quickfix or make script fixing it13:58
vknecht@Lukapanio: gotta be quickier to telnet and type command after boot :-)14:01
vknechtor get dmesg buffer bigger iirc14:02
rinigusMister_Magister: thanks. (will go and read up on it to avoid locks)14:05
Mister_Magisteru can go ask on phh-treble if you don't trust me (and if  you don't get banned)14:08
rinigusMister_Magister: interesting reading - https://github.com/sonyxperiadev/bug_tracker/issues/16514:15
Mister_Magisterrinigus: almost exactly what i told u :P14:17
mal@elros34 btw, you can add optional things to that regex in that sed so it could support both ways14:18
rinigusMister_Magister: pretty much. I'll ask sony devs if there is a gentle way to enable it :)14:18
Mister_Magisterenable what14:19
riniguskeymaster config14:21
T42<birdzhang> can you upgrade to
T42<birdzhang> Error: Location 'https://store-repository.jolla.com/releases/' is temporarily unaccessible14:23
rinigusMister_Magister: : ... according to error message, its INVALID_ARGUMENT . let's see what's given as arguments in its init14:23
T42<elros34> mal: I use sed -n 's|.*'"${RPM_BUILD_ROOT}"'\(.*\)$|   \1|gp' so both busybox should works14:23
Mister_Magistererm rinigus u need that version in kernel otherwise it won't work14:23
Mister_Magisteror patch kernel on live like phh did it14:24
T42<elros34> I mean both diff*14:24
Mister_Magisterthere isn't any enabling config14:24
Mister_Magisterthey have to match. if they match it will work14:24
Mister_Magisterrinigus: keymaster sends both bootimage and vendorimage to whatever security it was called (above system level in bootloader level) and it checks if they are correct14:25
Mister_Magisteryou can't overcome that in any way14:25
mal@elros34 that is also possible, assuming there can be no other error which could match that14:25
Mister_Magisterpatch manually or do it live are the only options. otherwise phh-treble would do it differently14:25
rinigusMister_Magister: ok. but now how can patching of hybris-boot (assuming we are talking about it) lock bootloader? if I understood your issue correctly14:27
rinigus... with 5z14:27
Mister_Magisterrinigus: for some reason bootimg patched by me freezed bootloader14:27
Mister_Magisterwhen phhussion did it it didn't14:28
rinigusMister_Magister: and that's what I don't understand.14:28
Mister_Magisteri don't understand either14:29
Mister_Magisternoone understands14:29
Mister_Magisterjust watch out14:29
Mister_Magisteryou can still flash boot from booted sfos14:29
Mister_Magisteror switch slot and then flash boot14:29
rinigusMister_Magister: thanks! and how do find these magic spl/android numbers?14:30
rinigusMister_Magister: I cannot switch slots. only slot_a works (thanks to bootloader)14:30
T42<elros34> mal: good point, I can't use .*14:30
Mister_Magisterrinigus: android is 9.0.014:31
Mister_Magisterand vendor patch level is in vendor/build.prop or smth14:32
Mister_Magisterif i find some patched bootloader i can help you later14:32
Mister_Magisteri'm at work currently14:32
rinigusMister_Magister: I will look for those. thanks! no worries, I'll do it later14:32
T42<Lukapanio> @elros34  here is full dmesg https://pastebin.com/pGhW0MrT15:24
T42<Lukapanio> so any idea what is wrong?15:36
T42<elros34> dmesg looks good but looks like your system partition is not mounted. DO you have even /lib/systemd/system/system.mount unit?15:37
T42<Lukapanio> @elros34 [dmesg looks good but looks like your system pa …], hmmmm no15:42
T42<Lukapanio> иге црн,15:45
T42<Lukapanio> but why?*15:45
T42<Lukapanio> fixup-mountpoints problem?15:45
T42<elros34> search for *fstab* and uevent*rc in out directory15:45
T42<Lukapanio> @elros34 [search for *fstab* and uevent*rc in out direct …], ./vendor/etc/fstab.qcom15:50
T42<Lukapanio> ./system/vendor/ueventd.rc15:50
T42<elros34> is this somwhere in out/ directory?15:51
T42<Lukapanio> idk why it create 12mb vendor.img15:51
T42<Lukapanio> @elros34  whats next with this files?15:51
T42<Lukapanio> where must i place them?15:53
T42<Lukapanio> @elros34 [is this somwhere in out/ directory?], yep15:54
T42<Lukapanio> and ueventd.rc is in /data/.stowaways/sailfishos too15:55
T42<elros34> hmm then maybe check $ANDROID_ROOT/droid-hal-$DEVICE.log to figure out why system.mount is not created15:58
rinigusMister_Magister: solution that made keymaster to start was adding `--os_version 9 --os_patch_level 2019-08-01` to https://github.com/sailfishos-sony-tama/droid-hal-img-boot-sony-tama-pie/blob/master/rpm/droid-hal-akari-img-boot.spec#L3 . Thanks for help and help of Marijn pointing to mkbootimg from sony devs channel!16:00
rinigusno gui still16:00
T42<elros34> verbose obs failed: any idea https://build.sailfishos.org/package/show/home:elros34:sailfish-devel/rpm?16:15
Mister_Magisterrinigus: told you it needs to be added to kernel16:23
Mister_Magisterone way or another16:23
Mister_Magisterstill have bricked device xd16:23
T42<Lukapanio> @elros34 [hmm then maybe check $ANDROID_ROOT/droid-hal-$ …], cant finde it there16:38
ThaodanMister_Magister: i got that too because my device is still in early stages of aosp17:29
Mister_Magisterrinigus: lmao i actually helped lol17:30
ThaodanMister_Magister: isn't that what you describe about booting part of avb 2.0 (which would also allow relocking with user key's if it weren't for Sony)17:31
rinigusMister_Magister: yes, thanks for help!17:31
Mister_MagisterThaodan: dunno what u r talking about sorry17:32
Thaodanrinigus: is there an irc channel for Sony devs?17:32
Thaodanrinigus: maybe we should gather such kind of information in a wiki.17:33
rinigusThaodan: not to my knowledge. they use slack for it and I've asked for access through xda PM17:34
ThaodanMister_Magister: the verification of boot images17:34
Mister_Magisterah stil dunno17:34
Mister_MagisterThaodan: u just need rinigus fix right?17:34
rinigusThaodan: we have wiki already under github/mer-hybris. that would be decent place to add17:35
Thaodanrinigus: please do that.  does the gui works now?  Also a good place is to lock at the device repo from Sony for boot parameters.17:36
ThaodanMister_Magister: I don't need the fix currently as my device is to wip but better have that knowledge for Android 1017:36
Mister_Magisterwell i don't understand you at all hd17:37
rinigusThaodan: you mean vbmeta/dtbo and such? no gui yet, have to do something else for bit of time17:37
Mister_Magisterrinigus: i still need to unbrick my device xd17:37
Thaodanrinigus: yeah especially for the kernel building process because this stuff is no longer intree17:39
ThaodanMister_Magister: Id just liked to now if this(keymaster) stuff is required for gui that I can prepare and look for changes between Android 9 and 1017:41
Mister_MagisterThaodan: it most likely is required for gui17:41
Mister_Magisterhwc wasn't staritng for me without it iirc17:41
Mister_Magisterwell i never got gui after all so can't confirm17:41
Mister_Magisterbut it's surely crucial step17:42
Mister_Magisteras it blocks services17:42
Thaodanthis stuff is so badly documented like the init split for example17:42
Mister_MagisterThaodan: if your device didn't came out with 15.1 on board then you probably don't need it17:42
Mister_Magisterthat requirement was removed in 16.0 and devices that came out with 16.0 don't have it17:42
Mister_MagisterThaodan: documented… well i told rinigus a story17:43
Mister_Magisterit was required in 15.1 but google didn't specify how to do it so vendors did whatever they wanted and were too lazy to remove it in 16 as it was removed in 1617:43
Mister_Magisterannying companies17:43
ThaodanMister_Magister: mine came with pie but the support for the soc wasn't in aosp at that time17:44
Mister_Magisterpie is 16?17:45
deathmistyep, LineageOS 16 / Android 917:46
T42<Lukapanio> so @elros34  i cant finde system.mount in log18:02
Mister_MagisterThaodan: then you don't need it at all18:04
Mister_Magisterit was removed in 16.018:04
T42<elros34> @Lukapanio sure otherwise it would be created but the question is why. Here it should find your fstab: https://github.com/mer-hybris/droid-hal-device/blob/master/droid-hal-device.inc#L44318:20
piggzmal: vknecht: which of your PRs should come first?  I suspect either way will be a lot of conflicts18:23
vknechtlet the cleanup go first, I'll adapt :-)18:25
malpiggz: did we agree on the cleanup already?18:27
T42<elros34> mal: here is patch for rpm https://build.sailfishos.org/package/show/home:elros34:sailfish-devel/rpm but I can't build it18:33
piggzmal: well, we may aswell go with it, im willing to follow the style guide if it says no ;18:37
piggzstill needs testd though18:37
T42<Lukapanio> @elros34  i have https://bpaste.net/show/U2S26 in log18:55
T42<elros34> then I don't know. I take your fstab from here https://github.com/luka177/android_device_motorola_cedric/blob/lineage-15.1/rootdir/etc/fstab.qcom and mount unit is generated19:07
piggzmal: ive ran through every function with the cleanup PR, no errors logged on the console, so it seems fine19:08
malpiggz: merge if you feel it's good19:09
T42<hacker12455> @elros34 maybe it's some config issue?19:09
T42<elros34> I don't think so, he can always create system.mount manually based on other created mount units, it's easy19:11
T42<hacker12455> oh neat19:13
piggzmal: not an issue, as i know its the "more correct" way ... but i was never sure why QObject *obj; was better than QObject* obj; ... as the type is supposed to be QObject-Pointer, so always seemed normal for me for the * to be beside the type19:13
malpiggz: I have always used that QObject *obj way, that was also from autoformatter19:18
piggzmal: stroustrup implies im correct :) http://www.stroustrup.com/bs_faq2.html#whitespace19:21
malpiggz: there are many different styles :)19:23
T42<Lukapanio> @elros34  i must mount systempartition to /system?19:26
T42<elros34> take a look at your fstab19:26
piggzmal: done. vknecht: pls rebase :)19:27
maland use correct style for any new code19:28
piggzyes, so, from now on, save to use auto formatter ?19:30
piggzmal: should an on-device update to 3.2 be save for ports, without hal/mw rebuild ?19:34
vknechtwill do19:35
malpiggz: not sure, quite a lot of changes to packages so might be scary update19:38
malpiggz: maybe I should test on my secondary fp219:39
T42<Lukapanio> @elros34  like https://bpaste.net/show/MSWY219:39
piggzmal: oh, pls do, before i wreck my mido :)19:39
T42<Lukapanio> ?19:39
piggzi was about to take the plunge, but if you have a donor device!19:39
T42<elros34> @Lukapanio  yeah, something like that19:42
malpiggz: version --dup running, we'll see what happens :D19:43
malpiggz: my secondary fp2 is completely empty device, just clean sfos installation, I used that to test flashing new images (among other things like mainline testing)19:43
*** electro is now known as Guest4744819:49
T42<Lukapanio> @elros34 [@Lukapanio  yeah, something like that], new journalctl https://bpaste.net/show/LFJ4U19:51
T42<hacker12455> Jan 01 02:05:14 Sailfish droid-hal-init: Failed to initialize property area19:55
T42<hacker12455> Jan 01 02:05:14 Sailfish systemd[1]: droid-hal-init.service: Main process exited, code=exited, status=1/FAILURE19:55
deathmist@Lukapanio I remember you not having any *propety_context files in out/, so check if "/system/etc/selinux/plat_property_contexts" for example exists as that's what I have symlinked on /19:57
T42<elros34> system partition is still not mounted20:05
T42<hacker12455> hmm it can't seem to find it20:08
Thaodanif someone needs to generate vendor patches that are applied on top of AOSP like Jolla does for Sony you at this PR:20:20
Thaodaneh here: https://github.com/mer-hybris/droid-hal-source/pull/720:21
malpiggz: it booted but audio and camera don't work, some other issues also20:22
piggzmal: interesting, thoughts on what caused that?20:22
malnot yet20:23
T42<Lukapanio> @elros34 [system partition is still not mounted], hmmm but why?20:23
vknechtjust wondering, should there really be an empty line here ? https://github.com/piggz/harbour-advanced-camera/blob/1e418434ef22b5cd379f8a8f2e227ac0c1ebe41d/qml/pages/GalleryUI.qml#L1220:24
T42<hacker12455> does sailfish automatically use the mount units in a directory?20:24
piggzvknecht: well, according to mal :)20:25
malvknecht: blame the qt creator auto formatter20:25
vknechtok no problem ; btw, is there some setting to check in QtCreator for better compliance ?20:26
vknechtor is it all on by default ?20:26
malnot sure20:27
malpiggz: also volume buttons are broken, interesting that system sounds like when plugging usb work but settings app or csd doesn't20:28
piggzill hold off updating then for now!20:28
malpiggz: I assume some of our middleware depends on some older version of something and something wasn't updated because of that20:29
malpiggz: I'll try one more thing, I might have been using testing repos for adaptation which have older packages so trying using devel20:36
malpiggz: ok, that fixed both cam and audio and buttons, so you need to have new enough pulse droid plugin and gst-droid etc20:41
piggzmal: still no build logs available on obs :(20:41
malpiggz: so looks like that everything might be working20:41
piggzmal: cool, will update20:41
piggzmal: scrap that, ive got a log now20:42
malpiggz: live build log is not working afaik20:43
vknechtsnapshot pr rebased20:49
malvknecht: some style nitpicking, in c++ files we have { in same line as if or else20:51
malvknecht: check some other file for example20:52
vknechtok, will see later, already on sdcard one20:52
piggzmal: update started.... thoughts on this error? %setup -q -n %{name}-%{version}/upstream21:00
vknechtis there a way to apply source formatting to whole project at once, or only select all of each file one by one and Edit->Advanced->Auto-indent selection ?21:06
malvknecht: I think I used astyle plugin21:11
malfor c++ side21:11
maland "Qml/JS->Format file" for qml21:12
vknechthmm, can't find this astyle, guess it's an extra ? reinstalled app sdk earlier today, doesn't seem present (have C++ Beatifier there, disabled, tho)21:19
malyes, you might need to install the astyle package to your OS first21:20
malbefore it gets active21:21
vknechtalright, thanks21:21
malthe artistic style under beautifier21:21
rinigusas test_hwcomposer is still crashing on akari, I am posting strace https://dpaste.de/sJbx/raw and corresponding logcat section https://dpaste.de/bXmm/raw21:24
vknechtseems beautifier/astyle needs a config file21:29
malrinigus: have you made sure all ueventd*.rc files were copied to out/21:37
malrinigus: that suggest a permission issue which could be due to missing udev rules which sometimes are caused by missing ueventd*.rc21:37
malduring build21:37
rinigusmal: you mean during system and vendor image builds?21:38
malno during hybris-hal21:39
rinigusbut, as such, no, I haven't made sure all is copied. I will have to check it then21:39
rinigusmal: and how would you check for it? compare out/ of aosp and sfos hybris-hal?21:40
malrinigus: check output of make modules for any ueventd*.rc and if there is one try make for that module, of course first check find out/ -name 'uevent*.rc' for comparison21:40
malrinigus: if you have both aosp and sfos out/ then use that find for both21:41
rinigusmal: thanks, will do that then. I do have the both trees (we actually need plane aosp9  for system & vendor image building, as I follow xperia 10 instructions)21:42
rinigusplain aosp9 :)21:42
malok, that is quicker to compare21:42
riniguswill start with that tomorrow evening... thanks for checking out the logs!21:43
vknechthmm, looks like qml/js formatter simplifies21:45
vknechtfor (var i = 0; i < modelStorage.rowCount(); i++)21:45
vknechtfor (; i < modelStorage.rowCount(); i++)21:45
vknechtbut np I caught it21:45
T42<elros34> rinigus: didn't your previous strace of  test_hwc2 fail right /selinux? That could be important21:45
malvknecht: is i defined somewhere earlier21:47
mal@elros34 I noticed that in earlier strace also21:47
malnew strace didn't fail in same place21:48
vknechtnot sure, but at runtime sure got ReferenceError: i is not defined21:48
malquite odd21:48
malvknecht: which part of the code?21:48
riniguselros34: thats strace for hwc2 https://dpaste.de/65A421:49
malrinigus: that looks bad21:49
vknechtthis one, https://github.com/piggz/harbour-advanced-camera/blob/370681159dfe8c1c5af00b50b37feec1aa6b0eb5/qml/pages/SettingsOverlay.qml#L53721:51
vknechtand it also mods the findIndex for grid setting in same file21:52
rinigusmal: it was run using EGL_PLATFORM=hwcomposer test_hwc2 . as for bad, what exactly ?21:53
riniguslib path?21:53
malvknecht: wondering why it didn't do it for me21:53
malrinigus: the final messages are about selinux21:54
rinigusmal: yes, I still have selinux enabled. as I haven't got yet recommendation in disabling it21:54
malrinigus: I'm quite sure I suggested that to you earlier21:55
malalthough in theory it should work assume you have all needed parts21:55
rinigusmal: so, that's an assumption. and its hard to be sure that I do have all the parts. I did base it all on xperia 10 and all repos are there, but its still questionable.21:57
rinigusyou did suggest with similar 'in theory' remark. in this respect we can conclude that I should proceed with dropping selinux and rebuilding without it21:58
rinigusmal: /sys/fs/selinux is empty on device, but exists. there is no /selinux22:03
rinigusmal: as soon as I mounted selnux (mount -t selinuxfs none /sys/fs/selinux), test_hwc2 worked!22:08
malrinigus: hmm, wondering what should mount that22:19
vknechtPRs updated, 'night22:23

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!