rinigus | mal: have you had a chance to checkout or ask about storage detection by settings/{storage,backup,camera}? | 13:55 |
---|---|---|
rinigus | re: our issue with /dev/sda-sdf disks when on internal storage | 13:55 |
mal | not yet, completely forgot | 14:02 |
mal | rinigus: do those show at the end of the storage page or how? | 14:05 |
rinigus | mal: then its good to remind :). as I have only two fs as a "normal" storage (/ and /home) they show up after that. | 14:06 |
rinigus | mal: its quite a long list of different partitions. | 14:07 |
rinigus | mal: some of them are of "non-correctly" formatted (shown with red labels) and I think it proposed to format them too | 14:07 |
rinigus | on camera and backup, some of the partitions can be used to store images/backups. | 14:08 |
rinigus | probably list of "good" ones - ext4 or similar | 14:08 |
rinigus | mal ^ | 14:08 |
mal | rinigus: so do you see the usual User files and system files and then external ones? | 14:11 |
mal | rinigus: can you show the output of mount? | 14:16 |
rinigus | mal: can't make screenshot right now, so I try to explain. In Settings/Storage, we have rings describing each partition. For XZ2 (and I take for 1+5 and pro1), we have also rings for those system-used partitions (firmware and such) | 14:16 |
mal | rinigus: but you also have the usual ones? | 14:17 |
rinigus | mal: mount does not have that many of them. let me see if I can get df from my earlier pastes (at work right now) | 14:17 |
rinigus | mal: but its surely not as many mounted | 14:17 |
rinigus | mal: yes, I do | 14:17 |
mal | so those extra ones are listed in the external list at the end | 14:17 |
rinigus | mal: discussion started on sunday morning | 14:18 |
rinigus | mal: yes, in this respect they are | 14:18 |
mal | first is always user then system and the memory cards etc | 14:18 |
rinigus | mal: as there is no clear distinction in UI, I cannot tell if its already external. but yes, first was expected ones (home and system, I presume) and then looooong list with funky partitions and uuid's | 14:19 |
rinigus | as I have on onyx uuid for sd card | 14:20 |
mal | rinigus: everything after system is "external" | 14:20 |
mal | so those are for some reason not seen as "internal" and therefore are shown in the list | 14:21 |
rinigus | mal: we suspect its related to the fact that internal partitions are on /dev/sd{a,b,c,d} | 14:21 |
rinigus | mal: I tried to flag them as system ones or asked for them to be ignored by udisk2, but that didn't help much. | 14:22 |
rinigus | mal: so, question is how are those partitions detected by storage. if there is some flag we can set | 14:22 |
mal | I'll need to find the udev rule changes you made | 14:23 |
rinigus | mal: I used this: https://github.com/sailfishos-sony-tama/droid-config-sony-tama-pie/blob/master/sparse/etc/udev/rules.d/80-udisks2.rules#L45 | 14:24 |
rinigus | location as on device | 14:24 |
rinigus | also, see http://www.merproject.org/logs/%23sailfishos-porters/%23sailfishos-porters.2019-11-03.log.html#t2019-11-03T11:13:31 | 14:25 |
mal | rinigus: are those ones seen in settings sdb* (or other like c and so on) or do sda* also show? | 14:25 |
rinigus | mal: sda shows up as well. I don't have that many partitions on sdb,c | 14:26 |
mal | rinigus: does it create mount service for those? mount-sd@*.service | 14:27 |
rinigus | mal: note I am very confident in it, but I cannot check right now. in 1-3 hours can | 14:27 |
rinigus | mal: with the default rules, it made mount services for couple of them. with the overwritten rules, as in my current config, these are not made | 14:28 |
rinigus | mal: I noticed the failed mount services, but didn't check the others. with new rules, the failed ones disappeared | 14:30 |
mal | rinigus: ok, does your device support sd cards? if so how do those show in /dev? | 14:31 |
rinigus | mal: it does, but I haven't inserted any yet | 14:32 |
rinigus | deathmist, piggz: have you tried sd cards on your devices? (see discussion above) | 14:32 |
T42 | <adampigg> Later | 14:35 |
mal | rinigus: would be interesting to know how it appear to make sure it is detected correctly in those udev rules | 14:46 |
rinigus | mal: I will test it then. probably the rules will have to be adjusted, unless it shows up as the one already used there. | 14:47 |
rinigus | mal: coming back to the question - how is jolla's settings detecting external storage? | 14:48 |
deathmist | mal: rinigus: my phone doesn't have an SD card slot (thank OnePlus lol), but I've tested USB OTG storage and it shows up normally (along the mess of system partitions) in Settings > Storage and I've backed up to and restored my SFOS user stuff from it too | 14:50 |
mal | rinigus: that information comes from lower level, nemo-qml-plugin-systemsettings and where it gets the data | 14:51 |
mal | deathmist: do you also have the same issue that rinigus has? | 14:51 |
deathmist | yep, OnePlus 5 | 14:52 |
rinigus | mal: pro1 has the same issue | 14:52 |
deathmist | afaik for me all of sd[a-f]* is shown as I can see some labels from https://pastebin.com/iUPQSmJX etc | 14:53 |
deathmist | those are all meant to be system partitions ofc | 14:53 |
rinigus | mal: that's good taking that it is open source! | 14:54 |
mal | deathmist: can you grab udevadm info things for one of those partitions | 14:55 |
mal | rinigus: settings app didn't have any smart things there, just using PartitionModels with differenty types | 14:56 |
rinigus | mal: so, we have to figure out how its populated and change settings or code accordingly. I will be able to grab udevadm info when I get back home | 14:59 |
T42 | <nitin03 %lastname%> build package for poco f1 ..I was unable to telnet this time I did "touch init_enter_debug2" in sfos directory...then I was able to telnet into the device..got a shell...enter devel-su..but it asks for a password | 15:02 |
T42 | <hacker12455> Can you get to GUI? | 15:02 |
T42 | <nitin03 %lastname%> no | 15:03 |
mal | rinigus: I think it needs some udev magic | 15:03 |
T42 | <hacker12455> Hmm | 15:03 |
T42 | <hacker12455> nitin03 what base? | 15:03 |
mal | @nitin03 telnet is already root, no need to use devel-su in there | 15:04 |
rinigus | mal: reading the code, looks like it. will have to see what this magic could be | 15:04 |
T42 | <nitin03 %lastname%> I did edit Storage=automatic in journald.conf...but reboot command doesn't work | 15:05 |
T42 | <nitin03 %lastname%> it says Failed to talk to init daemon. | 15:05 |
T42 | <nitin03 %lastname%> @hacker12455 [Hmm], lineage16.0 | 15:06 |
T42 | <elros34> use reboot -f :P | 15:06 |
mal | @nitin03 if you do "touch init_enter_debug2" that disables systemd so the boot stops very early | 15:07 |
mal | @nitin03 what things have you added to config repo, some changes are mentioned in faq, not sure if all | 15:07 |
T42 | <nitin03 %lastname%> files you suggested...like ld.config.28.txt and in its corresspoding file and symlink file in lib/systemd/system folder | 15:12 |
mal | and the .rc files? | 15:13 |
mal | @nitin03 can you tell how you used that ld.config.28.txt, you added some .mount file for it? | 15:14 |
T42 | <nitin03 %lastname%> @mal [and the .rc files?], yes I added mount file plus the symlink in local.fs.target.wants | 15:15 |
mal | @nitin03 you also added the .rc files mentioned here https://github.com/mer-hybris/hadk-faq#hybris-16-0 ? | 15:18 |
T42 | <nitin03 %lastname%> filename system-etc-ld.config.28.txt.mount...and its content https://pastebin.com/syQEx43F | 15:18 |
T42 | <nitin03 %lastname%> @mal [@nitin03 you also added the .rc files mentione …], yeah i already have these 3 files | 15:19 |
mal | did you add anything to straggler files in droid-hal spec file? | 15:20 |
T42 | <nitin03 %lastname%> @mal [did you add anything to straggler files in dro …], yes | 15:20 |
mal | hopefully logs tell something, you need to remove init_enter_debug2 after you changed journal logging, you could also try masking droid-hal-init to see if that helps | 15:23 |
T42 | <nitin03 %lastname%> okk...thanks so much | 15:24 |
deathmist | mal: here's the output of udevadm info for my /vendor partition for example https://pastebin.com/cqp6LGfb | 15:46 |
T42 | Thinhx2 was added by: Thinhx2 | 15:47 |
T42 | <Thinhx2> @nitin03 %lastname% [okk...thanks so much], Sailfish booted in your poco f1? | 15:50 |
T42 | <nitin03 %lastname%> @Thinhx2 [Sailfish booted in your poco f1?], no | 15:50 |
T42 | <Thinhx2> Same mi8se | 15:51 |
T42 | <nitin03 %lastname%> @Thinhx2 [Same mi8se], at which stage you r stuck? | 15:52 |
T42 | <Thinhx2> Libstick is crash | 15:52 |
T42 | <Thinhx2> Fwd from Thinhx2: Telnet,led,log debug,usb port,battery,network fine,button fine | 15:53 |
deathmist | @Thinhx2 give journalctl -b output, also what base? | 15:53 |
T42 | <nitin03 %lastname%> @Thinhx2 [Telnet,led,log debug,usb port,battery,network …], so it booted? | 15:53 |
T42 | <Thinhx2> @deathmist [@Thinhx2 give journalctl -b output, also what …], Los16 bro | 15:54 |
T42 | <Thinhx2> @nitin03 %lastname% [so it booted?], Stuck mi logo | 15:54 |
T42 | <Thinhx2> https://pastebin.com/8A3x2FjW | 15:55 |
deathmist | at least droidmedia is not built but that shouldn't be an issue iirc, can you link your droid-config repo? | 15:59 |
deathmist | and give output of "mount" command | 15:59 |
T42 | <Thinhx2> @deathmist [at least droidmedia is not built but that shou …], https://github.com/BusterGR18/droid-config-sirius | 16:01 |
T42 | <Thinhx2> Here for you | 16:01 |
rinigus | deathmist: vendor partition is probably not the best example, it maybe checked for mount. There was some coffee in repo referenced by mal. What about some other, obscure partition? | 16:04 |
rinigus | Not mounted one | 16:05 |
deathmist | rinigus: mal: https://pastebin.com/cqp6LGfb there, updated with my "LOGO" partition instead which definitely isn't mounted | 16:07 |
mal | also check info from one of those disk (like sdb or something) | 16:08 |
mal | deathmist: is that shown in settings storage list? | 16:08 |
T42 | <Thinhx2> What i need to do now,m | 16:11 |
mal | is that hybris-16.0? | 16:11 |
T42 | <Thinhx2> Right | 16:11 |
T42 | <Thinhx2> Use linage source 16.0 android 9 | 16:12 |
deathmist | I honestly don't know, all unmounted ones except a few say "Unsupported SAMSUNG memory card" and "The filesystem is incompatible. Formatting is needed.". from the mounted ones I see /system, firmware, dsp, vendor. updated same paste with sdb info | 16:13 |
T42 | <Thinhx2> @deathmist [I honestly don't know, all unmounted ones exce …], Oh shit,my mi8se using samsung emmc | 16:15 |
mal | @Thinhx2 you are missing the mount service for ld.config.vndk_lite.txt, the droid-hal-early-init.sh is not working well and should be replaced with a mount service (adapt this https://pastebin.com/syQEx43F, name should be system-etc-ld.config.vndk_lite.txt.mount) | 16:15 |
mal | although not sure if that is even needed | 16:16 |
T42 | <Thinhx2> Thank you so much, thank all | 16:16 |
T42 | <Thinhx2> Let me try | 16:16 |
mal | @Thinhx2 you need to provide logs, journalctl -b and if possible /usr/libexec/droid-hybris/system/bin/logcat | 16:17 |
rinigus | Sounds to me that we have to blacklist devices on udev level as udisks_ignore was pretty much ignored by udisks and it still created entries under dbus interface. (As checked this weekend). | 16:17 |
rinigus | deathmist mal /\ | 16:18 |
rinigus | Although, checking on onyx, there are descriptions for partitions on dbus that are not down in settings.. | 16:22 |
vknecht | gotta hope this assertive regexp is not the cause of your trouble (just wondering, can't really get all it implies...) https://git.merproject.org/mer-core/nemo-qml-plugin-systemsettings/blob/master/src/udisks2monitor_p.h#L48 | 16:57 |
mal | vknecht: rinigus https://git.merproject.org/mer-core/nemo-qml-plugin-systemsettings/blob/master/src/partitionmanager_p.h#L46 | 17:01 |
rinigus | vknecht: good find! corresponding commit: https://git.merproject.org/mer-core/nemo-qml-plugin-systemsettings/commit/5772467e04150535b97f6a5796bce9d204a46f3b | 17:01 |
mal | rinigus: we still need to know how sd card is shown before we do anything to those lines | 17:02 |
mal | probably needs some configuration option to use a custom regex? | 17:02 |
deathmist | mal: damn it seems lists my internal device partitions "sd[a-f]*" as external, could this be it? when I plugged in a USB drive via OTG it showed up as sdg | 17:03 |
mal | deathmist: I think it's because of that | 17:04 |
deathmist | guess I could compile a custom version right now to test it for my own device | 17:04 |
deathmist | for me adjusting it the sdX range to sd[g-z] should be good enough | 17:04 |
mal | yes, but a proper fix is needed | 17:05 |
rinigus | mal: I'll test. It's just after rebuild yesterday, I have boot loops due to ofono. Ofono is disabled by moving it's service. On to of it, i lost wifi and I'm trying to get some logs to figure out why | 17:31 |
deathmist | mal: rinigus: yep, after the change all seems to work perfectly :) https://imgur.com/a/2k63nPk | 17:32 |
rinigus | As for fix, we should probably check for udisk2 or udev env variable. That way we can skip all this hard coded regex from code | 17:32 |
mal | deathmist: now that is missing the internal storage parts, user and system | 17:53 |
deathmist | tbh I don't know how it's supposed to look, I've only browsed the internal storage using the entry there, what is it meant to look like? | 17:54 |
*** rinigus97 is now known as rinigus_ | 17:55 | |
mal | deathmist: it should have "User data", "System data" and then variable amount of external devices depending on what is supported by the device | 17:55 |
mal | deathmist: I assume that "Mass memory" is root or something? | 17:56 |
mal | which would suggest it is also detected incorrectly | 17:56 |
rinigus_ | mal: Mass memory is in the case it doesn't detect 2 partitions (/ and /home). | 18:00 |
deathmist | mal: I guess it's actually "User data", when I go to "file manager" there it goes to "User data", not sure how I would rename those properly since I don't remember seeing those before either in the menus. I assume "User data" = /home/nemo and "System data" = / then? | 18:01 |
deathmist | I added a few more screenshots there too now | 18:01 |
rinigus_ | https://git.merproject.org/mer-core/nemo-qml-plugin-systemsettings/blob/master/src/partitionmanager.cpp#L113 | 18:01 |
rinigus_ | mal: same is on onyx | 18:01 |
mal | rinigus_: yes, seems like it, I only checked official device for that | 18:02 |
mal | deathmist: the "Mass memory" is correct | 18:02 |
mal | in ported devices | 18:02 |
vknecht | ah crap, was hoping to use partitionmanager's externalStoragesPopulated signal, but it's too new :-( | 18:08 |
vknecht | grr, seems to lead to harbourd invalidation anyway... too bad, seemed to work... | 18:42 |
T42 | <nitin03 %lastname%> do I need to build udevadm also? | 18:51 |
T42 | <nitin03 %lastname%> it isn't mentioned anywhere in the guide | 18:51 |
mal | @nitin03 that is not relevant for you | 18:54 |
mal | we were talking about a different issue here | 18:54 |
T42 | <nitin03 %lastname%> @mal [@nitin03 that is not relevant for you], oh | 18:59 |
T42 | <nitin03 %lastname%> I was reading hadk faq page | 18:59 |
T42 | <nitin03 %lastname%> It was mentioned there | 18:59 |
mal | which part of it? | 19:00 |
mal | what issue are you trying to fix now? | 19:00 |
T42 | <nitin03 %lastname%> @mal [which part of it?], It was a general question | 19:02 |
T42 | <nitin03 %lastname%> it was mentioned in debugging tips | 19:02 |
T42 | <nitin03 %lastname%> So I asked if I will ever need it | 19:02 |
piggz | rinigus: so, im inserting an sd card to see what happens on pro1? | 19:03 |
piggz | rinigus: | 19:11 |
piggz | UDEV [15865.971553] add /devices/soc/c0a4900.sdhci/mmc_host/mmc0/mmc0:e624/block/mmcblk0 (block) | 19:11 |
piggz | UDEV [15866.247304] add /devices/soc/c0a4900.sdhci/mmc_host/mmc0/mmc0:e624/block/mmcblk0/mmcblk0p1 (block) | 19:11 |
piggz | so, system is /dev/sd[a=f] | 19:11 |
piggz | and, sd is mmcblk0 | 19:11 |
rinigus | piggz: interesting, does it show up in settings/storage then? | 19:12 |
piggz | rinigus: i dont think it does | 19:12 |
piggz | but, the list is so long, its hard to be sure! | 19:12 |
rinigus | mal: see above, on pro1. I'm still fighting with my wifi, will be able to test later | 19:16 |
rinigus | piggz: do you know if it's mounted on insertion? | 19:17 |
piggz | doesnt seem to be | 19:17 |
piggz | i did get a notification on insertion tho | 19:17 |
piggz | "memory card inserted SDCARD" | 19:18 |
piggz | clicking notification takes to storage settings page | 19:18 |
mal | rinigus: ok, that will need some configuration because normally mmcblk0 is assumed to be the internal storage | 19:21 |
piggz | mal: anything i can do? | 19:22 |
mal | piggz: you mean for the storage handling? check the repo mentioned earlier and see if can see some easy way to make the internal/external detection configurable | 19:23 |
T42 | <adampigg> (Photo, 2560x1440) https://irc.thaodan.de/.imgstore/mxqpbJ04CD.png | 19:23 |
T42 | <adampigg> Kimmoli^^ | 19:23 |
T42 | <adampigg> Mal, ok | 19:24 |
T42 | <adampigg> The nemo one? | 19:24 |
mal | @nitin03 can you show output of dmesg and also /usr/libexec/droid-hybris/system/bin/logcat (assuming that works) | 19:24 |
mal | piggz: https://git.merproject.org/mer-core/nemo-qml-plugin-systemsettings/commit/5772467e04150535b97f6a5796bce9d204a46f3b | 19:24 |
T42 | <DylanVanAssche> Out of curiosity, the Aliendalvik 8.1 depends it on Android base adaptation or just the Linux kernel (like lxc support)? | 19:26 |
rinigus | mal piggz: yes, looks like we need ability to configure that. ideally, it should be via udisks2, so we could drop all regex handling over there. | 19:33 |
mal | rinigus: that is one option, I'll discuss this internally tomorrow | 19:34 |
rinigus | mal: thanks! | 19:35 |
T42 | <nitin03 %lastname%> @mal [@nitin03 can you show output of dmesg and also …], https://pastebin.com/FwBfvRbw dmesg | 19:38 |
mal | hmm, no messages from droid-hal-init | 19:50 |
piggz | mal: rinigus: perhaps use the HintSystem property? | 19:50 |
mal | piggz: what is that? | 19:52 |
piggz | mal: a property for block devices in udesks | 19:53 |
piggz | http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Block.html#gdbus-property-org-freedesktop-UDisks2-Block.HintSystem | 19:53 |
piggz | it seems to be set correctly for me for /dev/sd? and mmcblk0p0 | 19:53 |
piggz | etc | 19:53 |
rinigus | piggz: I did try on sunday, but it somehow wasn't taking it into account | 19:53 |
piggz | ie, true for sd?, false for sdcard | 19:53 |
kimmoli | @adampigg sähkölinnun kakkaa :) on my old KE20 corolla, i had a stone under drivers seat to keep it not falling down. Just changed to larger when it did drop through the floor | 19:57 |
T42 | <nitin03 %lastname%> @mal [hmm, no messages from droid-hal-init], any way to solve it? | 20:32 |
mal | not sure, that just makes debugging a bit more difficult, did /usr/libexec/droid-hybris/system/bin/logcat work? | 20:35 |
T42 | <nitin03 %lastname%> @mal [not sure, that just makes debugging a bit more …], no | 20:35 |
T42 | <nitin03 %lastname%> will masking droid-hal-init help? | 20:36 |
mal | do you still have the file /init_enter_debug2? | 20:37 |
T42 | <nitin03 %lastname%> @mal [do you still have the file /init_enter_debug2?], yes | 20:37 |
mal | well then obviously logcat cannot work as that stops boot very early | 20:37 |
T42 | <nitin03 %lastname%> @mal [well then obviously logcat cannot work as that …], problem is if I remove it | 20:38 |
T42 | <nitin03 %lastname%> I can't telnet into the device | 20:38 |
T42 | <nitin03 %lastname%> i did ran journalctl -fa ...should i share it? | 20:38 |
mal | from which kind of boot? | 20:39 |
mal | I think the issue could be usb-moded configuration which might break usb | 20:39 |
mal | masking droid-hal-init could be one thing to do and then remove /init_enter_debug2 and see if you can still telnet | 20:40 |
T42 | <nitin03 %lastname%> ok let me try | 20:41 |
T42 | <nitin03 %lastname%> https://pastebin.com/UsWLaHWF | 20:42 |
T42 | <nitin03 %lastname%> I was able to telnet...try running logcat...it returns logcat read failure | 20:47 |
mal | logcat requires droid-hal-init to be running | 20:47 |
mal | this is just one step in debugging process | 20:47 |
T42 | <nitin03 %lastname%> systemctl status droid-hal-init...returns this droid-hal-init.service | 20:51 |
T42 | <nitin03 %lastname%> Loaded: masked (/dev/null) | 20:51 |
T42 | <nitin03 %lastname%> Active: inactive (dead) | 20:51 |
T42 | <nitin03 %lastname%> Warning: droid-hal-init.service changed on disk. Run 'systemctl daemon-reload' to reload units. | 20:51 |
rinigus | piggz mal: when checking internal storage, HintSystem was set to true for its partitions. good thing is that it can be easily set in udev rules via udisks_system making it easy to adjust | 20:52 |
T42 | <nitin03 %lastname%> in dmesg droid-hal-init: Failed to initialize property area..this shows up | 20:52 |
piggz | rinigus: yes, thats why i think thats a way to go | 20:56 |
piggz | rinigus: mal: maybe this will help https://github.com/canonical-system-enablement/udisks2-examples/blob/master/query-block-devices.c | 21:01 |
T42 | <hacker12455> Update: fixed the ofono issue after adding droidmedia on cedric | 21:04 |
T42 | <hacker12455> I needed to remove and reinsert the SIM card | 21:04 |
Thaodan | Does avbtool get run during the creation of boot.img for devices? Mine won't boot with the image I build during droid-img-boot compared to the android image | 21:15 |
Thaodan | I noticed aosp does run out/host/linux-x86/bin/avbtool add_hash_footer --image out/target/product/griffin/boot.img --partition_size 0x04000000 --partition_name boot --prop com.android.build.boot.os_version:10 after creating the image | 21:17 |
rinigus | looks I just had issues with prev image. clean build, wifi / bt back and I have correct imei as well (as well as mac & bt addresses as on aosp). | 21:36 |
rinigus | now would have to test how cellular works... | 21:37 |
rinigus | Thaodan: not sure it does. | 21:40 |
Thaodan | Mine doesn't boot used the same kernel as in sfos, i'll test later if that helps. | 21:41 |
Thaodan | Need someone else that wants to step into the tarkness of android 10 :D | 21:41 |
rinigus | Thaodan: have you removed all possible extra filesystems in your config? I had too large kernel with nfs and other goodies included (opened an issue regarding it on sony's github) | 21:43 |
Thaodan | rinigus: only nfs as you did but the exact same kernel builds aosp.. | 21:44 |
Thaodan | *boots | 21:44 |
Thaodan | Also I didn't have --os_version 10 --os_patch_level 2019-09-05 in my boot pkg | 21:46 |
rinigus | Thaodan: I think there was more, like cifs and something else. I found it by mainly commenting out as much extra options as I could. But mine was showing 'corrupted device'. do you make it to sony logo? | 21:46 |
Thaodan | rinigus: yes the screen stays black for a while and then reboots | 21:47 |
Thaodan | I wish I had uart aviable | 21:47 |
rinigus | Thaodan: then its maybe something else. recovery? | 21:48 |
rinigus | ... trying to boot recovery? | 21:48 |
Thaodan | I should try? I already boot to hybris-recovery to debug stuff | 21:49 |
piggz | rinigus: mal: my reading of the plugin code indicates that internally, it ignores the properties from udisks, and just sets system/external based on its own criteria | 21:49 |
rinigus | piggz: does it at least load from udisks? | 21:50 |
piggz | rinigus: there is a monitor that listens to udisk add events | 21:51 |
rinigus | piggz: thanks for looking into it! | 21:55 |
T42 | kisekinopureya was added by: kisekinopureya | 22:10 |
r0kk3rz | piggz: what criteria? | 22:19 |
piggz | r0kk3rz: i mean that it has its own abstraction of the storageTypes (external/system etc) and doesnt seem to query udisks for them | 22:26 |
r0kk3rz | where is the codes? | 22:27 |
piggz | r0kk3rz: https://git.merproject.org/mer-core/nemo-qml-plugin-systemsettings/commit/5772467e04150535b97f6a5796bce9d204a46f3b | 22:48 |
r0kk3rz | ah, so blame rainemak ;) | 22:52 |
r0kk3rz | https://git.merproject.org/mer-core/nemo-qml-plugin-systemsettings/blob/master/src/partitionmanager_p.h#L46 | 22:55 |
r0kk3rz | hmmmmmmm | 22:55 |
r0kk3rz | is my regex fu failing, or does that look like it matches pretty much everything other than mmcblk0* disk paths | 22:56 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!