| T42 | <Matthew %lastname%> Is Sailfish more difficult to pott to an Android RootFS? If so, why? | 07:18 |
|---|---|---|
| r0kk3rz | not really, we do that commonly | 07:45 |
| T42 | <Matthew %lastname%> What changes would be needed? | 07:49 |
| T42 | <Matthew %lastname%> (besides not being able to have a custom /init ) | 07:49 |
| r0kk3rz | you need a custom init and kernel | 08:27 |
| r0kk3rz | otherwise no dice | 08:27 |
| Mister_Magister | r0kk3rz: custom kernel is not really needed, same is custom init we could just edit init on /system since it's system as root now | 08:30 |
| Mister_Magister | to not have custom kernel one would have to patch glibc a lot | 08:30 |
| Mister_Magister | but it's doable | 08:31 |
| r0kk3rz | systemd wouldnt work without a custom kernel | 08:44 |
| Mister_Magister | if you patch glibc it would | 08:45 |
| *** Mister_Magister is now known as Guest839 | 10:57 | |
| *** Mister_Magister_ is now known as Mister_Magister | 11:47 | |
| T42 | <adampigg> Liking the new after call dialog on 3.2.1 | 15:37 |
| Mister_Magister | rinigus: you fixed bootctl in your sony device. can you tell me how you did it? | 16:03 |
| mal | doesn't the default bootctl work? | 16:15 |
| mal | if you mean the command to set successful boot | 16:15 |
| Mister_Magister | no default bootctl doesn't work | 16:20 |
| Mister_Magister | it didn't work either in 5z or pro1 | 16:20 |
| T42 | <adampigg> Mister_Magister: is our patch not good enough for you? | 16:24 |
| Mister_Magister | mal: question for you, why https://github.com/mer-hybris/android_system_core/blob/hybris-15.1/init/README.md#options capabilities don't work in 16.0 | 16:25 |
| Mister_Magister | @adampigg what patch | 16:25 |
| Mister_Magister | you told me to ask rinigus about patch | 16:25 |
| T42 | <adampigg> i said we have one, and rinigus improved it a little | 16:25 |
| Mister_Magister | idk what patch you are talking about | 16:28 |
| mal | Mister_Magister: not sure what the issue is, can you show what you are trying to do | 16:28 |
| mal | @adampigg what are you even patching | 16:28 |
| T42 | <adampigg> mister_magister: 632befce0d88528a9fe986504eafc11518bacf30 | 16:29 |
| Mister_Magister | mal: bootctl | 16:29 |
| T42 | <adampigg> mal: specifically, vendor/qcom/opensource/recovery-ext/oem-recovery/gpt-utils.cpp | 16:29 |
| Mister_Magister | mal: i need CAP_NET_BIND_SERVICE in capabalities for a pm-service to work | 16:30 |
| Mister_Magister | or removing validation for it | 16:30 |
| mal | what does pm-service do | 16:31 |
| Mister_Magister | i have no idea but it's needed for device to boot | 16:32 |
| Mister_Magister | i can ask though | 16:32 |
| mal | on sonys we don't need anything, except making boot as successful https://github.com/mer-hybris/droid-config-sony-ganges-pie/commit/e2adc564fa9c6b5f81d03e94f77bf42214feb375 | 16:33 |
| T42 | <adampigg> mal: android uses absolute filenames, sfos relative, the bootctl binary expects only the androidnaming scheme https://paste.gnome.org/p0wwvxhp3 | 16:33 |
| T42 | <adampigg> mal: rinigus added a patch to sony aosp repo for same thing | 16:33 |
| Mister_Magister | @adampigg i don't have that file | 16:35 |
| Mister_Magister | in addition, i have prebuild bootctl | 16:35 |
| T42 | <adampigg> mal: mister_magister: https://github.com/sonyxperiadev/device-sony-common/pull/655 | 16:37 |
| T42 | <adampigg> ^^rinigus PR | 16:37 |
| mal | @adampigg but why don't we have issues on xa2 or x10? | 16:38 |
| T42 | <adampigg> mal: not having eiterh device, ive no idea! ;) | 16:39 |
| Mister_Magister | mal: did i mention mount --bind is also not working lmao | 16:39 |
| T42 | <adampigg> mal: do those use sdX for rootfs, or mmc? | 16:40 |
| Mister_Magister | @adampigg doubt they use any recent flagship cpu | 16:40 |
| Mister_Magister | like 835 or 845 | 16:41 |
| Mister_Magister | @adampigg meanwhile i'm hacki… erm fixing problems ^^ https://github.com/VerdandiTeam/android_kernel_asus_sdm845/commit/6e240e6c0fb368e84faac8d0a88b2f6c0f6eb9e2 | 16:42 |
| Mister_Magister | mal: capabalities don't work so i have to do this ^ | 16:43 |
| mal | the real question is why are capabilities not working | 16:50 |
| Mister_Magister | @adampigg i don't have gpt-utils | 16:50 |
| Mister_Magister | mal: ye that was my question ^^' | 16:50 |
| Mister_Magister | mal: i did this https://paste.opensuse.org/ce14abaf | 16:50 |
| mal | Mister_Magister: what error do you see in logs | 16:52 |
| Mister_Magister | mal: spam of [ 222.473161] (CPU:7-pid:4224:pm-service) IPC_RTR: msm_ipc_router_bind: pm-service Do not have permissions | 16:53 |
| Mister_Magister | like spam aka after boot i don't see anything else in dmesg/journal | 16:53 |
| rinigus | evening! https://github.com/sonyxperiadev/device-sony-common/pull/655 is a correct pr and there is the same pr pushed into sony's aosp9 tree | 17:33 |
| rinigus | mal: as for why you don't you have the same issue in x10 and xa2 - not sure. | 17:34 |
| mal | rinigus: I find it very odd why some sonys would have such issue but others don't | 17:38 |
| rinigus | mal: chipsets are different, storage is organized differently. so, looks like symlinks are made differently as well. for xz2, symlinks were such that the assumptions used in gpt-utils were incorrect. fix was initially done by piggz for his device, adjusted later for sonys | 17:40 |
| rinigus | in this respect looks like the divide is by chips, not manufacturer of device. | 17:41 |
| Mister_Magister | rinigus: that doesn't help me much as i don't build bootctl sadly | 17:42 |
| Mister_Magister | but thanks | 17:42 |
| Mister_Magister | mal: any idea how to change lipstick height | 17:42 |
| rinigus | Mister_Magister: yes, it comes from android side of things. but you should probably build it and get it used somehow. | 17:43 |
| Mister_Magister | rinigus: wdym | 17:43 |
| rinigus | how do you plan to mark boot as 'successful'? | 17:44 |
| rinigus | Mister_Magister: ^ | 17:44 |
| Mister_Magister | i have no idea | 17:44 |
| mal | rinigus: so did you look at checking if symlinks could be fixed if those are causing some issues | 18:11 |
| mal | rinigus: I gave the link to how boot is marked successful | 18:12 |
| rinigus | mal: I believe I am using the same way as xa2 and x10 to mark the boot successful. in the end of the day, its calling that function in gpt-utils. as that function was just trimming link names, we made it better. | 18:15 |
| mal | so was the issue udev rules really? | 18:15 |
| mal | which you ended up fixing in another way? | 18:15 |
| rinigus | it was some time ago and I don't remember the details. but, from the comment on https://github.com/sonyxperiadev/device-sony-common/pull/655/files#diff-f8df0a90ebacd45554ab97ad4a3402c1L1056 it sounds like we have different path for created links | 18:16 |
| rinigus | mal: no, udev makes all correctly. just it makes them differently from what's made in android | 18:16 |
| mal | but if the issue is link then to me that seems like udev rule issue not issue in that | 18:16 |
| mal | rinigus: well then those are not correct if android doesn't like it | 18:17 |
| mal | the whole point of the complicated rules is to make android side happy | 18:17 |
| mal | it wouldn't be the first time we have to change the rules | 18:18 |
| Mister_Magister | mal: i can experiment with udev rules | 18:18 |
| rinigus | mal: depends on your pov. as that android function was particularly silly, sony's aosp accepted the change. | 18:19 |
| rinigus | and it now works for aosp and linux | 18:19 |
| mal | my view is that if our udev rules break something then it's our fault not android side | 18:19 |
| T42 | <adampigg> mal: my view is that the android code should make such simple assumptions....they even assume a fixed length block device name | 18:24 |
| rinigus | mal: ok, let's get down to this. that function was assuming that device is in /dev/block/sda form. so, when link was to /dev/sda, you were screwed. see https://github.com/sailfishos-sony-tama/device-sony-common/blob/4a7c0ca31ed91ede4ff456bf241ee323c3064c2c/hardware/gpt-utils/gpt-utils.cpp#L1075 | 18:24 |
| T42 | <adampigg> s/shouldnt | 18:24 |
| rinigus | and https://github.com/sailfishos-sony-tama/device-sony-common/blob/4a7c0ca31ed91ede4ff456bf241ee323c3064c2c/hardware/gpt-utils/gpt-utils.cpp#L81 | 18:24 |
| Mister_Magister | also mal and rinigus here is my log https://paste.opensuse.org/51913509 | 18:25 |
| rinigus | new code checks for buffer overflows and in a more correct way (not perfect though, that would require way more data) finds device from partition name. | 18:25 |
| T42 | <adampigg> mister_magister, error isnt bootctl binary, its the boot service ... check android log | 18:26 |
| Mister_Magister | oh | 18:26 |
| Mister_Magister | bootcontrolhal: get_partition_attribute: Failed to get disk info | 18:27 |
| Mister_Magister | oh and gpt-utils: gpt_get_header: Failed to open ../../../../.. : Is a directory | 18:27 |
| mal | rinigus: so incorrect udev rules | 18:29 |
| Mister_Magister | mal: i can help debugging if you want… | 18:29 |
| rinigus | Mister_Magister: check where do those links really point. its | 18:29 |
| Mister_Magister | what links though? | 18:29 |
| rinigus | its the same issue as piggz and I had | 18:29 |
| mal | @adampigg of course android code can make stupid assumptions, we just have to live with it, we don't really want to patch all bases with some random patches | 18:29 |
| Mister_Magister | rinigus: i have no idea what links are those | 18:30 |
| mal | probably would be a good idea to boot to android if possible and check the ls -lR /dev/ | 18:30 |
| mal | or just /dev/block/ | 18:31 |
| mal | but based on what rinigus said the fix should be quite simple | 18:31 |
| mal | maybe | 18:31 |
| rinigus | mal: I do understand your point. not all are as responsive as sony | 18:32 |
| T42 | <adampigg> or us with the fxtec source :) | 18:32 |
| Mister_Magister | c…closed source here… | 18:33 |
| T42 | <adampigg> well, you can be the first to try mal's way then | 18:33 |
| Mister_Magister | well i offered my help but well | 18:33 |
| T42 | <adampigg> as mal said, you will need the /dev/ path from android, and write udev rules to re-create fully on sfos | 18:34 |
| Mister_Magister | oki asked people for /dev already | 18:34 |
| Mister_Magister | it will take a while though | 18:34 |
| T42 | <adampigg> no symlinks aloud | 18:35 |
| Mister_Magister | you mean allowed? | 18:35 |
| rinigus | Mister_Magister: pull /dev/block ls -lR | 18:35 |
| T42 | <adampigg> ayw | 18:35 |
| T42 | <adampigg> aye | 18:35 |
| Mister_Magister | https://paste.opensuse.org/d717ea65 | 18:35 |
| Mister_Magister | you want sfos one too? | 18:36 |
| rinigus | in sfos we use relative links and point to /dev/sda | 18:37 |
| rinigus | as in ../../../../sda for example. | 18:37 |
| Mister_Magister | hmm | 18:37 |
| Mister_Magister | can we not use relative links? | 18:37 |
| Mister_Magister | https://paste.opensuse.org/88392344 sfos here | 18:37 |
| rinigus | hence you get that stupid error message from gpt-utils | 18:37 |
| rinigus | mal: looking forward to udev magic to fix those symlinks | 18:38 |
| Mister_Magister | rinigus: passive agressive :P | 18:39 |
| Mister_Magister | i will have to yet make custom install to allow sfos install in twrp | 18:41 |
| Mister_Magister | rinigus: we killed him ;-; | 18:51 |
| T42 | <Akatsu %lastname%> can i use one HADK to develop for two separated devices? | 18:51 |
| rinigus | Mister_Magister : surely not :) | 18:52 |
| vknecht | mal, following up on yesterday, seems I have all correct patches esp. wrt. selinux... could it be I need to adapt ld.config.txt (which loire has), like it's done for ld.config.28.txt (which loire hasn't) ? | 18:58 |
| vknecht | seems like a goog alternative to adding lots of ld preloads... | 18:59 |
| vknecht | *good | 18:59 |
| mal | could be | 19:22 |
| vknecht | hmm, there must be something else, seeing « SELinx: failed to acquire [...] context. Aborting » in logcat https://pastebin.com/d047zRgM | 19:27 |
| vknecht | looks like it's binder complaining | 19:32 |
| mal | vknecht: so are you trying to have selinux enabled or disabled? | 19:46 |
| vknecht | enabled, if possible | 19:50 |
| vknecht | does this question imply that if I don't use selinux=0 cmdline, I shouldn't disable selinux in /etc/selinux/config ? | 19:54 |
| mal | yes | 19:57 |
| mal | and the proper patch to system/core so android doesn't try to init selinux and systemd does | 19:57 |
| mal | vknecht: https://github.com/mer-hybris/droid-config-sony-ganges-pie/commit/2ddbae734f48e3ea0aec5fec5e017bcfea11ebbe | 19:58 |
| mal | do you have all of those | 19:58 |
| T42 | <adampigg> vknecht: i fell foul of this, when updating to 3.2.0, i had selinux enabled but permissive, 3.2.0 systemd turns it on, and dhi breaks | 19:59 |
| vknecht | I have those in sparse, tho disabled in config ; so SELINUX= in config should match what's set on boot ? | 20:01 |
| vknecht | will have to try that then... | 20:02 |
| mal | disabled in config? | 20:03 |
| mal | just check the sony ganges kernel configs to see how it should be | 20:04 |
| vknecht | I meant in sparse/etc/selinux/config | 20:04 |
| mal | you should use the ones in that commit I linked | 20:04 |
| mal | i.e. permissive mode | 20:05 |
| mal | and what did you mean by " so SELINUX= in config should match what's set on boot" | 20:05 |
| vknecht | was wondering if it's a problem when selinux mode set on boot (by bootloader) is different than what's set in sparse/etc/selinux/config at SELINUX= line | 20:07 |
| mal | it shouldn't matter afaik, hopefully | 20:07 |
| rinigus | mal & vknecht: while I was able to have selinux in permissive in 3.1. on xz2, 3.2 with new systemd didn't allow me to boot properly. to look into it is in my todo list at some moment... | 20:44 |
| rinigus | ... would like to get selinux supported properly and move in parallel with official devices | 20:45 |
| vknecht | rinigus, what were the symptoms following 3.2 change ? was it something like {hw,vnd}servicemanager getting killed, or something else ? | 21:02 |
| rinigus | vknecht: it was stuck on logo, I think. can't find log right now, will probably have to try again some other night | 21:04 |
| rinigus | (getting late over here) | 21:05 |
| vknecht | ok well, that's what I have (stuck on logo, with led lighting for ~30s then off), tried both disabled and permissive in config file but it's the same | 21:06 |
| vknecht | tho I suspect there's some loire difference to handle | 21:06 |
| vknecht | but right, it's late, we'll see :-) | 21:07 |
| vknecht | I mostly followed tama's procedure, but I have a doubt about syspart section: ganges' procedure mention doing a "rpm/apply-patches.sh --mb" while tama's don't | 21:10 |
| rinigus | vknecht: interesting... I used ganges as a base and I do wonder whether I missed it when I was doing it | 21:13 |
| vknecht | maybe it's nothing, or handled differently, can't say I have it all wrapped around my head | 21:13 |
| vknecht | uh, is the community meeting tomorrow ? too bad there was no reminder :-) | 21:20 |
| mal | there are sets of patches, one for system partition and other for hybris, in the sony build | 21:29 |
| vknecht | ah, and the syspart part is just the equivalent of sony's repo_update, right ? | 21:32 |
| T42 | <edp_17> @Elros, Can you help me if you are around, please? | 22:17 |
| deathmist | there is definitely something horribly wrong with RIL on SFOS side for me, logcat -b radio only gives about 200 lines and never gets any output after toggling cellular, compared to android with almost 4400 lines from same output and connected cellular data right after boot | 22:22 |
| deathmist | SMS and calls work flawlessly, just cellular data is dead and not working in Sailfish OS for me... | 22:23 |
| deathmist | device is OnePlus 5 / cheeseburger based on hybris-16.0 (RIL v15) | 22:24 |
| T42 | <edp_17> I am still struggling with my S7 port. Have added the suggested parameters into my kernel defconfig, recompiled the kernel, rebuilt the sfos image, flashed on the device and got the same symptom: the phone stuck on Samsung logo and I manually need to assign a mac address then an IP address to be able to telnet into it. | 22:24 |
| T42 | <edp_17> I am puzzled what's wrong. 😢 | 22:25 |
| T42 | <edp_17> I have connected to the phone with telnet, then did a 'tail -f /init.log &' then 'echo "continue" >/init-ctl/stdin' but still stuck at the samsung logo. | 22:27 |
| T42 | <edp_17> When I tried 'systemctl --user restart lipstick' I got: 'Failed to get D-Bus connection: No such file or directory' | 22:28 |
| deathmist | @edp_17 prob just means systemd isn't running correctly, did you run that from initramfs (telnet 23) or SFOS rootfs (telnet 2323)? | 22:30 |
| T42 | <edp_17> I did 'telnet 192.168.2.15 2323' | 22:31 |
| T42 | <edp_17> Should I try to 'telnet 192.168.2.15 23'? | 22:32 |
| T42 | <edp_17> The 'telnet 192.168.2.15 23' gives me: 'telnet: Unable to connect to remote host: Connection refused' | 22:33 |
| deathmist | no lol that is for very early init, you don't use it unless SFOS rootfs fails to load (/data not mounted or something) | 22:33 |
| deathmist | dbus issues / journalctl not working point to incorrect defconfig iirc, there could be other things wrong too that influence this tho. what base are you using? output of "mount" command is probably useful | 22:35 |
| T42 | <edp_17> I use CM14.1 base. The output of mount: https://pastebin.com/Udx3vLgp | 22:37 |
| T42 | <edp_17> Soryyyyy, wrong mount output! That's my pc's | 22:39 |
| T42 | <edp_17> I accidentally exited the telnet before I did the mount. | 22:40 |
| T42 | <edp_17> This is the output of mount of the device: https://pastebin.com/xDqn5tZY | 22:40 |
| T42 | <edp_17> Sorry! | 22:40 |
| deathmist | right, well you only seem to have /data mounted which isn't much help to get droid services running etc. other mounts like /system should've be picked up from your device fstab => fstab is probably not in out/ of your HADK source tree | 22:45 |
| deathmist | that's all I'm gonna say as I'll have to go now and get some sleep | 22:45 |
| T42 | <edp_17> Thank you and good night! | 22:46 |
| T42 | <elros34> @edp_17 have you checked droid-hal-$DEVICE.log like I told you? | 22:52 |
| T42 | <elros34> you also had android.mount in you log. Where did it come from? | 22:56 |
| T42 | <edp_17> Hi @Elros! Yes, and I found something bigger issue. | 23:02 |
| T42 | <edp_17> Or maybe it is not, I just think big. | 23:02 |
| T42 | <elros34> so why don't you pastebin it and upload your droid-config changes because that mount unit looks wrong and timouts | 23:03 |
| T42 | <edp_17> Give me a few minutes I commit and push all changes to github. | 23:03 |
| T42 | <edp_17> Oh well, yes I can put that to the pastebin. In a minute. | 23:04 |
| T42 | <edp_17> The issue I have found was: the .repo/manifest.xml was pointing to the manifests/default.xml rather to the local_manifests/herolte.xml | 23:06 |
| T42 | <edp_17> At least in my hammerhead build the .repo/manifest.xml is pointing into the local_manifests/hammerhead.xml | 23:07 |
| T42 | <elros34> I also have manifest.xml -> manifests/default.xml | 23:10 |
| T42 | <edp_17> Okay, so this might wasn't a problem then. | 23:11 |
| T42 | <elros34> problem is probably with your mount points | 23:12 |
| T42 | <edp_17> In the meantime I uploaded the defconfig: https://pastebin.com/TWGqZh4a | 23:12 |
| T42 | <edp_17> and the mer-kernel-check result: https://pastebin.com/DYyC2RDS | 23:12 |
| T42 | <edp_17> How and where should I check that mounting point? Is it supposed to be somewhere in sparse? | 23:15 |
| T42 | <elros34> I told you check droid-hal-$DEVICE.log | 23:16 |
| T42 | <elros34> not sure if that is important but you should set CONFIG_UEVENT_HELPER_PATH="", CONFIG_AUTOFS4_FS=y and CGROUP related when possible | 23:17 |
| T42 | <edp_17> The droid-hal-herolte.log: https://pastebin.com/7h4Nd3PF | 23:19 |
| T42 | <edp_17> Yes, I did check that, but I wasn't sure what I see was good or not so good. | 23:19 |
| T42 | <elros34> check content of /lib/systemd/system/system.mount. It should mount /dev/sdaX. Looks like you are missing detritus package | 23:23 |
| T42 | <edp_17> Okay, I set those what you suggested in the kernel defconfig and re-try. Thanks. | 23:24 |
| T42 | <elros34> kernel changes are not that importatn right now. You still didn't answer about android.mount . It's not created by droid-hal so I guess you created it? | 23:26 |
| T42 | <edp_17> I didn't do that. | 23:29 |
| T42 | <edp_17> 5.3 in the hadk. Oops. I didn't need to worry about that in hammerhed so I skipped that for the S7 too. I go back and check. | 23:30 |
| T42 | <elros34> check what package provides these moun units: rpm -qf /lib/systemd/system/android.mount and android_external.mount and what they contains. | 23:34 |
| T42 | <edp_17> I have found out that I did update the fixup-mountpoints with the relevant stuff: https://pastebin.com/qVNJgprw | 23:35 |
| T42 | <edp_17> android.mount and android_external.mount are by me: https://github.com/edp17/droid-config-herolte/tree/edp17/sparse/lib/systemd/system | 23:36 |
| T42 | <edp_17> I wanted to mount the android root into /android and the external sd card into /externalsd. | 23:37 |
| T42 | <edp_17> Wasn't a good idea? | 23:37 |
| T42 | <elros34> no, android.mount is wrong (it use /dev/block/sdaX instead /dev/sdaX) and pointless, this partition is already mounted in /data. External sdcard should be mounted by udisks | 23:38 |
| T42 | <elros34> Remove them drom device, reboot and get fresh journalctl. This is also needed: https://github.com/edp17/droid-hal-herolte/blob/master/droid-hal-herolte.spec#L12 | 23:41 |
| T42 | <elros34> from* | 23:41 |
| T42 | <edp_17> Okay, the android.mount I copied over from hammerhead and modified, then I created the other. | 23:41 |
| T42 | <elros34> droid-hal-startup.sh is also wrong. You added to many custom changes instead just trying to get gui working first | 23:43 |
| T42 | <edp_17> Aye aye, sir. android.mount and the other plus the corresponding .sh from /usr/bin are removed. | 23:44 |
| T42 | <edp_17> I am a bit lost, where that droid-hal-startup.sh is located? | 23:46 |
| T42 | <edp_17> Found it. | 23:47 |
| T42 | <edp_17> I didn't add anything extra into that. Hmm. | 23:48 |
| T42 | <edp_17> The thing is, based on my recent hammerhed work, I thought I squeeze everything into the firs S7 build what I could. Seemingly that was a very bad idea. | 23:53 |
| T42 | <edp_17> I wanted to save time and do less iteration. | 23:53 |
| T42 | <elros34> if you want to do less iteration then make changes on device | 23:54 |
| T42 | <edp_17> I see. | 23:55 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!