| jusa | piggz: what pketo said | 07:33 |
|---|---|---|
| pketo | or maybe propose suitable times to have a chat if you really want synchronous discussion? | 07:51 |
| T42 | <adampigg> Jusa: available? I had to patch the pa meego volume plugin because it crashed with an invalid number of channels... | 08:52 |
| T42 | <adampigg> So far i made it not crash, but its also not.working to control the volume | 08:53 |
| T42 | <adampigg> wondered if u had any thoughts what could cause it | 08:55 |
| T42 | <adampigg> device is pinephone, so not hybrs based | 08:55 |
| T42 | <adampigg> git.sailfishos.org/piggz/pulseaudio-modules-nemo/tree/vol-debug | 08:58 |
| piggz | rinigus: mal: can either of you create new projects on obs? | 19:56 |
| rinigus | piggz: looks like I can: https://build.merproject.org/project/show/home:rinigus:sandbox:hello | 19:58 |
| rinigus | package as well | 19:58 |
| piggz | rinigus: can you create nemo:devel:hw:fxtec:QX1000 | 19:59 |
| rinigus | piggz: no, I don't think so. I don't have permissions for that. | 20:04 |
| piggz | mare | 20:04 |
| mal | I can | 20:05 |
| piggz | mal: \o/ | 20:05 |
| mal | piggz: aren't codenames usually in lower case? | 20:05 |
| piggz | they changed the device name of the Pro1 between the dev kit and the release | 20:05 |
| piggz | mal: not this one | 20:05 |
| piggz | hang on, ill check what device says | 20:05 |
| mal | piggz: you can have different codename in hybris-hal build and rpm packaging | 20:06 |
| mal | like I do on fp2 | 20:06 |
| piggz | mal: so, i shoul stick with the t5 repo? | 20:06 |
| mal | you can if you want | 20:06 |
| piggz | would be easier than copying all the packages over | 20:06 |
| mal | or we can create qx1000 for example | 20:06 |
| piggz | mal: in settings/about it is capitals | 20:07 |
| piggz | and in usdk, £device is QX1000 for the lunch command | 20:07 |
| mal | piggz: well at least when I was porting fp2 packaging scripts didn't like capital letters in codenames | 20:07 |
| piggz | hmmm | 20:08 |
| piggz | in the t5 repo on obs, should I add droid-hal-QX1000 ? | 20:09 |
| piggz | and associated -config- and -version- ? | 20:09 |
| piggz | or some other way? | 20:09 |
| mal | probably easier to do a new repo if you are doing to rename things | 20:17 |
| mal | and use qx1000, not QX1000 | 20:17 |
| piggz | mal: how will that work when the actual name is QX1000 when it comes to the flashing checks? | 20:22 |
| mal | piggz: install script is created in hybris-hal build meaning it uses the codename from android side | 20:25 |
| mal | piggz: why don't you trust that I know what I'm talking about :) | 20:26 |
| piggz | mal: I do trust you, im just wondering where the case issue is, just obs? | 20:26 |
| piggz | packages can use upper? | 20:27 |
| mal | I think somewhere in dhd, dhc or dhv | 20:27 |
| mal | submodules | 20:27 |
| mal | or something like that | 20:27 |
| mal | can't remember where | 20:27 |
| piggz | so, $device has to be lowercase in build sdk, but upper in android sdk? | 20:28 |
| mal | android side can be anything | 20:29 |
| mal | our scripts are just limited somehow | 20:29 |
| piggz | ok | 20:29 |
| piggz | pls make lower case repo, and ill make some changes here | 20:30 |
| mal | piggz: https://build.sailfishos.org/project/show/nemo:devel:hw:fxtec:qx1000 | 20:32 |
| mal | piggz: if you want to check how to do the separate codenames check my fp2 repos | 20:32 |
| piggz | ok | 20:32 |
| mal | https://github.com/mlehtima/droid-hal-fp2-sibon/blob/master/droid-hal-fp2-sibon.spec#L2 | 20:32 |
| piggz | mal: mer kernel checker fails becuase it looks for out/target/product/qx1000/...... and not QX1000 | 20:46 |
| mal | piggz: are you sure you are doing things correctly | 20:48 |
| piggz | is that where the rpm_device comes in? | 20:48 |
| mal | piggz: you need to export DEVICE=QX1000 in habuild_sdk | 20:48 |
| mal | piggz: I don't have any issues with fp2 build but I export the android side device codename in habuild | 20:49 |
| piggz | yeah, the habuild (android_ side is fine, the platform sdk doesnt find the correct folders..... | 20:51 |
| mal | hmm | 20:52 |
| mal | wondering what is wrong | 20:52 |
| mal | upload the repos | 20:53 |
| piggz | think i fixed it | 20:53 |
| mal | what was wrong? | 20:53 |
| piggz | in spec, device is QX1000 and rpm_device is qx1000 | 20:53 |
| mal | yeah, what did you have there | 20:56 |
| piggz | i didnt have rpm_devce | 20:56 |
| piggz | and device was lowercase | 20:57 |
| mal | ah, so you didn't check the link I gave :) | 21:08 |
| piggz | mal: i had to understand the link u gave | 21:22 |
| piggz | mal: you didnt tell me about export HABUILD_DEVICE :) | 22:54 |
| mal | piggz: ah, never remembered that, I use old way on fp2 | 23:07 |
| mal | hmm, it seems I have it now, forgot about it anyway | 23:08 |
| piggz | mal: without that, i had issues with packagin droidmedia, on investigating i found that the script checks that variable | 23:08 |
| mal | yeah | 23:08 |
| mal | sorry | 23:08 |
| piggz | mal: what is DROID_AUDIO_HAL_ATOI_FIX for? | 23:09 |
| mal | piggz: that is an old thing, enabled by default on android >= 5 | 23:10 |
| mal | https://github.com/mer-hybris/pulseaudio-modules-droid/blob/dcb0b67f67a90df7cb6e0492249953d22addd6a5/src/common/droid-util.c#L716 | 23:10 |
| mal | I probably should cleanup my repos a bit | 23:11 |
| mal | piggz: that was enabled by default already back in 2017 | 23:12 |
| piggz | ive never used ised it, just saw it in your spec | 23:13 |
| piggz | mal: is the tama branch of https://github.com/sailfishos-sony-tama/mer-libhybris.git in libhybrs main yet? | 23:38 |
| piggz | ah, its for flatpak | 23:39 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!