Monday, 2020-03-30

T42<elros34> If thats the code it use:  then yes 1/0  are only allowed values. As you can se there are many printk(KERN_DEBUG "[TouchKey-BLN] which should be printed in dmesg00:02
T42<edp_17> Thanks @elros34. Yes, that is the latest kernel I use. I'll check the messages in dmesg.00:05
T42<edp_17> The 'dmesg | grep BLN' is full of:
T42<elros34> I would disable timeout completely so write 0 to notification_timeout00:10
T42<edp_17> By default that was -1. I wrote 0 into it and rebooted.00:14
T42<edp_17> I unplugged the cable and a message appeared at the top saying: "Charging..."00:15
T42<edp_17> As the battery is full, the leds are on.00:15
T42<edp_17> Now I got the 'Charging completed' message (cable is still unplugged) and the leds started to blink.00:16
T42<elros34> sysfs is virtual file system so if you reboot values you wrote are lost. So you are getting charging state when usb is unplugged and it stays like that?00:19
T42<edp_17> I have created a service that writes 1 into notification_enabled. I added into the script to write 0 into notification_timeout.00:25
T42<edp_17> And yes, I got 'Charging' message when unplugged the cable and a little later 'Charging completed'00:26
T42<edp_17> Sometimes when there is no cable plugged in to the device I get a 'Not enough power to charge' message too.00:27
T42<edp_17> That's why I think the led configs are ok-ish, and there is something underlying problem with setting the charging status somewhere.00:28
T42<elros34> you could run: mce -Tq -l "modules/battery-udev.c:*" to see if everything looks sane when you disconnect cable00:40
*** Oksana_ is now known as Oksana02:39
spiiroin@edp_17 In case of "odd" battery full signaling, the last resort is something like "if charging stops at something resembling battery full percentage, assume maintenance charging until charger disconnect / battery level drops < threshold" - I guess you are hitting that04:04
spiiroin@edp_17 that unknown charger type warning is due: if charger device has no type property -> device name is used instead. generally speaking: qc devices have "usb" charger that has types like "cdp"/"usb"/... for dedicated-charger/pc-connection/... and mtk devices have charger names such as "ac" / "usb" / ...04:08
spiiroinand what you have is probably not matching either of these expectations -> interpreted as "some sort of charger" + diagnostic warning04:09
spiiroinand the other symptoms (not enough power to charge / battery full while cable is disconnected) look like false positive "charger is connected"04:14
spiiroinwhich is likely to come from broblems with battery-full interpretation. if battery reports it is getting charged / is full, an assumption is made that "there just has to be a charger connected for this to make sense"04:22
spiiroinnow if there are issues with battery state notifications, the sum of heuristics can become: once percentage is high enough -> battery is full and therefore there is a charger04:26
spiiroinways to fix include: get battery state notifications flowing / poll props periodically (if it produces more correct info than notifications) / reverse the assumption (=battery can't be full if no chargers are online)04:29
*** Oksana_ is now known as Oksana06:04
T42Hans_Jo was added by: Hans_Jo07:33
T42<edp_17> @elros34 : Thank you, I'll try that.08:46
T42<edp_17> @spiiroin: Thank you!08:46
T42KasperRib was added by: KasperRib08:48
piggzmal: did you get the config repo i sent08:52
malpiggz: yes, didn't see anything obviously wrong09:45
walidhwhen open image catured with camera its black10:06
T42<edp_17> @elros34 : I ran the suggested mce -Tq -l "modules/battery-udev.c:*"11:32
T42<edp_17> When it ran in fingerterm on the device, I got:
T42<edp_17> When I ran it on the PC I got:
walidhmal: when open image got black screen , i added #define WANT_ADRENO_QUIRKS 1  but nothing change12:54
T42<elros34> walidh: this is fix for black images:
T42<elros34> @edp_17 example from my device for comparison:
T42<edp_17> @elros34 : Thanks. Have you13:41
T42<edp_17> I think know the issue. My device is looking for different type of charger (max8997 and max8922) and the result is wrong "fuelgauge: battery @ cap" value. This would explain why I receive charging messages when the usb is not even plugged in. The relevant comparison against your log is here:
walidhrepo problem: nothing provides needed by droid-config-h918-1-1.armv7hl ??? is in out dir14:19
T42P@t %lastname% was added by: P@t %lastname%14:38
malwalidh: what are you trying to do?14:55
walidhmal: i'm trying to change some vendor blobs files (exp :etc/firmware/a530_zap.b01, vendor/lib/, because now i must push them under recovery,14:58
malyou should not do that14:58
malwhy are those not on the device?14:59
malI mean in /system or /vendor or some firmware partition14:59
malthat is the wrong of trying to fix some thing15:00
walidhbecause cm14.1 based on old bootloader and firmware15:00
walidhso i think  i must create twrp file to change thoes files15:02
T42<elros34> @edp_17 I connected it to wall charger and started mce via ssh15:13
vknechtwalidh, maybe you'd be better off making your own lineageos build, fixing stuff in there directly15:17
vknechtI ended up doing that for fixing proximity sensor, dualsim and useless 3rd "eyeverify" camera which crashed cam apps on switching rear/front15:18
vknechtand lineageos user were happy too :-)15:19
T42<elros34> @edp_17 when you disconnect usb (I assume it happens in line 41) you get led_pattern_activate_pipe PatternBatteryFull instead deactivate. Probably spiiroin could tell you what to do if you show him full log15:21
T42<elros34> There is a ways to blacklist some devices:
T42<edp_17> @elros34 : Good idea to connect via wifi because if I use the usb cable, it looses the connection when I unplug it. Thank you. I will ask spiiroin about that. He already told a lot about it but I need time to get my head around that.15:23
walidhvknecht yes i think this is the best solution15:44
spiiroin@elros34 @edp_17: look out for battery.POWER_SUPPLY_STATUS initial state (line 17) vs changes (only line 55) -> initially "charging", stays that way over disconnect (triggers "battery is charging -> there is a charger" heuristics), changes to "discharging" briefly after reconnect -> discharging while charger connected -> triggers "is full" heuristics15:45
spiiroini.e. notifications about POWER_SUPPLY_STATUS = do not to reflect reality. and since that it is given more weight than -> hiccups15:48
T42<elros34> what if he blacklist: max8997-charger, max8922-charger, ac? If I get it right usb reports correct "present=-1 online=0 -> active=015:50
walidhmal: in camera app i can't switch to front camera there is no button16:40
walidhmal: app camera not show front camera and can't acces to it20:34
vknechtwalidh, try with GST_DEBUG :
vknecht(to get better logs)20:56

Generated by 2.17.1 by Marius Gedminas - find it at!