| Mighty | Umm guys is the matrix bridge broken? | 02:42 |
|---|---|---|
| spiiroin | piggz: scoping the wakeup key thing: it looks like emitting it is used to solve a unique problem one specific device has -> I'm not sure whether there is anything generally usable/useful to do about it | 06:14 |
| spiiroin | if it is a spontaneous (vs. something user does) -> it probably should not wake up display | 06:15 |
| spiiroin | if the reason for emitting those events is to get out and stay out from suspend -> waking display conditionally might not even work | 06:16 |
| spiiroin | if the idea is just to block suspend -> it starts with wakup down. but when does the blocking end? | 06:16 |
| spiiroin | is the "key" is held "down" all the way until incoming call is handled? or is there down event immediately followed by up event? | 06:18 |
| spiiroin | if former, then blocking suspend while key is down = harmless enough to be handled in "core mce" | 06:19 |
| spiiroin | if the end of blocking needs to be deduced from something, like call state -> there is no obvious correlation between the keypress itself and what needs to be done | 06:20 |
| spiiroin | i.e. "wakeup key means something about incoming call" is something that should be handled in device specific way | 06:21 |
| spiiroin | which could be for example a mce plugin used for this particular product only (could be reused of course if need arises) | 06:22 |
| spiiroin | but if this is in a way part of cellular stack -> should mce even be involved with it? which is where standalone binary / patching something else than mce would come in picture | 06:24 |
| T42 | <adampigg> Spiiroin: key up comes in immediately...then, anothet key down/up for every ring of the modem | 06:26 |
| spiiroin | how far apart those are? or does it vary? | 06:27 |
| T42 | <adampigg> A few seconds. .. 5ish probably | 06:27 |
| T42 | <adampigg> For as long as phone is ringing | 06:28 |
| spiiroin | once call state changes suspend is blocked due to that happening too | 06:29 |
| spiiroin | for a while / each call state change | 06:29 |
| spiiroin | might have been that is blocked for duration of incoming call / ringing | 06:30 |
| T42 | <adampigg> Atm, im not getting the call state changed, as ofono isnt picking up the ring while in suspend | 06:30 |
| spiiroin | I mean if ofono gets there -> babysitting ofono is needed until it handles the call | 06:31 |
| spiiroin | have you checked timing between wakeup keypress and call state change? | 06:31 |
| spiiroin | but probably using a automatically canceling wakelock for ~5 seconds should do it | 06:33 |
| T42 | <adampigg> Spiiroin, well, there are a bunch of issues other ports are dealing with like the modem dissapearing from the usb bus while suspended. .. These things are still being workee on | 06:33 |
| spiiroin | is that usb wonkyness just incoming call phase or during call too? | 06:34 |
| spiiroin | because there is built-in assumption in mce that cpu can be put to sleep after call is activated | 06:35 |
| spiiroin | suspend is blocked for initial 30s (or so) of active call, then suspend is allowed (=hack to get non-suspend-aware dtmf playback working) | 06:36 |
| T42 | <adampigg> Just incoming i think.... The bus needs to be re enumerated before ofono can handle call | 06:36 |
| spiiroin | so, to scope whether/how/what works, we could try doing "block suspend for 5 seconds on wakup key down" in mce | 06:38 |
| spiiroin | if that is enough, I see no harm in putting and leaving such thing in mce | 06:39 |
| T42 | <adampigg> cool ... if you want a read-up on the current state, see https://invent.kde.org/teams/plasma-mobile/issues/-/issues/3#note_218386 | 06:39 |
| spiiroin | (if something else uses KEY_WAKEUP for some other reasons, this kind of patch does not affect it) | 06:40 |
| T42 | <adampigg> this is separate from the wakup ... this is around fixing the USB | 06:40 |
| spiiroin | roughly -> case KEY_WAKEUP: mce_wakelock_obtain("key_wakeup", 5000); break | 06:45 |
| spiiroin | plus the adding of KEY_WAKEUP in probing array you already had | 06:46 |
| piggz | spiiroin: so, different to how I had it, converting to a gesture? | 06:46 |
| piggz | and ... when ofono if fixed to detect the call, that will wake up the screen instead? | 06:47 |
| spiiroin | piggz: yes. if it is not user initiated -> it is not really a gesture/power key like thing | 06:47 |
| T42 | <KathrineKarlsen> 𝗜𝗻 𝗺𝘆 𝗹𝗶𝗳𝗲, 𝗜 𝗵𝗮𝘃𝗲 𝗮𝗹𝘄𝗮𝘆𝘀 𝗯𝗲𝗲𝗻 𝘀𝘂𝗿𝗿𝗼𝘂𝗻𝗱𝗲𝗱 𝗯𝘆 𝗮 𝗹𝗼𝘁 𝗼𝗳 𝗮𝗺𝗮𝘇𝗶𝗻𝗴 𝗽𝗲𝗼𝗽𝗹𝗲. 𝗧𝗵𝗮𝗻𝗸𝘀 𝗳𝗼𝗿 𝗯𝗲𝗶𝗻𝗴 𝗼𝗻𝗲 𝗼𝗳 𝘁𝗵𝗲𝗺 𝗠𝗿 𝗠𝗶𝗰𝗵 𝗔𝗻𝗱𝗲𝗿𝘀𝗼𝗻,𝗵𝗲 𝗶𝘀 𝗮 𝗵𝗲𝗹𝗽𝗲𝗿 | 06:47 |
| T42 | <KathrineKarlsen> https://t.me/joinchat/8h6DdZNoEm00MDYx | 06:47 |
| spiiroin | yes. incoming call = display policy special case -> display will unblack when/if proximity / cover sensor is not covered | 06:48 |
| spiiroin | gesture is ignored if display can't be woken up at the time the event is received | 06:49 |
| piggz | ok .. hopefully in the next few weeks there will be some work on ofono ... other distros use newer ofono/plugin so i will likely have to try and port to our version | 06:50 |
| T42 | cryptoheals was added by: cryptoheals | 15:54 |
| rinigus | pketo: sounds like "Xperia XZ2 (h8266 / h8266)" is not registered in the store. would you mind to check it and register if it is missing? | 17:14 |
| rinigus | it is one of the devices from Sony Tama port | 17:15 |
| mal | rinigus: which ones do you support? is that just some variant of the same device you have done before or different device | 17:40 |
| rinigus | mal: there are six devices in sony tama (xz2/xz2c/xz3 x 1- and 2-sim variants). I support all of them, but not all were registered in the store | 17:41 |
| rinigus | ... so, I get once in a while complaint that the store shows limited apps. then I grep irc archive and check if it was registered | 17:42 |
| rinigus | when I asked to register all in one go, pketo preferred to register only ones that I had either access to or some user had access to | 17:43 |
| rinigus | so, no new port or variant in this respect | 17:43 |
| piggz | if anyone fancies being glitlab vertified for free https://about.gitlab.com/blog/2021/04/20/everyone-can-get-certified/ | 17:49 |
| pketo | rinigus: h8266 added | 18:21 |
| rinigus | pketo: thank you very much! | 18:27 |
| T42 | nerd7473 was added by: nerd7473 | 23:43 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!