Tuesday, 2021-05-11

Umeaboy@elros34: I created my droid-hal-beyond2lte with the spec file and the PR was opened, but I can't seem to approve it. Where's the option on Github to merge?00:01
UmeaboyAll I see is a green button saying Compare & Pull request, but I see no button to merge the changes.00:02
UmeaboyThe repo is public and anyone should be able to open a PR in it.00:03
UmeaboyAt least according what I see in the repo Settings.00:03
T42<elros34> what repo?00:03
T42<elros34> not sure what do you mean by PR. If I get it right this is your repo so you only need to push changes. I can see that master branch already have something00:08
UmeaboyI guess I can delete the main branch then.00:09
Umeaboy@elros34: Now that I created and pushed the droid-hal-device.conf, does it look correct to you?00:23
T42<elros34> only generated files so there is nothing to check except droid-hal-device.conf which is wrong: splited lines and some arrow added00:27
UmeaboyNow that I checked that and fixed it, can I have my 3 repos upstreamed now?00:45
UmeaboyI can't find a hybris-17.1 in https://github.com/mer-hybris/local_manifests/branches00:46
UmeaboyI'd like to have it added.00:47
UmeaboyThis happened now: https://ghostbin.co/paste/rxhn00:51
T42<elros34> do you have ANDROID_ROOT set correctly?01:00
Umeaboy@elros34: export ANDROID_ROOT="$HOME/hadk"........ Isn't that correct then?01:17
UmeaboyThat's what's in my .hadk.env01:18
UmeaboyI noticed I can't do cd $ANDROID_ROOT in Platform_SDK, but I can do that in HABUILD_SDK.01:19
UmeaboyI meant PlatformSDK....... Sorry for the underline, but you get the point.01:19
UmeaboyWeird...... Now I CAn do that.01:20
UmeaboyPlatformSDK [kristoffer@localhost ~]$ cd $ANDROID_ROOT01:20
UmeaboyPlatformSDK [kristoffer@localhost hadk]$01:20
UmeaboyI seem to have put the rpm dir in $HOME. Have to read the HADK part to see if I made a boo boo.01:23
UmeaboyI can't seem to build no matter what I change the line to define the target cpu in the spec file.01:33
UmeaboyHow do I fix this?01:34
UmeaboyI don't need to do it right away, but as soon as possible.01:34
UmeaboyI added %define droid_target aarch64 to droid-hal-beyond2lte.spec01:35
T42<birdzhang> Umeaboy: %define droid_target_aarch64 101:45
T42<birdzhang> like https://github.com/mer-hybris/droid-hal-f5121/blob/master/droid-hal-f5121.spec#L1301:45
Umeaboy@birdzhang: https://ghostbin.co/paste/53m2s01:47
T42<birdzhang> Check /home/kristoffer/hadk/droid-hal-beyond2lte.log for full log01:48
Umeaboy@birzhang: That log tells me that CONFIG_NFS_ACL_SUPPORT is unset and when I use Ctrl F in Pluma (based on Gedit) I can't find it in the defconfig.01:54
UmeaboyI managed to build hybris-boot and hybris-recovery with the same defconfig.01:55
T42<birdzhang> CONFIG_NFS_ACL_SUPPORT is optional01:56
T42<birdzhang> show your full log01:56
Umeaboy@birdzhang: https://ghostbin.co/paste/43pp02:00
T42<birdzhang> take care of ERROR part02:01
Umeaboy@birdzhang: After changing the errors in the defconfig I got this: https://ghostbin.co/paste/czuasp02:23
T42<birdzhang> you need rebuild hybris-hal first, then build droid-hal. Please show full log02:26
UmeaboyI'm off to bed. I'll give you a build log later today.02:35
T42<A_T_R> how to do this - disable both NINJA and JACK ?04:42
*** wiktorek141 is now known as wiktorek14006:28
T42<adampigg> @A_T_R grep the logs https://piggz.co.uk/sailfishos-porters-archive/index.php?log=2018-08-10.txt#line1407:57
*** Zuccace is now known as Zucca09:07
UmeaboyIf anyone is awake I can tell you that rebuilding hybris-hal and hybris-boot went fine, but as I ran rpm/dhd/helpers/build_packages.sh --droid-hal I got this: https://ghostbin.co/paste/ze356jj10:29
T42<elros34> Umeaboy if you would read notes you got then you will find workaround for this very issue10:54
Umeaboy@elros34: You mean I have to rebuild droidmedia as well?11:43
UmeaboyI looked at 7.2.2 and my error is not described there.11:45
UmeaboyAre you talkng about adding straggler files to the hal spec file?11:58
Umeaboydroidmedia won't rebuild. Weird.12:09
T42<A_T_R> make clean then > https://paste.ubuntu.com/p/7jpvy8W2bs/ new error12:45
T42<elros34> Umeaboy no I am talking about notes from here: http://collabedit.com/kr9xx12:58
UmeaboyI forgot about that page. It should be included in the title here. :)13:22
UmeaboyAnyway..... After fixing that line I got this: https://ghostbin.co/paste/p3z829j13:22
UmeaboyIs this where the straggler files come to mind?13:23
UmeaboyI see it mentioned in 7.2.2, but they aren't the same.13:24
T42<A_T_R> after ```make clean``` again compiling hybris-hal > new error  https://paste.ubuntu.com/p/7jpvy8W2bs/13:25
UmeaboyCan you succesfully build Lineage or Android?13:30
Umeaboy@elros34: Would that be correctly done?13:30
T42<A_T_R> @Umeaboy - i don't build android roms13:31
UmeaboyA_T_R Aren't you using Android as a base?13:46
T42<A_T_R> Yeah ,Using lineage 17.1 as base for hybris-17.113:50
UmeaboyA_T_R: In case you weren't aware of it. Lineage is made from Android so you are in fact building a custom Android rom as a base. :)14:00
UmeaboyIf that device tree can build Lineage and it installs then your setup is not fully correct.14:01
UmeaboyFinally I'm building hal. :)14:01
T42<A_T_R> @Umeaboy [A_T_R: In case you weren't aware of it. Lineag …], I know thid,I mean I don't build android14:03
UmeaboyYou're building parts of AOSP in a way.14:05
T42<A_T_R> @A_T_R [I know thid,I mean I don't build android], Sorry ,* standalone android roms14:07
Umeaboy@elros34: Is %define community_adaptation 1 still needed in the droid-config spec file?14:18
T42<elros34> yes14:19
T42<A_T_R> can anyone look at this https://pastebin.ubuntu.com/p/jYt4MTGDCK/17:07
T42<A_T_R> is the error due to clang ?17:07
rinigusmal: as I have video non-resuming issue, I started looking into PA bugs as well. into https://github.com/sailfishos-sony-tama/main/issues/13519:41
rinigusfor some reason, and I cannot figure out why, PA droid (or something else) tries to search for a lib in /vendor/lib instead of /vendor/lib64. as there is a lib with the same name in 32-bit space, it happily states "is 32-bit instead of 64-bit" and stops searching further19:43
rinigusas if something in PA changes ld search path... or am I imagining it?19:43
malrinigus: maybe those happen in android side19:44
malrinigus: do those libs exist in lib64?19:44
rinigusyes, they do. not all, but some19:45
rinigusin my case, minimediaservice is 64 bit19:45
rinigusmal: as for android side, hard to say. I get more debug info with HYBRIS_LD_DEBUG19:46
malrinigus: check vendor/qcom/opensource/audio-hal/primary-hal/hal/audio_hw.h19:46
maland other stuff in there, grep for soundfx for example19:47
riniguslet me see19:47
malrinigus: vendor code has hardcoded the path to lib19:48
rinigusmal: I presume `LINUX_ENABLED` if absent there...19:48
rinigus(where it selects the path in that code)19:49
malcould be19:49
malrinigus: Makefile.am does define that but of course android build doesn't use that19:50
rinigusdoes it mean that I should somehow get droidmedia into 32-bit?19:50
malif that works19:50
malwill it be loaded in that case19:51
rinigusyeah, not sure if it works.19:51
rinigusbut have to test probably19:51
malrinigus: what issue are you trying to fix?19:54
rinigusmal: video not resuming playback if you go out of the browser and return back19:55
rinigusohm and friends are all on the last versions and not sure what else can I do19:56
rinigusmal: https://github.com/sailfishos-sony-tama/main/issues/13419:56
rinigus^ with logs as well19:56
rinigus... coming back to PA droid, not sure if those libs are that needed to fix the real issue19:57
malrinigus: those libs are most likely some extra things20:05
rinigusmal: agree, as the sound seems to be ok otherwise20:06
rinigushave to go, let me know please if you have some idea on how to approach the video issue20:09
Thaodanrinigus: You could use mount bind for that process to trick it loading the 64bit libs20:09
T42<b100dian> mal and @elros34 - for closure, my selinux problem was firstly 640 rights on /sys/fs/selinux/enforce  (detected by dbus which probably switches user) and fixed in the device repo init_${device}.cpp (safetynet precautions;) and secondly me stupidly adding a LD_PRELOAD for seliunux_stubs in `frameworks/native/cmds/servicemanager/servic20:45
T42emanager.rc` a week before, detected by the first message in logcat when starting servicemanager.20:45
mal@b100dian how far did you get now after fixing those?20:46
UmeaboyWould %define pixel_ratio 1.5 be right to put in the droid-hal-beyond2lte spec?20:47
maldid you estimate the value using the examples given in some instructions?20:47
T42<b100dian> mal: I don't have the whole picture yet - drodid-hal-init doesn't crash anymore, some camera service keeps on crashing in logcat (need to grep the beginning, maybe there are others) and droid-bootctl service failing - which may be something I picked from t5, need to see if it is actually needed.20:50
Umeaboymal: Nope.21:04
UmeaboyWhat about %define have_modem 1 ?21:05
UmeaboyThaodon: What actually decides the content of the droid-hal-$DEVICE.spec file?21:43
Thaodanread the spec file you include droid-hal-device.inc21:48
UmeaboyUhhhm. There's a step missing in the HADK because droid-config-beyond2lte.spec didn't get created for some reason.21:54
UmeaboyI got this error: droid-config-beyond2lte.spec21:54
Umeaboyrpm/dhd/helpers/build_packages.sh --droid-hal built just fine.21:55
UmeaboyI checked the HADK and I can't find any instruction that I've missed on done wrong to not have that spec file.21:57
UmeaboyTo create that file manually I need to know what to add in it.21:58
UmeaboyFixed the issue.22:07
UmeaboyFor some reason I have put a hybris folder in $HOME.22:07
UmeaboyIt's building now.22:07
T42<b100dian> mal: services android.hardware.graphics.composer, vendor.xiaomi.hardware.displayfeature and android.hardware.camera.service are failing with "stack corruption detected" :( and test_hwcomposer with `SharedModule: hdrdynamic: dlopen failed:22:19
T42<b100dian> library "libhdrdynamic.so" not found` then crashes (that lib is nowhere to be found not even in the original system.img).22:19
T42<b100dian> where should I direct my worries first?22:19
ThaodanUmeaboy: hal != config, you can build droid-configs like this: https://gitlab.com/Thaodan/hadk_tools/-/blob/master/templates/mer.droid.configs.hadk#L30 or build_packages.sh --configs22:49
UmeaboyI can't build: https://ghostbin.co/paste/kr4k23:28
UmeaboyThaodan: ^^23:29
UmeaboyI ran the command to create the spec and I got no error.23:29
UmeaboyAs soon as I tried toi build --configs I get that.23:29
UmeaboyHow can I solve that?23:34
Umeaboy@elros34: You got an idea?23:53

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!