| T42 | <elros34> Any particular reason why there is no cpio in allowed tools patch in hybris-patches for hybris-18? TEMPORARY_DISABLE_PATH_RESTRICTIONS doesn't work anymore and that part is quite critical or this issue only affects me? | 13:13 |
|---|---|---|
| mal | looks like I have a patch for that in my local tree which I forgot to push to hybris-18.1 | 13:20 |
| mal | @elros34 https://github.com/mer-hybris/hybris-patches/pull/25 | 13:22 |
| T42 | <elros34> thanks. I think this commit should also by in hybris-18 branch https://github.com/mer-hybris/android/commit/d0ceed913ec1e5829ecbf6c33dc06db0c2a42d88 | 13:23 |
| mal | feel free to make a PR, I can approve and merge it, please test my patch also and approve if ok | 13:24 |
| T42 | <elros34> ok | 13:24 |
| mal | I also should rebase 18.1 manifest | 13:26 |
| mal | but that can be done separately from that simple change | 13:26 |
| T42 | <elros34> I have used hybris-18.1-update. | 13:32 |
| T42 | <elros34> branch | 13:32 |
| T42 | <elros34> at least it builds fine | 13:32 |
| mal | oh, did I make one :D | 13:33 |
| mal | not sure why I forgot to make a PR for that | 13:34 |
| mal | probably better to update it again | 13:34 |
| mal | I can try to update it again | 13:35 |
| mal | @elros34 I'm making a new update branch, I can include removal of that one repo in it | 13:41 |
| mal | you can then test it | 13:41 |
| T42 | <elros34> ok | 13:41 |
| mal | @elros34 https://github.com/mer-hybris/android/tree/hybris-18.1-update-new let me know if that works | 13:44 |
| mal | hmm, I probably should also sync the patches with that | 13:57 |
| mal | but would be first nice to get the cpio patch in | 13:58 |
| T42 | <elros34> anybody with failed to build droidmedia because of listAudioSessions error: https://github.com/sailfishos/droidmedia/pull/107 | 14:03 |
| T42 | <elros34> I hope this will not break sailfish x | 14:04 |
| T42 | <elros34> is CONFIG_AUTOFS4_FS really needed by anything, especially by hybris-boot script? | 14:14 |
| mal | not sure really | 14:14 |
| mal | why? | 14:15 |
| T42 | <elros34> it's required by hybris-boot init-script, optional in mer-kernel-check and in reality documentation talks something about network file system | 14:17 |
| mal | based on the description of that seems unlikely | 14:17 |
| mal | that option is optional for systemd but recommended, probably not really important for us | 14:19 |
| mal | @elros34 you can always make a PR to hybris-boot repo to remove such optional things | 14:23 |
| T42 | <elros34> yeah just don't wont to break something | 14:24 |
| mal | that needs to be tested | 14:28 |
| mal | I couldn't find any explanation why that is in the required list | 14:28 |
| T42 | <Verevka86> Good work 👍🤝 (re @elros34: anybody with failed ...) | 17:38 |
| T42 | <elros34> did you test it? | 17:44 |
| T42 | <elros34> I only tested it on hybris-18, would bee good to know whether it works on other bases | 17:46 |
| T42 | <Verevka86> Yes, hybris18.1 (re @elros34: did you test it?) | 17:47 |
| mal | @elros34 I can make some test builds of that droidmedia PR for official devices | 17:49 |
| T42 | <elros34> if 'cat frameworks/av/services/audiopolicy/service/AudioPolicyService.h | grep listAudioSessions' fails then I think it shouldn't break anything | 17:50 |
| T42 | <Verevka86> and no one solved the problem with playing the standard sailfishos 4 video in the gallery? | 18:17 |
| T42 | <elros34> mal: I have repo init to hybris-18.1-update-new and repo sync --force-sync. Build finished without issues. | 18:28 |
| T42 | <Verevka86> I also checked, compiled and run without problems (re @elros34: mal: I have repo ini...) | 18:34 |
| T42 | <Verevka86> and no one solved the problem with playing the standard sailfish_OS_3.0.mp4 video in the gallery? (edited) | 18:35 |
| mal | which device and android base? | 18:43 |
| T42 | <Verevka86> Xiaomi vayu hybris-18.1 | 18:54 |
| T42 | <Verevka86> Xiaomi vayu android 11.0 (edited) | 18:55 |
| mal | @elros34 if that branch works then I will make PR for it | 20:12 |
| T42 | <elros34> that would be great | 20:13 |
| mal | @elros34 can you check how big external/chromium-webview/prebuilt/ is? wondering if we need those prebuilts | 20:15 |
| T42 | <elros34> 223,2 MB | 20:19 |
| mal | so not huge but quite big | 20:20 |
| T42 | <elros34> there are only *.apk files there | 20:20 |
| mal | ok, can you check if it still build if you remove those | 20:20 |
| mal | it could have some dependency, hopefully not | 20:20 |
| mal | there is that chromium patches repo which might affect it also | 20:21 |
| T42 | <elros34> removed external/chromium-webview/prebuilt/ and seems to build fine | 20:30 |
| mal | ok, I will comment out those from my branch then | 20:31 |
| mal | @elros34 https://github.com/mer-hybris/android/pull/168 | 20:34 |
| Thaodan | If I read https://cateee.net/lkddb/web-lkddb/AUTOFS4_FS.html is see a use case for it, e.g. if remote file systems such as cifs or nfs are used. In any case the impact on the kernel isn't bug enough to make it worth skipping. | 20:40 |
| mal | Thaodan: the problem is that mer-kernel-check doesn't require it but init-script does | 20:41 |
| Thaodan | mal: but only the one from hybris-boot? | 20:43 |
| mal | yeah | 20:43 |
| mal | and we usually tell porters to only fix errors so that can cause issues if it's not enabled by default | 20:44 |
| mal | either we for it in checker or remove it from init-script | 20:44 |
| mal | *force it | 20:44 |
| Thaodan | that's od, but I see now. | 20:48 |
| Thaodan | It comes from https://github.com/mer-hybris/hybris-boot/commit/63582c87da449ed28bf281b06fcd5fa56abff44d | 20:48 |
| mal | yes, not sure why it is listed as required | 20:49 |
| Thaodan | I don't know why the check was made but it is quite fragile since kernel symbols change between versions and require checking twice. | 20:49 |
| Thaodan | I would vote to remove the check and solely relay on mer_verify_kernel_config. | 20:50 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!