T42 | <b100dian> It was the lz4 step that went wrong, `lz4 -l -12 --favor-decSpeed` is needed according to build/make/core/Makefile | 01:07 |
---|---|---|
T42 | <k1gen> hey, I'm stuck on `error: device/google/coral/parts/Android.bp:7:1: "GoogleParts" depends on undefined module "org.lineageos.settings.resources"` on making hybris-hal. any ideas? | 13:28 |
T42 | <BigChadCat> Don't think this is required for SailfishOS, you can remove GoogleParts from both the device tree and device.mk or equivalent (re @k1gen: hey, I'm stuck on er...) | 13:31 |
T42 | <BigChadCat> If you still want to compile it, you can clone https://github.com/LineageOS/android_packages_resources_devicesettings - but you'll have to take care of the branch you are trying to compile for | 13:32 |
T42 | <k1gen> thanks (re @BigChadCat: If you still want to...) | 13:33 |
T42 | <k1gen> what's the path for this repo? (re @BigChadCat: If you still want to...) | 13:34 |
T42 | <k1gen> I mean `<project path=""` | 13:35 |
T42 | <BigChadCat> packages/resources/devicesettings | 13:36 |
T42 | <BigChadCat> You can refer to LineageOS manifest for the paths. | 13:37 |
T42 | <k1gen> thank you | 13:39 |
mal | @k1gen just to be sure, did you apply patches as instructed in faq? | 13:43 |
T42 | <k1gen> I did. it builds fine for now, but /boot is undetected | 13:44 |
T42 | <k1gen> hybris/hybris-boot/Android.mk:71: warning: ********************* /boot appears to live on | 13:45 |
mal | do add boot to your fstab in device repo | 13:45 |
mal | that should fix it | 13:45 |
mal | you can use the other entries in the fstab as example | 13:46 |
T42 | <k1gen> how do I find needed fstab to add /boot to? | 13:46 |
mal | there should only be one in the device repo, or two in worst case | 13:49 |
mal | use something like this: "find device/$VENDOR -name '*fstab*'" | 13:49 |
T42 | <k1gen> I have flame and coral | 13:50 |
T42 | <k1gen> command finds two files: | 13:51 |
T42 | <k1gen> device/google/coral/fstab.hardware | 13:51 |
T42 | <k1gen> device/google/coral/fstab.postinstall | 13:51 |
mal | how does the first look like? | 13:51 |
T42 | <k1gen> https://pastebin.com/uvS09x2X | 13:52 |
mal | add this line to that file: /dev/block/bootdevice/by-name/boot /boot emmc defaults defaults | 13:54 |
T42 | <k1gen> there's two `cat`s in that paste | 13:55 |
mal | to the first one | 13:57 |
T42 | <k1gen> ok | 13:57 |
T42 | <k1gen> kernel finally linked, ld.lld used 24G of ram | 18:21 |
T42 | <k1gen> what to do with config keys that mer_verify_kernel_config says must be enabled, but aren't present in defconfig already? | 18:22 |
mal | android builds take huge amount of memory | 18:23 |
T42 | <k1gen> CONFIG_SYSVIPC or CONFIG_IPC_NS for example | 18:23 |
mal | you add them | 18:23 |
T42 | <k1gen> alright, thanks | 18:23 |
mal | just some example which might be useful https://github.com/mer-hybris/android_kernel_sony_msm/blob/hybris-sony-aosp/LA.UM.9.12.r1/arch/arm64/configs/aosp_lena_pdx213_defconfig#L844 not all are relevant for every device but that describes what is adding on official devices | 18:25 |
mal | *added | 18:25 |
T42 | <k1gen> Do not follow mer-kernel-check advice about CONFIG_FW_LOADER_USER_HELPER in hadk-hot applies to all devices? | 18:30 |
mal | I suggest having CONFIG_FW_LOADER_USER_HELPER=y and CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y | 18:32 |
mal | not sure what hadk-hot suggests | 18:32 |
T42 | <k1gen> same, but without fallback | 18:33 |
mal | maybe fallback is not necessary | 18:33 |
T42 | <k1gen> it's =y by default | 18:34 |
mal | ok, just leave it | 18:34 |
T42 | <k1gen> should I turn off selinux at boottime as mer-kernel-check suggests? | 18:35 |
mal | no, keep selinux enabled | 18:36 |
mal | it's required for more recent android bases | 18:36 |
T42 | <k1gen> ok | 18:37 |
mal | which android base do you use? | 18:37 |
T42 | <k1gen> 18.1 | 18:37 |
mal | then keep selinux enabled, faq has comment about the selinux configs needed in config repo | 18:37 |
T42 | <k1gen> that's why I asked | 18:37 |
T42 | <k1gen> how do I access kernel cmdline? | 18:38 |
mal | it's in board config file in device repo | 18:38 |
mal | BoardConfig.mk or something like that | 18:39 |
mal | which has BOARD_KERNEL_CMDLINE variable in there | 18:39 |
T42 | <k1gen> BoardConfigLineage.mk for me, yeah | 18:39 |
T42 | <k1gen> thanks, and how do I set selinux to permissive in cmdline? | 18:40 |
mal | add this to kernel command line androidboot.selinux=permissive | 18:40 |
T42 | <k1gen> no *CMDLINE* in this file (re @SailfishFreenodeIRCBridgeBot: <mal>which has BOARD...) | 18:40 |
T42 | <k1gen> I mean no keys like thih at all | 18:41 |
T42 | <k1gen> *this | 18:41 |
mal | can you give a link to your device repo on github | 18:41 |
T42 | <k1gen> https://github.com/LineageOS/android_kernel_google_coral | 18:41 |
T42 | <k1gen> I have flame, but coral has flame files | 18:42 |
T42 | <elros34> @k1gen about hadk-hot: yes to all, once this: https://github.com/mer-hybris/mer-kernel-check/pull/35/commits/288442e056de6ef3d4ec30aa744561c886d8fd0d will be merged then advice will be not relevant anymore | 18:42 |
T42 | <k1gen> got it, thanks (re @elros34: @k1gen about hadk-ho...) | 18:42 |
mal | @k1gen check the BoardConfig-common.mk | 18:43 |
T42 | <k1gen> I see. thanks | 18:43 |
mal | device/google/coral/BoardConfig-common.mk | 18:43 |
T42 | <k1gen> yeah, found it | 18:43 |
mal | @elros34 I merged that PR now | 18:46 |
T42 | <k1gen> nice | 18:47 |
T42 | <k1gen> guys, I still have the /boot appears to live on message | 18:55 |
T42 | <k1gen> I have boot line in fstab.hardware in device tree | 18:56 |
mal | and you rebuilt hybris-hal? | 19:05 |
mal | I mean ran "make hybris-hal" in correct environment | 19:05 |
T42 | <k1gen> no, I ran make hybris-boot without rebuilding hybris-hal | 19:07 |
T42 | <k1gen> after editing defconfig | 19:07 |
mal | if you edited fstab then you need to rerun make hybris-hal also if you edit device repo or things like that | 19:08 |
T42 | <k1gen> should I wait for kernel to finish linking? | 19:10 |
mal | you can abort that build if you don't want to wait | 19:10 |
T42 | <k1gen> never saw something like this in my whole life, ld.lld choked on 46.4Gb of ram with swappiness 100 : https://irc.thaodan.de/.imgstore/c9a3bddd/file_4756.jpg | 19:26 |
mal | wow | 19:28 |
T42 | <k1gen> do you see the message? because I don't, weird | 19:30 |
T42 | <k1gen> I thought it got deleted | 19:30 |
mal | yeah I see the link to the image you sent | 19:30 |
mal | of course irc is different | 19:31 |
T42 | <elros34> thanks for merging PR | 19:33 |
T42 | <k1gen> alright, that's my first time getting as far as I got now. all mer-kernel-check warnings are fs-related, and everything compiles. should I keep following hadk pdf, do you guys have any advices for me? | 20:12 |
mal | you should also check faq and hadk-hot | 20:16 |
T42 | <b100dian> That boot partition detection is for boot.img updates, right? Not for .. booting | 20:23 |
T42 | <elros34> for sfos install script | 20:28 |
T42 | <k1gen> https://pastebin.com/2e2XphyL what's wrong with the script? | 21:30 |
T42 | <elros34> probably incorrect droid-config structure | 21:35 |
T42 | <k1gen> what does ! -d $PATTERNS_TEMPLATES_DIR mean? | 21:35 |
T42 | <elros34> check if directory doesn't exist | 21:36 |
T42 | <k1gen> yeah, there is no hybris/droid-configs directory | 21:37 |
T42 | <k1gen> my mistake | 21:38 |
T42 | <k1gen> how do I add selinux to sparce? | 22:09 |
T42 | <elros34> /etc/selinux? just copy needed files from device | 22:11 |
T42 | <k1gen> I see that in hadk-faq there's a link to sony repo | 22:11 |
T42 | <k1gen> I thought I need to copy files from this repo, but I don't know where to | 22:12 |
T42 | <elros34> sony is not good example in this case because it use different porting path | 22:13 |
T42 | <elros34> to similar place as in sony repo in sparse directory | 22:13 |
T42 | <k1gen> where on my device is selinux directory located? | 22:16 |
T42 | <k1gen> stupid question, sorry | 22:17 |
T42 | <elros34> you create same structure like on sony repo in your droid-config's sparse but instead copying symlinks from sony you copy actual files from your device | 22:18 |
T42 | <k1gen> all the /system/etc/selinux folder? | 22:18 |
T42 | <elros34> no | 22:18 |
T42 | <elros34> just copy sony's droid-conifig/sparse/etc/selinux to your device and then replace symlinks | 22:19 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!