Wednesday, 2023-04-26

*** Danct12 is now known as Guest1220606:22
T42<TheVancedGamer> mal: did you not get11:30
T42<TheVancedGamer> ```11:30
T42<TheVancedGamer> vendor/halium/droidmedia/droidmediacamera.cpp:303:59: error: too few arguments to function call, expected 3, have 211:30
T42<TheVancedGamer>     if (android::Camera::getCameraInfo(camera_number, &inf) != 0) {```11:30
T42<TheVancedGamer> 11:30
T42<TheVancedGamer> while compiling hybris-20? for me getCameraInfo has one new argument called OverrideToPortrait11:30
T42<TheVancedGamer> (I am using your fork of droidmedia, branch android13)11:30
mal@TheVancedGamer hmm, I did build that successfully, need to test again11:39
T42<TheVancedGamer> quite odd IMO, i'm getting so many weird errors11:41
malyou are building for hybris-20 and not hybris-19?11:43
T42<TheVancedGamer> i'm actually just making LOS20 work for Halium 1311:44
T42<TheVancedGamer> so far rebased patches and made a manifest11:44
T42<TheVancedGamer> it's gotten upto about 80% build done11:44
malI didn't yet push my manifest11:45
maldid you see my patches11:45
T42<TheVancedGamer> where?11:45
mal obviously11:45
T42<TheVancedGamer> I was looking at your repos :P11:46
T42<TheVancedGamer> I made
T42<TheVancedGamer> we don't have as many patches11:47
T42<k1gen> I'm thinking of upstreaming everything we've accomplished, any advices? I'd commit everything at once, but I think there's a better way to do it12:00
T42<Verevka86> Hi, my bluetooth still does not turn on in and , the macaddress is determined, the output of rfkill list is -
T42<Verevka86> help me figure out what the problem is, in 4.4 it worked fine13:54
T42<Verevka86> hybris18.1 (lineage18.1) Poco x3 Pro msm8150 4.1413:56
T42<Verevka86> hybris18.1 (lineage18.1) Poco x3 Pro sm8150 4.14 (edited)13:56
T42<k1gen> huh, bluetooth works on my pixel on sm8150, same kernel and sailfish versions14:02
T42<Verevka86> worked for me too until 4.5 :(14:04
T42<Verevka86> do you have hybris-20?14:04
T42<Ayman_rgab> start working for since 4.5 πŸ˜‚ (re @Verevka86: worked for me too un...)14:06
T42<Ayman_rgab> start working for me since 4.5 πŸ˜‚ (edited) (re @Verevka86: worked for me too un...)14:07
mal@Verevka86 does bluebinder log anything?14:27
maldoes it work if you unblock it manually with rfkill?14:27
T42<Verevka86> strangely, with hybris-boot from 4.4,bluetooth works 😊14:30
T42<Verevka86> Most likely this is my mistake, I will look for it now14:31
maldid you change something in kernel?14:34
T42<Verevka86> I canceled a couple of comments, everything worked, I'm sorry πŸ˜‡14:44
T42<elros34> you change kernel and forget about modules? That is why I always force kernel release to be without any additional characters14:45
T42<Verevka86> @elros34 I don't use modules in the kernel14:53
T42<Verevka86> mal: hybris-20 can't be tried yet?  Can't see hybris-20.0 branch in android repo14:57
malI didn't yet push the manifest14:58
T42<k1gen> mal: do you remember what we did to make sound work? how can I upstream this?17:41
T42<k1gen> add to sparse and Requires: hidl_compat to patterns?18:07
T42<elros34> there is no such a package as hidl_compat  so you can't add it to 'Requires'. Built library will by probably automatically packaged in droid-hal (yes you can unpack rpm and check)18:12
T42<k1gen> so packaging should be enough?18:16
T42<elros34> if that was your only change then yes18:16
T42<k1gen> how can I provide edited /vendor/etc/vintf/manifest.xml in builds to fix SecCam?18:19
T42<k1gen> also, any way to fix airbrush automatically?18:20
T42<elros34> and how did you provide it now?18:20
T42<k1gen> I do mount -o bind /etc/vintf_manifest.xml /vendor/etc/vintf/manifest.xml in droid-hal-early-init.sh18:20
T42<elros34> for sure you didn't edit anything in /vendor so do the same but just in sparse/18:20
T42<elros34> sparse/ is your / on device18:21
T42<k1gen> got it, thanks18:21
T42<Verevka86> Please add my device, I have a 100% working port18:37
T42<elros34> don't expect it will be merged unless you are jolla dev18:40
T42<b100dian> Was wondering about that:) There is a slew of PRs to hybris boot and I think it is recommended in hadk, isn't it "please don’t forget to upstream your fixup-mountpoints patch."18:51
T42<k1gen> why does -d complain about CONFIG_FW_LOADER_USER_HELPER=y again?18:54
T42<b100dian> @k1gen sorry, checking your previous question: put it in sparse/usr/bin/droid/ in droid-config-$DEVICE18:54
T42<k1gen> yeah, I got this already :)18:55
T42<k1gen> elros gave a good advice18:55
T42<k1gen> didn't answer the airbrush one though18:55
T42<b100dian> I think the mer checker doesn't recommend CONFIG_FW_LOADER_USER_HELPER yet but it is useful18:56
T42<elros34> I just do not have easy instruction18:57
T42<elros34> @b100dian it has if you have up-to-date sources18:58
T42<k1gen> how do I pull mer checker?18:58
T42<b100dian> sorry, it is
T42<b100dian> what was the airbrush fix?19:01
T42<k1gen> just search airbrush :)19:02
T42<elros34> are  you serious?19:02
T42<b100dian> well:)19:02
T42<k1gen> let me search for airbrush then19:02
T42<b100dian> "leading question";)19:03
T42<k1gen> userdel -r vendor_airbrush; useradd -M -U -u 2907 vendor_airbrush19:03
T42<elros34> @b100dian it's about adding 1 user but not sure how to do this correctly in droid-config/hal19:04
T42<elros34> not sure if you can add additional %post scriptlet in droid-config-device.spec19:06
T42<b100dian> What I don't see is where that user is created, so that you need to delete it, Is it in an .rc file. If it is not, and you don't need to remove it, then what Elros says, there are scripts creating users (I see their output in β€”mic command)19:10
T42<elros34> forget about usedel, it was needed because previous mistake, it only need useradd/groupadd19:11
T42<b100dian> It's a binary that generates the users?19:12
T42<k1gen> my mistake, we don't have to delete, I was just fixing my mistake19:13
T42<b100dian> Actuall ys from a generated header generated_android_filesystem_config19:13
T42<b100dian> *is generated_android_filesystem_config.h19:13
T42<k1gen> earlier I created this user with wrong uid19:13
T42<k1gen> so we only need to automatize useradd -M -U -u 2907 vendor_airbrush19:14
T42<b100dian> What does this python script do in your android base?
T42<k1gen> how to safely pull changes from upstream to mer-kernel-check?19:15
T42<k1gen> @b100dian
T42<k1gen> sorry for the .bin19:16
T42<b100dian> you need to run the `build/make/tools/fs_config/  aidarray         $ANDROID_ROOT/system/core/libcutils/include/private/android_filesystem_config.h` in PlatformSDK to see its output19:18
T42<k1gen> @b100dian
T42<b100dian> Ok, no airbrush there indeed. I think it makes sense because the script is not vendor -related19:22
T42<b100dian> So it seems to me that in that droid-hal-inc, the %buid does create the `droid.ids`  and the file is used in `%post users` (I'm just lagging here:). `users` is one of the packages of many in that spec subset. In that script there is `%{?custom_build_cmds}`19:32
T42<b100dian> Maybe in droid-hal-device you can19:34
T42<b100dian> %define custom_build_cmds echo "vendor_airbrush 2907" >> %{dhd_path}/helpers/droid.ids19:34
T42<b100dian> in the spec I mean. But I am still rpm rookie, the syntax may be off19:34
T42<k1gen> elros, what do you say?19:35
T42<k1gen> thanks for helping, @b100dian19:35
mal@Verevka86 any chance you could rebase that branch in the PR, it now has that extra merge commit which I don't like19:35
T42<elros34> @k1gen about vlad investigation? I do not know try and see. You have now to options to test %post and custom_build_cmds, there are my ways to solve this19:37
T42<elros34> many*19:37
T42<k1gen> ok, but to build droid-hal, I have to pass mer kernel check. may I ask again: how to safely pull changes from upstream to mer-kernel-check?19:38
T42<elros34> it's not complicated you could find it yourself: git pull19:39
T42<elros34> there is small instruction in hadk-faq about updating submodules which you can use also19:40
T42<k1gen> thanks, because git pull doesn't work in submodule dir19:40
T42<b100dian> Mister_Magister, @K31j0 these are two sake repositories that I coudn't host under b100dian since they would end up in my previous port (after they were moved)
T42<b100dian> Are you building the Zenfone 8 port from scratch or do you want to work together?20:19
T42<b100dian> I would need you github usernames to add you as owners if yes20:20
T42<Verevka86> mal: Can I make a new PR and close the old one?20:32
T42<elros34> force push your changes instead20:38
T42<k1gen> -d mixes kernels again, can't remember how I fixed that month ago:
T42<k1gen> omg, is still not upstreamed20:48
T42<elros34> because it's wrong and breaks aosp devices20:49
T42<b100dian> sounds like a case needing `shopt -s extglob` before `?(KERNEL_OBJ/)`21:01
T42<k1gen> there is hidl_compat lib in droid-hal rpm, and I added the to sparse. now git commit and push, hope I didn't forget anything :)21:03
T42<b100dian> What about users?  droid.ids21:04
T42<k1gen> oh, yeah, let me check. they're in this rpm, right?21:05
T42<k1gen> or should I run this python command and send the output?21:06
T42<b100dian> in droid-hal-*-users21:08
T42<b100dian> if you used one of the advices around spec21:08
T42<k1gen> here's contents of droid.ids in droid-hal-*-users:
T42<k1gen> I have %define custom_build_cmds echo "vendor_airbrush 2907" >> %{dhd_path}/helpers/droid.ids in the end of rpm/droid-hal-flame.spec21:11
T42<b100dian> what do you mean in the end. It should be before `%include rpm/dhd/` to work21:12
T42<k1gen> I see, let me rebuild droid-hal21:12
T42<k1gen> @b100dian:
T42<b100dian> and the contents of the spec?21:15
T42<k1gen> sure, one sec21:15
T42<b100dian> btw, new error = progress :)21:15
T42<elros34> spec syntax... good luck with that21:16
T42<b100dian> heh:)21:17
T42<b100dian> I just tried it here.. but my spec looks differently formatted
T42<b100dian> and I do get droid.ids with vendor_airbrush :)21:23
mal@Verevka86 you really should learn how to do proper rebase21:23
malalways making new PRs to fix trivial issues is just annoying21:24
T42<k1gen> @b100dian well, the remark syntax is the same, but I have these main package errors and you don't21:26
T42<k1gen> alright, I'm gonna go sleep and see what I can do in the morning21:28
T42<K31j0> 6 and later is Tensor which is Exynos @k1gen but I guess someone already explained that22:32

Generated by 2.17.1 by Marius Gedminas - find it at!