| mal | @TheVancedGamer you had the droidmedia build issue earlier, I got the same now, I will fix it in the android 13 branch | 18:21 |
|---|---|---|
| T42 | <TheVancedGamer> mal: I've already fixed it | 18:41 |
| T42 | <TheVancedGamer> but upstream is better :) | 18:41 |
| mal | yeah, I assumed you have some fix for it, I remember seeing some patch at some point but can't find it but fixing that simple anyway | 18:45 |
| mal | but annoying thing is that that broke within android 13 versions, earlier version worked but never didn't | 18:45 |
| mal | we just have to assume everyone uses new enough revision of android 13 | 18:46 |
| T42 | <k1gen> mal: revision? you meant security patch? | 18:47 |
| mal | well what ever those are called, that change was introduced in android-13.0.0_r32 | 18:49 |
| T42 | <TheVancedGamer> mal: I fixed it yeah, was on my github | 19:00 |
| mal | looks like almost the same fix now that I found your version, only difference is that I did the extra parameter conditional slighty different way in the first part | 19:02 |
| T42 | <TheVancedGamer> but looking at this this probably could be used for devices that have wrong camera orientation | 19:03 |
| mal | yeah, but only on android 13 base so not very generic fix | 19:04 |
| T42 | <TheVancedGamer> we can always backport it :) | 19:04 |
| mal | yeah, but that becomes even more messy | 19:05 |
| mal | are there some devices which have incorrect camera orientation? | 19:05 |
| T42 | <TheVancedGamer> my Redmi 9C has 270 degree camera orientation for front camera | 19:05 |
| mal | hmm | 19:05 |
| mal | in pictures or viewfinder or both? | 19:06 |
| T42 | <TheVancedGamer> well the sensor outputs as 270 degrees, qtubuntu-camera fixes it iirc | 19:06 |
| mal | so both have wrong orientation | 19:09 |
| mal | I thought camera sensor would report the orientation and camera app should handle that | 19:09 |
| T42 | <TheVancedGamer> I believe qtubuntu-camera flips it back to porttait | 19:09 |
| mal | is there any chance the android side camera config is somehow wrong? | 19:10 |
| T42 | <TheVancedGamer> not really | 19:10 |
| T42 | <TheVancedGamer> the sensor physically outputs flipped images | 19:10 |
| mal | I mean the android camera configuration at least one qcom devices has option which tells the orientation of the sensor | 19:11 |
| T42 | <TheVancedGamer> 9C is mediatek, so not here | 19:11 |
| mal | ok | 19:11 |
| mal | @adampigg I noticed that your droid-hal-version native branch is missing some changes which cause it to pull in obsolete memless vibrator package | 19:24 |
| T42 | <adampigg> Ok, thx | 19:32 |
| T42 | <adampigg> Mal: pr ready? ;) | 19:34 |
| mal | I thought you would just rebase it | 19:35 |
| mal | rebasing with PR is ugly | 19:35 |
| T42 | <adampigg> K | 19:42 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!