Friday, 2023-06-09

mal@TheVancedGamer you had the droidmedia build issue earlier, I got the same now, I will fix it in the android 13 branch18:21
T42<TheVancedGamer> mal: I've already fixed it18:41
T42<TheVancedGamer> but upstream is better :)18:41
malyeah, I assumed you have some fix for it, I remember seeing some patch at some point but can't find it but fixing that simple anyway18:45
malbut annoying thing is that that broke within android 13 versions, earlier version worked but never didn't18:45
malwe just have to assume everyone uses new enough revision of android 1318:46
T42<k1gen> mal: revision? you meant security patch?18:47
malwell what ever those are called, that change was introduced in android-13.0.0_r3218:49
T42<TheVancedGamer> mal: I fixed it yeah, was on my github19:00
mallooks like almost the same fix now that I found your version, only difference is that I did the extra parameter conditional slighty different way in the first part19:02
T42<TheVancedGamer> but looking at this this probably could be used for devices that have wrong camera orientation19:03
malyeah, but only on android 13 base so not very generic fix19:04
T42<TheVancedGamer> we can always backport it :)19:04
malyeah, but that becomes even more messy19:05
malare there some devices which have incorrect camera orientation?19:05
T42<TheVancedGamer> my Redmi 9C has 270 degree camera orientation for front camera19:05
malin pictures or viewfinder or both?19:06
T42<TheVancedGamer> well the sensor outputs as 270 degrees, qtubuntu-camera fixes it iirc19:06
malso both have wrong orientation19:09
malI thought camera sensor would report the orientation and camera app should handle that19:09
T42<TheVancedGamer> I believe qtubuntu-camera flips it back to porttait19:09
malis there any chance the android side camera config is somehow wrong?19:10
T42<TheVancedGamer> not really19:10
T42<TheVancedGamer> the sensor physically outputs flipped images19:10
malI mean the android camera configuration at least one qcom devices has option which tells the orientation of the sensor19:11
T42<TheVancedGamer> 9C is mediatek, so not here19:11
mal@adampigg I noticed that your droid-hal-version native branch is missing some changes which cause it to pull in obsolete memless vibrator package19:24
T42<adampigg> Ok, thx19:32
T42<adampigg> Mal: pr ready?  ;)19:34
malI thought you would just rebase it19:35
malrebasing with PR is ugly19:35
T42<adampigg> K19:42

Generated by 2.17.1 by Marius Gedminas - find it at!