Monday, 2023-06-26

T42<smatkovi> i still couldn't build hybris-hal and droidmedia, would anyone try to compile those? i have uploaded the manifest and the fixup-mountpoints, getting overlay-lineage will probably fail, but i added it because the build wanted to have that directory https://drive.google.com/drive/folders/1sFEr--HPggqtOrL8n1UZbPRmkTiyd2cS?usp=sharing10:00
T42<TheVancedGamer> mal: so google added a new argument to Camera::connect with june patch, `forceSlowJpegMode`. would it be possible to add it to droidmedia as well? I don't think this serves us any real purpose11:40
mal@TheVancedGamer so they again broke that? quite annoying, not sure if we would need that for anything13:11
malthis is starting to be difficult, not sure how to handle those when the version doesn't really change13:12
mal@smatkovismatkovi you are now showing how it fails now13:15
mal*not showing13:16
T42<TheVancedGamer> mal: yeah, they keep changing almost everything every release13:26
malnot sure if there is some way get that version in the code13:27
malI mean that r5213:27
T42<TheVancedGamer> I mean it's just another `false` that needs to be added13:27
T42<TheVancedGamer> to droidmedia13:27
malyes but handling the difference might be a problem13:28
malif we just add it without any condition it would break older android 13 bases13:28
T42<TheVancedGamer> you could just bump mer-hybris manifest as well :P13:29
deathmist1@adampigg got some notes on Halium-bassed SFOS porting yet?14:38
T42<adampigg> i havnt ... will try ... but you can mostly just copy my OBS projects, copy the kickstart file, and use the UBPorts boot.img14:49
deathmist1hm could you also build images locally similar to HADK described method (including without OBS repos)?14:51
T42<adampigg> i dont see why not ... just a case of setting the repo locations15:30
T42<smatkovi> @mal here you go https://pastebin.com/DB9R1mA818:32
malhave you removed something from sources?18:54
T42<smatkovi> no i downloaded everything, this time i even haven't got the error about testing modules18:56
maldid you try this before build export ALLOW_MISSING_DEPENDENCIES=true19:00
T42<smatkovi> yes then i got another error, but i will try again and show you the result19:02
T42<smatkovi> hopefully i don't have it this time19:03
T42<smatkovi> that's the relevant line: FAILED: ninja: 'libhwc2_compat_layer', needed by 'hybris-hal', missing and no known rule to make it19:04
malso you didn't do what faq said19:16
malhttps://github.com/mer-hybris/hadk-faq#hybris-17-1 note that you need to also check relevant parts of the older bases above that19:17
T42<smatkovi> Add to sparse: https://github.com/mer-hybris/droid-config-sony-seine/tree/eaa09db67b94352ef801417363008dc4005d9213/sparse/etc/selinux. You may need to replace symlinks with the actual files from your device.19:17
T42<smatkovi> Add '%define android_version_major 10' to droid-config-$DEVICE.spec19:17
malyou didn't clone libhybris19:17
T42<smatkovi> these 2 i don't know how to do19:17
malthose are relevant a bit later19:17
malyou are not in that stage of hadk pdf yet19:18
T42<smatkovi> how can i clone that, should it be in the manifest?19:19
T42<smatkovi> but i have a hybris folder in hadk19:20
T42<elros34> hybris!=libhybris19:21
Mister_Magisterhow is it19:23
Mister_Magisterhow is it not19:23
T42<elros34> ok: hybris directory!= libhybris directory19:24
T42<Mister_Magister> now better19:24
malthis clearly says what to do https://github.com/mer-hybris/hadk-faq#hybris-16-019:27
Mister_Magisteri don't think theres more annoying thing than people not reading or following instructions or reporting back19:27
mal@smatkovi do you now understand in that link I just gave how to clone libhybris19:28
T42<smatkovi> yes i can curl them one by one from their raw pages19:28
malwhat?19:29
T42<elros34> frankly not every new porter will guess immediately that for hybris-17 you need one step from hybris-1619:29
T42<smatkovi> like curl -L -O https://raw.githubusercontent.com/sailfishos-oneplus5/droid-config-cheeseburger/hybris-16.0/sparse/usr/libexec/droid-hybris/system/etc/init/disabled_services.rc19:29
Mister_Magistermy mind just melted19:29
mal@elros34 PRs are welcome to faq19:29
T42<elros34> focus on libhybris only first19:29
mal@smatkovi those other parts of hybris-16 instructions are not relevant19:30
malonly the libhybris part19:30
T42<smatkovi> oh yes sry, i forgot that19:31
T42<smatkovi> i thought i did that already19:31
T42<smatkovi> you mean cloning it and applying the patch19:31
T42<elros34> cloning and building hybris-hal, you should already have patches applied19:32
T42<smatkovi> oh yes now these errors appear: https://pastebin.com/ued3bgvS19:33
T42<smatkovi> could it be that it was successful?19:33
T42<smatkovi> and they are only warnings?19:34
T42<elros34> there is something wrong in fixup-mountpoints. Did you make any changes to defconfig?19:34
T42<smatkovi> not as far as i remember19:34
T42<smatkovi> https://irc.thaodan.de/.imgstore/f8a295f1/parts.txt19:35
T42<smatkovi> i took them from this output from android19:35
T42<elros34> I remember that you had fixup-mountpoints wrong previously but you had more serious issues so I didn'tt tell you. check it again19:36
T42<smatkovi> it was aboot instead of boot, right?19:38
T42<elros34> IIRC all block devices were wrong19:38
T42<Mister_Magister> xdd19:39
T42<smatkovi> oh it should be /dev/block/platform/*/by-name/?19:41
T42<elros34> no. second part, check "git diff" in hybris-boot directory and then compare your changes to any other device19:42
T42<smatkovi> oh, i also edited the other devices with a search and replace19:46
T42<smatkovi> maybe19:46
T42<smatkovi> i think the paths should be dev/block/platform/soc.0/7824900.sdhci/by-name/20:04
T42<smatkovi> at least that's what i get on the device in android20:05
T42<smatkovi> but i get the same build error20:05
T42<elros34> you are missing the point, show your changes (git diff) then I will tell you what is wrong20:06
T42<smatkovi> i see20:06
T42<smatkovi> https://pastebin.com/NPE8MQ3G20:08
T42<elros34> now compare it to: https://github.com/mer-hybris/hybris-boot/commit/334fd32bc93023daf12f20d65a9b1b50e8020f46. DO  you see mistake20:09
T42<smatkovi> oh i shouldn't have /dev/block/*20:10
T42<elros34> yes but also unneeded white spaces and by-name path which you changed again is probably wrong now but for that check android's fstab file in device repositor20:10
T42<smatkovi> have i got the device repository locally or do i have to look it up online?20:16
T42<elros34> it's all in $ANDROID_ROOt/device/20:17
mal@smatkovi are you sure thos paths are really correct, I found this fstab in the device repos https://github.com/Galaxy-MSM8916/android_device_samsung_msm8916-common/blob/lineage-17.1/rootdir/etc/fstab.qcom20:19
maland the build log also says /dev/block/bootdevice/by-name/boot20:20
T42<smatkovi> i changed it back now and now it is compiling, thank you very much :)20:22
malback to what?20:23
T42<smatkovi> that error is strange: make[1]: /home/sebastian/hadk/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/arm-linux-androidkernel-gcc: Command not found20:23
T42<smatkovi> to /dev/block/bootdevice/by-name20:24
T42<smatkovi> i can see that it exists, but is a symlink to arm-linux-androidkernel-gcc -> arm-linux-androideabi-gcc20:32
T42<elros34> is that only error you have?  Nothing about python?20:39
T42<elros34> in local manifest there is explicitly added arm-eabi-7.220:42
T42<smatkovi> i try this now: Use make CC=clang ... to build with Clang rather than gcc20:45
T42<elros34> is it really that easy just set CC=clang?20:46
T42<smatkovi> i think this takes me further20:46
T42<smatkovi> yes seems so20:46
T42<smatkovi> no20:46
T42<smatkovi> i celebrated too early20:46
T42<smatkovi> https://pastebin.com/VpVVJa7x20:48
T42<smatkovi> this is the only error appearing repeatedly20:48
T42<smatkovi> when i made source build/envsetup.sh it complained about python20:49
T42<elros34> don't you think it's worth to show it then?20:51
T42<smatkovi> it was breakfast: sebastian@sebastian-Alienware-13-R3:~/hadk$ breakfast $DEVICE20:53
T42<smatkovi> /usr/bin/env: ‘python’: No such file or directory20:53
T42<smatkovi> but then it gave me the list of environment variables and seemed to exit fine20:54
T42<elros34> Didn't you use focal ubuntu from hadk?20:54
T42<smatkovi> no i installed ubuntu 22.04.2 lts, as someone suggested here20:55
T42<smatkovi> and i'm building on this20:55
T42<smatkovi> no virtual machine20:55
T42<elros34> for old devices this is always great idea...20:55
T42<elros34> so what python version do you have installed20:56
T42<smatkovi> tu use focal ubuntu from hadk?20:56
T42<elros34> or older depends on device20:56
T42<smatkovi> i see20:56
T42<elros34> so do you have python and which version?20:57
T42<smatkovi> i have python 2 and 3, but when i just enter python it says command not found, that is strange20:57
T42<smatkovi> (2.7.18-3) and (3.10.6-1~22.04)20:57
T42<elros34> 'which python' and then check that file20:58
T42<smatkovi> nothing20:58
T42<smatkovi> i could create an alias20:58
T42<elros34> I think this is handled byt some dpkg package or update-alternatives20:59
T42<smatkovi> lol there is a package called python-is-python321:00
T42<smatkovi> now breakfast says this: Trying dependencies-only mode on a non-existing device tree?21:00
T42<elros34> IIRC this is normal21:01
T42<smatkovi> now i get a similar error without CC=clang:   File "/home/sebastian/hadk/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.9/bin/arm-linux-androidkernel-gcc", line 58, in invoke_compiler  os.execv(self.argv0, self.execargs) FileNotFoundError: [Errno 2] No such file or directory21:03
T42<smatkovi> should i try it with ubu-chroot?21:05
T42<elros34> maybe this is some python 2/3 issue21:06
T42<smatkovi> with ubu-chroot it is the same, even with the old ubuntu trusty image21:29
T42<smatkovi> there is only python3 strangely21:29
T42<smatkovi> i have the feeling that it doesn't even use python21:31
T42<smatkovi> should it use python2 or python3=21:32
T42<smatkovi> so strange i uninstalled python3 and installed python2 and created an alias, but it is still complaining that python is missing21:35
T42<smatkovi> okay i try again with python-is-python3 and python3 installed, that one i forgot earlier in the chroot21:36
T42<smatkovi> File "/home/sebastian/hadk/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-421:37
T42<smatkovi> .9/bin/arm-linux-androidkernel-gcc", line 58, in invoke_compiler21:37
T42<smatkovi>     os.execv(self.argv0, self.execargs)21:37
T42<smatkovi> no still the same21:37
T42<elros34> maybe you should use CROSS_COMPILE with that arm-eabi-7.2 which is defined in local_manifest21:37
T42<elros34> I assume they added it for a reason21:37
T42<smatkovi> should i export CROSS_COMPILE=arm-eabi-7.2 ?21:38
T42<elros34> no, look at the make hybris-hal output how its set for 4.9. Frankly I do not know if you can just export it or you need ot set it somwhere to be used during make hybris-hal21:40
T42<smatkovi> https://pastebin.com/fwWxkQqt21:41
T42<smatkovi> there are very strange things21:42
T42<smatkovi> TARGET_ARCH should be aarch64 and not arm i guess21:42
T42<smatkovi> then HOST_CROSS_OS should be linux and not windows21:42
T42<elros34> its arm device so why aarch64?21:42
T42<smatkovi> i don't know^^21:43
T42<smatkovi> was just a thought, because the cpu is aarch6421:45
T42<smatkovi> okay so the local manifest has arm-eabi-7.2, but i don't know how to cross compile for that and you neither i guess, so we're stuck here21:47
T42<elros34> did you even bother to try with simple export?21:47
T42<smatkovi> i could write another architecture in the manifest and hope it exists and downloads that21:47
T42<smatkovi> yes i did export CROSS_COMPILE=arm-eabi-7.221:48
T42<smatkovi> but i didn't do make clean21:48
T42<smatkovi> so i'll try that now21:49
T42<elros34> oh c'mon told you to look how CROSS_COMPILE  looks like in your paste21:49
T42<elros34> CROSS_COMPILE=\" /home/sebastian/hadk/prebuilts/gcc/linux-x86/arm21:49
T42<elros34> /arm-linux-androideabi-4.9/bin/arm-linux-androidkernel-\"21:49
T42<elros34> adapt this21:49
T42<Mister_Magister> @elros34 ya still didn't give up, i admire u21:49
T42<elros34> or find where it's defined, for sure somebody already tried building kernel with different toolchain21:50
T42<smatkovi> i'm a total noob, i try that for the first time, so i don't know where to look21:51
T42<smatkovi> but i think exporting this looks good21:53
T42<elros34> another idea is CONFIG_CROSS_COMPILE in defconfig21:54
T42<smatkovi> compilation takes way longer, so i think that did the trick21:54
T42<elros34> so it use new path for cross_compile in log?21:55
T42<smatkovi> is this in the standard terminal output or somewhere else?21:56
T42<elros34> yeah21:56
T42<smatkovi> i think yes:  ARCH=arm CROSS_COMPILE=\" /home/sebastian/hadk/prebuilts/g21:57
T42<smatkovi> cc/linux-x86/arm/arm-linux-androideabi-4.9/bin/arm-linux-androidkernel-\"21:57
T42<elros34> so no, this is old path21:58
T42<smatkovi> yes you're right21:58
T42<smatkovi> i think i understand just now what you meant earlier21:58
T42<smatkovi> so i should change that variable to /home/sebastian/hadk/prebuilts/gcc/linux-x86/arm/arm-eabi-7.2 ?22:00
T42<elros34> I would say something like: /home/sebastian/hadk/prebuilts/gcc/linux-x86/arm/arm-eabi-7.2/bin/arm-eabi-22:01
T42<smatkovi> but it ignored my exported variable22:02
T42<elros34> that is why I sad I do not know if exporting is enough or maybe you chould add it somewhere in build files or defconfig: CONFIG_CROSS_COMPILE.22:04
T42<smatkovi> yes, but which defconfig?^^22:04
T42<smatkovi> there are many22:05
T42<elros34> see you paste, you find file names there22:07
T42<smatkovi> there are two: KCONFIG_SELINUX(arch/arm/configs/selinux_defconfig) and KCONFIG_VARIANT(arch/arm/configs/msm8916_sec_j5xnlte_eur_defconfig)22:10
T42<smatkovi> okay i can just look into them and search for this variable22:11
T42<elros34> or add it just like that22:12
T42<smatkovi> in which one, or both?22:12
T42<elros34> device specific one sound reasonable22:15
T42<smatkovi> i used both, but it is still the old variable22:17
T42<smatkovi> i try again with make clean22:17
T42<elros34> build only hybris-boot, it will be faster than hybris-hal22:18
T42<smatkovi> okay now it is also the old variable22:24
T42<smatkovi> what does this variable do, does it tell make which compiler to use for cross compilation?22:25
T42<elros34> yes, you use it when building kernel manually together with ARCH variable22:26
T42<elros34> your kernel even have bunch of  build*kernel.sh scripts22:29
T42<smatkovi> here it is: export CROSS_COMPILE=$(pwd)/../PLATFORM/prebuilts/gcc/linux-x86/arm/arm-eabi-4.8/bin/arm-eabi-22:36
T42<smatkovi> in kernel/samsung/msm8916/build_kernel.sh22:37
T42<smatkovi> i changed it to your suggestion, but it was still the old variable, now i try again after doing make clean22:40
T42<elros34> do you even cloned arm-eabi-7.2? https://github.com/Galaxy-MSM8916/android_device_samsung_msm8916-common/blob/lineage-17.1/BoardConfigCommon.mk#L15922:42
T42<smatkovi> i think so, at least it shows up in the local_manifest22:43
T42<elros34> do not guess just check22:44
T42<smatkovi> i am executing the sh file now and see if that works22:45
T42<smatkovi> <project path="prebuilts/gcc/linux-x86/arm/arm-eabi-7.2" name="Galaxy-MSM8916/android-prebuilts-gcc-linux-x86-arm-arm-eabi-7.2" remote="github" revision="master"/>22:46
T42<elros34> so it is cloned or not?22:48
T42<smatkovi> yes it's there22:49
*** phlixi is now known as Guest427622:53
*** phlixi_ is now known as phlixi22:53
T42<smatkovi> now it complains about missing libncurses.so.522:55
T42<elros34> Then I do not know. Wait for somebody who knows better android build system . What happen if you remove that "if "check from boardconfig?22:55
T42<smatkovi> i already installed libncures-dev and libncurses5-dev22:55
T42<smatkovi> lol i don't need the dev packages22:55
T42<smatkovi> i guess if the build_kernel.sh works i can run make again and then it just skips compiling the kernel, am i right?22:56
T42<elros34> I think no but you will see, do you even use correct defconfig with that script?22:58
T42<smatkovi> VARIANT_DEFCONFIG=msm8916_sec_gtelwifi_usa_defconfig22:59
T42<smatkovi> so probably not22:59
T42<smatkovi> i changed it to msm8916_sec_j5xnlte_eur_defconfig23:00
T42<smatkovi> that also has the correct CROSS_COMPILE variable set23:01
T42<smatkovi> that's very strange now at compilation it used the old variable. i could grep the directories for this variable and then check back the result tomorrow, edit it and then try to compile again23:13
T42<smatkovi> okay i must be tired, that's the file i edited earlier...23:17
T42<smatkovi> grep -rnw . -e "arm-linux-androideabi-4.9/bin/arm-linux-androidkernel-"23:21
T42<smatkovi> thanks for your help for today :)23:21
T42<smatkovi> oh it found 2 files out/soong/soong.variables and out/soong/build.ninja where it was set23:31
T42<smatkovi> you know what, i could just copy the compiler file there and then it automatically uses the right compiler23:35

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!