T42 | <TheVancedGamer> mal: checked logcat, no errors | 08:46 |
---|---|---|
*** rdr_ is now known as rdr | 16:53 | |
*** rdr_ is now known as rdr | 17:11 | |
piggz | wondering if sailfish will move to https://gitlab.com/ubports/development/core/hybris-support/pulseaudio-module-droid-discover ? | 17:49 |
piggz | mal: ^^ | 17:49 |
mal | piggz: hmm, need to think | 17:54 |
T42 | <TheVancedGamer> mal: made a quick hack to pa-droid for parsing sampling rates with spaces, how does it look? | 18:43 |
T42 | <TheVancedGamer> https://paste.myself5.de/sibejixono.cpp | 18:43 |
mal | @TheVancedGamer did you check the package I mentioned? dummy af | 18:52 |
T42 | <TheVancedGamer> mal: yeah dummy is installed but never started | 19:31 |
mal | @TheVancedGamer try to get it started | 19:42 |
mal | and see what happens | 19:42 |
mal | afaik it's needed for call audio with qti audiosystem-passthrough | 19:43 |
T42 | <TheVancedGamer> mal: hmm, might try in morning | 19:43 |
mal | @TheVancedGamer https://github.com/mer-hybris/droid-config-sony-lena/blob/master/patterns/patterns-sailfish-device-adaptation-pdx213.inc#L37 | 19:43 |
T42 | <TheVancedGamer> could you maybe look at that crude diff in the meanwhile? | 19:43 |
mal | does camera app work for your? | 19:43 |
T42 | <TheVancedGamer> works on Volla X23 at least | 19:43 |
mal | even video recording? | 19:44 |
T42 | <TheVancedGamer> mal: yup, everything works | 19:44 |
T42 | <TheVancedGamer> (halium, not sfos :p) | 19:44 |
T42 | <TheVancedGamer> only thing remaining is call audio and that's it | 19:44 |
mal | because I think the error you had might be due to the dummy af not being there so the dbus call fails, or something | 19:45 |
mal | just a theory at the moment | 19:45 |
T42 | <TheVancedGamer> mal: I'll try that tomorrow morning and see if it works | 19:47 |
mal | ok | 19:47 |
T42 | <TheVancedGamer> also was playing around with pa-droid and tried adding parsing support for spaced sampling rates | 19:47 |
T42 | <TheVancedGamer> https://paste.myself5.de/sibejixono.cpp | 19:48 |
T42 | <TheVancedGamer> if you wanna look | 19:48 |
mal | any example of such rate? | 19:50 |
mal | @TheVancedGamer about that change, would it make more sense to have some local delimiter variable and testing the input for space and VALUE_SEPARATOR to see which is used then doing the loop using the selected one, less code duplication that way | 19:57 |
mal | *the existing loop | 19:58 |
T42 | <TheVancedGamer> I feel like I can do better, just don't know how I could | 20:00 |
T42 | <TheVancedGamer> mal: Volla X23 has audio policy version 7 | 20:00 |
T42 | <TheVancedGamer> which uses spaces | 20:00 |
T42 | <TheVancedGamer> works there | 20:00 |
mal | something like "char separator = strchr(str, " ") ? ' ' : VALUE_SEPARATOR;" and then "while ((entry = pa_split(str, VALUE_SEPARATOR, &state))) {" -> "while ((entry = pa_split(str, separator, &state))) {" | 20:02 |
mal | wouldn't that work in theory? | 20:02 |
T42 | <TheVancedGamer> mal: yeah that could | 20:05 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!