| genericv3 | i'll, you are elros34 on github right? | 05:02 |
|---|---|---|
| genericv3 | Also mal, can i get your github username too | 05:02 |
| genericv3 | Also i need to take my phone to service tomorrow. I need to delay everything if we can't fix it today, but i'll have more time than usual today. | 05:03 |
| T42_ | <elros34> I am, why do you ask? | 11:03 |
| T42_ | <b100dian> Probably related to the upload of droid config on github, but I think there's a misunderstanding, you don't need the usernames to give access to a project, unless it is private, and I wouldn't recommend making a porting effort private. | 12:27 |
| genericv3 | I'll make repos private for development stage, not gonna make these efforts entirely private as b100dian said :) | 12:49 |
| genericv3 | Elros i sent you a organization invitation, you can leave after everything is done if you want. | 12:59 |
| T42_ | <Herrie1982> mal: On the sensorfwd issue: seems we had some race condition with sensorfwd and sam (webOS component) that were both taking 90s (default timeout to kill). Adding "TimeOutStopSec=5" brings the reboot down to an acceptable 10s. Maybe not the most proper solution but does the trick | 13:31 |
| mal | @Herrie1982 any chance you could attach gdb to the sensorfw process when it appears in hanged state and check from backtraces where it's waiting? | 13:52 |
| mal | does the same happen if you just try to restart the sensorfw service? | 13:53 |
| T42_ | <Herrie1982> mal: Yes that also takes forever | 13:53 |
| T42_ | <Herrie1982> I'm pretty sure it's one of our components that doesn't do stuff gracefully and not sensorfw | 13:53 |
| T42_ | <Herrie1982> So it locks sensorfw | 13:54 |
| mal | we haven't noticed such issues at least, which backend does the device use? hal or binder? | 13:55 |
| T42_ | <Herrie1982> Well it's PT2 on mainline in this case | 13:55 |
| T42_ | <Herrie1982> But have seen it on Halium with binder too | 13:55 |
| T42_ | <Herrie1982> So I suspect it could be our ALS or other component using sensorfw | 13:56 |
| mal | so iio? | 13:56 |
| mal | that reminds me, I should finish my iio fixes for sensorfw | 13:57 |
| T42_ | <Herrie1982> Yes iio | 14:07 |
| genericv2 | i am home finally, starting to work on sparse | 15:56 |
| genericv2 | mal: what about your gh username, are going to give it or no? | 15:57 |
| mal | mlehtima | 16:12 |
| mal | it's quite public knowledge and visible in logs | 16:12 |
| mal | I still don't know why you have to make the project private | 16:14 |
| genericv2 | idk i want to make it private before we could make it boot to gui | 16:18 |
| genericv2 | uploaded everything | 16:31 |
| genericv2 | mal: https://github.com/Sailfish-Sagit | 17:37 |
| genericv2 | am i going fine? | 17:38 |
| mal | some odd things in there | 17:39 |
| genericv2 | like | 17:40 |
| mal | missing sparse/etc/selinux/minimum/contexts/files/file_contexts | 17:41 |
| genericv2 | https://github.com/Sailfish-Sagit/droid-config-sagit/blob/master/sparse/etc/selinux/minimum/contexts/files/file_contexts | 17:42 |
| genericv2 | isn't it this one | 17:42 |
| mal | the system mount stuff should not really be there, you should fix fstab instead and rebuild hybris-hal and then droid-hal rpms (at the same adding some other small fixes) | 17:43 |
| mal | sparse/etc/selinux/minimum/contexts/files/policy.30 should not exists, that file is in sparse/etc/selinux/minimum/policy/policy.30 | 17:43 |
| mal | also wondering about all of those files in sparse/usr/libexec/droid-hybris/system/etc/init | 17:44 |
| genericv2 | they came with the submodule | 17:44 |
| genericv2 | i didin't added them | 17:44 |
| mal | if they are in submodule why did you copy them? | 17:45 |
| genericv2 | i didin't, they were already there. as i remember | 17:45 |
| genericv2 | hm | 17:45 |
| mal | what? | 17:45 |
| mal | you must have copied those from somewhere | 17:46 |
| mal | I have no idea where those are from | 17:47 |
| genericv2 | me too tbh, i am checking right now | 17:47 |
| mal | as you can see in submodule things are disabled like this https://github.com/mer-hybris/droid-hal-configs/blob/238588b0e735ef9120e8b0d69b8b3f856194a710/sparse-13/usr/libexec/droid-hybris/system/etc/init/disabled_services.rc | 17:47 |
| mal | and you don't have to touch that | 17:48 |
| mal | also the repo is missing the task_profiles things | 17:48 |
| genericv2 | i know i am gonna add it too | 17:49 |
| genericv2 | okay i found where i got those from | 17:49 |
| genericv2 | hadk-faq hybris-15.1 section xD | 17:49 |
| genericv2 | wait i'll clean this mess | 17:49 |
| mal | you should remove installroot, tmp and documentation.list from git and add this kind of git ignore to prevent them getting there in the future https://github.com/mlehtima/droid-config-fp4/blob/devel/.gitignore | 17:50 |
| mal | nothing in 17.1 or 16.0 instructions said you should do 15.1 also | 17:52 |
| mal | 17.1 only said to apply patches like in 16.0 nothing more | 17:52 |
| genericv2 | i know i know. i made that mistake in very beginning | 17:52 |
| genericv2 | right before we are messing with kernel issue | 17:52 |
| mal | why did you remove the repo now? | 17:53 |
| mal | you know you can just force push to it | 17:53 |
| genericv2 | i'll start from beginning in that repo, i did so much mistakes for that | 17:53 |
| mal | that was not necessary | 17:54 |
| genericv2 | ah right | 17:54 |
| genericv2 | force push is a thing | 17:54 |
| mal | now you will probably miss things again | 17:54 |
| genericv2 | yeah xD | 17:54 |
| genericv2 | but i am not that stupid now, so it'll be better | 17:54 |
| genericv2 | it must be okay now | 18:09 |
| genericv2 | can you check ? | 18:10 |
| genericv2 | Now about system mount, i must do it like this right?: "/dev/block/bootdevice/by-name/system /system_root" | 18:13 |
| T42_ | <elros34> no, you never use by-name paths, that is whole point of fixup-mountpoints | 18:28 |
| genericv2 | this is no fixup-mountpoints. wait wait wait | 18:28 |
| T42_ | <elros34> its not but whole explanation from fixup-mountpoints is valid here too and for every systemd mount unit | 18:29 |
| genericv2 | Now, to fix system mount, i'll need to change system to system_root from fixup mountpoints right? | 18:30 |
| genericv2 | That file was fstab.qcom | 18:31 |
| mal | you only fix fstab | 18:35 |
| mal | fixup remains as it is | 18:35 |
| genericv2 | as i guessed | 18:36 |
| genericv2 | is mounting by-name/system to /system_root enough or | 18:36 |
| genericv2 | do i need to add another entry | 18:36 |
| mal | you are now completely misunderstanding what to do | 18:36 |
| mal | what kind of change did you do to fstab? | 18:36 |
| genericv2 | :( | 18:36 |
| genericv2 | nothing right now | 18:37 |
| mal | you only touch fstab, do not touch fixup | 18:37 |
| genericv2 | i know, didin't edited fixup-mountpoints | 18:37 |
| genericv2 | i am talking about fstab | 18:37 |
| mal | the whole point is that if fstab has /system then it becomes / | 18:37 |
| mal | I mean you replace it like that | 18:38 |
| genericv2 | Directly to "/" or "/system_root"? | 18:38 |
| mal | system_root is not something that belong to anywhere, it's just internal magic done in droid-hal rpm build | 18:38 |
| genericv2 | ah okay then | 18:38 |
| genericv2 | "/dev/block/bootdevice/by-name/system /" | 18:38 |
| genericv2 | like this right | 18:39 |
| mal | yes, after building hybris-hal and then droid-hal rpms you should see the correct mount services in droid-hal rpm (one of those, can't remember if the main one) | 18:39 |
| genericv2 | okaay, saved it like this then. | 18:39 |
| genericv2 | I remember like there was a ld.config thingy, i'll add that to sparse aswell | 18:40 |
| mal | there should be no ld-config things in android 13 base | 18:40 |
| mal | are you sure you didn't take that from the 15.1 instructions | 18:41 |
| T42_ | <elros34> now I understand why you had ld.config mount unit in your previous logs | 18:42 |
| genericv2 | I applied everything from 15.1 instructions in my previous bulds. That config is HILARIOUS | 18:42 |
| genericv2 | But you know i am not stupid now. | 18:43 |
| genericv2 | now, about usb-moded. Can i obsolote it from config or masking it from sparse was right? | 18:43 |
| genericv2 | Then /odm and thats it i think, i'll check irc logs again to see if i missed something | 18:45 |
| T42_ | <elros34> are you sure you even need to mask it? Its only sometimes needed. Definitely not something you want on working port | 18:46 |
| genericv2 | i am sure, it aggressively kills my usb port when it's enabled. | 18:47 |
| genericv2 | If my power button was working. that will not be gonna a big deal but.. | 18:47 |
| mal | usb-moded disabling is just temporary and should not probably be added to git | 18:48 |
| T42_ | <elros34> I am curious why do you create all of these from scratch like mount units? You already had them created and even working | 18:49 |
| genericv2 | Just purged droid-configs. Didin't touched to fixup-mountspoints etc and anything else | 18:49 |
| mal | I really hope you took a backup of the droid-config changes | 18:50 |
| genericv2 | mal: are you sure it'll work now, you know we will need to wait for hours if it fails again | 18:50 |
| mal | ? | 18:51 |
| genericv2 | talking about usb-moded | 18:51 |
| genericv2 | not gonna mask it as you said | 18:52 |
| mal | no idea, but I said not to add it to git, you can have it locally until you verify you can re-enable it | 18:52 |
| genericv2 | oh okay | 18:52 |
| mal | all I meant was that adding temporary hacks to git is not good, especially if those are only for very early porting | 18:53 |
| genericv2 | yeah yeah i understand what you said after writing that | 18:53 |
| mal | please verify the mount services in droid-hal rpms before rebuilding a new image | 18:55 |
| genericv2 | sure | 19:06 |
| genericv2 | lets see if this beautiful build works after previous mess | 19:08 |
| T42_ | <b100dian> mal: I have two droidmedia camera2 PRs: 121 with fixes for Zenfone8 and 122 with a hack for initial params. Just 1. so you know and 2. maybe add camera2 tag to them | 20:40 |
| T42_ | <b100dian> draft PRs, by all means | 20:41 |
| mal | tagged | 20:42 |
| mal | @b100dian I had also wip code locally to properly handle parameter setting, need to check how different your code is | 20:42 |
| genericv2 | i built and flashed now. Mountpoints are okay. Gonna reboot | 20:43 |
| T42_ | <b100dian> mal: hope you have a saner solution, mine's just a hack | 20:43 |
| T42_ | <b100dian> but thanks for tagging them | 20:44 |
| mal | @b100dian my changes have some bug which I didn't yet find, I will compare and see which makes more sense | 20:44 |
| T42_ | <b100dian> maybe half sane / half hack :) | 20:45 |
| mal | @b100dian with those changes you have does it keep the settings when for example going from viewfinder to checking taken pictures and back? | 20:45 |
| T42_ | <b100dian> let me check | 20:46 |
| T42_ | <b100dian> Yes. That is, PR 122 | 20:46 |
| T42_ | <b100dian> I'm afraid a clean solution is to change some things around camera usage from the gst-droid plugin | 20:47 |
| mal | yeah, gst-droid is not really that great for camera2 | 20:48 |
| mal | I have even considered making a new one | 20:48 |
| T42_ | <b100dian> The whole machinery is kind of involved there, and so is the gstreamer code, and seems hard to refactor, but I do agree it is a wonder that it exists and works! | 20:49 |
| mal | I remember the was some talk in gstreamer to refactor some camera things to make it more compatible with camera2 | 20:50 |
| T42_ | <b100dian> You know, last summer I was fixing playback on Zenfone8 by watching the interaction of gecko-camera and droidmedia on my device. And I could, and I did! | 20:51 |
| T42_ | <b100dian> Next would have been fixing gst-droid + droidmedia interaction | 20:51 |
| T42_ | <b100dian> I failed | 20:51 |
| T42_ | <b100dian> Interesting, that is, gstreamer mailing list? | 20:52 |
| mal | once those settings are working in camera2 I still need to fix the video recording issue which is probably something simple, the issue is that the output video only shows first frame because some issue with timestamps or something like that | 20:52 |
| T42_ | <b100dian> ah, was gonna ask about that! | 20:53 |
| mal | @b100dian can't remember if there, or issue tracker or somewhere else | 20:53 |
| T42_ | <b100dian> So video is also crashing gst-droid/gstreamer? | 20:53 |
| mal | ? | 20:53 |
| T42_ | <b100dian> I know you have made progress around video, but dont' know what the state of the current problem | 20:54 |
| mal | it doesn't crash in my development code | 20:55 |
| mal | it records video, the size of the file looks ok but playback fails except for first frame | 20:55 |
| mal | camera works also in browser with my code | 20:55 |
| T42_ | <b100dian> Oh, maybe I have old versions, first let me check | 20:56 |
| mal | it's not in that camera2 branch | 20:56 |
| T42_ | <b100dian> yes, there are several | 20:57 |
| mal | it might be that camera2-test3 branch but need to check that later if it really was that | 20:57 |
| mal | it does say almost working video in commit messages :) | 20:57 |
| mal | nice commit messages in that bracnh | 20:57 |
| T42_ | <b100dian> yes, I think those I have | 20:58 |
| T42_ | <b100dian> the commit messages don't matter now:) | 20:59 |
| T42_ | <b100dian> I was seeing crashes, that you may not have, let me try find who/what | 20:59 |
| T42_ | <b100dian> First frame does seem promising, maybe you need a decoding patch :D but feel free to share a 'broken' video, maybe just maybe there's something ffmpeg can tell us about it | 21:00 |
| genericv2 | mal: droid-hal-init is timing out right now | 21:01 |
| genericv2 | made timeoutsec 9999, but it's probably in loop | 21:02 |
| mal | @b100dian I remember seeing messages that playback drops frames a lot | 21:02 |
| mal | genericv2: wondering what you are missing | 21:02 |
| genericv2 | xD, me too. i wonder what did i do wrong | 21:03 |
| genericv2 | ohmd.service fails to start | 21:03 |
| mal | that selinux config in git is still a mess | 21:03 |
| genericv2 | no, i (think) i fixed it | 21:03 |
| mal | you have two policy.30 files there now | 21:03 |
| mal | in different places | 21:03 |
| genericv2 | yeah it's still a mess i guess | 21:04 |
| genericv2 | i am getting loss to fix it, bye for a few minutes | 21:04 |
| genericv2 | lost* | 21:04 |
| genericv2 | i need to fix my english aswell | 21:04 |
| T42_ | <b100dian> mal: but it matters how the final product is on desktop too. Playback dropping frames is .. well, something for ccodec2 devices I made PR 111 if you remember, but it may not apply here of course | 21:04 |
| mal | @b100dian I tested playing the video on my laptop also, failed there also | 21:05 |
| mal | genericv2: how about you look at the folder structure here for example https://github.com/mlehtima/droid-config-fp4/tree/devel/sparse/etc/selinux | 21:06 |
| T42_ | <b100dian> Ok. It is not like your device was immediately upgraded from ACodec to CCodec2 if you recorded with camera2 API:) So there is a recording problem | 21:07 |
| genericv2 | yeah i was searching for it | 21:07 |
| T42_ | <b100dian> I am currently seeing `Thread 56 "CodecLooper" received signal SIGSEGV, Segmentation fault` in jolla-camera but no logcat errors when video recording crashes camera2 | 21:07 |
| T42_ | <b100dian> GST_DEBUG=4 jolla-camera https://pastebin.ubuntu.com/p/zGsQFZgbxr/ Since there's no logcat error per se I don't post it here. | 21:13 |
| T42_ | <b100dian> Anyway, no need to look into that. The info that you can record and I can't is already useful | 21:13 |
| T42_ | <elros34> what cause all of these false "library "*" not found". Is it android or some libhybris changes fault? | 21:17 |
| mal | @b100dian need to check if that branch even has all my changes | 21:21 |
| T42_ | <b100dian> mal: yes pleaae. make camera2-test4 branch:) | 21:25 |
| genericv2 | mal: can you check the current selinux config | 21:29 |
| mal | seems reasonable | 21:30 |
| genericv2 | finally | 21:30 |
| genericv2 | droid-hal-init.service: Start operation timed out. Terminating | 21:34 |
| genericv2 | :( | 21:34 |
| genericv2 | great great great | 21:34 |
| genericv2 | now theere is no hwservicemanager etc. is that okay" | 21:36 |
| genericv2 | /usr # ls ./libexec/droid-hybris/system/etc/init/ | 21:36 |
| genericv2 | apexd.rc disabled_services.rc ecclist.rc hw hybris_extras.rc minimediaservice.rc minisfservice.rc servicemanager.rc | 21:36 |
| genericv3 | No luck (: I need to take phone to service tomorrow morning. Maybe it'll get back in a week, or two. This will be long for me but nothing to do. At least i'll continue with a new screen and a working power button :) I'll continue checking here as always. Thanks everyone. | 22:04 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!