| mal | https://forum.sailfishos.org/t/sailfish-os-for-fairphones-devices/21516 Sailfish OS ports for Fairphone 4 and 5 now available | 13:04 |
|---|---|---|
| T42 | <b100dian> Awesome! | 13:21 |
| T42 | <b100dian> FP5 troubles playing back - is this in the browser too? I have tried to fight this on sake with Android 11 base (LOS 18.1). Yours is newer I guess? | 13:22 |
| mal | probably affects browser, forgot to test :) | 13:25 |
| mal | @b100dian does your device use c2 hw codec? | 13:26 |
| mal | I suspect my issue is related to that, not sure yet | 13:26 |
| T42 | <b100dian> Yes, and that's why I tried to doctor droidmedia for that, but only for browser it wored | 13:26 |
| T42 | <b100dian> *worked | 13:26 |
| T42 | <b100dian> I have a PR that is already oldish for that, I think you were suggesting simplifying it and I didn't get the chance | 13:27 |
| mal | hmm, forgot about that, need to check | 13:27 |
| mal | in browser video starts to play but after a couple of frames gets corrupted | 13:28 |
| T42 | <b100dian> no worries, my device is killed by asus so I wasn't very investing into it either. But might worth a try with browser playback. | 13:28 |
| T42 | <TheVancedGamer> oops | 13:29 |
| b100dian | what did I say now, I got kicked out again? | 13:29 |
| T42 | <TheVancedGamer> /unban @b100dian | 13:29 |
| T42 | <TheVancedGamer> b100dian: sorry, "investing" got you kicked :p | 13:29 |
| T42 | <TheVancedGamer> I'll reconfigure it to only kick later | 13:30 |
| mal | is there so much spam in telegram side? | 13:30 |
| T42 | <b100dian> Alright. So, I did not "spend time" on this because asus killed my device | 13:31 |
| T42 | <b100dian> The "after a couple of frames" is exactly what I had in the browser | 13:31 |
| T42 | <b100dian> @TheVancedGamer no worries, at least I get to keep the channel back history when joining. | 13:32 |
| T42 | <TheVancedGamer> it's a toggle, I turned it off when I implemented the blocklists | 13:32 |
| mal | @b100dian I'll test that PR you made | 13:33 |
| T42 | <b100dian> Cool | 13:34 |
| T42 | <b100dian> mal: for camera look for c2inputsource https://piggz.co.uk/sailfishos-porters-archive/index.php?log=2023-05-09.txt#line3 | 13:43 |
| T42 | <b100dian> Maybe you also have that same problem:p | 13:44 |
| mal | afaik Android 13 removed the internal things we use for video recording but need to check | 13:46 |
| T42 | <b100dian> Ah, so much newer base than mine | 13:49 |
| mal | those fp4 and fp5 ports use Android 14 base | 13:49 |
| mal | @b100dian I got video playback working in browser but not in gallery app | 14:20 |
| T42 | <b100dian> Yea, I didnt figure out gallery, I ended up disabling hw codecs too.. | 14:22 |
| T42 | <b100dian> Avc in particular.. https://github.com/sailfishos-on-sake/droid-config-sake/commit/66044bf985c5dc8b84cf88349a4a821fea790f8b | 14:23 |
| T42 | <b100dian> One thing I remember, even the waydroid's lineage gallery wasn't working, so I have no clue how to fix that | 14:23 |
| mal | I also needed GECKO_CAMERA_DROID_FORCE_MEDIA_BUFFER=1 for browser | 14:24 |
| T42 | <b100dian> Ah, yes, that is correct, the changes only affect that codepath. | 14:24 |
| mal | I suspect it's not taking the same code path or something, need to debug a bit | 14:26 |
| T42 | <b100dian> I remember it does take the same code path, but I didnt manage to pinpoint what in the gstreamer + gstdroid machinery was not going on the same when using droidmedia | 14:45 |
| mal | well both browser and gallery use droidmedia, just a bit different way | 14:46 |
| mal | @b100dian I checked a bit how the codec issue is happening in gallery app, it takes different code path because mGraphicBuffer is NULL, you patch applies only to the != NULL case | 19:58 |
| mal | not sure why that is NULL | 19:58 |
| mal | hmm, actually that only happens sometimes | 19:59 |
| mal | but even when it gets to that != NULL path it never goes to the new code | 20:01 |
| T42 | <b100dian> Maybe something more fundamental about buffer handling needs rework. | 20:06 |
| T42 | <b100dian> My patch comes from an empiric observation of behavior, not some documentation or android source code reading | 20:07 |
| mal | yeah, could be it fixes some case but not the actual root cause | 20:11 |
| mal | I need to have a more through look into android and droidmedia code | 20:11 |
| mal | probably after xmas though | 20:12 |
| T42 | <b100dian> Of course. Thanks for testing the branch and let's hope there's a cleaner solution;) | 20:16 |
| *** Mister_Magister_ is now known as Mister_Magister | 23:26 | |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!