| rinigus | @TheVancedGamer: with your PR https://github.com/sailfishos/droidmedia/pull/130, I have a camera on nagara/los21. thank you very much! (cc mal) | 12:12 |
|---|---|---|
| mal | I tested that on x10v and at least the new services showed up in binder-list so probably fine | 12:14 |
| mal | maybe I'll still test on fp4 or fp5 to verify | 12:14 |
| T42 | <TheVancedGamer> it works on my pixel at least, gets hwc up | 12:14 |
| T42 | <TheVancedGamer> otherwise it wouldn't boot | 12:14 |
| Mister_Magister | does it restore camera1 api or something? | 12:14 |
| T42 | <TheVancedGamer> no, stubs sensorservice and IStats but over AIDL | 12:15 |
| T42 | <TheVancedGamer> a lot of services depend on these two HALs (at least for me) | 12:15 |
| Mister_Magister | I was told there's no camera on a14 due to no camera1 api | 12:15 |
| Mister_Magister | in fact mal said it | 12:15 |
| Mister_Magister | so are y'all using camera2 api? | 12:16 |
| mal | no, camera2 still needs a bit of work | 12:16 |
| rinigus | @TheVancedGamer: for me composer was fine, just camera. although, composer is blob-lifted from moto blobs. with sony blobs I couldn't start composer when making LOS21. | 12:16 |
| mal | camera in a14 works without video recording | 12:16 |
| rinigus | @TheVancedGamer: you asked me regarding composer earlier. nagara has vendor.qti.hardware.display.composer@3.1::IQtiComposer/default and android.hardware.graphics.composer@2.4::IComposer/default . | 12:17 |
| T42 | <TheVancedGamer> yeah you have hwc2 | 12:18 |
| Mister_Magister | mal: via camera2 api | 12:18 |
| Mister_Magister | so i'm confused how that fix restores camera for y'all if y'all aren't using camera2 api a14 doesn't have camera1 api supposedly | 12:19 |
| mal | Mister_Magister: no, I mean camera1 picture mode work fine in a14, the part they removed was the video pipeline we use | 12:19 |
| Mister_Magister | ahhh | 12:19 |
| Mister_Magister | but you also only get picture in camera2 api cause you didn't fix video yet | 12:19 |
| rinigus | since I have been living under the rock and not following camera1/2 - what do I need to get multiple lenses working on SFOS? right now looks like its loading one of the back lenses out of three. and also can switch to front . but cannot choose which one of the back lenses is used | 12:20 |
| Mister_Magister | confusion cleared | 12:20 |
| Mister_Magister | rinigus: nothing much, use advanced camera | 12:20 |
| mal | well my test camera2 code I have did record video but due to some timestamp issue or somethings like that it couldn't be played back, the video data was there in the file | 12:20 |
| Mister_Magister | so close | 12:20 |
| mal | yeah | 12:20 |
| T42 | <TheVancedGamer> mal: you've pushed all of your camera2 stuff right? | 12:20 |
| mal | I think no | 12:20 |
| T42 | <TheVancedGamer> I'm interested in getting camera2 running on UT with FP5, so I could help if you want | 12:21 |
| Mister_Magister | I'm like on the two edges of spectrum | 12:21 |
| Mister_Magister | i want camera2 api for my a14 device and I want fix for kernel 3.4 on my 11 years old device | 12:21 |
| Mister_Magister | old and new | 12:21 |
| Mister_Magister | the newest and the oldest | 12:21 |
| rinigus | Mister_Magister: advanced camera doesn't show multiple lenses either. any config needed? | 12:21 |
| Mister_Magister | rinigus: nope, it ususally works straight away | 12:22 |
| T42 | <TheVancedGamer> mal: I would also appreciate it if you could merge the libhybris PR before I forget to update UT packaging :D | 12:22 |
| rinigus | :( . | 12:22 |
| Mister_Magister | also the mce pr pretty please | 12:22 |
| Mister_Magister | I've been touching grass and it works perfect | 12:22 |
| Mister_Magister | rinigus: could be camera2 api thing | 12:24 |
| rinigus | Mister_Magister: hmm, you mean its not supported with camera1 api? I have a feeling it was similar on LOS21, but don't remember for sure | 12:25 |
| Mister_Magister | rinigus: on a14 | 12:25 |
| mal | @TheVancedGamer would you like to do a quick rebase of that libhybris memory fix so I get cleaner git history (I want the merge commit there so I don't want to use the rebase feature) | 12:25 |
| Mister_Magister | but thats just a guess | 12:25 |
| T42 | <TheVancedGamer> mal: sure, can do | 12:25 |
| rinigus | yeah, could be. but to test it I would have to go back to LOS21. probably should | 12:26 |
| T42 | <TheVancedGamer> mal: done | 12:26 |
| mal | @TheVancedGamer something went wrong, it shows the commit you pushed in the PR | 12:28 |
| T42 | <TheVancedGamer> hmm | 12:28 |
| T42 | <TheVancedGamer> it shouldn't appear if you merge it though | 12:28 |
| T42 | <TheVancedGamer> because I only rebased my branch on top of origin | 12:28 |
| mal | did you cherry-pick the commit or merge instead of rebase? | 12:28 |
| T42 | <TheVancedGamer> rebase | 12:28 |
| mal | https://github.com/muhammad23012009/libhybris/commits/master/ | 12:28 |
| mal | those are in wrong order | 12:28 |
| T42 | <TheVancedGamer> how did that happen even | 12:29 |
| mal | no idea | 12:29 |
| T42 | <TheVancedGamer> sec | 12:29 |
| T42 | <TheVancedGamer> hmmm : https://irc.thaodan.de/.imgstore/6096409e/file_7454.jpg | 12:29 |
| mal | that branch is not pushed based on that? | 12:30 |
| T42 | <TheVancedGamer> it's confusing, I pushed this | 12:30 |
| T42 | <TheVancedGamer> I'll try fixing it | 12:30 |
| mal | it should so the someremote/master in the commit line | 12:30 |
| mal | how did you rebase? | 12:31 |
| T42 | <TheVancedGamer> pulled origin with pull.rebase | 12:31 |
| mal | but that branch looks ok in that screenshot, not sure what happened when pushing, try force pushing again | 12:31 |
| T42 | <TheVancedGamer> ok, fixed | 12:33 |
| mal | merged | 12:35 |
| T42 | <TheVancedGamer> great, thanks mal! | 12:36 |
| mal | I'll probably wait for that hwc2/hwc3 PR to be fixed before updating sailfish packaging | 12:36 |
| T42 | <TheVancedGamer> fortunately for us we use two separate forks of libhybris :P | 12:36 |
| mal | are there any changes in those that could be upstreamed? | 12:37 |
| T42 | <TheVancedGamer> there is an issue on Android 14+ vendors, VNDK got fully dropped and now we need to use HYBRIS_LD_LIBRARY_PATH with /system/lib64 | 12:38 |
| T42 | <TheVancedGamer> no idea how to properly handle that | 12:38 |
| mal | yeah, that vndk has been causing some headache for me also | 12:39 |
| T42 | <TheVancedGamer> I managed to drop all dependencies on vndk.v34, but I still need system libs | 12:39 |
| mal | I did reorder the paths in our packaging https://github.com/mer-hybris/libhybris/commit/c97746de1696a09bf5a4b067fdfb7918874c5285 | 12:39 |
| T42 | <TheVancedGamer> because everything is now moved back to either vendor or system | 12:39 |
| T42 | <TheVancedGamer> mal: could you turn that into a proper patch in libhybris itself? | 12:40 |
| T42 | <TheVancedGamer> e.g. we do this for UT: https://gitlab.com/ubports/development/core/packaging/libhybris/-/blob/ubports/latest/debian/patches/0009-q-Add-com.android.i18n-apex-to-library-path.patch?ref_type=heads | 12:40 |
| mal | need to see what the defaults are there | 12:40 |
| T42 | <TheVancedGamer> maybe it'd be good to unify everything in one place | 12:40 |
| mal | is that com.android.i18n from some newer android linker? | 12:41 |
| T42 | <TheVancedGamer> A12+ iirc | 12:41 |
| mal | I remember having issues with that path | 12:41 |
| T42 | <TheVancedGamer> some mandatory libraries got moved to i18n apex | 12:41 |
| mal | yeah, that would be good for upstreaming, maybe android version conditionally if that was added in a12? | 12:41 |
| T42 | <TheVancedGamer> possibly yeah | 12:41 |
| mal | but should not matter much if it's unconditional, maybe | 12:42 |
| mal | this is how we have handled that issue https://github.com/mer-hybris/droid-config-sony-murray/tree/master/sparse/system/lib64 | 12:42 |
| mal | which is a terrible way | 12:42 |
| T42 | <TheVancedGamer> oh dear | 12:43 |
| T42 | <TheVancedGamer> uhhh xD | 12:43 |
| mal | I didn't have time to check linker side when fixing that | 12:44 |
| mal | but please have a look at upstreamging that patch, would be useful for us also | 12:44 |
| Mister_Magister | mal: oh yeah right i'm dumb i have photos working on my a14 device i just forgot | 12:47 |
| T42 | <TheVancedGamer> mal: would it make sense to use linkerconfig for ld paths? | 12:47 |
| Mister_Magister | too many devices to keep track of | 12:47 |
| mal | @TheVancedGamer how do you mean? i think we do get some parts from linkerconfig already, it generates the linker configs at boot | 12:48 |
| mal | but not in lh | 12:48 |
| T42 | <TheVancedGamer> mal: linkerconfig also specifies list of paths that should be used for libraries | 12:48 |
| rinigus | mal: for some reason s didn't work on nagara/los21. as linker was refusing to follow to apex dir. so, I had compiled apex and added these libs as copies in hybris. if UT solution works, its way better | 12:48 |
| mal | rinigus: linker is quite strict about namespaces now | 12:49 |
| rinigus | edit: (symlinks didn't work) | 12:49 |
| rinigus | it is. | 12:49 |
| mal | and symlinks | 12:49 |
| mal | that is why some devices have needed some bind mount hacks | 12:49 |
| Mister_Magister | yeap like me | 12:50 |
| mal | I know the linker stuff is a bit hacky at the moment | 12:50 |
| Mister_Magister | i can't preload i can't symlink i can't even put it in libexec/droid-hybris | 12:50 |
| Mister_Magister | i need to mount --bind it to vendor | 12:50 |
| mal | I'll take a break now, will be back a bit later, I'll verify that droidmedia PR later today and merge it and maybe rebase the camera2 stuff I have | 12:51 |
| rinigus | actually, with nagara I dropped bind mounts and use overlays. which seem to work nicely | 12:52 |
| mal | would be nice to solve the linker issues to remove the need for things like those | 12:52 |
| Mister_Magister | mal: is c2 also on a14? | 12:53 |
| T42 | <TheVancedGamer> ooh that does remind me, OMX has been deprecated with 15/16 | 12:53 |
| mal | yeah, codec stuff might need some changes soon | 12:54 |
| mal | Mister_Magister: a13, which has same camera issues as a14 | 12:54 |
| Mister_Magister | ah | 12:54 |
| mal | for video recording | 12:54 |
| Mister_Magister | @TheVancedGamer good old a5, nothing beats a5 | 12:54 |
| mal | @TheVancedGamer those ndk codecs might be the way forward (also used in camera2) | 12:55 |
| T42 | <TheVancedGamer> mal: we have c2 codecs on gst-hybris | 12:56 |
| rinigus | let's let mal have his break :) | 12:56 |
| Mister_Magister | rinigus: thats a tough one | 12:57 |
| Mister_Magister | he never ever wants to take a break | 12:57 |
| Mister_Magister | he's legend like that | 12:57 |
| T42 | <TheVancedGamer> nah he's just finnish | 12:58 |
| Mister_Magister | yeah | 12:58 |
| T42 | <morciatka> he's not finished /s | 12:58 |
| mal | @TheVancedGamer can you point be to the repo of that | 12:58 |
| T42 | <TheVancedGamer> mal: https://gitlab.com/ubports/development/core/hybris-support/gst-hybris | 12:58 |
| Mister_Magister | we shall name him angel of sailfish | 12:58 |
| T42 | <TheVancedGamer> we need some work for audio codecs still | 12:58 |
| T42 | <morciatka> the mermaid or what /s | 12:58 |
| Mister_Magister | @TheVancedGamer audio codecs? those are done in software | 12:59 |
| T42 | <TheVancedGamer> gst-hybris cannot handle any audio codecs | 12:59 |
| Mister_Magister | ye | 12:59 |
| T42 | <TheVancedGamer> it has code, just needs to be fixed | 12:59 |
| Mister_Magister | becuase there's no point for it to | 12:59 |
| T42 | <TheVancedGamer> there is | 12:59 |
| mal | @TheVancedGamer codecs in droidmedia have some issues with c2-only devices, some devices have issues | 12:59 |
| T42 | <TheVancedGamer> codecs like eac3 are proprietary | 13:00 |
| T42 | <TheVancedGamer> and android bundles them | 13:00 |
| Mister_Magister | ah | 13:00 |
| mal | Mister_Magister: droidmedia has couple of audio codecs | 13:00 |
| mal | and gst-droid | 13:00 |
| Mister_Magister | so instead of paying for license you just use android side | 13:00 |
| mal | yes :) | 13:00 |
| Mister_Magister | :)))))))) | 13:00 |
| Mister_Magister | i love it | 13:00 |
| T42 | <TheVancedGamer> who wants to pay Dolby millions of dollars | 13:00 |
| mal | rinigus: about that multicamera issue on nagara, does the issue happen in all camera apps? | 15:36 |
| rinigus | mal: yes, it does. I haven't checked, but I think its not supported on LOS21 using camera1 api | 15:37 |
| rinigus | also adding multicamera setting to /vendor/etc/camera/camxoverridesettings.txt doesn't help either. | 15:38 |
| mal | anyway that droidmedia PR has now been merged | 15:38 |
| rinigus | mal: thanks! | 15:39 |
| mal | @TheVancedGamer https://github.com/libhybris/libhybris/pull/582 | 17:21 |
| T42 | <TheVancedGamer> mal: lgtm! | 17:23 |
| T42 | <TheVancedGamer> and thank you for working on it :D | 17:23 |
| mal | @TheVancedGamer in case you want to test this in ubuntu builds https://github.com/libhybris/libhybris/pull/583 | 20:02 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
