| mal | Mister_Magister: time to fix the PR today? | 17:03 |
|---|---|---|
| Mister_Magister | maaan you in hurry | 20:00 |
| Mister_Magister | mal: i'm not sure which identation you'd like, the sfos code is always very weird about them | 20:04 |
| Mister_Magister | mal: done | 20:07 |
| Mister_Magister | lemme see what compiler says now | 20:07 |
| Mister_Magister | still complaining | 20:09 |
| Mister_Magister | oh | 20:09 |
| Mister_Magister | honestly that return is too dense i would split it | 20:11 |
| Mister_Magister | but you sfos guys have weird rules xd | 20:11 |
| Mister_Magister | ok now the warning is quiet | 20:13 |
| Mister_Magister | hope the identation is okay | 20:13 |
| mal | Mister_Magister: I think we are not exactly following the style in that, you check https://github.com/mer-hybris/ofono-binder-plugin/blob/master/src/binder_radio_caps.c#L340 that gives an idea how it should look, so the base indentation is 4 spaces in the second line and the for each multiline parentheses there is one space indentation to make it clearer that what belongs under inside the | 21:11 |
| mal | parentheses | 21:11 |
| Mister_Magister | ughh xd | 21:12 |
| mal | to me this is the way https://pastebin.com/u1cN116q | 21:12 |
| mal | at least how I see the style being used | 21:13 |
| Mister_Magister | ya know you could just make the commit xd | 21:13 |
| Mister_Magister | github has feature where maintainers can commit to the pr repo | 21:13 |
| Mister_Magister | pushed | 21:14 |
| Mister_Magister | the formatting is very inconsistent | 21:14 |
| mal | hmm, you didn't change the base indentation, the next line after return should have 4 spaces i.e. the ( is below second r of return | 21:16 |
| mal | like in the example I showed | 21:16 |
| Mister_Magister | i literally copy pasted what you gave me xd | 21:16 |
| mal | hmm | 21:16 |
| Mister_Magister | how about now | 21:17 |
| mal | or is github messing up things again | 21:17 |
| Mister_Magister | i fixed it | 21:17 |
| mal | now looks like I want | 21:17 |
| mal | argh, I always miss things | 21:18 |
| mal | the function parameters should 4 spaces not 8 | 21:18 |
| mal | of that binder_data_manager_set_preferred_data_modem_allowed | 21:19 |
| Mister_Magister | fixed | 21:19 |
| Mister_Magister | y'all should invest in some linter | 21:19 |
| Mister_Magister | in php land we have tools that reformat the files | 21:19 |
| Mister_Magister | my IDE normally does that for me | 21:19 |
| mal | some projects have those, most don't | 21:20 |
| mal | I remember some project has git commit hook to check some stuff | 21:20 |
| Mister_Magister | am back to gaming | 21:20 |
| mal | thanks for the fixes, I'll merge that in a moment | 21:21 |
| mal | that open PR I have there is getting bigger all the time | 21:21 |
| Mister_Magister | now you ought to help me fix the volte once it gets merged lol | 21:21 |
| mal | volte is like black magic | 21:22 |
| Mister_Magister | it really is | 21:23 |
| mal | I know the binder side of it but anything below that is just a black box | 21:23 |
| Mister_Magister | but i have even less idea than you xd | 21:23 |
| mal | I think volte in general was a terrible idea | 21:24 |
| Mister_Magister | we just gotta deal with it i guess | 21:26 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!