| Mister_Magister | @abranson also 5th PR https://github.com/sailfishos/qtwayland/pull/8 | 00:58 |
|---|---|---|
| *** n2klb_ is now known as n2klb | 01:52 | |
| T42 | <adampigg> Yes ta | 08:06 |
| T42 | <abranson> @Mister_Magister could you try this instead please, without the foreign-display plugins-base patch: https://github.com/abranson/qtwayland/tree/event-thread | 11:29 |
| T42 | <Mister_Magister> sure thing boss | 17:20 |
| Mister_Magister | itsa building | 18:01 |
| Mister_Magister | @abranson indeed it does | 18:35 |
| Mister_Magister | "it does fix the issue" is what i've meant | 18:35 |
| Mister_Magister | let me check with gst-plugins-good on correct branch too | 18:40 |
| Mister_Magister | @abranson so gst-plugins-base is built at tmp branch which is same as pr with last commit removed https://build.sailfishos.org/package/show/home:mister/gst-plugins-base, then qtwayland is built off of your branch https://build.sailfishos.org/package/show/home:mister/qtwayland and gst-plugins-good is built off of PR branch and there's no freezing | 19:23 |
| T42 | <abranson> very good | 19:24 |
| T42 | <adampigg> @abranson , so, the question is, why was the event loop removed, and whats the impact of adding it back? | 19:28 |
| T42 | <abranson> Not sure. I think a heavy handed way to solve a problem, which I think I've avoided adding back. | 19:29 |
| Mister_Magister | there's still second issue that's not resolved :P | 19:31 |
| Mister_Magister | probaly just as difficult | 19:31 |
| Mister_Magister | when you toggle the screen video goes black | 19:32 |
| T42 | <abranson> Don't vibe it this time please. If you don't understand what it's doing, then it tends to go off in strange directions. Those things need shepherding in the right direction, especially Claude. That last ejaculation ended up being a right mess and no help at all. | 19:37 |
| T42 | <abranson> Its fine for your own projects where the code is only maintained by you, but you shouldn't expect other people to take on and maintain code like that. | 19:38 |
| Mister_Magister | I think you misunderstand | 19:41 |
| Mister_Magister | Basically what you are telling me is "give up on the entire idea" | 19:42 |
| T42 | <abranson> no, just make sure you always understand what it's doing | 19:42 |
| Mister_Magister | But I don't, I have no knowledge of understanding of this code, I wasn't able to fix the initial crash yet alone the turbo weird freeze bug. So I either let LLM do that or ask someone for help and for months nobody was offering help, so what you're saying essentially is "give up" | 19:44 |
| Mister_Magister | You need such an in-depth understanding of this code i'd have to study this codebase for years to even fix the initial crash | 19:45 |
| Mister_Magister | And i don't love sfos that much to spend years chasing one bug | 19:45 |
| T42 | <abranson> Of course I'm not telling you to give up. The LLM can help you find the bits of the code that are at fault, and explain them to you. It can tell you what it's doing. The mistake is letting it go off without keeping you updated. | 19:45 |
| Mister_Magister | nope, this is way beyond my understanding | 19:46 |
| T42 | <abranson> You don't need to know everything inside out, you just have to keep following the LLM. If it loses you, tell it to stop and explain itself. | 19:46 |
| T42 | <abranson> It's not rocket surgey | 19:46 |
| T42 | <abranson> It's not rocket surgery (edited) | 19:46 |
| Mister_Magister | it's rocket science | 19:46 |
| Mister_Magister | no i'm serious this is so beyond my head i still have no clue what any of the patches are about | 19:47 |
| T42 | <abranson> that's because they got out of control. I don't really know what half of that stuff claude spewed out is for. it's a spaghetti mess. | 19:47 |
| T42 | <abranson> it's not very fair to generate something like that and expect someone else to spend hours trying to understand what you didn't try it | 19:48 |
| T42 | <abranson> it's not very fair to generate something like that and expect someone else to spend hours trying to understand what you didn't try to (edited) | 19:48 |
| Mister_Magister | no, it's not that, and i'm even talking about the original crash fix, you need in-depth understanding of encoding and stuff | 19:48 |
| Mister_Magister | sure | 19:48 |
| Mister_Magister | I get you | 19:48 |
| T42 | <abranson> i don't think other people have such a comprehensive knowledge either | 19:48 |
| Mister_Magister | but you gotta undersand my position | 19:48 |
| T42 | <abranson> but they know how to find out, and claude can help with that just as easily as it can generate spaghetti | 19:49 |
| T42 | <abranson> cos if we kept merging things like that we'd end up with a system no-one could understand | 19:49 |
| Mister_Magister | no I agree | 19:49 |
| Mister_Magister | but you gotta understand my point of view :D | 19:50 |
| T42 | <abranson> I understand that you thought it would help, and I thought it might too until I started trying to read it :D | 19:50 |
| T42 | <abranson> even the commit comment made me go cross-eyed | 19:50 |
| Mister_Magister | :P | 19:50 |
| Mister_Magister | thing is i want this stuff fixed, i have no clue how this code works so i have no chances of fixing it myself | 19:51 |
| Mister_Magister | and no, i'm not looking for sympathy just stating a fact | 19:52 |
| Mister_Magister | and I appreciate your help with this bug | 19:52 |
| Mister_Magister | at least the crash fix is okay | 19:52 |
| T42 | <abranson> well you got quite far really... | 19:56 |
| T42 | <abranson> but hitting that bug would have been the one to start bugging mal about :P | 19:56 |
| T42 | <abranson> homer_backing_into_bush.gif | 19:57 |
| Mister_Magister | yeah mal wasn't willing to help, maybe I should've pinged you every day instead about the second bug now? :D | 19:59 |
| Mister_Magister | so @abranson we're moving forward with your commit/fix? | 20:01 |
| T42 | <abranson> will have to get someone else to review at some point | 20:01 |
| Mister_Magister | so… is that a yes? should i close my Pr and reverse te commit? | 20:02 |
| T42 | <abranson> yes please. don't make me look at that again. | 20:03 |
| Mister_Magister | xddd ok | 20:03 |
| T42 | <abranson> you owe me one for that | 20:03 |
| Mister_Magister | sure :D | 20:03 |
| Mister_Magister | make sure to make PR to qtwayland though | 20:04 |
| Mister_Magister | I'll try to spend some quality time to fix the video going black, i roughly understand the idea, the context goes out of whack, same happened when i didn't create opengl program on scenegraphInitialized signal | 20:05 |
| Mister_Magister | @abranson I think you're right, I think i went too HAM when i think about it | 23:15 |
| Mister_Magister | i could put more human brain to it | 23:15 |
| Mister_Magister | will keep it in mind for the future | 23:15 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!