| *** amccarthy is now known as Guest16652 | 02:24 | |
| *** amccarthy_ is now known as amccarthy | 02:24 | |
| rinigus | on nagara port, I have logcat infested with messages like "19 I SDM : StcManager::ProcessModeSwAssets():781 Cannot find mode (gamut 1 gamma 1 intent 0) in mode list" | 13:07 |
|---|---|---|
| rinigus | from comparing los21 and sfos logcats, it looks like getColorModes are not requested in sfos. | 13:07 |
| rinigus | also, from grepping libhybris and qt5-qpa-hwcomposer-plugin, I don't see anywhere where setcolormode would be called. also, in hybris, only setColorMode version without intent is available. | 13:07 |
| rinigus | longer description with logs is at https://github.com/sailfishos-sony-nagara/main/issues/14 | 13:07 |
| rinigus | am I missing something or is that part not implemented? | 13:07 |
| mal | I think we might not be supporting wide color ranges properly | 13:15 |
| mal | rinigus: where is that setColorMode in android side? | 13:16 |
| rinigus | mal: in surfaceflinger | 13:22 |
| rinigus | mal: for example in HidlComposer::setColorMode | 13:23 |
| rinigus | ... in general, there is a lot of color handling in surfaceflinger. would have to look it through | 13:26 |
| mal | yeah, hwc2 compat layer doesn't have setColorMode at the moment | 13:36 |
| Mister_Magister | what about changing refresh rate | 13:44 |
| mal | is there some issue with framerate? other that sfos not showing high values correctly? | 13:54 |
| rinigus | mal: if I want to hack something which would set solor mode, I should start from https://github.com/mer-hybris/qt5-qpa-hwcomposer-plugin/blob/master/hwcomposer/hwcomposer_backend_v20.cpp#L219 | 14:15 |
| rinigus | and then move where it takes me? libhybris I guess... | 14:15 |
| mal | you would need to add set color mode support to https://github.com/libhybris/libhybris/blob/master/compat/hwc2/hwc2_compatibility_layer.cpp | 14:17 |
| mal | and the header of that | 14:18 |
| mal | hwc2_compat_display_set_color_mode would be needed | 14:18 |
| mal | and maybe get color modes also, not sure | 14:19 |
| rinigus | yes, probably. and getrenderintent as well. but I would have to call those from qpa-hwcomposer, right? | 14:19 |
| mal | yes, afaik | 14:19 |
| rinigus | thanks! will try/test and report back | 14:20 |
| T42 | <NotKit> for hwc2, also check my MR which imported newer Android classes | 14:20 |
| T42 | <NotKit> but as mal said, hwc2_compat_display_set_color_mode need to be added | 14:20 |
| rinigus | @NotKit: yes, I saw that in libhybris repo. the one with aidl support, right? | 14:24 |
| T42 | <TheVancedGamer> yes | 14:27 |
| mal | I should have a look at that PR | 14:30 |
| Mister_Magister | mal: it works but android dynamically lowers it to save battery | 15:00 |
| Mister_Magister | also there is, its in issue tracker | 15:01 |
| Mister_Magister | mal: how about having a look at my timed pr pretty please :P | 15:01 |
| *** deathmist1 is now known as deathmist | 18:48 | |
| T42 | <freesoftwareman> Xiaomi Redmi Note 13 Pro emerald port? | 20:13 |
| T42 | <elros34> @adampigg do you have some pointers why mtp doesn't work on pro1x? | 21:49 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!