| T42 | <Verevka86> Good afternoon, is the fingerprint on the screen still not implemented? | 09:43 |
|---|---|---|
| T42 | <adampigg> It was implemented on one device iirc | 09:55 |
| T42 | <Verevka86> Xiaomi Tucana? unfortunately on versions higher than hybris-10 this no longer works ( | 09:57 |
| Mister_Magister | mal: so about HBM, I've enabled it but it doesn't work. Let me describe. https://github.com/sailfishos/mce/blob/master/modules/display.c#L1887 this gets 255 as an input (when brightness is 65535), and then sends that to here https://github.com/sailfishos/mce/blob/master/modules/display.c#L3705 where it takes first 8 bits as brightness (which is 255 max) and then anything above as HBM so as you gathered already, it never gets | 22:00 |
| Mister_Magister | to be 1 and it only accepts 0/1 values. couldn't find how mdy_datapipe_display_brightness_cb is called but something is very wrong | 22:00 |
| Mister_Magister | ahh max_brightness is from sysfs which says 255 | 22:04 |
| Mister_Magister | perhaps were I to override that it would've worked but thats not ideal | 22:04 |
| Mister_Magister | although to be more precise now i'm seeing that value only goes up to 100 | 22:16 |
| Mister_Magister | hbm_level=0, brightness=100 | 22:17 |
| Mister_Magister | https://github.com/sailfishos/mce/blob/master/modules/display.c#L11726 i suppose this is to blame | 22:22 |
| Mister_Magister | so HBM will never ever be active | 22:22 |
| Mister_Magister | anyway here's PR https://github.com/sailfishos/mce/pull/41 | 22:39 |
| Mister_Magister | long story short, mce is checking hbm so that: if brightness is below 255 its off, if brightess is 256 its on but brightness is 0? if brightness is above 256 then hbm doesn't take input because of too high value? AND THE VALUE IS CAPPED TO 100??!?!?!??!? | 22:51 |
| Mister_Magister | i love when nothing makes sense xd | 22:51 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!