Saturday, 2025-06-14

« Friday, 2025-06-13 Index Sunday, 2025-06-15 »
*** Daaanct12 is now known as Daanct1204:51
T42<adampigg> Rinigus: sure, im away today, feel free to ship09:29
rinigus@adampigg: will do09:29
*** Mister_Magister_ is now known as Mister_Magister10:05
malPSA: anyone building 5.0 adaptations in testing projects on OBS please add sailfishos_5.0 target to your adaptation project, I switched the repos to use major.minor versioning to remove the need to have separate target for each small release13:14
malan example https://build.sailfishos.org/project/show/nemo:testing:hw:fairphone:fp513:14
malso next time someone updates their devices from testing project the adaptation and common repo will change to use that 5.0 target13:15
Mister_Magistermal: what about my mce PR ;-;13:22
Mister_Magistertime to abuse obs13:23
* Mister_Magister opening literally 6 projects13:24
Mister_Magisteralso mal what about 3.4 fix?13:25
Mister_Magisterits been months13:31
Mister_MagisterMight just build the fix you didn't like cause i'd like not to be stuck at 4.6 :P13:32
malwell the fix didn't work on all devices which is the problem13:33
malor if it works on any 3.4 devices13:34
Mister_MagisterI see13:34
Mister_Magisterwell I believe in you <313:34
Mister_MagisterI've tested the mce PR on two phones and it works great13:35
Mister_Magisterit could use some debounce but other than that its great13:35
malthe brightness value changes are something I wonder13:49
Mister_Magisterwhat do you mean?13:50
malisn't new_hbm_level now 1?13:50
Mister_Magistercould you elaborate on what do you mean? out of context i don't know what you mean13:50
malhttps://github.com/sailfishos/mce/pull/41/files#diff-c54a5a546ff09891bf77db63660f655be34e29666b9d646bbd82838d455f538aR357813:51
Mister_Magisternew_hbm_level is 1 when brightness is 100 yes13:51
Mister_Magisterand if its less than maximum brightness its 013:51
malbut before it was something else13:51
Mister_Magisterbefore it was always 013:51
Mister_Magisterwhich is explained in description13:52
Mister_Magistersecond paragraph13:52
Mister_Magisterbefore code made it so that it will never be anything but 013:53
Mister_MagisterI've debugged it through and through i can explain you everything to tiniest detail if need be :D13:57
malsome comments: there is indentation mismatch in line with "MCE_CONF_HBM_CONTROL_PATH, 0);", the comment before that part is for next code block so the new code is in wrong place, I wonder if where the new code for config loading should be because now there is tiny chance of memory leak if that hbm path is configured and it ends up in the condition "ss(DISPLAY_BACKLIGHT_PATH DISPLAY_DISPLAY0, W_OK)14:18
mal== 0)"14:18
malone option would be to have it before display_type_get_from_config call in mdy_display_type_get and adding a null check to that DISPLAY_DISPLAY0 case14:20
Mister_Magistermal: yeah I wasn't sure where to put loading of the config14:22
malor it could be near the end of mdy_display_type_get with maybe check that display_type != DISPLAY_TYPE_NONE14:23
Mister_Magisteralright i'll see about that14:23
rinigusmal: regarding your PSA - I guess this is the corresponding commit: https://github.com/mlehtima/droid-config-fp5/commit/8740bf43f9325d8fb9eadfd236a3b32bd8062af014:23
malrinigus: that is special for fp4 and fp5, those have extra repo hosted on my server14:24
malno need to do anything to droid-config for normal devices14:24
malunless you have some manually added custom repo14:24
malrinigus: this is the change for the normal repos https://github.com/mer-hybris/community-adaptation/pull/614:25
rinigusthanks! I do have custom repos for tama, will have to look into it14:26
malcan you point me to those?14:26
rinigusbut this change makes sense - no need to race for each small change14:26
malyeah, we got annoyed with the amount of targets on community obs, both in common and even more in chum14:27
malthose chum builds take a lot of space from the server14:27
maland also makes chum rebuilds much slower14:28
rinigusmal: having huge chum is, in principle, sign that it works. but trimming it to MajorMinor does make sense14:30
malMister_Magister: if you put it to the end make sure you free the old hbm path14:30
Mister_Magisterthank14:30
malassuming it's set, only that one case sets it14:30
Mister_MagisterI think setting it at the top makes most sense14:31
malwell the it would try to load the config even if there is no display, doesn't matter much14:32
Mister_Magisteryeah we don't really need display to load config14:32
malbut the config would be useless anyway14:33
Mister_Magisterbut it causes no harm :P14:42
Mister_Magistermal: https://paste.opensuse.org/c77b8e7087ba is that okay?23:12
*** Mister_Magister_ is now known as Mister_Magister23:31
malseems reasonable23:31
Mister_Magisteroki23:33
malMister_Magister: a small style comment, check the formatting of if statements in other parts, your code doesn't match23:33
mallooks like you have "if (something)" when code in mce uses "if( something )"23:33
Mister_Magisteroh because you guys waste the bytes on useless spaces23:34
Mister_Magisteryeah23:34
Mister_Magisterthe wrong kind of formatting23:34
Mister_Magisteri'll chaaaaange iiiit23:34
malit's old nokia legacy and we just keep using it in that project so code is consistent23:34
Mister_Magisteri know i know23:35
malI also think that code style is very odd23:35
Mister_Magistermal: the ifs literally above don't follow it either xd23:35
malit seems some do and some don't23:36
Mister_Magisterhttps://github.com/sailfishos/mce/pull/41/files#diff-c54a5a546ff09891bf77db63660f655be34e29666b9d646bbd82838d455f538aR553423:36
Mister_Magisterif does, else doesn't23:36
malI have been considering removing those old legacy platform things from mce23:37
Mister_Magisterpushed the changes23:37
Mister_Magisteroh shiet23:37
Mister_Magisternow we good23:38
malwondering if that if( display_type == DISPLAY_TYPE_DISPLAY0 ) is good, it does work but would it be cleaner to just check if mdy_high_brightness_mode_output.path is non-null23:38
Mister_Magistermdy_high_brightness_mode_output.path == NULL or nullptr?23:39
Mister_Magisterit doesn't seem to be initialized23:39
Mister_Magisterso I don't think you can check if its null23:39
malpretty sure it has to be null, otherwise g_free((void*)mdy_high_brightness_mode_output.path); which is done always would do bad things23:40
Mister_Magisterbut which null23:41
malNULL seems to be used in other parts of the code23:41
Mister_Magisteraight23:41
Mister_Magisterpushed, now i'll rebuild it and check23:42
Mister_Magisterbtw are there any docs that need updating?23:42
Mister_Magistermmm don't think so23:42
malhmm, actually free does work on NULL so the if is useless in a way, no null check here either https://github.com/sailfishos/mce/blob/master/modules/display.c#L1240023:43
Mister_Magisterokay i broke something cause it doesn't build xd23:43
Mister_Magisterahh23:44
malif you need to fix something remove that null check23:44
Mister_Magisteri did23:45
Mister_Magisterdon't you worry23:45
Mister_Magisteri needed to move the hbmdir variable23:45
Mister_Magisteraand it built23:45
malwell hbmdir could be in the if also, some examples in the code elsewhere with variable inside if23:46
malsince it's only used there anyway23:47
Mister_Magisterstill works, didn't destroy my phone23:49
malalso I think you don't release the hbmdir variable, check in mdy_display_type_get_from_config what is done to the return value of mce_conf_get_string_list23:49
malg_strfreev seems to be used23:49
Mister_Magisteryou're entirely correct23:50
Mister_Magisterfixed now23:51
Mister_Magisterstill works23:52
Mister_MagisterI guess I can add instructions to hadk faq after it gets merged23:53
Mister_Magisterif it gets merged*23:53
malsorry to nitpick but that is a bit ugly to have gchar **hbmdir = 0; and the on next line set a new value when it could be just one line, remember to fix indentation of next line when you have that23:53
Mister_Magisterand btw link to hadk faq is still broken23:53
Mister_Magistermal: thought it was more according to the code style23:54
malhttps://github.com/sailfishos/mce/blob/master/modules/display.c#L5292 just an example23:54
Mister_Magisterye ye i know23:54
Mister_MagisterI'm like professional or something xd23:54
maland I'm always complaining about style :)23:55
malwell in this case also a bit more than just style23:56
Mister_Magisteras long as it gets merged ill suffer through nitpicking :P23:56
malwondering why those links are broken23:57
malit's not like the content is anything bad23:57
Mister_Magistermaybe use google's shortener23:58
Mister_Magistermost of those shorteners used are blocked by adblockers/malware blockers anyway23:59
malalso that always-grep-irc-logs is broken, wondering where it pointed23:59
Mister_Magisterhttps://piggz.co.uk/sailfishos-porters-archive/23:59
« Friday, 2025-06-13 Index Sunday, 2025-06-15 »

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!