Mister_Magister | you guys talking about 3G 4G motivated me to finally debug ofono so pardon as i'm gonna be talking a lot here today :D | 12:46 |
---|---|---|
Mister_Magister | https://paste.opensuse.org/pastes/8c7af4eeb430 this backtrace is oh so useful xd | 13:00 |
T42 | <adampigg> saifish-ofono isnt really ofono anymore :) | 13:05 |
Mister_Magister | hm? | 13:06 |
Mister_Magister | ah great, you open one file and the error is at the line 1978. When your lines resemble years, you should rethink your decisions | 13:27 |
T42 | <adampigg> i mean, upstream has diverged quite somewhat at this point | 13:52 |
Mister_Magister | i'm not sure how that does help me | 13:52 |
T42 | <morciatka> wasn't there a community effort once to bring it back to upstream level? | 13:53 |
T42 | <adampigg> yeah, that was me :) | 13:53 |
T42 | <morciatka> oh, I remember reading the posts until... they didn't happen anymore :// | 13:53 |
Mister_Magister | it wouldn't be sailfishos if it wasn't outdated | 13:54 |
mal | Mister_Magister: no debug symbols for ofono-binder-plugin? maybe build it on community obs and install from there if the debug symbols are missing from official repo | 14:03 |
Mister_Magister | mal: I fixed it already don't you worry i'm not that dumb :P | 14:03 |
mal | Mister_Magister: does your device use hidl or aidl in ofono-binder-plugin? | 14:04 |
Mister_Magister | no idea | 14:04 |
Mister_Magister | up till now it was using ril-binder-plugin | 14:04 |
mal | is that some old device? | 14:04 |
Mister_Magister | oneplus 6 | 14:05 |
mal | which android base? | 14:05 |
Mister_Magister | lineage 16 | 14:05 |
Mister_Magister | so android 9 i imagine | 14:06 |
Mister_Magister | it does this weird thing where it goes into infinite loop and then crashes because i think it allocates too much memory | 14:06 |
Mister_Magister | but only if i select sim to use for mobile data | 14:07 |
Mister_Magister | and well the crash is in binder_data lol | 14:08 |
mal | just to be sure, check binder-list for radio interfaces | 14:08 |
mal | I might have an idea but need the info from binder-list | 14:09 |
Mister_Magister | i'm not sure what you mean so here's output of binder-list https://paste.opensuse.org/pastes/1963a2187e24 | 14:11 |
Mister_Magister | maybe i am dumb after all | 14:11 |
mal | yep, just as I suspected, you have only android.hardware.radio.config@1.0::IRadioConfig which is not really working in ofono-binder-plugin, you should revert back to the ril binder plugin | 14:12 |
mal | 1.1 is really needed in ofono-binder-plugin at the moment | 14:12 |
mal | I tried to figure out how to fix 1.0 but didn't manage to do it yet | 14:13 |
Mister_Magister | but i don't want to revert back to ril-binder-plugin i want volte | 14:13 |
Mister_Magister | so its time to figure out 1.0 in binder plugin | 14:13 |
Mister_Magister | mal: no offence but i'm currently waiting for so many fixes that waiting really doesn't get me anywhere | 14:17 |
mal | that one binder call in binder data code fails which then causes new attempt and when it always fails it goes to endless loop | 14:17 |
Mister_Magister | okay | 14:18 |
Mister_Magister | if i spend enouguh time in gdb surely i'll figure something out | 14:21 |
mal | afaik binder_data_set_preferred_data_modem_submit only works with 1.1 | 14:23 |
mal | https://android.googlesource.com/platform/hardware/interfaces/+/refs/heads/main/radio/config/1.1/IRadioConfig.hal#48 | 14:23 |
mal | vs https://android.googlesource.com/platform/hardware/interfaces/+/refs/heads/main/radio/config/1.0/IRadioConfig.hal which doesn't have that | 14:23 |
mal | not sure yet how to handle preferred data modem on 1.0 | 14:24 |
mal | or should we just skip it | 14:24 |
Mister_Magister | but wait thats in case its dual sim right? what if I just ignore second sim slot for now? | 14:24 |
Mister_Magister | if we cannot set prefered modem lets just not set it xd | 14:29 |
Mister_Magister | monke brain | 14:29 |
mal | I checked android code, it just skips the call if it's not supported | 14:29 |
Mister_Magister | so I shall do the same | 14:30 |
Mister_Magister | i just need to figure out how | 14:30 |
mal | make the code in that conditional with the first two from this https://github.com/mer-hybris/ofono-binder-plugin/blob/master/src/binder_data.c#L2776 | 14:34 |
mal | i.e. check for hidl and interface >= 1.1 | 14:34 |
mal | you should be able to figure out the rest | 14:34 |
Mister_Magister | yeap thanks that's all i needed | 14:35 |
Mister_Magister | my how are you so good at this | 14:35 |
Mister_Magister | i suck xd | 14:35 |
mal | well if I have added all of the recent interfaces to ofono binder code so I might have learned a thing or two | 14:36 |
Mister_Magister | :D | 14:36 |
Mister_Magister | i'm just lowly web developer | 14:36 |
Mister_Magister | man any employer gonna be confused as heck when they check my github expecting webdev and they find some weird android binder stuff xd | 14:39 |
Mister_Magister | nice it built first try | 14:41 |
Mister_Magister | nice that worked i have now 4G connectivity | 14:43 |
Mister_Magister | volte doesn't seem to be doing much of anything, yes i have qti.conf | 14:44 |
T42 | <PandoraTrillion> Which device are you working on? (re @SailfishFreenodeIRCBridgeBot: <Mister_Magister>vol...) | 14:47 |
Mister_Magister | op6 | 14:47 |
T42 | <PandoraTrillion> Okay, good work. (re @SailfishFreenodeIRCBridgeBot: <Mister_Magister>op6) | 14:48 |
Mister_Magister | mal: i'll make PR in a sec | 14:48 |
T42 | <PandoraTrillion> What is PR? (re @SailfishFreenodeIRCBridgeBot: <Mister_Magister>mal...) | 14:48 |
Mister_Magister | pull request | 14:48 |
T42 | <PandoraTrillion> Okay (re @SailfishFreenodeIRCBridgeBot: <Mister_Magister>pul...) | 14:49 |
T42 | <TheVancedGamer> you know you could google some of this terminology | 14:49 |
Mister_Magister | and please don't use respond feature that much | 14:49 |
Mister_Magister | it's completely unnecessary | 14:49 |
Mister_Magister | hmm i'm not sure its using qti_ext as i can't seem to find any mention in the logs | 14:54 |
Mister_Magister | though "Adding "qti" plugin" that seems to be it | 14:55 |
Mister_Magister | https://paste.opensuse.org/pastes/524cb8cef4ca seems promising | 14:56 |
Mister_Magister | oh wait i forgot this sim is data only hold on xd | 14:59 |
Mister_Magister | hmm it seems to just error out for no reason ims:imsradio0: QtiRadioRegInfo state:1 radiotech:15 error_code:0 | 15:02 |
mal | state 1 is not registered afaik | 15:07 |
Mister_Magister | thats what gui says | 15:08 |
Mister_Magister | im not sure what that means | 15:08 |
Mister_Magister | like the sim is on the network and stuff | 15:11 |
Mister_Magister | though it doesn't dispaly network in the ui | 15:11 |
Mister_Magister | hmm when i manually searched networks and I click one to register, it throws error | 15:12 |
Mister_Magister | registration failed, error INVALID_ARGUMENTS | 15:12 |
Mister_Magister | but if i leave it automatic it is registered | 15:13 |
Mister_Magister | so im not sure why qti plugin says not registered when it is | 15:14 |
Mister_Magister | in the binder code it does append string so i'm not sure why would it return invalid argument | 15:17 |
Mister_Magister | its acutally quite funny cause we set network manually with x parameter then it fails and proceeds to register this network automatically | 15:20 |
mal | don't confure volte registration and network registration | 15:21 |
Mister_Magister | yeah i'm not sure whats the volte registration | 15:21 |
Mister_Magister | like what does that mean | 15:22 |
Mister_Magister | but its still weird that you cannot select network manually, but anyway | 15:22 |
Mister_Magister | mal: do you want output or too busy? | 15:26 |
Mister_Magister | i'm actually not sure how much of that output is safe for public | 15:27 |
mal | you might see phone numbers and imei in the logs in some cases maybe | 15:29 |
Mister_Magister | my car radio does register as volte so the sim itself should be working | 15:29 |
Mister_Magister | unless operator doesn't like my phone? | 15:30 |
Mister_Magister | any clues? | 15:30 |
T42 | <exynosnineninety> mister_magister: my operator has a whitelist, my op7tp was not allowed on there and ims registration failed on it | 15:32 |
T42 | <exynosnineninety> not saying that's in your case, but it's just something to note | 15:32 |
Mister_Magister | but if my random chinese car radio works, how would it be whitelisted | 15:32 |
Mister_Magister | but i'm aware, the op7pro dev had same whitelist issue on sfos | 15:34 |
T42 | <morciatka> my 6T also has no VoLTE here in Slovakia. Checked on carriers, it just works on the 7TP and some other phones | 15:34 |
Mister_Magister | here he is | 15:34 |
T42 | <morciatka> as for Poland, T-Mobile dropped calls last time and Orange switched to 3G | 15:35 |
T42 | <morciatka> granted, I was on roaming. But still | 15:36 |
Mister_Magister | it could be that it doesn't like my phone | 15:36 |
Mister_Magister | i'm not saying no, i just want to know if I can check that | 15:36 |
Mister_Magister | because "not registered" doesn't say much xd | 15:36 |
T42 | <morciatka> the whole IMS situation is a chaos and the fact that qualcomm has some proprietary carrier specific files for modems doesn't spark much confidence | 15:36 |
Mister_Magister | mal: https://github.com/mer-hybris/ofono-binder-plugin/pull/46 | 15:37 |
mal | More accurate would be "Fix IRadioConfig 1.0 support" also a style nitpick, the line (binder_data_set_preferred_data_modem_new(data)); has 4 spaces too many indentation :) | 15:40 |
mal | the indentation is 4 relative to the previous line | 15:41 |
Mister_Magister | yes master | 15:42 |
Mister_Magister | it is done | 15:42 |
T42 | <TheVancedGamer> btw mal did you get to fix the USB issue on FP5? :D | 15:42 |
mal | hmm, forgot which one | 15:44 |
T42 | <TheVancedGamer> the SDP issue | 15:45 |
T42 | <TheVancedGamer> the PR got merged | 15:45 |
mal | forgot to add the fix to my fp5 port | 15:46 |
T42 | <TheVancedGamer> now you can :D | 15:47 |
mal | I have been debugging various issues on fp6 and other things also | 15:47 |
Mister_Magister | mal: any clue how to debug the volte? or is there nothing i can do | 16:01 |
mal | not sure, I'll test that PR on was it x10 or xa2 which had that issue when I tried | 16:06 |
mal | one of the older xperias anyway | 16:06 |
Mister_Magister | i mean it just says unregistered and i don't even know if it tries to register or something | 16:06 |
Mister_Magister | also can I help you debug the 3.4 wpa supplicant issue? | 16:06 |
Mister_Magister | oh, i can go and do the HBM fix | 16:22 |
mal | yes, you can fix the PR | 16:25 |
Mister_Magister | xd | 16:27 |
T42 | <adampigg> anyone got a device where enabling tethering appears to work, but in reality, the interface fails to add to the bridge device? | 16:28 |
T42 | <morciatka> I messed with ECM/NCM instead of RNDIS and that was the thing that was broken for me. Maybe usb-moded related? Maybe related to the.... uhhh.. downstream OnePlus kernel which had weird USB modifications? | 16:30 |
mal | Mister_Magister: you forgot that nitpick in hbm PR, the F_OK vs W_OK | 16:39 |
Mister_Magister | mal: don't worry i'm just debugging | 16:39 |
mal | ok | 16:39 |
Mister_Magister | and i just did that 5s ago locally xd | 16:39 |
mal | :) | 16:39 |
Mister_Magister | yeah with changes reverted HBM doesn't work at all because its limited to a 100 in the code so i'm not sure what spiiroin is on about | 16:45 |
Mister_Magister | i'm pumping max value into light sensor | 16:46 |
Mister_Magister | led_brightness_pipe: execute 100 | 16:47 |
Mister_Magister | okay i put 300 in every single spot i could and it finally worked | 17:20 |
Mister_Magister | i don't get how it works | 17:20 |
*** amccarthy is now known as Guest25062 | 17:26 | |
*** amccarthy_ is now known as amccarthy | 17:26 | |
Mister_Magister | how the hell does this thing work | 17:31 |
Mister_Magister | i don't understand how this thing works at all, it should be turning on HBM and it doesn't | 17:48 |
Mister_Magister | now i'm just causing floating point exceptions | 17:52 |
T42 | <TheVancedGamer> aka divide by zero | 17:53 |
Mister_Magister | and nothing makes goddamn sense | 17:55 |
Mister_Magister | I give up nothing in this code makes sense. I put 256 in every spot? nope, put 200? nope | 18:02 |
Mister_Magister | idk i just asked spiiroin | 18:26 |
T42 | <b100dian> Mister_Magister: mce -v -T -l modules/filter-brightness-als.c:* | 19:29 |
T42 | <b100dian> Should output some values | 19:30 |
Mister_Magister | @b100dian yes and? | 19:30 |
Mister_Magister | the values make no sense | 19:30 |
T42 | <b100dian> aren't the values related to the ones from /etc/mce/20als-defaults.ini ? | 19:30 |
Mister_Magister | no | 19:30 |
Mister_Magister | picking profile 0 slot 20 that in config has 500? nothing | 19:30 |
T42 | <b100dian> I mean my understanding is that Profile0 is the only one that spans up to 2000 | 19:31 |
T42 | <b100dian> and 356 as in 256 + 100 was the value suggested by spiiroin in the PR, wasn't it? | 19:32 |
Mister_Magister | yes | 19:33 |
Mister_Magister | anything higher than 256 should enable HBM | 19:33 |
T42 | <b100dian> hmm I remember it was working when I changed half of the slot 0 to 3xx on sake | 19:39 |
T42 | <b100dian> it was a bit "too soo" hbm so I backed that out now | 19:40 |
Mister_Magister | anyway patch is fixed we just need sample config | 19:50 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!