| rinigus | looks like a known bug: generated KS does not have releaseMajorMinor but lines like repo --name=adaptation-community-xqct54-@RELEASE@ --baseurl=https://repo.sailfishos.org/obs/nemo:/testing:/hw:/sony:/nagara:/latest/sailfishos_latest_@ARCH@/ | 12:32 |
|---|---|---|
| rinigus | was wondering how to work around it (for few hours!) and found out that we just need to forget about generated KS. example: https://github.com/HelloVolla/droid-config-halium-mimir/tree/master/sparse/usr/share/kickstarts | 12:33 |
| rinigus | maybe there is a better solution? apart from KS parsing and sed | 12:34 |
| mal | which community-adaptation package do you have? | 12:49 |
| mal | rinigus: ^ | 12:54 |
| rinigus | mal: sorry for delay. I am using https://github.com/sailfishos-sony-nagara/community-adaptation | 14:15 |
| rinigus | btw, same happens with adaptation-community-common | 14:23 |
| rinigus | and generated ssu feature files are correct | 14:23 |
| mal | rinigus: local builds? | 15:03 |
| mal | check which package you have installed in local target | 15:04 |
| rinigus | mal: no, OBS. | 15:04 |
| rinigus | and local packages are not used by create images script. it pulls generated KS | 15:04 |
| mal | rinigus: I mean local mic build or some other way? | 15:04 |
| rinigus | mal: some other way. while on PC, basically pulling KS from https://build.sailfishos.org/package/binary/nemo:testing:hw:sony:nagara:5.0/droid-config-xqct54?arch=aarch64&filename=droid-config-xqct54-ssu-kickstarts-1%2Bmain.20251106194635.ea31dcd-1.1.1.bso.aarch64.rpm&repository=sailfishos_5.0_aarch64 and then using it to generate image | 15:05 |
| rinigus | persistent link: https://build.sailfishos.org/package/show/nemo:testing:hw:sony:nagara:5.0/droid-config-xqct54 , package ssu-kickstarts | 15:06 |
| mal | well since I have no idea how you really build the image it's difficult to debug | 15:07 |
| rinigus | mal: I have a script that generates image using kickstart file. the issue is not even in the script, but the fact that kickstart file is generated wrong. for some reason, instead of URLs used by me in https://github.com/sailfishos-sony-nagara/community-adaptation/blob/main/adaptation-community.testing.ini.in , they get processed and dumped into KS in a wrong way | 15:12 |
| rinigus | from https://repo.sailfishos.org/obs/nemo:/testing:/hw:/sony:/nagara:/%(releaseMajorMinor)/sailfishos_%(releaseMajorMinor)%(arch)/ I get https://repo.sailfishos.org/obs/nemo:/testing:/hw:/sony:/nagara:/latest/sailfishos_latest@ARCH@/ | 15:13 |
| rinigus | which is a bug either in my config or code generating this KS file | 15:13 |
| rinigus | mal: ^ | 15:13 |
| rinigus | * from https://repo.sailfishos.org/obs/nemo:/testing:/hw:/sony:/nagara:/%(releaseMajorMinor)/sailfishos\_%(releaseMajorMinor)_%(arch)/ I get https://repo.sailfishos.org/obs/nemo:/testing:/hw:/sony:/nagara:/latest/sailfishos\_latest_@ARCH@/ | 15:14 |
| rinigus | (even after editing my message some urls are incorrect, see github and generated ssu-kickstarts for proper urls) | 15:16 |
| mal | rinigus: it seems releaseMajorMinor ends up being latest | 15:18 |
| mal | in the .ks | 15:18 |
| rinigus | mal: exactly! no idea why | 15:18 |
| rinigus | and that seems to be for common as well | 15:19 |
| mal | argh, how dumb are people doing search features, nice when searching for code and search just ignores special characters like @ | 15:32 |
| rinigus | mal: I can try to search as well. unless I messed up configs, I guess it is somewhere in ssu code. | 15:34 |
| mal | I see same for fp5 | 15:34 |
| mal | I have used manual .ks for image builds so didn't notice it before | 15:35 |
| rinigus | I guess its a reason, or one of them, why we use manual KS files. | 15:35 |
| mal | I suspect I know the reason, need to test | 15:37 |
| mal | root cause probably exists in two repos, problem is that one of them is a closed one | 15:40 |
| mal | yeah, quite sure I know why that happens | 15:44 |
| rinigus | mal: ssu-kickstart-configuration-jolla? looks like it is missing releaseMajorMinor in its configs | 15:44 |
| mal | rinigus: yes, 01-kickstart | 15:48 |
| rinigus | mal: maybe also in addition post/60_ssu. there is something extra going on there | 15:49 |
| mal | rinigus: and second part that is missing is replacing what ever variable we set there back to proper variable | 15:49 |
| rinigus | I see. OK, for now then we will sed it away | 15:50 |
| rinigus | until the fix will land on this guarded proprietary code :) | 15:50 |
| mal | I'll fix it in internal repo and make a PR to whatever is doing the replacing the other way | 15:51 |
| rinigus | thanks! | 15:52 |
| mal | I think fix is needed also in mic repo and droid-hal-configs | 15:53 |
| mal | https://github.com/mer-hybris/droid-hal-device/blob/master/helpers/build_packages.sh#L397 needs RELEASEMAJORMINOR or something like that but need to think a bit | 15:53 |
| rinigus | mal: yes, somehow we need to be able to replace it. don't think you need to touch mic as we give a map to it anyway when we start. otherwise it would have to be more clever about some specific var | 15:58 |
| mal | yeah, not sure yet if mic needs changes or not | 16:01 |
| mal | https://github.com/sailfishos/mic/blob/master/mic/utils/misc.py#L210 | 16:01 |
| mal | we still might want some fallback for those majorminor things there | 16:02 |
| mal | but not sure if that is needed | 16:03 |
| rinigus | its probably not critical as nobody noticed earlier and didn't complain loudly. for now, there are workarounds at least | 16:06 |
| mal | internal PR created :) | 16:18 |
| rinigus | nice! | 16:28 |
| mal | rinigus: https://github.com/mer-hybris/droid-hal-device/pull/346 | 16:54 |
| rinigus | 22 PRs in that repo. even mine :) | 16:56 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!