| Mister_Magister | mal: so I asked claude if sharpening and denoising can be disabled on camera1 api and it litearlly did it in like 8 lines of code, so now I don't even need camera2 api | 01:19 |
|---|---|---|
| Mister_Magister | i thought it was not doable | 01:36 |
| *** n2klb_ is now known as n2klb | 02:01 | |
| T42 | <elros34> @Mister_Magister I have impression this is same as @the_hiktor isse few weeks/monts ago. If you remove selinux policy then these journal socket error might dissappear but that will probably cause other errors. No idea how he fixed it | 02:42 |
| T42 | <Mister_Magister> I fixed it thanks | 02:43 |
| T42 | <elros34> how? | 02:43 |
| T42 | <Mister_Magister> ^ (re @SailfishFreenodeIRCBridgeBot: <Mister_Magister>som...) | 02:43 |
| T42 | <Mister_Magister> Check miami droid-configs repo | 02:44 |
| T42 | <Mister_Magister> Its 5am i ought eel | 02:44 |
| T42 | <Mister_Magister> Eep | 02:44 |
| T42 | <elros34> "mount -o context=system_u:object_r:tmp_t:s0 userdata.img tmp" in image creation script. ok that could explain, IIRC he also used this custom scripts | 02:48 |
| mal | Mister_Magister: I thought it was not possible, can you show what would be needed | 10:33 |
| T42 | <b100dian> Yeah, I remember searching for sharpening and noise controls in camera1 too. Are there any? | 11:18 |
| Mister_Magister | mal: basically camera1 on new enough android goes through camera2 to camera1 converter and you can change the parameters in that converter | 13:45 |
| Mister_Magister | mal: in here https://github.com/LineageOS/android_frameworks_av/blob/lineage-23.2/services/camera/libcameraservice/api1/client2/Parameters.cpp#L2418 it added this https://paste.opensuse.org/pastes/52f1f4c097dc | 13:47 |
| Mister_Magister | it's not universal fix cause it needs said converter so like android 10+ | 13:48 |
| Mister_Magister | but maybe i'll bother claude to figure it out for older ports, my op6 is android 9 | 13:49 |
| Mister_Magister | but the difference in quality is night and day | 13:49 |
| mal | yeah, I did some testing with android apps on jolla phone and the noise reduction affected a lot, edge mode also but not as bad effect | 14:14 |
| mal | Mister_Magister: good way to test the effect is to take a picture of a tree with leaves | 14:19 |
| Mister_Magister | so you're now believer in no sharpening and denoising by default | 14:20 |
| mal | well it seems to be different per device | 14:20 |
| T42 | <abranson> tbh all cmos cameras need a bit of that in the firmware because they're not very good. but it's got to be done properly. | 14:28 |
| Mister_Magister | trust me 99% cameras are better off with those two disabled | 14:30 |
| Mister_Magister | that's what my camera guru said | 14:30 |
| T42 | <b100dian> "basically camera1 on new enough android goes through camera2 to camera1 converter" | 14:58 |
| T42 | <b100dian> somehow I knew that | 14:58 |
| T42 | <b100dian> but never crossed my mind to change the sources | 14:58 |
| T42 | <b100dian> like adding it as a patch and be done | 14:58 |
| T42 | <NotKit> I don't know if it goes through converter on newer MTKs, but it can be changed in HAL for Jolla Phone as well | 14:59 |
| T42 | <NotKit> though I did see some weird artifacts in viewfinder with edge sharpening turned off | 15:00 |
| T42 | <b100dian> jp2 really removes details, not only noise. Sake was sharpening like crazy. Should try this when updating to 5.2 ;) | 15:01 |
| T42 | <K31j0> Why does the polish pope remove details (re @b100dian: jp2 really removes d...) | 15:02 |
| T42 | <K31j0> Oh sorry this is no Michał's group shouldn't be joking | 15:02 |
| T42 | <K31j0> Excuse me | 15:02 |
| T42 | <b100dian> root cause may be polish though:) | 15:04 |
| T42 | <abranson> first time i've heard that. might have to start calling it the polish pope | 15:09 |
| T42 | <Mister_Magister> jp2 is acronym for John Paul 2 not for jolla phone 2 sorry | 15:16 |
| *** Mister_Magister_ is now known as Mister_Magister | 15:16 | |
| T42 | <K31j0> It's not yellow enough (re @abranson: first time i've hear...) | 15:22 |
| T42 | <abranson> why-not-both.gif | 15:22 |
| T42 | <Mister_Magister> because SEO gets confusing and annoying with both | 15:23 |
| T42 | <Mister_Magister> like D programming language, try to find anything | 15:24 |
| T42 | <Mister_Magister> to find anything using jp2 you'll have to write jp2 phone | 15:24 |
| T42 | <Mister_Magister> https://jambophone.xyz/products/jp2 JAMBO PHONE | 15:24 |
| T42 | <abranson> i guess i'm not catholic enough to understand | 15:24 |
| T42 | <Mister_Magister> long story short its taken | 15:24 |
| T42 | <Mister_Magister> so its better to use jp26 | 15:25 |
| T42 | <abranson> yeah. it's never actually been called the 'jolla phone 2' | 15:25 |
| mal | yeah, jp2 is wrong in every way, jp is more accurate | 15:52 |
| mal | jp2601 is the internal codename, nothing to do with 2 | 15:53 |
| T42 | <abranson> the only really correct way to refer to it is JOLLA PHONE (2026) in all caps. | 15:59 |
| T42 | <abranson> but i just call it 'the deck' now | 16:00 |
| T42 | <TheVancedGamer> jolly phone is better | 16:36 |
| T42 | <Mister_Magister> jp26 broskis | 16:49 |
| Mister_Magister | mal: aaand claude also fixed wide angle camera that was not present on camera1 api for me. Say what you want about LLMs but they're freakishly useful little buggers xd | 18:40 |
| mal | what was the reason for that? | 18:50 |
| Mister_Magister | hold | 18:51 |
| Mister_Magister | mal: don't be insulted by llm response but https://paste.opensuse.org/pastes/3ea93fc2e2e5 | 18:54 |
| Mister_Magister | yo mister @b100dian if you apply same fix for disabling denoising and sharpening on mi note 10, according to my guy you'll have best camera on any sfos device currently ported | 18:55 |
| Mister_Magister | If that entices you contact me for further information xd | 18:55 |
| T42 | <b100dian> Your buddy should get a Mi Note 10 Pro, port should work ;) | 18:56 |
| T42 | <b100dian> but yes, that's also too denoised, but not in JOLLA PHONE (2026) TM league:) | 18:57 |
| Mister_Magister | @b100dian i can explain you the patches if you interested | 18:59 |
| Mister_Magister | https://paste.opensuse.org/pastes/18d4df7cddbe | 19:00 |
| T42 | <b100dian> first, I'd like to know if your friend got the device and really needs it, or it is just because I bragged on portslists about 1/1.33" sensor ;) | 19:00 |
| T42 | <b100dian> (really needs the patches) | 19:00 |
| Mister_Magister | no he doesn't, but don't you want to improve camera for users? | 19:01 |
| T42 | <b100dian> Nobody complained:) But I shall test that, thanks for the diff, and if it is unlocking some real difference, of course. Otherwise, the camera1 defaults on tucana look fine-ish | 19:02 |
| Mister_Magister | ofc nobody will complain because they don't even know they're missing out | 19:03 |
| Mister_Magister | @b100dian it will be night and day | 19:03 |
| Mister_Magister | ayayay it messed up viewfinder on op6 | 19:07 |
| Mister_Magister | but its fine when taking pictures so ill just apply it when its taking picture xd | 19:08 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!