| *** n2klb_ is now known as n2klb | 01:59 | |
| Mister_Magister | mal: so what do you think about LLM's fix for gst-droid issue? https://github.com/Michal-Szczepaniak/gst-droid/commit/e490867bbc7981d1f163fbba6e4042c9003d4e67 https://github.com/Michal-Szczepaniak/droidmedia/commit/81db5a7b2a50083f70f1249d99b9c1a735ff4114 | 09:44 |
|---|---|---|
| Mister_Magister | looks clean to my eye | 09:44 |
| T42 | <abranson> does it work? | 09:58 |
| Mister_Magister | That's wonderful question! | 10:00 |
| Mister_Magister | Does master gst-droid and droidmedia work on sfos 5.1? | 10:00 |
| T42 | <abranson> no idea, but that looks like it'll cherry pick onto earlier | 10:00 |
| Mister_Magister | aigh i'll get on it soon, and yes I know i should test before making PR, i'm just excited okay | 10:01 |
| T42 | <abranson> yeah it looks good | 10:09 |
| T42 | <abranson> which llm did that? | 10:09 |
| Mister_Magister | claude | 10:21 |
| Mister_Magister | looks simple enough :P And with that + enabling qmlglsink and we'll finally have legit video player on sfos | 10:21 |
| T42 | <adampigg> i see a stack of new apps on openrepos using claude .. i hope they just dont turn into abandonware | 10:33 |
| T42 | <abranson> will qmlglsink work with the droid video streams? | 10:40 |
| Mister_Magister | @abranson with the fix yessir thats why i love it | 11:04 |
| Mister_Magister | i can use gst-droid AND apply filters over output because qmlglsink forces gst-droid to convert it back from droidmedia format to normal format | 11:05 |
| Mister_Magister | thats why that bug was unearthed in the first place, nothing in sfos uses that part of code | 11:05 |
| T42 | <abranson> i thought the whole reason why we had droideglsink was because it needed special handling | 11:05 |
| Mister_Magister | I already tested it and gstreamer can now render subtitles over droidmedia output | 11:05 |
| T42 | <abranson> well that sounds good | 11:05 |
| Mister_Magister | @abranson nope! droidmedia has conversion inbuilt | 11:05 |
| Mister_Magister | https://github.com/sailfishos/droidmedia/blob/master/droidmediaconvert.cpp | 11:06 |
| Mister_Magister | droid_media_convert_to_i420 | 11:06 |
| T42 | <abranson> ah right. the old browser conversion | 11:06 |
| Mister_Magister | and i won't have to use my overcomplicated gstdroid sink and can just slap qmlglsink simplifying apps wanting to use gstdroid pipeline A TON | 11:06 |
| Mister_Magister | and as i said already it unlocks subtitles in video players | 11:07 |
| Mister_Magister | even graphic ones | 11:07 |
| Mister_Magister | and i can use same sink for software and hardware decoding | 11:07 |
| Mister_Magister | and then it just becomes case of missing codecs but community can take care of it wink wink | 11:07 |
| T42 | <abranson> but that requires the i420 conversion blob. the browser thing has a manual one for when that's not present. i think some xperias don't have it | 11:07 |
| Mister_Magister | what do you mean? | 11:07 |
| T42 | <abranson> i'll find it | 11:08 |
| T42 | <abranson> that thing is a hybris wrapper: https://github.com/sailfishos/droidmedia/blob/master/droidmediaconvert.cpp#L55 | 11:09 |
| T42 | <abranson> it depends on that libI420colorconvert.so being present. that's supposed to be able to convert from whatever the native format is to I420, so the native format could be custom or even completely opaque and you can still get buffers. | 11:09 |
| Mister_Magister | i think it's not being present on my device and works anyway | 11:10 |
| Mister_Magister | so maybe it doesn't use the droid_media_convert_to_i420 | 11:10 |
| Mister_Magister | https://github.com/sailfishos/gst-droid/blob/master/gst/droidcodec/gstdroidvdec.c#L868 | 11:11 |
| Mister_Magister | so it might simply be not using it | 11:12 |
| Mister_Magister | yeah | 11:13 |
| Mister_Magister | it's the else if | 11:13 |
| Mister_Magister | because it goes into gst_droidvdec_convert_yuv420_semi_planar_to_i420 | 11:13 |
| Mister_Magister | so if that so is available it uses it otherwise it has bunch of conversions inbuilt is what I'm getting | 11:14 |
| Mister_Magister | and those conversions is code that probably nothing in sfos reaches currently | 11:14 |
| Mister_Magister | correctmeifimwrong | 11:15 |
| T42 | <abranson> aha maybe that's where it ended up! it's been a while... | 11:15 |
| Mister_Magister | I think qmlglsink is insanely big deal and should be prioritized but that's just my effort :P I hope the PRs get merged as well as qmlglsink enabled then i can swap my apps to qmlglsink and have massive improvement and we can finally watch anime with subtitles | 11:16 |
| Mister_Magister | And I won't have to learn japanese | 11:16 |
| T42 | <abranson> yep I think this is the enabling commit: https://github.com/sailfishos/gst-droid/commit/8131c6d7ba68d0f1f23748a87f6fa64ab8a66f5b | 11:17 |
| Mister_Magister | also things like movie rips will be playable with subtitles because graphic subtitles will also work | 11:17 |
| T42 | <abranson> have you done a PR for the qmlglsink too? | 11:17 |
| Mister_Magister | nah not yet | 11:18 |
| Mister_Magister | i need to make PRs to gst-plugins-base and -good | 11:18 |
| Mister_Magister | because wayland stuff is broken too | 11:18 |
| Mister_Magister | I'll rebase it on top of master and make PR | 11:19 |
| Mister_Magister | https://github.com/sailfishos/gst-plugins-base/pull/14 that's one | 11:26 |
| Mister_Magister | and that's second https://github.com/sailfishos/gst-plugins-good/pull/13 | 11:28 |
| Mister_Magister | the gst-plugins-base/good are tested changes | 11:29 |
| Mister_Magister | now I just need y'all to merge all 4 and deploy onto sfos 5.1 pretty please :D | 11:29 |
| T42 | <abranson> well it won't make 5.2 now, but I'll get round to reviewing those. | 11:35 |
| Mister_Magister | thank you <3 I'm currently gonna build the droidmedia, not sure which droidmedia version i need for 5.1 but if master won't work then i'll worry | 11:36 |
| T42 | <abranson> looks like 0.20260522.0 is the 5.1 release version of droidmedia | 11:49 |
| Mister_Magister | thank you | 11:52 |
| Mister_Magister | @abranson uhh a hand please? https://paste.opensuse.org/pastes/66aa36a20d82 | 12:29 |
| Mister_Magister | oh | 12:44 |
| Mister_Magister | oh i need android 15 branch | 12:44 |
| Mister_Magister | hmm i think i'm lacking droidmedia-devel now | 13:09 |
| Mister_Magister | yep built nicely | 13:14 |
| Mister_Magister | dang i can't test it until i upgrade to 5.1 because i built it on 5.1 to not disturb 5.0 users xd | 13:19 |
| Mister_Magister | lemme finish work and imma do it | 13:19 |
| T42 | <adampigg> youre not on 5.2 already?? | 13:21 |
| Mister_Magister | 5.2 is not released??? | 13:22 |
| mal | I probably should have merged the android 15 branch | 13:22 |
| Mister_Magister | you probably should | 13:22 |
| T42 | <adampigg> 5.2 is in public repos and on OBS, just not official for anything other than jp2 | 13:24 |
| Mister_Magister | shush | 13:25 |
| T42 | <adampigg> i dont think its secret | 13:26 |
| Mister_Magister | no just don't let anybody know because i can't be bothered | 13:27 |
| Mister_Magister | also i still haven't updated all ports to 5.1 because it took me long time to get g2/x2 running and seniors get seniority priority | 13:27 |
| Mister_Magister | @abranson mal i updated to 5.1 and some videos are playing but normal ones like camera recording are not and i'm not quite sure if it is my patches or android15 branch being outdated for sfos 5.1 | 15:22 |
| Mister_Magister | like you hit play and it just hangs | 15:23 |
| mal | which device? | 15:28 |
| mal | which android base? | 15:28 |
| Mister_Magister | since i'm using android15 branch its android15 | 15:28 |
| Mister_Magister | miami, motorola edge 30 neo | 15:28 |
| mal | anything in logs? journal or logcat | 15:29 |
| Mister_Magister | here's gst-debug https://paste.opensuse.org/pastes/d3aeb5a694ce | 15:31 |
| mal | which gst-droid version are you using? | 15:31 |
| Mister_Magister | like i said, android15 branch | 15:31 |
| mal | that is droidmedia | 15:32 |
| Mister_Magister | ah sorry thats droidmedia | 15:32 |
| Mister_Magister | I'm using the PR branch, so master | 15:32 |
| Mister_Magister | here's journal https://paste.opensuse.org/pastes/53f30f7d1c83 | 15:33 |
| Mister_Magister | "module-alsa-card.c: Failed to find a working profile." does'nt sound fun | 15:33 |
| Mister_Magister | @abranson i'm not quite sure what do you mean in the PR commit | 15:34 |
| mal | do you use udev module in pulseaudio? is the udev rule correct? | 15:34 |
| Mister_Magister | I don't have the udev rule on this device | 15:35 |
| Mister_Magister | it was working fine without it | 15:35 |
| Mister_Magister | i can add it for testing | 15:35 |
| mal | but do you have the udev module loaded? | 15:35 |
| mal | https://github.com/mlehtima/droid-config-fp5/blob/master/sparse/etc/pulse/arm_droid_card_custom.pa#L2 that one | 15:36 |
| Mister_Magister | ye https://github.com/VerdandiTeam/droid-config-miami/blob/master/sparse/etc/pulse/arm_droid_card_custom.pa | 15:36 |
| mal | udeb rule is only needed if that module is loaded | 15:36 |
| mal | *udev | 15:37 |
| Mister_Magister | ye but what i'm saying is that audio and usb audio has been workign fine without the udev rule :P | 15:37 |
| mal | well it might be causing that error you mention | 15:37 |
| Mister_Magister | well i added the udev rule but video is still not playing | 15:38 |
| mal | that was not relevant for video | 15:38 |
| Mister_Magister | ah xd | 15:38 |
| mal | gst-droid has some codec reconfiguration changes which I think require changes from other repos | 15:38 |
| Mister_Magister | https://paste.opensuse.org/pastes/48ed8141a3e2 | 15:39 |
| mal | maybe try with gst-droid 0.20251025.0 with your commit on top | 15:39 |
| Mister_Magister | sure thing boss | 15:39 |
| T42 | <abranson> that's for the adaptive streaming! | 15:40 |
| mal | @abranson but wasn't it so that it needs changes in other packages also and might be causing issues otherwise? | 15:40 |
| Mister_Magister | building the gst-droid | 15:41 |
| T42 | <abranson> just those two I think. aren't they the only adaptation ones? | 15:41 |
| Mister_Magister | mal: that fixed it, thanks for assistance! | 15:42 |
| Mister_Magister | so @abranson the PRs are definitely not breaking anything | 15:43 |
| Mister_Magister | now i'll check if they're fixing the issue | 15:43 |
| Mister_Magister | @abranson what do you mean by the "MIN (version, 4)'"? | 15:43 |
| mal | @abranson the other adaptive playback changes are only in 5.2 | 15:44 |
| T42 | <abranson> i mean rather than the 3, you've got an argument there stating exactly what the current compositor supports. so you can get it to choose that or 4, whichever is lower | 15:44 |
| Mister_Magister | wait for real? | 15:45 |
| T42 | <abranson> seemed to me. might be upstreamable then too. | 15:45 |
| Mister_Magister | ooh the scary word | 15:46 |
| Mister_Magister | wish those proceses would be quite faster ;-; | 15:46 |
| Mister_Magister | it will be months before those changes will land in sfos if not longer ;-; | 15:47 |
| *** Ischwitch is now known as Ingvix | 17:06 | |
| Mister_Magister | @abranson applied the change you suggest and its confirmed working | 17:12 |
| Mister_Magister | something is messed up with sensors but ig i just have to rebase sensorfwd | 17:13 |
| Mister_Magister | @abranson also I've now confirmed the fix in droidmedia/gstdroid to be working, there needed to be one change in gst-droid because apparently droidmedia doesn't provide the sizes anyway "When droidmedia doesn't report real stride/slice-height and the padded-alignment guess doesn't fit the actual buffer size, fall back to unpadded exact-dimensions geometry instead of rejecting the frame, since some decoders emit tightly packed | 17:15 |
| Mister_Magister | buffers with no slice padding." | 17:15 |
| T42 | <Mister_Magister> I've now confirmed it working end to end all 4 packages | 17:15 |
| Mister_Magister | there's weird freeze happening when i pause qmlglsink video so i gotta figure out if thats gst-droid or just my app | 18:41 |
| Mister_Magister | Well well well claude apprently figured it out and it's qmlglsink incompatibility with our gst-droid :D "Found it — root cause confirmed. GstQSGMaterial::bind() (in qmlglsink, gstqsgmaterial.cc) calls gst_video_frame_unmap()/gst_video_frame_map() around every single redraw, even when redrawing the exact same still frame while paused. For gst-droid's buffer memory, that map/unmap pair translates directly into droid_media_ | 18:54 |
| Mister_Magister | buffer_lock() / droid_media_buffer_unlock() (gstdroidmediabuffer.c:449 / :467) — real calls into Android's gralloc buffer locking. During active playback this happens every ~8ms with a constantly-cycling fresh buffer and is fine. But when paused and redrawing the same buffer repeatedly (e.g. for the controls-overlay fade animation triggered by your tap), re-locking a buffer whose GPU fence apparently isn't being freshly | 18:54 |
| Mister_Magister | signaled hits a slow path in this device's gralloc/driver — and that's your ~10 second stall, exactly bracketing the gap in every trace." | 18:54 |
| Mister_Magister | I'm fully aware how I'm beginning to sound but i don't understand any of this so cut me some slack plz | 19:10 |
| Mister_Magister | apparently that wasn't it but there is some weird hiccup happening 100% | 19:49 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!