Wednesday, 2026-08-19

*** n2klb_ is now known as n2klb01:59
Mister_Magistermal: so what do you think about LLM's fix for gst-droid issue? https://github.com/Michal-Szczepaniak/gst-droid/commit/e490867bbc7981d1f163fbba6e4042c9003d4e67 https://github.com/Michal-Szczepaniak/droidmedia/commit/81db5a7b2a50083f70f1249d99b9c1a735ff411409:44
Mister_Magisterlooks clean to my eye09:44
T42<abranson> does it work?09:58
Mister_MagisterThat's wonderful question!10:00
Mister_MagisterDoes master gst-droid and droidmedia work on sfos 5.1?10:00
T42<abranson> no idea, but that looks like it'll cherry pick onto earlier10:00
Mister_Magisteraigh i'll get on it soon, and yes I know i should test before making PR, i'm just excited okay10:01
T42<abranson> yeah it looks good10:09
T42<abranson> which llm did that?10:09
Mister_Magisterclaude10:21
Mister_Magisterlooks simple enough :P And with that + enabling qmlglsink and we'll finally have legit video player on sfos10:21
T42<adampigg> i see a stack of new apps on openrepos using claude .. i hope they just dont turn into abandonware10:33
T42<abranson> will qmlglsink work with the droid video streams?10:40
Mister_Magister@abranson with the fix yessir thats why i love it11:04
Mister_Magisteri can use gst-droid AND apply filters over output because qmlglsink forces gst-droid to convert it back from droidmedia format to normal format11:05
Mister_Magisterthats why that bug was unearthed in the first place, nothing in sfos uses that part of code11:05
T42<abranson> i thought the whole reason why we had droideglsink was because it needed special handling11:05
Mister_MagisterI already tested it and gstreamer can now render subtitles over droidmedia output11:05
T42<abranson> well that sounds good11:05
Mister_Magister@abranson nope! droidmedia has conversion inbuilt11:05
Mister_Magisterhttps://github.com/sailfishos/droidmedia/blob/master/droidmediaconvert.cpp11:06
Mister_Magisterdroid_media_convert_to_i42011:06
T42<abranson> ah right. the old browser conversion11:06
Mister_Magisterand i won't have to use my overcomplicated gstdroid sink and can just slap qmlglsink simplifying apps wanting to use gstdroid pipeline A TON11:06
Mister_Magisterand as i said already it unlocks subtitles in video players11:07
Mister_Magistereven graphic ones11:07
Mister_Magisterand i can use same sink for software and hardware decoding11:07
Mister_Magisterand then it just becomes case of missing codecs but community can take care of it wink wink11:07
T42<abranson> but that requires the i420 conversion blob. the browser thing has a manual one for when that's not present. i think some xperias don't have it11:07
Mister_Magisterwhat do you mean?11:07
T42<abranson> i'll find it11:08
T42<abranson> that thing is a hybris wrapper: https://github.com/sailfishos/droidmedia/blob/master/droidmediaconvert.cpp#L5511:09
T42<abranson> it depends on that libI420colorconvert.so being present. that's supposed to be able to convert from whatever the native format is to I420, so the native format could be custom or even completely opaque and you can still get buffers.11:09
Mister_Magisteri think it's not being present on my device and works anyway11:10
Mister_Magisterso maybe it doesn't use the droid_media_convert_to_i42011:10
Mister_Magisterhttps://github.com/sailfishos/gst-droid/blob/master/gst/droidcodec/gstdroidvdec.c#L86811:11
Mister_Magisterso it might simply be not using it11:12
Mister_Magisteryeah11:13
Mister_Magisterit's the else if11:13
Mister_Magisterbecause it goes into gst_droidvdec_convert_yuv420_semi_planar_to_i42011:13
Mister_Magisterso if that so is available it uses it otherwise it has bunch of conversions inbuilt is what I'm getting11:14
Mister_Magisterand those conversions is code that probably nothing in sfos reaches currently11:14
Mister_Magistercorrectmeifimwrong11:15
T42<abranson> aha maybe that's where it ended up! it's been a while...11:15
Mister_MagisterI think qmlglsink is insanely big deal and should be prioritized but that's just my effort :P I hope the PRs get merged as well as qmlglsink enabled then i can swap my apps to qmlglsink and have massive improvement and we can finally watch anime with subtitles11:16
Mister_MagisterAnd I won't have to learn japanese11:16
T42<abranson> yep I think this is the enabling commit: https://github.com/sailfishos/gst-droid/commit/8131c6d7ba68d0f1f23748a87f6fa64ab8a66f5b11:17
Mister_Magisteralso things like movie rips will be playable with subtitles because graphic subtitles will also work11:17
T42<abranson> have you done a PR for the qmlglsink too?11:17
Mister_Magisternah not yet11:18
Mister_Magisteri need to make PRs to gst-plugins-base and -good11:18
Mister_Magisterbecause wayland stuff is broken too11:18
Mister_MagisterI'll rebase it on top of master and make PR11:19
Mister_Magisterhttps://github.com/sailfishos/gst-plugins-base/pull/14 that's one11:26
Mister_Magisterand that's second https://github.com/sailfishos/gst-plugins-good/pull/1311:28
Mister_Magisterthe gst-plugins-base/good are tested changes11:29
Mister_Magisternow I just need y'all to merge all 4 and deploy onto sfos 5.1 pretty please :D11:29
T42<abranson> well it won't make 5.2 now, but I'll get round to reviewing those.11:35
Mister_Magisterthank you <3 I'm currently gonna build the droidmedia, not sure which droidmedia version i need for 5.1 but if master won't work then i'll worry11:36
T42<abranson> looks like 0.20260522.0 is the 5.1 release version of droidmedia11:49
Mister_Magisterthank you11:52
Mister_Magister@abranson uhh a hand please? https://paste.opensuse.org/pastes/66aa36a20d8212:29
Mister_Magisteroh12:44
Mister_Magisteroh i need android 15 branch12:44
Mister_Magisterhmm i think i'm lacking droidmedia-devel now13:09
Mister_Magisteryep built nicely13:14
Mister_Magisterdang i can't test it until i upgrade to 5.1 because i built it on 5.1 to not disturb 5.0 users xd13:19
Mister_Magisterlemme finish work and imma do it13:19
T42<adampigg> youre not on 5.2 already??13:21
Mister_Magister5.2 is not released???13:22
malI probably should have merged the android 15 branch13:22
Mister_Magisteryou probably should13:22
T42<adampigg> 5.2 is in public repos and on OBS, just not official for anything other than jp213:24
Mister_Magistershush13:25
T42<adampigg> i dont think its secret13:26
Mister_Magisterno just don't let anybody know because i can't be bothered13:27
Mister_Magisteralso i still haven't updated all ports to 5.1 because it took me long time to get g2/x2 running  and seniors get seniority priority13:27
Mister_Magister@abranson mal i updated to 5.1 and some videos are playing but normal ones like camera recording are not and i'm not quite sure if it is my patches or android15 branch being outdated for sfos 5.115:22
Mister_Magisterlike you hit play and it just hangs15:23
malwhich device?15:28
malwhich android base?15:28
Mister_Magistersince i'm using android15 branch its android1515:28
Mister_Magistermiami, motorola edge 30 neo15:28
malanything in logs? journal or logcat15:29
Mister_Magisterhere's gst-debug https://paste.opensuse.org/pastes/d3aeb5a694ce15:31
malwhich gst-droid version are you using?15:31
Mister_Magisterlike i said, android15 branch15:31
malthat is droidmedia15:32
Mister_Magisterah sorry thats droidmedia15:32
Mister_MagisterI'm using the PR branch, so master15:32
Mister_Magisterhere's journal https://paste.opensuse.org/pastes/53f30f7d1c8315:33
Mister_Magister"module-alsa-card.c: Failed to find a working profile." does'nt sound fun15:33
Mister_Magister@abranson i'm not quite sure what do you mean in the PR commit15:34
maldo you use udev module in pulseaudio? is the udev rule correct?15:34
Mister_MagisterI don't have the udev rule on this device15:35
Mister_Magisterit was working fine without it15:35
Mister_Magisteri can add it for testing15:35
malbut do you have the udev module loaded?15:35
malhttps://github.com/mlehtima/droid-config-fp5/blob/master/sparse/etc/pulse/arm_droid_card_custom.pa#L2 that one15:36
Mister_Magisterye https://github.com/VerdandiTeam/droid-config-miami/blob/master/sparse/etc/pulse/arm_droid_card_custom.pa15:36
maludeb rule is only needed if that module is loaded15:36
mal*udev15:37
Mister_Magisterye but what i'm saying is that audio and usb audio has been workign fine without the udev rule :P15:37
malwell it might be causing that error you mention15:37
Mister_Magisterwell i added the udev rule but video is still not playing15:38
malthat was not relevant for video15:38
Mister_Magisterah xd15:38
malgst-droid has some codec reconfiguration changes which I think require changes from other repos15:38
Mister_Magisterhttps://paste.opensuse.org/pastes/48ed8141a3e215:39
malmaybe try with gst-droid 0.20251025.0 with your commit on top15:39
Mister_Magistersure thing boss15:39
T42<abranson> that's for the adaptive streaming!15:40
mal@abranson but wasn't it so that it needs changes in other packages also and might be causing issues otherwise?15:40
Mister_Magisterbuilding the gst-droid15:41
T42<abranson> just those two I think. aren't they the only adaptation ones?15:41
Mister_Magistermal: that fixed it, thanks for assistance!15:42
Mister_Magisterso @abranson the PRs are definitely not breaking anything15:43
Mister_Magisternow i'll check if they're fixing the issue15:43
Mister_Magister@abranson what do you mean by the "MIN (version, 4)'"?15:43
mal@abranson the other adaptive playback changes are only in 5.215:44
T42<abranson> i mean rather than the 3, you've got an argument there stating exactly what the current compositor supports. so you can get it to choose that or 4, whichever is lower15:44
Mister_Magisterwait for real?15:45
T42<abranson> seemed to me. might be upstreamable then too.15:45
Mister_Magisterooh the scary word15:46
Mister_Magisterwish those proceses would be quite faster ;-;15:46
Mister_Magisterit will be months before those changes will land in sfos if not longer ;-;15:47
*** Ischwitch is now known as Ingvix17:06
Mister_Magister@abranson applied the change you suggest and its confirmed working17:12
Mister_Magistersomething is messed up with sensors but ig i just have to rebase sensorfwd17:13
Mister_Magister@abranson also I've now confirmed the fix in droidmedia/gstdroid to be working, there needed to be one change in gst-droid because apparently droidmedia doesn't provide the sizes anyway "When droidmedia doesn't report real stride/slice-height and the padded-alignment guess doesn't fit the actual buffer size, fall back to unpadded exact-dimensions geometry instead of rejecting the frame, since some decoders emit tightly packed17:15
Mister_Magisterbuffers with no slice padding."17:15
T42<Mister_Magister> I've now confirmed it working end to end all 4 packages17:15
Mister_Magisterthere's weird freeze happening when i pause qmlglsink video so i gotta figure out if thats gst-droid or just my app18:41
Mister_MagisterWell well well claude apprently figured it out and it's qmlglsink incompatibility with our gst-droid :D "Found it — root cause confirmed. GstQSGMaterial::bind() (in qmlglsink, gstqsgmaterial.cc) calls gst_video_frame_unmap()/gst_video_frame_map() around every single redraw, even when redrawing the exact same still frame while paused. For gst-droid's buffer memory, that map/unmap pair translates directly into droid_media_18:54
Mister_Magisterbuffer_lock() / droid_media_buffer_unlock() (gstdroidmediabuffer.c:449 / :467) — real calls into Android's gralloc buffer locking. During active playback this happens every ~8ms with a constantly-cycling fresh buffer and is fine. But when paused and redrawing the same buffer repeatedly (e.g. for the controls-overlay fade animation triggered by your tap), re-locking a buffer whose GPU fence apparently isn't being freshly18:54
Mister_Magistersignaled hits a slow path in this device's gralloc/driver — and that's your ~10 second stall, exactly bracketing the gap in every trace."18:54
Mister_MagisterI'm fully aware how I'm beginning to sound but i don't understand any of this so cut me some slack plz19:10
Mister_Magisterapparently that wasn't it but there is some weird hiccup happening 100%19:49

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!