vtyhty | Hello | 02:23 |
---|---|---|
vtyhty | Is it still unsupported to install from android 10? | 02:24 |
*** zbenjamin is now known as Guest9307 | 02:49 | |
*** zbenjamin_ is now known as zbenjamin | 02:49 | |
dcaliste | Hello chriadam, I hope you're fine. | 07:47 |
chriadam | hi dcaliste, I'm well thanks. How are you? | 07:47 |
dcaliste | I'm fine also, thanks. | 07:51 |
chriadam | that's good | 07:51 |
chriadam | I haven't managed to progress your caldav PR yet - I have been busy with planning activities and also the QMF stuff unfortunately | 07:51 |
chriadam | let me quickly check if flypig had any comments there, sec | 07:52 |
dcaliste | No problem. | 07:52 |
chriadam | merged, will tag once my smoke-test build succeeds | 07:54 |
dcaliste | Great thank you. There is this one https://git.sailfishos.org/mer-core/buteo-sync-plugin-caldav/merge_requests/77 about trying to solve the problem of calendar color overriding. | 07:55 |
dcaliste | We discussed it three weeks ago I think. | 07:55 |
dcaliste | It's the implementation from our discussion. | 07:56 |
chriadam | thanks very much. I've just created bug for that one. I haven't yet fixed it on google-calendars or exchange side, but will hopefully get a chance to do that early next week | 07:58 |
dcaliste | Ok, thanks also. | 08:00 |
dcaliste | I've seen you created a QmfList to ease the transition in QMF. That's a very good approach in my opinion. | 08:00 |
dcaliste | I'll give a closer look later today or tomorrow and add +1 there. | 08:01 |
chriadam | thanks, no rush on that one. there's still a unit test failure due to something within messageserver5 not working properly | 08:01 |
chriadam | I have been bashing my head against the wall for a couple of days and made no progress unfortunately | 08:02 |
dcaliste | Ah, too bad. Which one is it, I may help if I can ? | 08:02 |
chriadam | the original failure is in tst_QMailStorageAction::test_storageaction_add, but then a later test depends on the result and causes a crash in messageserver5 (well, Q_ASSERT) | 08:04 |
chriadam | can see it by doing: | 08:04 |
chriadam | ./target_wrapper.sh build/tst_qmailstorageaction test_storageaction_add test_storageaction_movetostandardfolder test_storageaction_restoretopreviousfolder | 08:04 |
chriadam | after running in a separate terminal: | 08:05 |
chriadam | gdb --ex=run --args ~/messagingframework/src/tools/messageserver/build/messageserver5 | 08:05 |
chriadam | my current understanding is that void ServiceHandler::addMessages(quint64 action, const QMailMessageMetaDataList &messages) is failing to add the messages for some reason | 08:06 |
chriadam | I got that far yesterday before giving up for the day haha. | 08:06 |
chriadam | but, fwiw, the tst_qmailstorageaction unit test is disabled in Qt CI | 08:06 |
chriadam | so it doesn't block integration. might be better to get the current changes integrated first before tackling that one further... not sure. | 08:07 |
dcaliste | In my opinion, we should have all the transition commit integrated first as soon as possible, so feature patchs like for SMTP... can go in one by one after that. Any way, for real production purposes, we will have to create a giant revert patch for Qt5.6... | 08:08 |
dcaliste | Thank you for the bug description. I'll try to find time to look at it also in the coming days. | 08:09 |
dcaliste | Hopefully with two pairs of eyes we will find the reason for it. | 08:10 |
chriadam | that'd be excellent - thank you very much | 08:10 |
chriadam | were there other PRs which need attention from our side? fyi flypig is on vacation this week, so if there's something he was following up on, I guess it will be next week | 08:11 |
dcaliste | Sure, I wish him great vacation. There is this MR : https://git.sailfishos.org/mer-core/buteo-syncfw/merge_requests/59 about syncing profile enbale bit with account one. | 08:12 |
chriadam | ah that's right | 08:12 |
chriadam | yeah, I mean, I agree with the MR. but I don't trust my eyes alone to review it. I need to poke flypig early next week, and maybe pvuorela or blam will have some time to check also | 08:15 |
chriadam | poked people via a comment on the MR, and will follow up myself early next week | 08:16 |
chriadam | thanks again and sorry for my slowness on that one | 08:16 |
dcaliste | No problem, as I explained to flypig two weeks ago, this is a log shot MR, when we will have logging UI possibilities, to see log appearing for disabled accounts. | 08:18 |
dcaliste | I've seen also that pvuorela is not opposed to the disabling-alarm for calendar MR. I'm going to work on the UI part so and see if it can be done in a pleasant way. | 08:19 |
chriadam | let me check that one, I didn't see | 08:19 |
dcaliste | ^ I mean for a buteo MR *not* to see log for diasbaled accounts. | 08:20 |
dcaliste | About the alarm-disabled MR in mKCal : https://git.sailfishos.org/mer-core/mkcal/merge_requests/54 | 08:20 |
chriadam | checking that one now. unrelated: is this one still valid / should I poke MartinS to review this one: https://bitbucket.org/jolla/ui-jolla-calendar/pull-requests/264 | 08:20 |
chriadam | ah, that mkcal one I remember now. I will try to keep in the loop, but I think pvuorela is the best person to handle that one anyway | 08:22 |
dcaliste | Yep, about jolla-calendar#264 there is no consensus yet, mostly due to how this can be translated in various languages where time, figure and text may not be as simply layout as in English or French (in my case). | 08:24 |
chriadam | ah, I see | 08:24 |
chriadam | would it be helpful for me to poke MartinS again and find out whether he had any thoughts, anyway? | 08:24 |
dcaliste | Well, I still find 10:00-23:59 quite ugly, but I don't want to create translating issues with other languages for something that is just cosmetic. | 08:25 |
chriadam | true, fair point. | 08:28 |
dcaliste | Anyway, thank you chriadam for your help. I'm going to work on the U part of the silence-alarm patch for calendars and try to find time to help you on the QMF bug you found. | 08:30 |
chriadam | sounds great - thanks again for your effort and time and willingness to help | 08:30 |
chriadam | I hope you have a great week! | 08:31 |
dcaliste | Thanks you too. | 08:31 |
*** flx_ is now known as mflux | 08:38 | |
*** frinring_ is now known as frinring | 09:07 | |
*** APTX_ is now known as APTX | 14:01 | |
fridl | When debugging my app in SailfishSDK and only changing Python and QML-Files, is it then necessary to recompile, or is there a faster way to only exchange those files in the emulator/debug device without "compiling"? | 14:49 |
Nico[m] | Well, if you only change qml, qmllivebench works well | 14:50 |
mal | I often test qml changes by editing the files directly on device | 14:54 |
Nico[m] | But for that you need to restart the app ;p | 14:55 |
mal | yes :) | 14:58 |
Nico[m] | livebench allows you to edit stuff live and see changes immediately, which is nice :3 | 14:59 |
fridl | Ok, so i think mal's way could work for me. I'll check it out. The QML Live Bench probably does not run my python code and I want to check the interaction. | 15:05 |
fridl | This "only copy, don't compile" could be a nice feature for the SailfishSDK then ;-P | 15:05 |
*** vilpan is now known as Guest51416 | 15:24 | |
*** Guest51416 is now known as vilpan | 15:40 | |
*** daniel is now known as Guest94347 | 17:44 | |
*** frinring_ is now known as frinring | 23:17 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!