Tuesday, 2021-03-23

*** zbenjamin is now known as Guest5963302:18
*** zbenjamin_ is now known as zbenjamin02:18
*** frinring_ is now known as frinring03:12
*** jrt is now known as Guest6491303:42
*** nyov is now known as Guest9102904:44
*** askolsam_ is now known as askolsam07:42
dcalisteHello chriadam, how was your day ?08:03
chriadamhi dcaliste, could be better - I'm a bit sick at the moment unfortunately08:04
chriadamhow are you?08:04
dcalisteToo bad, I hope you'll recover soon.08:04
chriadamyeah, it's just a head cold.  all good ;-)08:05
chriadamnot sure if you saw, but I had a couple of comments on some QMF PRs08:06
dcalisteYes, I've seen them. I need to address these few points. But I'm a bit concern with the modifications I've done to the Codec part, as pointed out by flypig.08:09
dcalisteQTextStream is UTF8-only in Qt6.08:09
chriadamyes, so output will be utf8, you mean?08:10
dcalisteWe cannot call setCodec() on it anymore for translating on the fly.08:10
dcalisteWhen I migrate this part of the code, I tried to move away all transcoding from qmailmessage and rewrote part of it.08:11
dcalisteBut as flypig pointed out, I may have broken some transcoding code by reading chunk in the middle of an encoded character or things like that.08:13
dcalisteI think, I need to fix this properly before we can proceed further.08:13
chriadamah, interesting.  is that because the MaxCharacters limit might be reached?  thus splitting a multi-byte character?  hrm.08:14
chriadamwhat is the solution?  actually check whether the final chunk is "complete" or not?  will that require validating all of the characters starting from the beginning of the buffer, or is there a simple way to do it from the other end?08:16
dcalisteI've no idea at the moment. It's kind of things I'm not familiar with. For reference, this is this patch : https://codereview.qt-project.org/c/qt-labs/messagingframework/+/31387508:17
chriadamit's not possible to set a codec on the QTextStream in Qt6, is it?  or am I misunderstanding?08:21
chriadamflypig: have you had a chance to think about any possible solutions to that one ^08:21
dcalisteYeh, that's the problem.08:21
flypigI vaguely recall there being some advice in the docs about it. Maybe I can find it, I'll have a look.08:22
dcalisteHello flypig, thanks. I'll try this week myself to go back to this patch and have a new look at it. Your remark, flypig, about the missing charset argument at one place is also relevant. I think I broke something there.08:23
flypigHere's the advice from the Qt6 docs. Looking at the example, it looks like their solution is to use a QTextDecoder.08:25
flypigFrom here: "The approach to use in these situations is to create a QTextDecoder object..."08:26
flypigI'm just scanning quickly, so this may not be appropriate.08:26
chriadamlooks like it should be.  but unless I'm misunderstanding, it means that the string needs to be built up in the while loop, and output after the while loop as finished08:28
chriadamnot a problem, just a slight difference.08:28
flypigI'm not sure whether that's necessarily implied from the example; that wasn't clear to me.08:28
flypigIf it's the case, that wouldn't be ideal.08:28
dcalisteWell, it looks promising. We may send back the partially decoded string into the next QTextStream now that it is UTF-8.08:29
chriadamdepends on what toUnicode(chunk) does in the split multibyte case, I suppose08:29
dcalisteWell, I suppose in that case that it is waiting for the next chunk to deliver the last character.08:30
chriadamah right, does that mean that toUnicode() will return the "complete" part only?08:30
chriadamcool, makes sense08:30
dcalisteI think so.08:30
chriadamwell, excellent.08:30
chriadamthank you flypig08:30
dcalisteYeh, it's explained in the toUnicode() doc of QTextDecoder.08:31
chriadamflypig: also, if you get a chance, can you take a quick look at my QMF PRs again - I updated according to your comments (or explained why I didn't) for all of those08:31
dcalisteI'll rework this patch with this then, and hopefully don't break anything this time.08:31
chriadamtyvm dcaliste08:31
flypigchriadam, sure, happy to. I was planning to go through them all in one go once everything is resolved, but if your changes are self-contained then I'll can take a look already.08:32
chriadamthey should be self contained, yes08:32
flypigOkay, then I'll do that. Thanks!08:32
chriadamdcaliste: am I correct to assume that we only need to look at (and eventually merge) the commits in the relation chain for https://codereview.qt-project.org/c/qt-labs/messagingframework/+/33729108:33
chriadami.e. that relation chain has no "outdated" or "merge conflict" warnings in it, currently, because i rebased everything in that chain08:33
chriadambut there are some other commits e.g. https://codereview.qt-project.org/c/qt-labs/messagingframework/+/334754/4 which have a bunch of "not current" or "indirect ancestor" or "merge conflict" warnings, I guess because they're not properly part of the rebased chain?08:34
dcalisteYes the 337291 chain is the valid one.08:35
dcalisteThe 334754, yes you can abandon it, I've merged it into another commit as suggested by flypig and is not part of the correct chain anymore.08:36
chriadamwell, I won't touch any other PRs just yet, I will close/abandon those other ones, once we've dealt with the "proper" relation chain08:36
chriadam(it'll be easier, I think, and safer ;-)08:36
chriadamum, on the caldav PR with setLastModified() and the extendedcalendar api addition, I created a PR for the google plugin, but there was only one point in the code which did the lastModified()/setLastModified() thing08:38
chriadamwhereas in the caldav PR there were 3 or 4 different cases which did that08:38
chriadamwondering whether I missed some cases in the google calendar code, or whether we did something slightly different between those two, or what08:38
dcalisteI reviewed the Google MR, I think you didn't miss any. Flypig created a function some MR ago to put all property change in one place.08:39
chriadamah!  great08:40
chriadamthank you for looking at that one.  (I have been sick at home friday, monday, today, so didn't see any PR comments over that time, sorry)08:40
chriadamin that case, I will merge the caldav and google one asap (hopefully tomorrow, maybe thursday).08:41
chriadamflypig: did you get a chance to look at the buteo-syncfw accounts enablement PR?08:41
flypigI did take a look. I have one last comment to add, but am just still trying to work something out in relation to it.08:41
flypigIt looks good. I just want to check that Accounts stuff. But it's all fine otherwise as far as I'm concerned. Nice.08:42
flypigBy "that Accounts stuff", I mean the enabled signals.08:42
chriadamindeed ... should we wait a bit for your work before merging that buteo one?08:43
dcalisteOk, thank you flypig. I'm waiting for your remark. I don't know if you see some comments I made about the difference between the enabled signal for an account and the enabled signal from a manager.08:43
dcalisteIt's this comment : https://git.sailfishos.org/mer-core/buteo-syncfw/merge_requests/59#note_7323908:44
flypigYes, it's exactly those comments dcaliste. What you say sounds correct, but when I looked through the libaccounts code, frankly, I couldn't figure it out. So I'm creating an example now just to be sure. Mostly for my own understanding.08:44
dcalisteOk, great then. That's good you check also, I may be wrong indeed.08:45
flypigHonestly, I'm happy to accept your word on it, so do feel free to merge. But, as I say, I'd like to test it for my own understanding anyway.08:45
flypigI just didn't feel comfortable adding a "LGTM" until I'd properly checked.08:46
dcalisteThat's wise :)08:46
dcalisteIt can definitely wait for your approval.08:46
chriadamI agree08:46
chriadamwere there any other PRs to discuss?08:47
dcalisteI don't think so, for information, I'm discussing with dyraig to solve his problem with caldav from https://forum.sailfishos.org/t/3-4-0-24-4-0-1-48-caldav-sync-with-nextcloud-server-fails/525908:49
dcalisteIt seems to me that it's related to cookies not passed back.08:50
flypigIs there something specific to the setup? I use a NextCloud calendar and it seems to work okay.08:53
chriadamcookies?!  I didn't know that dav was session-based08:53
flypigAh, sorry, this is CalDav, not using the NextCloud account plugin.08:54
chriadamthe other interesting thing I see in that thread is that the .well-known discovery requests seem not to be occurring according to his server logs - that's weird!08:54
chriadamnextcloud account plugin just uses caldav plugin under the hood08:54
dcalisteYes, I'm quite surprise. It's an issue with Nextcloud being installed in a subpath of the server.08:54
flypigI also use a subpath here. Odd.08:55
dcalisteMaybe a security setting the person switched on.08:55
dcalisteHe gave me yesterday an account on his server so I can now test freely on it.08:56
chriadamthank you for looking into that with him.  hopefully the cookie thing is the culprit, and it can be easily fixed?08:56
dcalisteYes, I've a MR not public yet that I want to test.08:57
dcalisteQt is doing cookie handling in one liner if called. So if it's this, the fix is simple.08:57
chriadamah great08:57
dcalisteI'm going to test further this week. But next week, I cannot attend our meeting, I need to go to the hospital (one last time).08:58
dcalisteBut you may see an MR before if I'm right on the cookie fix !08:59
chriadamah!  I hope all is well (is this for your finger?)08:59
chriadambut sounds good, thanks :-)08:59
dcalisteYes, it will be a final check with the surgeon that everything is fine.09:00
chriadamcool.  well, I hope that he can give good news.09:00
chriadamand I hope that you have a good two weeks - see you on the 6th of April!09:01
chriadamthank you as always for your effort and time and proactive help!09:01
chriadamit is greatly appreciated.09:01
dcalisteYeh, thank you both flypig and chriadam and see you in this meeting in two weeks. Or in a MR comment before ! Enjoy your week.09:01
* chriadam -> away, good night :-)09:02
flypigBy the way, dcaliste, would you have anything to add to the community news this week?09:02
flypigNot obligatory of course, but if you do, that'd be great.09:03
dcalisteflypig, no not really. QMF is still far from user land at the moment and still not ready. As a continuation of the last entry, pvuorela accepted the calligra MR, so converter will be in next-next version, as for the fix for ApB file.09:04
flypigOkay, I can mention about those as a follow-up. That's nice.09:04
flypigBut okay, in that case, let's leave more news for a future update when it's all merged :)09:05
flypigJust finally, for info, I still have your fingerterm PR to review. Consider this a self-nudge that I need to check it. I've not forgotten about it.09:07
*** vilpan is now known as Guest7944109:07
dcalisteflypig, no problem.09:08
flypigOkay; thanks again. I'll prod you for more news in a couple of weeks.09:09
dcalisteExactly. Thank you flypig for these summary of what is happening around SailfishOS development.09:10
flypigThey're quite fun to compile. It's hard to keep up with all the activity on the forum, but at least it gives me a solid reason to try :)09:12
*** Guest79441 is now known as vilpan10:57
*** vilpan is now known as Guest2185315:44
*** Guest21853 is now known as vilpan15:46
delopteshi, how can I understand qtcontacts-sqlite in the context of buteo-syncfw the easy way?22:43
deloptesI want to understand22:43

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!