| *** n2klb_ is now known as n2klb | 02:03 | |
| sharks[m] | New 5.2 issue - GPS seems to suck a fair bit more battery than it used to, has anyone experienced this / got any idea why it may be the case? | 03:52 |
|---|---|---|
| sharks[m] | Also, ofono-binder-plugin-ext-qti has caused me some issues, I know commit af7ca1e5 works but latest breaks things, only the first call after every reboot goes through correctly on latest. | 04:52 |
| sharks[m] | Not sure exactly which commit broke it | 04:52 |
| T42 | <adampigg> Been hacking on hbm on the plane | 09:05 |
| Mister_Magister | @adampigg no need, my PR works | 09:05 |
| T42 | <adampigg> its actually quite similar ... i made some changes to allowed values too though | 09:11 |
| T42 | <CRK_11755> Blade number 7 porch 37 39 and 41 for the vlan | 12:16 |
| Mister_Magister | bruh i jsut flashed 5.1 zip on g2 and it's also not booting to gui, the heck is wrong with 5.1 | 13:00 |
| T42 | <Mister_Magister> false alarm was my fault | 14:24 |
| *** Mister_Magister_ is now known as Mister_Magister | 15:50 | |
| T42 | <adampigg> @Mister_Magister for hbm, is some als cobfig needed? | 18:25 |
| T42 | <adampigg> What sets the upper bits of the payload? | 18:26 |
| T42 | <Mister_Magister> nah (re @adampigg: @Mister_Magister for...) | 18:27 |
| T42 | <Mister_Magister> max brightness (re @adampigg: What sets the upper ...) | 18:27 |
| T42 | <adampigg> Brigtlhtness is 0-100, hbm bits are in the upper byte, but i cant see what sets it (re @Mister_Magister: max brightness) | 18:29 |
| T42 | <Mister_Magister> whats what they want you to think ;) | 18:29 |
| T42 | <Mister_Magister> that's* | 18:29 |
| T42 | <Mister_Magister> https://github.com/sailfishos/mce/pull/41 | 18:30 |
| T42 | <Mister_Magister> i yeeted that and changed to gint new_hbm_level = hbm_and_level == 100; | 18:30 |
| T42 | <Mister_Magister> because that 0-7 bits stuff is simply wrong | 18:30 |
| T42 | <Mister_Magister> it assumes values go up to 255 | 18:31 |
| T42 | <Mister_Magister> and they don't | 18:31 |
| T42 | <Mister_Magister> it also assumes that you can control brightness of HBM, and you can't | 18:31 |
| T42 | <Mister_Magister> so it's wrong in every possible way | 18:31 |
| T42 | <Mister_Magister> if you're outside in the sun the brightness will be 100% all the time anyway | 18:31 |
| T42 | <Mister_Magister> spiiroin also mentioned "duration is limited even if conditions persist" no such thing is present in android, there's no limit | 18:36 |
| T42 | <Mister_Magister> "you can't choose hbm from settings (i.e. having 100 trigger hbm is not ok)" it's 100% ok xd | 18:36 |
| T42 | <Mister_Magister> And I am tired of pretending it is not xd | 18:36 |
| T42 | <adampigg> Ok, that explains why it works for you. The existing code does clearly say values are 0-100, with bits8 and 9 for enabling hbm | 18:42 |
| T42 | <adampigg> I was trying to make it fit that scheme | 18:42 |
| T42 | <Mister_Magister> the bits magic in the code expects the value to be 0-255 | 18:43 |
| T42 | <Mister_Magister> its 0-100 | 18:43 |
| T42 | <Mister_Magister> so it's very clearly wrong | 18:43 |
| T42 | <Mister_Magister> you'd have to remove normalizing to 0-100 and somehow get the raw value there, or simply fix the condition | 18:44 |
| Mister_Magister | and also sure you could pass raw value and make it go up to 255 and it would turn on if brightness is above 50%, but i can do the same with hbm_and_level >= 50 | 18:49 |
| Mister_Magister | it's exactly the same | 18:49 |
| T42 | <Mister_Magister> @b100dian ping | 19:03 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!