| *** n2klb_ is now known as n2klb | 01:59 | |
| Mister_Magister | mal: so what do you think about LLM's fix for gst-droid issue? https://github.com/Michal-Szczepaniak/gst-droid/commit/e490867bbc7981d1f163fbba6e4042c9003d4e67 https://github.com/Michal-Szczepaniak/droidmedia/commit/81db5a7b2a50083f70f1249d99b9c1a735ff4114 | 09:44 |
|---|---|---|
| Mister_Magister | looks clean to my eye | 09:44 |
| T42 | <abranson> does it work? | 09:58 |
| Mister_Magister | That's wonderful question! | 10:00 |
| Mister_Magister | Does master gst-droid and droidmedia work on sfos 5.1? | 10:00 |
| T42 | <abranson> no idea, but that looks like it'll cherry pick onto earlier | 10:00 |
| Mister_Magister | aigh i'll get on it soon, and yes I know i should test before making PR, i'm just excited okay | 10:01 |
| T42 | <abranson> yeah it looks good | 10:09 |
| T42 | <abranson> which llm did that? | 10:09 |
| Mister_Magister | claude | 10:21 |
| Mister_Magister | looks simple enough :P And with that + enabling qmlglsink and we'll finally have legit video player on sfos | 10:21 |
| T42 | <adampigg> i see a stack of new apps on openrepos using claude .. i hope they just dont turn into abandonware | 10:33 |
| T42 | <abranson> will qmlglsink work with the droid video streams? | 10:40 |
| Mister_Magister | @abranson with the fix yessir thats why i love it | 11:04 |
| Mister_Magister | i can use gst-droid AND apply filters over output because qmlglsink forces gst-droid to convert it back from droidmedia format to normal format | 11:05 |
| Mister_Magister | thats why that bug was unearthed in the first place, nothing in sfos uses that part of code | 11:05 |
| T42 | <abranson> i thought the whole reason why we had droideglsink was because it needed special handling | 11:05 |
| Mister_Magister | I already tested it and gstreamer can now render subtitles over droidmedia output | 11:05 |
| T42 | <abranson> well that sounds good | 11:05 |
| Mister_Magister | @abranson nope! droidmedia has conversion inbuilt | 11:05 |
| Mister_Magister | https://github.com/sailfishos/droidmedia/blob/master/droidmediaconvert.cpp | 11:06 |
| Mister_Magister | droid_media_convert_to_i420 | 11:06 |
| T42 | <abranson> ah right. the old browser conversion | 11:06 |
| Mister_Magister | and i won't have to use my overcomplicated gstdroid sink and can just slap qmlglsink simplifying apps wanting to use gstdroid pipeline A TON | 11:06 |
| Mister_Magister | and as i said already it unlocks subtitles in video players | 11:07 |
| Mister_Magister | even graphic ones | 11:07 |
| Mister_Magister | and i can use same sink for software and hardware decoding | 11:07 |
| Mister_Magister | and then it just becomes case of missing codecs but community can take care of it wink wink | 11:07 |
| T42 | <abranson> but that requires the i420 conversion blob. the browser thing has a manual one for when that's not present. i think some xperias don't have it | 11:07 |
| Mister_Magister | what do you mean? | 11:07 |
| T42 | <abranson> i'll find it | 11:08 |
| T42 | <abranson> that thing is a hybris wrapper: https://github.com/sailfishos/droidmedia/blob/master/droidmediaconvert.cpp#L55 | 11:09 |
| T42 | <abranson> it depends on that libI420colorconvert.so being present. that's supposed to be able to convert from whatever the native format is to I420, so the native format could be custom or even completely opaque and you can still get buffers. | 11:09 |
| Mister_Magister | i think it's not being present on my device and works anyway | 11:10 |
| Mister_Magister | so maybe it doesn't use the droid_media_convert_to_i420 | 11:10 |
| Mister_Magister | https://github.com/sailfishos/gst-droid/blob/master/gst/droidcodec/gstdroidvdec.c#L868 | 11:11 |
| Mister_Magister | so it might simply be not using it | 11:12 |
| Mister_Magister | yeah | 11:13 |
| Mister_Magister | it's the else if | 11:13 |
| Mister_Magister | because it goes into gst_droidvdec_convert_yuv420_semi_planar_to_i420 | 11:13 |
| Mister_Magister | so if that so is available it uses it otherwise it has bunch of conversions inbuilt is what I'm getting | 11:14 |
| Mister_Magister | and those conversions is code that probably nothing in sfos reaches currently | 11:14 |
| Mister_Magister | correctmeifimwrong | 11:15 |
| T42 | <abranson> aha maybe that's where it ended up! it's been a while... | 11:15 |
| Mister_Magister | I think qmlglsink is insanely big deal and should be prioritized but that's just my effort :P I hope the PRs get merged as well as qmlglsink enabled then i can swap my apps to qmlglsink and have massive improvement and we can finally watch anime with subtitles | 11:16 |
| Mister_Magister | And I won't have to learn japanese | 11:16 |
| T42 | <abranson> yep I think this is the enabling commit: https://github.com/sailfishos/gst-droid/commit/8131c6d7ba68d0f1f23748a87f6fa64ab8a66f5b | 11:17 |
| Mister_Magister | also things like movie rips will be playable with subtitles because graphic subtitles will also work | 11:17 |
| T42 | <abranson> have you done a PR for the qmlglsink too? | 11:17 |
| Mister_Magister | nah not yet | 11:18 |
| Mister_Magister | i need to make PRs to gst-plugins-base and -good | 11:18 |
| Mister_Magister | because wayland stuff is broken too | 11:18 |
| Mister_Magister | I'll rebase it on top of master and make PR | 11:19 |
| Mister_Magister | https://github.com/sailfishos/gst-plugins-base/pull/14 that's one | 11:26 |
| Mister_Magister | and that's second https://github.com/sailfishos/gst-plugins-good/pull/13 | 11:28 |
| Mister_Magister | the gst-plugins-base/good are tested changes | 11:29 |
| Mister_Magister | now I just need y'all to merge all 4 and deploy onto sfos 5.1 pretty please :D | 11:29 |
| T42 | <abranson> well it won't make 5.2 now, but I'll get round to reviewing those. | 11:35 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!