| T42 | <adampigg> bisect 6 also bad | 05:51 |
|---|---|---|
| T42 | <adampigg> 5 to go | 05:52 |
| masha11 | Hello. When I try to call or send SMS, I get the message "no network coverage."The inclusion of mobile data gives a message: "SIM card is not used". Any ideas how to fix this? | 06:55 |
| T42 | <Umeaboy> Does enabling and disabling Airplane mode fix it? | 15:54 |
| benclark06 | how do i package droidmedia? | 16:41 |
| benclark06 | ok when i'm trying to build it i'm getting Fatal: 'motorola-falcon-armv7hl' is not a known build target for some reason | 16:46 |
| benclark06 | that's literally the only thing on the log, so i have no idea what's happening | 17:29 |
| T42 | <elros34> check what name you set to your target: sdk-assistant | 17:32 |
| T42 | <elros34> sdk-assistant list | 17:33 |
| benclark06 | oh i forgot to set a target | 18:10 |
| benclark06 | sorry | 18:10 |
| benclark06 | okay so i've built gstreamer but now when i built the filesystem, i get Warning[10/01 18:21:54] : repo problem: nothing provides gstreamer1.0-droid needed by pattern:jolla-hw-adaptation-falcon-1-1.noarch, which is weird because i /just/ built it | 18:24 |
| mal | piggz: some comments to manual mode PR | 18:28 |
| mal | benclark06: are you sure you didn't mess up something like use wrong target or have incorrect ANDROID_ROOT set when building it? | 18:29 |
| benclark06 | mal: certain | 18:30 |
| piggz | mal: oh, thx... | 18:34 |
| mal | piggz: another one | 18:38 |
| piggz | mal: if all goes to plan, new p-o-v and find mesa problem tonight! | 18:39 |
| mal | piggz: I'm checking the other PRs also, some issues in one of those already, some style nitpicking :D | 18:39 |
| piggz | mal: that second message.... | 18:40 |
| piggz | the reason i did that was so that, if the settings/mode got out of sync, the selector would show the correct option ... what do you think? | 18:40 |
| mal | piggz: not sure if I understand, you mean the last comment or the "!_manualModeSelected" ? | 18:42 |
| piggz | mal: the last comment, the one that started "is this needed...." | 18:42 |
| mal | ok | 18:42 |
| mal | piggz: how did it get out of sync? | 18:43 |
| piggz | well, it shouldnt, and i dont know it can .. i was just being extra careful | 18:43 |
| mal | piggz: could it have been the other bug I mentioned? | 18:43 |
| mal | which caused it to go out of sync | 18:43 |
| T42 | <jgibbon> Barely on topic: I may be able to fix / rebase small things on the button PR on lunch break tomorrow. Let me know if necessary ;) | 18:45 |
| mal | piggz: if you are doing it like that you also need to fix focusIcon() function, it uses settings.mode.focus | 18:47 |
| mal | piggz: the difference between that and you new code caused the menu list and icon go out of sync if you pressed manual mode twice | 18:48 |
| mal | @jgibbon one style issue at least in your code, I'm still checking it more | 18:48 |
| deathmist | I'm confused about building an image using the OBS stuff, so I got a kickstarts file generated https://pastebin.com/63X0Mn6G and installed that rpm on my dev env (also updated contents of hybris/droid-configs/installroot/usr/share/kickstarts/Jolla-@RELEASE@-cheeseburger-@ARCH@.ks accordingly), now what? | 18:51 |
| deathmist | and by dev env I meant "sb2 -t $VENDOR-$DEVICE-$PORT_ARCH -m sdk-install -R zypper in ..." | 18:53 |
| vknecht | deathmist, building image from OBS needs just extracting the KS file from droid-config-$DEVICE-ssu-kickstarts-*.rpm and using it with mic | 18:55 |
| vknecht | not sure what you'd install in "dev env" ? | 18:55 |
| mal | deathmist: what do you mean? I don't understand why you edited hybris/droid-configs/installroot/usr/share/kickstarts/Jolla-@RELEASE@-cheeseburger-@ARCH@.ks that is not needed, you can just keep using same .ks always, I just keep a ready .ks in ANDROID_ROOT and almost never regenerate it | 18:56 |
| T42 | <jgibbon> mal: thanks, really appreciating you looking over it. kept most of the qml style where it made sense but was for example unsure about the bit mask white space. Not at all fluent with c++ style. | 18:57 |
| mal | like vknecht said you just extract a ready one from that rpm, but once it's extracted it's rarely necessary the local copy of the .ks | 18:57 |
| benclark06 | mal: figured out my issue, i just copy and pasted it wrong | 19:00 |
| mal | @jgibbon some inconsistencies, sometimes you have === sometimes == | 19:00 |
| T42 | <jgibbon> I left copied ==, true. Code I do always has === to be easier on runtime optimization. I'll gladly replace them :) | 19:03 |
| mal | if you are editing then at least replace those in your modified code | 19:04 |
| T42 | <jgibbon> Fair point. | 19:04 |
| mal | need to check how much of each type is used | 19:05 |
| benclark06 | alright new problem: when trying to build gst-droid, i get this https://paste.gnome.org/pb9jlisvs | 19:05 |
| benclark06 | full log: https://paste.gnome.org/pqfwtwwxs | 19:05 |
| mal | @jgibbon looks like mostly === in the code, sometimes == | 19:06 |
| piggz | mal: ill revery that last change and see if it actually causes an issue | 19:08 |
| piggz | revert | 19:08 |
| T42 | <jgibbon> mal: Either way, with same-type comparisons, == always does make a lot less sense than === | 19:10 |
| mal | @jgibbon if you want you can add a new commit which changes all of those to === in case both are same type | 19:11 |
| T42 | <jgibbon> mal: will do. Other changes are still supposed to be in a single commit, right? So I'll do that last. | 19:14 |
| T42 | <jgibbon> Preferably when the manual branch is ready, I hate rebasing on force pushes ;) | 19:15 |
| mal | @jgibbon probably good idea to wait until manual mode is in | 19:17 |
| mal | or ready | 19:17 |
| mal | it seems you did that on top of it | 19:17 |
| T42 | <jgibbon> Yeah, asked Adam about it since manual mode (focus is only for that) obviously only worked there. | 19:19 |
| piggz | mal: if youre happy, iwill commit anual mode | 19:20 |
| benclark06 | also when i try to run it again i get fatal: destination path 'gst-droid' already exists and is not an empty which is weird | 19:22 |
| mal | benclark06: you only run build_packages.sh -b hybris/mw/gst-droid | 19:26 |
| mal | piggz: I started to think, should we check in the beginning of setFocusMode if the focus mode is the same, and not do anything in that case? i.e. if (focus === settings.mode.focus) return; | 19:27 |
| benclark06 | mal: alright, thanks | 19:27 |
| piggz | mal: ah, yes, that an easier way to do it | 19:28 |
| mal | piggz: although it doesn't really matter much if we redo the things | 19:28 |
| piggz | the way it is now, it will trigger a camera stop/start even if the mode is the same | 19:28 |
| mal | yes | 19:29 |
| benclark06 | mal: still get the same error https://paste.gnome.org/pg8mehhsj | 19:29 |
| piggz | what do u think? im happy either way, commit now and fix later, or fix now | 19:29 |
| mal | piggz: your call, simple thing to fix if you want | 19:30 |
| piggz | mal: if the mode is the same, should it still reset the focus point? | 19:31 |
| mal | piggz: only thing I think is that will that cause anything when setting up mode the first time, I mean if it thinks mode is the same | 19:31 |
| mal | piggz: good question | 19:32 |
| piggz | it could be a way to reset the circle | 19:32 |
| mal | yes, still needs testing of the initial setup | 19:33 |
| piggz | ok, i'll reset my config | 19:33 |
| mal | piggz: I mean when starting the camera | 19:33 |
| T42 | <elros34> @benclark06: I guess it's because you removed your target ( for unknown reason) so droid-hal and libhybris is not installed. | 19:33 |
| mal | but indeed also when not having any settings | 19:34 |
| mal | piggz: starting up camera wouldn't work, we call setFocusMode(settings.mode.focus) in applySettings which means it would never set the initial mode | 19:37 |
| piggz | ok | 19:37 |
| benclark06 | @elros34, ah right, so i need to rebuild all the packages, right? | 19:38 |
| mal | piggz: unless we add some extra magic but probably would make things a bit complicated | 19:38 |
| T42 | <elros34> @benclark06: droid-hal and libhybris should be enough I think | 19:40 |
| benclark06 | ok, neat | 19:40 |
| mal | piggz: you can merge that if you want | 19:41 |
| piggz | mal: asis? ok | 19:42 |
| mal | piggz: btw, when did we stop using [tag] in the commits? | 19:42 |
| piggz | when i got lazy :D .... fixing | 19:43 |
| mal | piggz: well there are many of those already in commit history | 19:43 |
| mal | piggz: so this happens when I'm not nitpicking :D | 19:43 |
| piggz | mal: but your time is precious and rare ;) | 19:44 |
| benclark06 | alright now i get this when trying to build gst-droid https://paste.gnome.org/p73cgvhj1 | 20:06 |
| mal | does that folder exist? | 20:07 |
| mal | check what "echo $ANDROID_ROOT" prints | 20:07 |
| benclark06 | it prints /home/benclark/hadk | 20:08 |
| benclark06 | oh now it's just randomly working now | 20:09 |
| benclark06 | that's cool | 20:09 |
| piggz | @jgibbon you can rebase on master now | 20:20 |
| piggz | ;) | 20:20 |
| T42 | <jgibbon> piggz: awesome, will do in my lunch break tomorrow. | 20:21 |
| benclark06 | hi, so when i try to start up the port, i get lipstick.service: Main process exited, code=killed, status=11/SEGV | 20:46 |
| benclark06 | full logs: https://paste.gnome.org/pkq3n40zz | 20:49 |
| mal | that link doesn't work | 20:53 |
| benclark06 | crap | 20:59 |
| benclark06 | https://bin.disroot.org/?bb5db9c584744196#pB74EpnBja6gp4+zQKx2ZlMMF812oaz8cz1dQOqY0Ms= | 20:59 |
| benclark06 | mal: ^ | 20:59 |
| mal | which android base? | 21:03 |
| deathmist | vknecht: mal: thank you for clarifying! sometimes I just have no idea what I'm doing :D I've built a zip now and will test stuff tomorrow | 21:34 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!