| rinigus | piggz: just debugging a bit further. looks like I can list the stored fingers using enumerate (made some small additions). cannot remove though (yet) | 09:11 |
|---|---|---|
| rinigus | piggz: I can also remove single fingerprint from store. | 09:26 |
| rinigus | ... and remove them all one-by-one. I'll ask around, maybe its some bug with remove(0,0) | 09:35 |
| T42 | sky_sagit was added by: sky_sagit | 11:14 |
| rinigus | piggz: from help of Sony AOSP devs - Android is removing by iterating one by one, last FP is removed using remove(0), the one that fails for me even with one FP. Marijn from Sony AOSP wanted to check out if there is some issue on their side with it. | 11:16 |
| rinigus | piggz: I will add the support for listing stored FPs and should add also to your test GUI support for listing+removal one by one. | 11:17 |
| rinigus | I presume you work on auth bit | 11:17 |
| rinigus | piggz or someone else: do you know whether SFOS Settings list fingerprints and whether they allow to remove them one by one? | 11:18 |
| rinigus | piggz: how can I hook SFOS settings to FP? as you did for enrolling them | 11:18 |
| piggz | rinigus: thx... send a PR ... | 12:15 |
| piggz | i willw ork on auth bit later, been mtb :) | 12:15 |
| piggz | we need to enumerate, then convert them to finger1, finger2, finger3 etc for sfos i thin | 12:16 |
| rinigus | piggz: I wonder where should we keep a map between FPids and names... | 12:20 |
| rinigus | but OK, I continue with enumerate | 12:20 |
| rinigus | piggz: I am cleaning up the code a bit. question: in the logs, do you also have /data/system/users/0/fpdata//user.db <- double //? I'd drop trailing slash in the path that is given to android | 12:29 |
| piggz | rinigus: i was thinking about where to keep a map between names and ids, bt then thought we dont need to....we just enumerate them from the device, and name them in order ? | 12:57 |
| piggz | rinigus: you will probbaly beat me to impementing everything, i wont get a chance until later!! | 12:58 |
| rinigus | piggz: looks to me the API expects finger_string -> uint32_t id on daemon side though. we can't make up the map as user may want to remove some specific finger... if only we could let the client to keep the map | 12:59 |
| rinigus | piggz: but let me submit PR with cleanup and enumerate and then we can discuss | 13:00 |
| rinigus | piggz: just pushed into existing PRs (daemon + test code). will make a break now. feel free to review ... | 13:19 |
| piggz | rinigus: looking.....the Enumerate call....that isnt part of the closed-source api is it? | 13:20 |
| piggz | they use GetAll i think | 13:21 |
| piggz | going out for a few hours now....will do more later | 13:21 |
| rinigus | piggz: that's correct. thinking of it, I will hide it this part and make it internal | 14:12 |
| T42 | <ankaos> https://github.com/enesutku07/droid-hal-tissot https://github.com/enesutku07/droid-config-tissot https://github.com/enesutku07/droid-hal-version-tissot | 15:33 |
| T42 | <ankaos> device is bootloop. device not open. | 15:33 |
| T42 | <ankaos> https://github.com/enesutku07/tissot/blob/tissot-o-oss/arch/arm64/configs/tissot-perf_defconfig this is kernel config | 15:35 |
| T42 | <ankaos> @elros34 where is the problem? | 15:48 |
| rinigus | piggz: close with the list, have to make a break | 16:00 |
| T42 | <ankaos> rinigus: please look links | 16:00 |
| T42 | <elros34> @ankaos seems like problem is that you removed well working droid and kernel repos and created everything from scratch without any reason | 16:23 |
| T42 | <ankaos> @elros34 [@ankaos seems like problem is that you removed …], `'Enes'` `'hodja'`, [30.05.20 18:33] | 16:29 |
| T42 | <ankaos> https://github.com/enesutku07/droid-hal-tissot https://github.com/enesutku07/droid-config-tissot https://github.com/enesutku07/droid-hal-version-tissot | 16:29 |
| T42 | <ankaos> this is bad? | 16:29 |
| piggz | rinigus: ready to start.... | 16:47 |
| rinigus | 5 mins | 16:49 |
| rinigus | and I'll submit current state | 16:49 |
| rinigus | piggz ^ | 16:50 |
| piggz | rinigus: gr8 | 16:50 |
| rinigus | piggz: daemon submitted, not tested much yet | 16:51 |
| T42 | <elros34> @ankaos all these wlan related changes in your defconfig looks incorrect for me: like enabling pronto/prima or using builtin wil6210 and so on | 16:56 |
| rinigus | piggz: test submitted. had to cut short as I have a small meeting in few minutes. | 16:59 |
| rinigus | will be able to join in 20-45 mins, probably | 16:59 |
| piggz | rinigus: np, thx for helping | 17:01 |
| piggz | im sure we can nail this shortly | 17:01 |
| piggz | rinigus: identifying works | 17:07 |
| piggz | its a hack atm, need some other groundwork | 17:07 |
| rinigus | piggz: sounds great! | 17:09 |
| piggz | rinigus: that is pushed .... you currently have to re-add the finger every boot becuase the GetAll isnt implemented | 17:10 |
| rinigus | piggz: check prs | 17:11 |
| piggz | on it | 17:12 |
| piggz | rinigus: i think GetAll needs to return "finger1,finger2,finger3..." .... but i might merge your PR than work on the mapping between strings and id's | 17:15 |
| piggz | what do you think? | 17:15 |
| rinigus | piggz: please do | 17:15 |
| rinigus | piggz: can join when you are ready. to get the mapping, we will need to store strings with which keys were created by clients by calling `Enroll(const QString &finger);`. | 17:52 |
| rinigus | piggz: should I look into the test client? | 18:13 |
| rinigus | or anything else I could help with? | 18:14 |
| piggz | rinigus: im just thinking .... | 18:15 |
| piggz | rinigus: i guess we need a file store | 18:17 |
| rinigus | piggz: for string <--> uint32_t? | 18:17 |
| piggz | yes .... until you mentioned using the name the client sends , i was going to fudge it internally and assume fingerX | 18:18 |
| rinigus | I agree. we do need it, assuming that jolla's settings does send some proper unique string | 18:19 |
| rinigus | piggz: looking at API, does Remove have an argument? shouldn't there be one string? | 18:20 |
| rinigus | (all relates to that filestore with the map) | 18:20 |
| piggz | rinigus: I assume so .... reading mce will say for sure | 18:21 |
| piggz | probably some of those functions also need to return int not void | 18:21 |
| rinigus | piggz: they haven't sent you privatly API? | 18:21 |
| piggz | rinigus: no, im reverse engineering it! | 18:22 |
| rinigus | piggz: OK, but then we can make at least the test app working as we expect and later see how well it maps to SFOS Settings... | 18:23 |
| piggz | ofc | 18:23 |
| rinigus | piggz: do you know how identification works? which api is for that? | 18:23 |
| rinigus | with the map, where are expected to store it? somewhere in /var/cache? | 18:24 |
| rinigus | maybe /var/db | 18:25 |
| rinigus | just looked in /var and found .... /var/yp!!! | 18:26 |
| rinigus | now that's a blast from the past | 18:26 |
| piggz | rinigus: just testing load/save code | 19:45 |
| piggz | rinigus: first test looks good! | 19:50 |
| piggz | i will push and you can test too ... i rebooted and was able to unlock | 19:51 |
| piggz | mal: do you want to jump on the community fingerprint band wagon for your port? | 20:01 |
| mal | piggz: I have no community device with fingerprint support | 20:43 |
| rinigus | piggz: we should make a list of outstanding issues and I can help with fixing them | 20:47 |
| rinigus | as packaging android bits (pull into sailfish-fpd-community?) and the rest. | 20:47 |
| piggz | rinigus: sure, create an issue for each one | 20:48 |
| piggz | rinigus: yes, was thinking we could pull in that android file | 20:48 |
| rinigus | will make issues as I go along | 20:48 |
| rinigus | good, will you do that? | 20:49 |
| piggz | sure | 20:49 |
| rinigus | piggz: what's a plan with test code? leave it as it is? | 20:50 |
| piggz | rinigus: i will keep it for now, it may proove useful, but hopefully not needed much now .... | 20:51 |
| piggz | rinigus: i wonder how well it runs against the official fpd! | 20:51 |
| rinigus | piggz: how about removing FPs? is it possible one-by-one? | 20:51 |
| rinigus | piggz: re official fpd - good question | 20:52 |
| piggz | rinigus: that still needs implemented i think ... fell free! | 20:52 |
| rinigus | all thing looks bit unsecure. as soon as your phone is lying around unlocked, anyone can add FPs | 20:53 |
| piggz | rinigus: you have to enter the pin to enter a finger | 20:53 |
| rinigus | piggz: in official settings. not in DBus API | 20:53 |
| piggz | heh, i wonder how offical device copes with that | 20:54 |
| rinigus | ... as your app can be used without pin code | 20:55 |
| piggz | yes .... but an unlocked phone could also issue dbus-send commands | 20:56 |
| piggz | rinigus: android code imported and pushed | 21:04 |
| rinigus | piggz: let's just warn / document. or at least remember that concern | 21:05 |
| rinigus | looks like I cannot remove FPs from official settings. otherwise it works. will start filing issues | 21:05 |
| piggz | rinigus: remove looks easy to fix.... | 21:10 |
| piggz | signature needs changed for a start | 21:10 |
| rinigus | piggz: great. I am off to sleep, will be able to continue tomorrow on where you stopped | 21:11 |
| piggz | rinigus: Remove() implemented and pished | 21:42 |
| piggz | s/pushed | 21:42 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!