| T42 | maffeen was added by: maffeen | 06:17 |
|---|---|---|
| T42 | <maffeen> Hi | 06:17 |
| rinigus | Morning! Looks like only fingerprints added in settings can be removed, otherwise sailfish settings gets confused. I'll look into test app to support API fully | 06:18 |
| rinigus | piggz /\ | 06:18 |
| T42 | <adampigg> Rinigus : thanks | 06:35 |
| T42 | <maffeen> Hi! Does anyone know if I can use Lineage OS 17.1 as base? I would like to port Sailfish OS to my device. | 07:00 |
| r0kk3rz | not yet | 07:05 |
| T42 | <adampigg> R0kk3rz: you got any ports with a fp sensor ? | 07:10 |
| r0kk3rz | nope | 07:11 |
| r0kk3rz | maybe if they ever open up this nokia thing ive got | 07:12 |
| T42 | <maffeen> thanks r0kk3rz, I think that I'll just wait | 07:12 |
| rinigus | piggz: I am moving `setState(FPSTATE_IDLE)` as enumerate changes the state as well. let me know if it's wrong and you moved it there for some reason that I am missing | 07:44 |
| T42 | <adampigg> Rinigus: carry on, i can test later....working on project r5 this morning | 08:08 |
| T42 | <adampigg> I agree gplv3 btw | 08:09 |
| rinigus | piggz: very good, will continue | 08:09 |
| T42 | <adampigg> Rinigus: did you have to do any fixing at the hal level for your port? | 08:09 |
| rinigus | @adampigg: no, none | 08:10 |
| rinigus | as long as you don't use clear(), I was fine | 08:10 |
| T42 | <adampigg> Oh gr8, but biometryd didnt work? | 08:10 |
| rinigus | @adampigg: sorry for delay. just submitted PR for review and one issue with a crash | 08:40 |
| rinigus | @adampigg, @erfanoabdi: looks like biometryd was failing on my device for two reasons. 1: clear() leading to remove(0,0) on android side seems to be not supported on android. this is a working theory, has to be confirmed if someone wants to investigate. on my device, removing one-by-one works | 08:43 |
| T42 | <erfanoabdi> @rinigus [@adampigg, @erfanoabdi: looks like biometryd w …], removing fingerid 0 is clear all according to aosp api | 08:44 |
| rinigus | 2nd issue: biometryd got somehow confused with future and promises. as a result, it was constantly crashing on my device. | 08:44 |
| T42 | <erfanoabdi> If it's crashing the VTS also doesn't pass on your device | 08:45 |
| rinigus | @erfanoabdi: yes, it is. but looks like not all devices support it. sony devs told that at least in one case they have to loop over the fingerprints to remove them | 08:45 |
| rinigus | in practice, removal one-by-one is working and is used by android as well. | 08:46 |
| T42 | <erfanoabdi> In biomertyd git history there's the clear all method with one by one removing | 08:46 |
| T42 | <erfanoabdi> U can revert it | 08:46 |
| rinigus | as for VTS, no idea what is it even | 08:46 |
| T42 | <erfanoabdi> https://github.com/LineageOS/android_hardware_interfaces/blob/lineage-17.1/biometrics/fingerprint/2.1/vts/functional/VtsHalBiometricsFingerprintV2_1TargetTest.cpp#L340 | 08:48 |
| rinigus | @erfanoabdi: probably we can revert it. should look into it at some point. however, its rather difficult to debug that biometryd, or I am missing something. in this respect, bare bones piggz daemon looks to be sufficient. | 08:49 |
| T42 | <erfanoabdi> Yeah his daemon looks good for Sailfish | 08:49 |
| rinigus | @erfanoabdi: sony devs wanted to look into remove(0,0) issue. but nothing popped up when we checked just the beginning of the stack. its bit deeper where the error is issued | 08:50 |
| rinigus | I will check whether dropping clear from biometryd test will make it pass on my device. | 08:51 |
| rinigus | @erfanoabdi, @adampigg: when I disable clear() in the test, biometryd works as expected | 09:12 |
| rinigus | so, the issue was in the errors in clear() that somehow messed up the observer | 09:13 |
| rinigus | piggz: I will look now into test gui - as was planning earlier this morning | 09:20 |
| T42 | <erfanoabdi> 👍👍Nice | 09:34 |
| rinigus | @erfanoabdi: thank you very much for your help! | 09:38 |
| T42 | <erfanoabdi> rinigus: no problem, u guys did all the hard work ;) | 09:38 |
| rinigus | piggz did :) ^ | 09:39 |
| T42 | <adampigg> :) great code from erfan was the enabler though.... And thanks for the PRs this morning rinigus...while ive been rubber coating the undeside of my renault :D | 09:43 |
| T42 | <adampigg> Im wondering about adding different implementations of the android side in the future, for older bases like LOS 14 for mido port, as that likely wont like the hidl interface? | 09:44 |
| T42 | <RealDanct12> @adampigg is the src up? | 09:46 |
| T42 | <adampigg> @RealDanct12 [@adampigg is the src up?], Sure, github.com/piggz/sailfish-fpd-community | 09:46 |
| T42 | <erfanoabdi> @adampigg [Im wondering about adding different implementa …], just build the hybris backend with legacy hal | 09:47 |
| T42 | <adampigg> Ah, ok, ill try it latet | 09:47 |
| T42 | <erfanoabdi> @adampigg [Ah, ok, ill try it latet], there's a similar code for gps hal on ubports that opens legacy hal and uses it | 09:49 |
| T42 | <erfanoabdi> that can be useful to check as reference(thats what i did for fp) | 09:49 |
| T42 | <erfanoabdi> https://github.com/ubports/platform-api/blob/xenial_-_edge_-_android8/android/hybris/ubuntu_application_gps_for_hybris.cpp#L299 | 09:49 |
| rinigus | piggz: as I have no idea when Verify is called, I smuggled debug message into it as well. pushed it into PR waiting your review | 11:57 |
| ggabriel | o/ sorry for the n00b question... but I'm getting ninja: error: 'fstab.common' - I know you have to copy fstab.common to out, but I don't know exactly where. Anybody can help? | 13:33 |
| ggabriel | never mind... I needed fstab.common in . as opposed to out | 14:03 |
| ggabriel | (that must be a mistake in the ninja file) | 14:03 |
| rinigus | piggz: submitted PR for "test" app. so, there are 2 PRs for you to review: one for daemon and one for client. I will wait for reviews and do something else... | 14:07 |
| T42 | <ot_kurva> Problem: droid-config-jasmine_sprout-1-1.armv7hl obsoletes ofono-configs-mer provided by ofono-configs-mer-1.23+git12-1.armv7hl | 14:14 |
| T42 | <ot_kurva> How to fix? | 14:14 |
| piggz | rinigus: all merged \o/ | 14:49 |
| rinigus | thanks! :) | 14:49 |
| rinigus | piggz: just saw that we still have "default cover" for the app... will fix that too. | 14:51 |
| rinigus | I'll file few issues for GUI as well | 14:51 |
| piggz | ok ... later on i will start working through the issues, starting with ading a license and readme | 14:52 |
| piggz | i need to see if it will work on mido and pro1 | 14:52 |
| piggz | i just need to finish up with my car, after taking a break to fix my parents car! | 14:52 |
| piggz | i have no idea how a 150A fuse can blow!!!!! | 14:52 |
| piggz | i think it must have shorted while removing the battery | 14:53 |
| T42 | <Verevka86> @ot_kurva [How to fix?], https://github.com/nebrassy/droid-config-jasmine_sprout/blob/hybris-16.0/rpm/droid-config-jasmine_sprout.spec#L20 | 14:53 |
| rinigus | piggz: I wonder if you can reproduce https://github.com/piggz/sailfish-fpd-community/issues/10 | 15:13 |
| rinigus | for me its quite reproducible, unfortunately. sometimes it takes one FP fine, but the second leads to the reboot. | 15:40 |
| rinigus | so, in this respect, test app is working better. never seen that with it | 15:40 |
| rinigus | piggz ^ | 15:40 |
| T42 | <adampigg> Rinigus, ive not had an issue adding lots of fp, even when it fills up | 15:48 |
| T42 | <adampigg> Rinigus, maybe we could add a quirk for it? | 15:49 |
| zinstack | Hello. Building hybris and stuck at being unable to boot, obviously. My device is moto g7 (river), sdm632 chip, hybris-16.0 and lineage-16.0 as a base. Fun stuff happens in hybris-boot.img. I know selinux should be disabled, either by kernel command (looks like a preferred method) or by removing it from kernel altogether. In my case, neither work. With selinux, I can boot into init-debug with real rootfs and all, | 15:54 |
| zinstack | but as soon as I do anything about selinux, I get thrown into bootloader immediately after booting. In this case, no usb devices show up in dmesg. Here's my messy kernel config: https://pastebin.com/xJUTpqwz. Kernel config check results in a few warnings, but nothing that catches the eye. Please ignore SELINUX_DISABLE, it has no effect on the whole picture. I've been using calebccff's port to enchilada as my | 15:54 |
| zinstack | reference. Does anybody know what should I do? | 15:54 |
| T42 | <elros34> this is wrong: CONFIG_SECURITY_SELINUX_DISABLE=y. YOu must disable selinux via bootparam | 15:55 |
| T42 | <elros34> How fast does it reboot? | 15:59 |
| rinigus | piggz: let's see what your other devices do. I can also recommend 'test' app | 16:03 |
| T42 | <adampigg> Rinigus wdym recommend? | 16:05 |
| zinstack | elros34: This doesn't disable selinux, oddly, only permits disabling it in post-boot (don't know how though, it wasn't there before anyway): CONFIG_SECURITY_SELINUX_DISABLE=y. It reboots instantly, as if boot image is corrupt (I think, not entirely sure). | 16:05 |
| T42 | <elros34> For sure to get sfos working you must have CONFIG_SECURITY_SELINUX_DISABLE=n. Which exactly config cause instant reboot? | 16:07 |
| T42 | <elros34> Did you remove parsing of skip_initramfs in kernel? | 16:08 |
| zinstack | The same config with that exact line, but with bootparam selinux=0. About skip_initramfs, not sure, how'd I do it? | 16:09 |
| T42 | <elros34> https://github.com/mer-hybris/android_kernel_sony_msm/commit/e3648beea7a581e1671a1ac9c59cdb993475c95d#diff-02da53981755aab07523e5252ce7dc11 | 16:10 |
| T42 | <elros34> it will probably not help but instead selinux=0 you can use CONFIG_SECURITY_SELINUX_BOOTPARAM_VALUE=0 | 16:15 |
| zinstack | Will try that with bootparam first, enchilada port used bootparam and that patch, but I haven't paid enough attention to it. Thanks beforehand, will report after about half an hour | 16:17 |
| T42 | <elros34> that skip_initramfs patch is required, otherwise hybris-boot intrams could not be used | 16:19 |
| rinigus | piggz: I mean that users could use it for fingerprint management, not Sailfish Settings | 16:34 |
| rinigus | @adampigg: as for quirk, we would have to figure out what is causing the reboot, I guess. | 16:35 |
| T42 | <adampigg> Rinigus, the quirk would be to only allow adding one finger | 16:40 |
| rinigus | @adampigg: that's assuming it goes bad somewhere below the daemon. from the logs, I don't see even enroll being called | 16:51 |
| rinigus | ... but I would say its not critical as there is a workaround. | 16:52 |
| rinigus | in terms of using other software | 16:52 |
| rinigus | btw, on sony, I can use fingerprint to enter gestures. such as sliding the finger is translated into the keyboard's arrow keys (up, down, left, right). all is hooked nicely and can be used in ... terminal! | 16:54 |
| T42 | <adampigg> Rinigus: its all good fun this bringing fp to the porters! | 16:56 |
| rinigus | it is, indeed! | 17:00 |
| rinigus | @adampigg: I'll start then with android rpm bits https://github.com/piggz/sailfish-fpd-community/issues/3 . let's see if I will regret it | 17:02 |
| zinstack | Okay, having progress. Now it's not happy about /system not being mounted. Me too, but I think it's about fixup-mountpoint, am I right? My device is a/b, so there is no specific "by-name/system" partition, they have letters (Wow). I guess there should be one? | 17:48 |
| zinstack | Oh, and I had to touch *_property_contexts files in rootfs to make droid-hal-init go. Bummer that I don't know how to make them appear automatically. Does anybody know? | 17:51 |
| T42 | <elros34> Check whether system.mount system_root.mount in /lib/systemd/system are created and contains /dev/mmcblk or sdx path. About context files, Are you sure you use 3.3.0.16 target and you added them to straggler files? | 17:53 |
| zinstack | @elros34 Well, files exist but they only reference fstab.qcom, that's because I didn't mention "by-name/system" specifically, only system_a and system_b. I didn't touch straggler, but I know what it is now and how to fix it | 17:59 |
| T42 | <elros34> So probably you are using old target otherwise droid-hal will complain about missing files | 18:01 |
| zinstack | No, my target is 3.2.1-19 I think, it's pretty recent I believe | 18:02 |
| T42 | <elros34> latest is 3.3.0.16 and you should use it. Here are my notes for most common issues: http://collabedit.com/kr9xx | 18:04 |
| zinstack | Weird naming scheme or an abandoned branch? This thing is full of surprises | 18:10 |
| zinstack | Oh, and how do I know which straggler files would I need? Is it trial and error? Goodness I hope not | 18:11 |
| zinstack | Also, it appears that my eyesight is declining and I couldn't spot that 3 is bigger than 2. Or is it my sanity? | 18:15 |
| rinigus | @adampigg: Android bits packaged; PR submitted. Will probably stop here for now | 18:55 |
| T42 | <hacker12455> ```* dconf permission issues: | 18:57 |
| T42 | <hacker12455> Regenerate your ks file if you use custome one``` | 18:57 |
| T42 | <hacker12455> so I removed all kickstart files and rebuilt droid-config | 18:57 |
| T42 | <hacker12455> I still get dconf errors with mic | 18:57 |
| T42 | <hacker12455> except I have given address is empty errors | 18:58 |
| rinigus | any gurus: how do we make fingerprint android store as in https://github.com/erfanoabdi/android_device_halium_ubport/commit/eec61015dede9602f4fc6f704d53288a0e431593 | 19:02 |
| rinigus | if we need to mess with init scripts, were do those changes go? or should we make them somehow differenty as suggested by Thaodan in https://github.com/piggz/sailfish-fpd-community/issues/5#issuecomment-636407008 | 19:03 |
| T42 | <Verevka86> @rinigus [any gurus: how do we make fingerprint android …], This? | 19:06 |
| T42 | <Verevka86> https://github.com/SailfishOS-sagit/droid-config-sagit/commit/083a664ba5c36df0f61b364a67bd4fe5eebe150c | 19:06 |
| rinigus | Verevka86: as we need it rather late, maybe systemd would actually work. with its runtime dir support. will see the mans | 19:09 |
| piggz | rinigus: let me get up to speed with the days work, just getting to sit down! | 19:17 |
| rinigus | piggz: enjoy! | 19:24 |
| piggz | rinigus: are you around for comments? | 19:25 |
| rinigus | piggz: yes, for 5-10 mins | 19:34 |
| piggz | just those on the pr | 19:38 |
| rinigus | piggz: replied and going away for some time | 19:40 |
| piggz | rinigus: np, thx | 20:09 |
| rinigus | piggz: readme looks nice! | 20:56 |
| piggz | rinigus: thx, its a start! | 20:56 |
| T42 | <adampigg> @erfanoabdi building the android part on my mido port fails, with error "pre oreo not supported" .... does pre oreo need a different implementation? | 20:57 |
| rinigus | piggz: its late over here, I am off for today | 20:57 |
| piggz | rinigus: ill try and fix a few more packaging bits | 20:57 |
| rinigus | piggz: thanks! | 20:58 |
| Kabouik | @elros34, would you happen to know how one can force landscape orientation using the compositor for a Wayland app? | 21:45 |
| Kabouik | I'm asking you because I know you used some qxwayland tricks for sailfish_chroot, but maybe that would be different for Wayland apps? | 21:45 |
| Kabouik | I'm asking candidly without know much about the details, but I'm trying ot help a dev porting a desktop app to SFOS, and it's stuck to portrait at the moment | 21:46 |
| T42 | <elros34> I am not aware of any way to make lipstick rotate window for you. You need to do it in app itself and update content orientation property (IIRC this is how it's called in qt) so edge swipes works correctly. This is why I make qxcompositor so I could easy rotate xwayland (or any other app) to landscape without modifing sources. | 22:16 |
| T42 | <elros34> Take a look at kodi: it rotates its content to landscape but doesn't update content orientation so swipes are incorrect. Another nother not sillica/qml app is hextool | 22:19 |
| Kabouik | Interesting @elros34, thanks a lot. Did you see ishimaru's question just before in #sailfishos? | 22:28 |
| Kabouik | It's the more accurate question worded by a dev who knows what he is talking about, as opposed to my question | 22:29 |
| Kabouik | For the record, we were trying to force landscape orientation only, not autorotation; perhaps that would make things easier? | 22:31 |
| T42 | <elros34> I rarely use irc. So to sum up AFAIK client needs to rotate rendering | 22:31 |
| Kabouik | <ichimaru> With lipstick, in order to get landscape orientation, does the client app have to rotate all it's rendering? Or is it possible for the compositor to do the transform while the client renders as normal? | 22:32 |
| Kabouik | But I if I understand correctly, that's answer B | 22:32 |
| Kabouik | Erm I meant A | 22:33 |
| Kabouik | I will forward to him your answer elros34, thanks again. | 22:34 |
| T42 | <elros34> yes A or if you need only landscape then lazy way via nested compositor | 22:35 |
| Kabouik | We would only need landscape yes | 22:44 |
| T42 | <ankaos> Elros fixed bootloop | 23:02 |
| T42 | <ankaos> Thanks | 23:02 |
| T42 | <edp_17> @ankaos : What was the reason and how did you solve it? | 23:06 |
| T42 | <ankaos> Ofono service do mask | 23:06 |
| T42 | <ankaos> Ofono service not use | 23:06 |
| T42 | <edp_17> Oh, I thought it was something else. Thanks. | 23:09 |
| T42 | <edp_17> @elros34: Can you give me an example for how I can run a command when an evdev_trace action (certain button press) happens, please? | 23:10 |
| T42 | <edp_17> I know how to do something with a udev rule but I don't know whether that can be used for this or not. (I couldn't make it work with an udev rule bu I might did not do it correctly.) | 23:11 |
| T42 | <ankaos> @edp_17 [Oh, I thought it was something else. Thanks.], otherwise I couldn't look more. | 23:13 |
| T42 | <edp_17> Plus I have a question regarding the bluetooth. If I turn it on and do not do anything, after three minutes, it turns off automatically. Is this normal? | 23:13 |
| T42 | <elros34> udev rules are different thing. Not sure if there is nice way to do this with bash. It's quite easy with qt | 23:14 |
| T42 | <ankaos> @edp_17 [Plus I have a question regarding the bluetooth …], Yes. | 23:14 |
| T42 | <ankaos> This way on Android | 23:14 |
| T42 | <edp_17> @ankaos: I never experienced this on Android. My devices always kept the BT on until I manually turned it off. | 23:16 |
| T42 | <ankaos> Config_bt_sleep | 23:16 |
| T42 | <edp_17> @elros34: Oh boy! Qt? What I would like to achieve was to wake up the screen when I press the home button. | 23:17 |
| T42 | <ankaos> is there anything like this? | 23:17 |
| T42 | <ankaos> My port Bluetooth not work | 23:17 |
| T42 | <edp_17> The evdev-trace shows the action but I don't know how can I trigger the 'mcetool -U' command with it. | 23:18 |
| T42 | <edp_17> @ankaos: I do not have BT_SLEEP in this kernel. | 23:20 |
| T42 | <elros34> Maybe lipstick already support such a thing. I remember there were support for 'back' touch key but not sure whether it was only for android apps or something else. | 23:21 |
| T42 | <edp_17> @elros34: Think I found similar things to what you said. | 23:22 |
| T42 | <edp_17> I have checked /usr/share/lipstick-jolla-home-qt5/compositor.qml and /usr/share/lipstick-jolla-home-qt5/compositor/HardwareKeyHandler.qml but couldn't get closer. | 23:22 |
| T42 | <ankaos> mer-kernel-check/mer_verify_kernel_config at master · mer-hybris/mer-kernel-check · GitHub | 23:23 |
| T42 | <ankaos> https://github.com/mer-hybris/mer-kernel-check/blob/master/mer_verify_kernel_config | 23:23 |
| T42 | <ankaos> Miklos: please look | 23:23 |
| T42 | <edp_17> Plus I have managed to add the tests of the buttons (volume up/down, back and home) into csd and they all work in there. | 23:24 |
| T42 | <edp_17> @ankaos: Thanks, I am aware of this but as I said I don't have this in this kernel. I might need to add though. However it says "Causes problems with bluez thus disabling is recommended.", so I am not sure this is what I need. | 23:26 |
| T42 | <ankaos> I am currently trying to deal with the wlan problem. | 23:27 |
| T42 | <edp_17> What is the problem? | 23:27 |
| T42 | <elros34> @edp_17 maybe this could be useful: https://git.sailfishos.org/mer-core/mce/blob/master/inifiles/evdev.ini | 23:40 |
| T42 | <ankaos> @edp_17 [What is the problem?], wlan module not found. ı dont have wlan.ko | 23:45 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!