| T42 | <adampigg> Theodan,.mal, rinigus, needed for pro1 and pinephone | 07:42 |
|---|---|---|
| rinigus | @adampigg: I would expect pro1 be the same as tama (or very close). now pinephone could be a bit different. maybe you should check on that? | 08:16 |
| T42 | <adampigg> Sure | 08:20 |
| Thaodan | Currently it's broken devices with internal mmc since some shenanigans that udisks2 does it device if an mmc is removable or not. | 11:26 |
| Thaodan | Udisks2 needs to be updated/patched. | 11:26 |
| rinigus | Thaodan: but can't we help udisk2 via its config files? so, the port would include some config to help it out? | 11:35 |
| Thaodan | rinigus: udisk just needs to be updated | 12:03 |
| Thaodan | the kernels handling of what's removable or not has some tuning in udisk2 and newer versions are better in this | 12:04 |
| piggz | rinigus: ping | 15:27 |
| T42 | <Conrad> hey, i am trying to understand the porting and wanted to work on the Z3 compact tablet, which is heavily outdated. however, i even failed with the basics to reproduce the available images. I posted to problem talk.maemo.com | 15:29 |
| T42 | <Conrad> https://talk.maemo.org/showpost.php?p=1571936&postcount=182 | 15:29 |
| T42 | <Conrad> is there anything obvious I miss? | 15:29 |
| rinigus | piggz: pong | 15:48 |
| piggz | rinigus: its fine, sorted :) | 15:49 |
| rinigus | piggz: great! | 15:49 |
| T42 | <elros34> Conrad Try in platform sdk: https://sailfishos.org/wiki/Platform_SDK_Installation. But if you want to work on port than better read whole HADK pdf: https://sailfishos.org/develop/hadk/ | 15:50 |
| T42 | <Conrad> ok, thanks. i will have look | 15:53 |
| Thaodan | b100dian: You don't need to make your custom_data handling so complicated. I changed yours to allign with the one found in https://github.com/sonyxperiadev/vendor-qcom-opensource-vibrator/blob/aosp/LA.UM.7.1.r1/Vibrator.cpp#L100 that works fine. The issues lies elsewhere I think. | 16:46 |
| Thaodan | https://github.com/Thaodan/ngfd/commit/1b3bb1707417b6e3fb84b6749bef2d38e41d232d | 17:04 |
| T42 | <b100dian> Ok with that commit, but you dont't have the two others: moving to heap and fix for dbus request id regression https://github.com/sailfishos-on-tucana/ngfd/commits/master | 17:16 |
| *** mal_ is now known as mal | 17:25 | |
| T42 | <Conrad> So, this sdk which i can install via that tutorial is the basis for the docker Images like the one from coderus? | 17:26 |
| Thaodan | b100dian: the last two can be squashed and the typecasting you do there can be skipped. | 17:42 |
| T42 | <b100dian> Yes, I'll make it more readable once we get it properly working with ngf-qt | 18:17 |
| Thaodan | The erasing is the issue | 18:17 |
| Thaodan | the effect id is wrong then | 18:17 |
| Thaodan | effect id has to match one of the predefined effects during erasew | 18:18 |
| T42 | <b100dian> It happens when the effect is in flight? | 18:18 |
| T42 | <b100dian> I have some local changes for that, but far from perfect. Ill push them tonight for testing | 18:19 |
| T42 | <b100dian> I still wasnt able to.use the custom data [1] output parameter from my driver at least | 18:20 |
| T42 | <b100dian> To set a correct timeout | 18:20 |
| Thaodan | The effect has to be erase after play | 18:22 |
| Thaodan | See here: | 18:23 |
| Thaodan | https://github.com/sonyxperiadev/vendor-qcom-opensource-vibrator/commit/555beb22c2aa8d8b1d209bedb6b00a9780513ebc | 18:23 |
| T42 | <b100dian> That sounds like a good idea | 18:23 |
| Thaodan | So the erase during that is done if the effect is cached always has to be done | 18:23 |
| kquote03[m] | Hello. Now I'm building the RPMs, but i seem to get a weird error when running `rpm/dhd/helpers/build_packages.sh --droid-hal` https://pastebin.com/0PkjT3Y3 | 18:35 |
| kquote03[m] | sdk-assistant lists my target successfully, so idk why it is complaining about that, but more importantly I have no idea why the RPMS folder is empty. | 18:35 |
| kquote03[m] | And another question, is a black screen and an immediate reboot an expected result of flashing hallium-boot on the boot partition of an otherwise standard LOS installation (sorry, i couldn't help my self) | 18:35 |
| Thaodan | /home/kenan1099/hadk/droid-hal-a5y17lte.log check that | 18:36 |
| kquote03[m] | alright | 18:36 |
| Thaodan | Well you should flash hybris boot | 18:37 |
| T42 | <b100dian> Thaodan: I've pushed my working copy to a branch named temp. It adds effects to a queue from where they are erased before playing the next one https://github.com/sailfishos-on-tucana/ngfd/commit/9512cee62b25dbc1a3f04a8a351c65a1a7b32fe7 but I don't see the "reports back %d ms" ever displaying anything else than 0 | 18:37 |
| kquote03[m] | I apologize for my lack of reading comprehension | 18:40 |
| kquote03[m] | now it halts becuase it can't find ~/hadk/installroot/default.prop | 18:42 |
| kquote03[m] | i tried touching ~/hadk/installroot/default.prop, but no dice | 18:43 |
| kquote03[m] | * no dice (anyways seems like a bad idea) | 18:43 |
| Thaodan | post logs there is no help in telling us what it says | 18:44 |
| kquote03[m] | https://pastebin.com/K55c4Jr1 /home/kenan1099/hadk/droid-hal-a5y17lte.log | 18:48 |
| kquote03[m] | <Thaodan> " post logs there is no help in..." <- i feel that im a victim of not being able to straighten a dog's tail. apologies for repeatedly not listening to this advice | 18:50 |
| Thaodan | You have to fix the device config | 18:53 |
| kquote03[m] | you mean the .spec or the local_manifest? | 18:53 |
| Thaodan | $kernel_sources/arch/$arch/configs/$device_defconfig | 18:54 |
| kquote03[m] | ah the kernel config | 18:54 |
| Thaodan | the log says it call | 18:54 |
| kquote03[m] | Thanks for the tip | 18:54 |
| Thaodan | b100dian: tried that branch, it works good except that the vibrations are a little to long | 18:55 |
| Thaodan | It was better before | 18:55 |
| Thaodan | You can declare custom directly as __s16 no need to explicitly cast from int to __s16 | 18:57 |
| Thaodan | @b100dian: Which userspace vibrator software is used for your device? I don't think CUSTOM_DATA_LEN higher then 3 is needed. | 18:59 |
| T42 | <b100dian> That I don't know. I need to study Vibrator.cpp from your links. Of course it can be 3 as is in both our drivers. | 19:02 |
| Thaodan | Vibra erase effect: Invalid argument I hit that sometimes when it tries to erase the effect for a second time. | 19:02 |
| Thaodan | https://github.com/sonyxperiadev/vendor-qcom-opensource-vibrator/blob/aosp/LA.UM.7.1.r1/Vibrator.cpp#L100 | 19:03 |
| Thaodan | here my vibrator cpp | 19:03 |
| T42 | <b100dian> Yes, I'll look there. What is your current status w.r.t the ngfd PR + ngf-qt? MIne, with the 'temp' branch above, is that weak effect on keyboard vibrates 9 out of 10 keystrokes approx. and service is lost in about 1day - so there is some leak still there. | 19:08 |
| Thaodan | Maybe the way you allocate them mem? before no malloc was used. | 19:09 |
| T42 | <b100dian> no, I mean effect leak. but yeah, one idea is to have the custom-data int parsed and stored separatedly and the custo_data be re-inited for each upload instead of once at the beginning for all | 19:12 |
| T42 | <elros34> kquote03[m] comment out /default.prop from droid-hal-device.inc. About reboot, I think it shouldn't happen unless you did not make all needed changes | 19:12 |
| Thaodan | that's why need log: https://paste.opensuse.org/52377267 | 19:15 |
| Thaodan | sometimes I get one erase after another | 19:16 |
| Thaodan | than Vibra erase effect: Invalid argument happens | 19:16 |
| Thaodan | I think for android the custom data is also set each time Play is called | 19:17 |
| Thaodan | https://github.com/sonyxperiadev/vendor-qcom-opensource-vibrator/blob/aosp/LA.UM.7.1.r1/Vibrator.cpp#L80 | 19:18 |
| Thaodan | after rebooting the intensity of each vibration is fine | 19:19 |
| Thaodan | ah they do setup ff_effect each time they play. | 19:20 |
| Thaodan | Is there maybe a race condition in erasing effects? | 19:21 |
| T42 | <b100dian> because I cannot get this to work yet, yes maybe there's a timing race https://github.com/sonyxperiadev/vendor-qcom-opensource-vibrator/blob/aosp/LA.UM.7.1.r1/Vibrator.cpp#L118 | 19:24 |
| Thaodan | what does it do there? From what I read t | 19:26 |
| Thaodan | the effect was played in line 110 | 19:26 |
| Thaodan | can you skip the caching of the effect since it is already stored in the global table after the ini is parsed? | 19:28 |
| T42 | <b100dian> it reads back the milliseconds+useconds the effect will take to play. The data[1] and [2] are reporting that back right after upload | 19:32 |
| T42 | <Rogeriu> hi | 20:20 |
| T42 | <Rogeriu> port for redmi note 8? | 20:20 |
| T42 | <XAP2P> GitHub.com/sailfish-on-ginkgo (re @Rogeriu: port for redmi note ...) | 20:24 |
| T42 | <XAP2P> oh wow | 20:25 |
| T42 | <XAP2P> 4.2 (re @XAP2P: GitHub.com/sailfish-...) | 20:25 |
| T42 | <XAP2P> @birdzhang good job, thx :D (re @XAP2P: 4.2) | 20:25 |
| Thaodan | @b100dian: that's specific to the FF_CUSTOM? | 20:27 |
| T42 | <b100dian> yes | 20:27 |
| Thaodan | Do we need that or no? | 20:28 |
| T42 | <b100dian> since the custom effect is not presenting any duration, it is a good idea to use what is returned as a timer so that effects don't overlap | 20:33 |
| Thaodan | Hm that's a good idea | 20:33 |
| Thaodan | without a waveform its simpler in hardware but more complicated in software I guess | 20:34 |
| T42 | <b100dian> I think I found my error if you take the last commit of https://github.com/sailfishos-on-tucana/ngfd/commits/temp, I though it was ms + usecs, but it is seconds + mseconds actually. I don't seem to get missed vibrations now on the keyboard | 20:34 |
| T42 | <b100dian> yeah, my driver also reads those timings from firmware, so they are not well know beforehand | 20:35 |
| T42 | <b100dian> Thaodan: many things can be refactored as you've alreay shown - the temp branch is only if you want to test this w.i.p. If all goes well after in a couple of days I'll re-write the PR and commits properly | 20:36 |
| Thaodan | Tried your latest commit, it works as good as before just some times effects are erased a second time | 20:45 |
| T42 | <b100dian> I'll try to think why that happens | 21:14 |
| kquote03[m] | hey, I've run into an issue and the log file is very large (verbose.log), may i upload it gzipped on here or using any file hosting service? | 21:15 |
| T42 | <elros34> full output from console is usually enough | 21:36 |
| T42 | <Rogeriu> thanks (re @XAP2P: GitHub.com/sailfish-...) | 22:18 |
| Thaodan | Rinigus: Do you have hdr working with android 10? | 23:26 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!