*** izh79_ is now known as IZh | 07:57 | |
*** IZh is now known as izh79 | 07:57 | |
T42 | <TheVancedGamer> mal: sorry for the ping but I wanted to get back to that gbinder-hidl thing I'm doing | 10:05 |
---|---|---|
T42 | <TheVancedGamer> I did as you said, checked if gbinder_servicemanager_get_service_sync returns a valid pointer, and it does | 10:06 |
T42 | <TheVancedGamer> mal: back again :) | 19:43 |
T42 | <TheVancedGamer> how much bothering would it take to get this pulled into upstream libhybris? :D | 19:43 |
T42 | <TheVancedGamer> https://github.com/Linux-on-droid/libhybris/commit/12815016d4eb0f36219786158537b22f2b7035fa | 19:43 |
T42 | <TheVancedGamer> i'm attempting Halium 14 on Pixel 7 Pro, got container up but now i'm stuck because everything related to hybris complains TLS relocations are not implemented | 19:44 |
mal | @TheVancedGamer you notice the comment in that commit where we asked for it to be upstreamed | 19:46 |
T42 | <TheVancedGamer> yeah | 19:46 |
T42 | <TheVancedGamer> bothering luka now :D | 19:46 |
mal | it would mostly be about squashing those two commits into one since the second one is just a fix to that, and making sure the formatting is ok, for example commit message has a typo now | 19:48 |
mal | but probably quite much of that commit is code picked from android? | 19:49 |
T42 | <TheVancedGamer> about 90-95% of it looks like picked to me? | 19:49 |
T42 | <TheVancedGamer> yeah, almost all of it is drop-in from bionic | 19:50 |
mal | couple of small formatting issues there | 19:51 |
mal | like useless #if 1 stuff (to remove #if 0 we had added before), no reason to have if 1 when it could just be removed | 19:52 |
T42 | <TheVancedGamer> i'll try building it on phone and see if it works | 19:52 |
mal | I have used that on my a14 ports, I need it also | 19:52 |
mal | we have picked the two patches to a testing branch | 19:52 |
mal | some extra whitespace change in hybris/common/q/bionic/libc/private/bionic_tls.h | 19:53 |
T42 | <TheVancedGamer> sounds like it works then :D | 19:53 |
T42 | <TheVancedGamer> @Lukapanio is here actually | 19:54 |
mal | that is why asked to upstreaming, if it's not going to happen soon we'll just pick it ourselves | 19:54 |
T42 | <TheVancedGamer> i pinged luka before too, just waiting for him | 19:55 |
mal | @TheVancedGamer this is the branch I use in my tests https://github.com/mlehtima/libhybris/tree/update_a14 that is the packaging pointing to my fork with the two patches | 19:59 |
T42 | <TheVancedGamer> thanks mal | 20:00 |
mal | I have tested that on 3 a14 devices so far and haven't noticed any issues related to the patches | 20:01 |
T42 | <Lukapanio> i am here :D (re @TheVancedGamer: i pinged luka before...) | 20:44 |
T42 | <Lukapanio> ok ig ill clean up and pr then (re @SailfishFreenodeIRCBridgeBot: <mal>I have tested t...) | 20:44 |
mal | thanks | 20:45 |
T42 | <TheVancedGamer> mal: would it make sense to stub android.frameworks.stats in minimedia? pixel camera HALs want it | 20:46 |
mal | why not | 21:05 |
mal | what provides that usually in android? | 21:05 |
mal | some higher level service? | 21:05 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!