| T42 | <Lukapanio> @mal to review: https://github.com/libhybris/libhybris/pull/560 | 08:03 |
|---|---|---|
| mal | @Lukapanio added some comments about style issues | 10:55 |
| T42 | <adampigg> Classic mal :D | 11:08 |
| mal | sorry :) | 11:11 |
| T42 | <Mister_Magister> code style is very important i'm with mal | 11:34 |
| T42 | <adampigg> I am too, i only jest | 11:35 |
| T42 | <Lukapanio> @mal done | 12:01 |
| T42 | <Lukapanio> also pings in messages from other side of bridge dont work | 12:01 |
| T42 | <Lukapanio> idk why | 12:01 |
| mal | not sure if I want to request fixing one more indentation issue or not | 12:30 |
| T42 | <Lukapanio> where? (re @SailfishFreenodeIRCBridgeBot: <mal>not sure if I w...) | 13:57 |
| mal | linker_soinfo.h | 13:57 |
| T42 | <TheVancedGamer> btw just nudging in, its tls relocation, not reallocation :D | 13:57 |
| mal | oh | 13:57 |
| T42 | <Lukapanio> well i was told to change the name :D (re @TheVancedGamer: btw just nudging in,...) | 13:58 |
| mal | I just thought it had a typo | 13:58 |
| T42 | <TheVancedGamer> it was a typo before | 13:58 |
| mal | @Lukapanio ^ while at it fix the indentation in | 13:59 |
| mal | hybris/common/q/linker_tls.cpp | 13:59 |
| mal | the last change in that file | 13:59 |
| mal | return unregister_tls_module(si); | 13:59 |
| mal | @TheVancedGamer yeah, I somehow misread it what typo it had | 13:59 |
| mal | sorry | 14:01 |
| T42 | <Lukapanio> huh (re @SailfishFreenodeIRCBridgeBot: <mal>linker_soinfo.h) | 14:13 |
| T42 | <Lukapanio> i didnt edit that file except for dropping 1 __unused | 14:13 |
| T42 | <Lukapanio> fixed that one (re @SailfishFreenodeIRCBridgeBot: <mal>return unregist...) | 14:15 |
| mal | @Lukapanio linker_soinfo.h is fine, accidentally paste wrong filename | 14:15 |
| mal | thanks, I think that should be fine now | 14:23 |
| mal | @Lukapanio thanks for for PR, I have now merged it and updating the packaging for sailfish | 15:19 |
| T42 | <Lukapanio> Noice | 15:49 |
| T42 | <ĺáćé> My friends and I ported SFOS to Galaxy J1 2016 LTE (J120F, Exynos 3475, LOS 14.1) : https://irc.thaodan.de/.imgstore/30e53930/file_6426.jpg | 20:29 |
| T42 | <ĺáćé> https://irc.thaodan.de/.imgstore/13001b01/file_6427.jpg | 20:29 |
| T42 | <ĺáćé> https://irc.thaodan.de/.imgstore/35e15130/file_6428.jpg | 20:29 |
| mal | nice | 20:46 |
| T42 | <parmjotsinghrobot> It's username: (re @Lukapanio: also pings in messag...) | 23:13 |
| T42 | <parmjotsinghrobot> Ie parmjotsinghrobot: for me | 23:13 |
| T42 | <parmjotsinghrobot> parmjotsinghrobot: would be an example (edited) | 23:13 |
| T42 | <parmjotsinghrobot> It needs to be at the start though | 23:13 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
