| rinigus | @TheVancedGamer: looking forward to test this PR on nagara/los21 port. in logcat there are lots of messages regarding sensorservice | 05:21 |
|---|---|---|
| T42 | <TheVancedGamer> btw rinigus: does nagara have hwc2 or hwc3? | 05:49 |
| rinigus | @TheVancedGamer: I don't remember. I will be able to check it later tonight. here is hybris that is used on nagara so far: https://github.com/sailfishos-sony-nagara/libhybris/tree/a6f08a5c6b307106987b0560f675b90eae3c2a28 | 05:54 |
| T42 | <NotKit> mal, https://github.com/libhybris/libhybris/pull/577 - could you merge it as well please, I don't have permissions on libhybris group | 11:28 |
| Mister_Magister | my pr too my pr too lmao | 11:29 |
| mal | @NotKit yeah, I will also check that hwc a14 PR | 11:39 |
| mal | that reminds me, I should finally make a PR of my meson build system support for libhybris | 11:40 |
| mal | makes the build files a lot more simple than the old automake files | 11:41 |
| mal | @TheVancedGamer some issues in the droidmedia PR, commented to the PR | 14:37 |
| T42 | <TheVancedGamer> mal, ok thanks. did you get to review the libhybris PR too? | 14:38 |
| mal | I just did a test build of it and some of the other libhybris PRs | 14:39 |
| T42 | <NotKit> yeah, having meson should be nice, automake builds are quite slow as well | 14:39 |
| mal | @TheVancedGamer how does the libhybris issue you fixed show up? | 14:39 |
| mal | memory leak? | 14:40 |
| T42 | <TheVancedGamer> Forwarded from NotKit: ``` | 14:40 |
| T42 | <TheVancedGamer> root@(none):/tmp# test_dlopen | 14:40 |
| T42 | <TheVancedGamer> invalid pointer 0x558ecfd950 (page signature mismatch)Aborted``` | 14:40 |
| mal | ok | 14:40 |
| T42 | <TheVancedGamer> mal: this ^ error, and also a memory leak | 14:40 |
| T42 | <NotKit> mal, libc's malloc/free get shadowed at least for the linker library and that causes issues, presumably when compiler emits free for C++ objects | 14:42 |
| T42 | <TheVancedGamer> I added it in the commit description you t | 14:42 |
| T42 | <TheVancedGamer> too* | 14:42 |
| T42 | <NotKit> the reason it happens on UT and not on Sailfish could be related to compiler flags or similar differences | 14:43 |
| mal | @NotKit some issues in you hwc2 compat PR, fails to build on some older bases, ybris/mw/libhybris/libhybris/compat/hwc2/HidlComposerHal.cpp:1234:56: error: unknown type name 'DisplayCapability'; did you mean 'hardware::graphics::composer::hal::DisplayCapability'? | 15:42 |
| mal | that is with android 10 base | 15:45 |
| mal | @NotKit android 9 base builds fine though | 17:50 |
| T42 | <NotKit> I've tried to make it work on older bases, but need to retest with A10 then | 18:48 |
| mal | @NotKit maybe this needs to be >= 10 https://github.com/libhybris/libhybris/blob/11b9455d1b574aa23e075c7a5044516472a1d6dc/compat/hwc2/ComposerHal.h#L158 the a10 ComposerHal.h had that | 19:39 |
| T42 | <TheVancedGamer> btw mal do you have any idea about registering callbacks for aidl services? | 19:44 |
| T42 | <TheVancedGamer> with the hwc3 patch in that MR I have this issue where registering callbacks works, but I don't actually get any callbacks | 19:44 |
| T42 | <TheVancedGamer> and hwc3 Hal complains with status -129 | 19:44 |
| mal | need to see if any of my aidl things have callbacks | 19:45 |
| mal | maybe not tonight, it's a bit late already | 19:45 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!