| mal | Mister_Magister: do you want to try to make this use just regular grep https://github.com/sailfishos/tzdata-timed/pull/8 if the use is really just those greps | 15:34 |
|---|---|---|
| Mister_Magister | mal: if my mce PR gets merged | 15:49 |
| Mister_Magister | I don't want to spend any more time if it means my work won't get merged, you understand | 15:51 |
| mal | well those are quite unrelated so I don't see much logic in that | 15:53 |
| T42 | <TheVancedGamer> btw mal ping for the aidl stuff :D | 15:54 |
| mal | @TheVancedGamer also reminder about fixing the droidmedia PR | 15:55 |
| T42 | <TheVancedGamer> yeah, just sat down, will fix that | 15:55 |
| T42 | <TheVancedGamer> actually mal, local_shared_libraries adds the includes to aidl for me | 16:02 |
| mal | hmm | 16:02 |
| mal | @TheVancedGamer now I looked at the log more carefully, the problem is the minisf build | 16:05 |
| T42 | <TheVancedGamer> ah | 16:06 |
| mal | those parts of the Android.mk are separated by include $(CLEAR_VARS) | 16:06 |
| T42 | <TheVancedGamer> we don't build minisf in Halium | 16:06 |
| T42 | <TheVancedGamer> maybe that's why I didn't catch it | 16:06 |
| mal | so probably you need to add the same things to both libminisf and minisf builds, I think minisf is quite useless for a14 anyway | 16:06 |
| T42 | <TheVancedGamer> I can add the libraries for minisf too then | 16:06 |
| T42 | <TheVancedGamer> hm | 16:06 |
| T42 | <TheVancedGamer> so do you want to drop minisf? | 16:07 |
| mal | I think for now let's add the things to Android.mk and I can have a look another time about cleaning up things | 16:07 |
| T42 | <TheVancedGamer> okay | 16:09 |
| mal | the problem is this https://github.com/sailfishos/droidmedia/blob/master/detect_build_targets.sh | 16:10 |
| mal | which is used in our builds, it automatically build all of those | 16:10 |
| mal | but I will handle that later | 16:10 |
| T42 | <TheVancedGamer> mal: pushed | 16:12 |
| T42 | <TheVancedGamer> now I would love to fix the composer callbacks on pixel :P | 16:13 |
| mal | I suspect you forgot it from libminisf which also includes services.h | 16:14 |
| T42 | <TheVancedGamer> ofc I did | 16:15 |
| T42 | <TheVancedGamer> lol | 16:15 |
| mal | started a test build now, let's see how it builds | 16:17 |
| T42 | <abranson> Callbacks? Like creating a gbinder local object and giving that to an aidl service? | 16:48 |
| T42 | <TheVancedGamer> well yes but actually no | 16:48 |
| T42 | <TheVancedGamer> callbacks in hwc2_compat aren't working for aidl hwc4 | 16:49 |
| T42 | <TheVancedGamer> callbacks in hwc2_compat aren't working for aidl hwc3 (edited) | 16:49 |
| T42 | <TheVancedGamer> even though it's done exactly like surfaceflinger does | 16:49 |
| T42 | <NotKit> just curious, has it been attempted to mix and match the blobs for Xperia 10 IV/V of different versions? | 16:58 |
| T42 | <NotKit> regarding callbacks, I wonder if it is some kind of missing worker thread issue | 17:00 |
| T42 | <TheVancedGamer> there is only one thread though | 17:00 |
| T42 | <NotKit> callbacks should come from another one | 17:00 |
| T42 | <TheVancedGamer> yeah, hwc3 process sends callbacks to lomiri | 17:01 |
| mal | @NotKit a13 blobs work better on x10iv/v in some ways but worse in other ways, newer a14 blobs need changes to various places | 17:08 |
| T42 | <NotKit> mal, can't we use the camera from A14 and keep the rest? may require some linker and kernel hacks though | 17:09 |
| mal | @TheVancedGamer now that droidmedia PR built without issues, need to test on some device | 17:09 |
| mal | linker hacks would be needed for that | 17:09 |
| T42 | <TheVancedGamer> mal: ok, let me know if it works, also did you get to test the libhybris PR? | 17:11 |
| mal | I did run that libhybris change on x10v and didn't see any regressions based on quick testing | 17:12 |
| T42 | <TheVancedGamer> okay | 17:15 |
| Mister_Magister | mal: my device installs hybris-libsensorfw-qt5-binder while it needs hybris-libsensorfw-qt5-hal, is there anything i'm doing wrong in patterns? https://github.com/VerdandiTeam/droid-config-victara/blob/master/patterns/patterns-sailfish-device-adaptation-victara.inc#L22 | 20:06 |
| Mister_Magister | also it installs binder ofono configs while i'd rather not cause its not working either | 20:06 |
| mal | Requires: hybris-libsensorfw-qt5-hal like done here https://github.com/mer-hybris/droid-config-f5121/blob/master/patterns/patterns-sailfish-device-adaptation-f512x.inc#L19C11-L19C37 | 20:09 |
| Mister_Magister | as i thought but I was confused because my second device https://github.com/VerdandiTeam/droid-config-titan/blob/master/patterns/patterns-sailfish-device-adaptation-titan.inc#L23 doesn't have -hal but installs -hal | 20:09 |
| mal | if you don't have -hal build can install random one of those | 20:10 |
| mal | if both are available | 20:10 |
| Mister_Magister | hm okay | 20:10 |
| Mister_Magister | and how about ofono configs? the second device provides its own so the issue doesn't exist | 20:11 |
| mal | so if you use -hal then patterns always should have just so it forces correct version always | 20:11 |
| mal | what ofono config issue? | 20:11 |
| Mister_Magister | it uses binder instead of ril config | 20:11 |
| Mister_Magister | https://github.com/mer-hybris/droid-hal-configs/blob/fa339dea81aa201d4e6ac808836e85a650b8d37b/sparse/etc/ofono/binder.conf so this | 20:12 |
| Mister_Magister | while it should use this https://github.com/mer-hybris/droid-hal-configs/blob/fa339dea81aa201d4e6ac808836e85a650b8d37b/sparse-10/etc/ofono/ril_subscription.conf | 20:12 |
| Mister_Magister | default sparse uses binder but my android is like android 5 iirc | 20:13 |
| mal | didn't quite get it, so that device uses ril plugin? | 20:13 |
| Mister_Magister | so it picks default one | 20:13 |
| Mister_Magister | yes | 20:13 |
| Mister_Magister | but because it doesn't have android 10 or newer it uses default one which is binder at least thats my understnading | 20:14 |
| Mister_Magister | its using lineage-13 which at that point was still cm | 20:14 |
| mal | ofono-configs-mer which afaik gets installed by default, you can remove the binder configs (which are useless for you) in delete_file.list | 20:16 |
| mal | that of course when you don't have stuff like this in spec https://github.com/mer-hybris/droid-config-f5121/blob/master/droid-config-common.inc#L15 | 20:16 |
| Mister_Magister | yeah i have that on my dualsism device thats why its not a problem there | 20:17 |
| Mister_Magister | so i can't make it provide ril_subscriptions? | 20:17 |
| Mister_Magister | unless i put them myself? | 20:17 |
| mal | you need some custom confif or not? | 20:17 |
| Mister_Magister | nope | 20:17 |
| Mister_Magister | default one does just fine | 20:17 |
| Mister_Magister | thats why i don't want binder and don't want override it either | 20:18 |
| mal | so the ofono-configs-mer is not enough? | 20:18 |
| Mister_Magister | just removing all the configs you mean? | 20:18 |
| mal | no | 20:18 |
| mal | the package ofono-configs-mer which gets installed if you don't provide ofono-configs in droid-config spec | 20:18 |
| Mister_Magister | ah it provides both binder and ril_subscriptions which is quite wierd as ril_subscriptions was missing on my device | 20:19 |
| mal | what? | 20:19 |
| mal | https://github.com/mer-hybris/ofono-ril-plugin/blob/master/rpm/ofono-ril-plugin.spec#L66C11-L66C28 | 20:19 |
| mal | which ofono plugin do you have installed? | 20:20 |
| Mister_Magister | ofono-ril-plugin | 20:20 |
| mal | so that ofono-configs-mer doesn't get installed? | 20:21 |
| Mister_Magister | nope | 20:21 |
| mal | what device are you talking about? | 20:22 |
| Mister_Magister | moto x 2014, victara | 20:23 |
| mal | but it has custom ofono config | 20:23 |
| mal | I don't understand what problem you have | 20:23 |
| Mister_Magister | tbh, now i'm as confused as you are | 20:23 |
| Mister_Magister | well anyway i'll figure it out | 20:24 |
| mal | if you want to remove the binder config just add suitable delete_file.list file | 20:25 |
| Mister_Magister | oki thanks | 20:25 |
| mal | here is an example (for binder device) https://github.com/mlehtima/droid-config-fp5/blob/master/delete_file.list | 20:25 |
| Mister_Magister | thankies | 20:25 |
| Mister_Magister | now mce pr plz thanks | 20:26 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!