| T42 | <elros34> just check same things as for previou device: compare backports .config with modules you have build | 00:03 |
|---|---|---|
| T42 | <edp_17> Thanks. I'll compare with the previous sfos version (4.4). BT is working on it. | 00:07 |
| T42 | <elros34> no, check current backports .config file and all built modules from backports ( better do build manually because make backports will probably move .ko files to out/) | 00:11 |
| T42 | <edp_17> This logs shows what modules the backports built: https://paste.ubuntu.com/p/W2h9kjwDgk/ | 00:13 |
| T42 | <elros34> I don't trust log, use find/ls. does .config really have only these few enabled? | 00:28 |
| T42 | <edp_17> Here is bluetooth defconfig: https://paste.ubuntu.com/p/f3kKpxwYt7/ | 00:31 |
| T42 | <edp_17> Only those flags are there. | 00:31 |
| T42 | <elros34> .config != defconfig | 00:32 |
| T42 | <edp_17> I know: https://paste.ubuntu.com/p/rxQDWSxRKK/ | 00:32 |
| T42 | <edp_17> And the full .config (from backports): https://paste.ubuntu.com/p/KtzjhsZpQR/ | 00:33 |
| T42 | <edp_17> I am sure those drivers on device are from kernel and not from backports. | 00:33 |
| T42 | <elros34> what if you clean out .config and "make * bluetooth" does it produce some info? | 00:36 |
| T42 | <elros34> "make * defconfig-bluetooth" | 00:37 |
| T42 | <edp_17> It failed: https://paste.ubuntu.com/p/KKspGbPWwg/ | 00:39 |
| T42 | <edp_17> Thanks for your support today, I'll continue later. | 00:40 |
| T42 | <edp_17> Have a nice night/day. | 00:40 |
| T42 | <elros34> I was too lazy to write all the neede args, by * I mean ARCH= CROSS_COMPIILE and so on. Anyway see ya | 00:43 |
| T42 | <edp_17> Oh, I see. That is one of the makes command you gave me last time. It was too late for me to think and remember. I'll continue when have time. Thanks. | 06:56 |
| rinigus | b100dian and mal : morning! making progress with aidl volte - can accept calls now and they work | 07:58 |
| rinigus | would have to figure out why call decline is not working | 07:58 |
| *** poetaster is now known as Guest22772 | 08:27 | |
| rinigus | OK, qti_ims_call_hangup is not implemented | 09:24 |
| rinigus | to gbinder experts: how I am expected to write AIDL parcelables? I can see that we have gbinder_writer_append_parcelable to dump data buffer. which would work if my struct is fixed length. what about if it with strings? | 11:40 |
| rinigus | do we have a way where I can compose parcelable via regular gbinder write functions (int32, string, ...), get data pointer and then add via gbinder_writer_append_parcelable to another writer? | 11:41 |
| mal | what are you trying to write? | 11:44 |
| rinigus | mal: right now testing whether parcelable would work for answering the call. somehow (magically?), just writing 3 int32 into writer is read by qcom lib correctly. it seems like it should be AnswerRequest parcelable instead. | 11:50 |
| rinigus | code where its written without parcelable: https://github.com/rinigus/ofono-binder-plugin-ext-qti/blob/main/src/qti_radio_ext.c#L1124 | 11:50 |
| rinigus | hower, I am preparing for handling hangup but testing on whats working now | 11:51 |
| T42 | <abranson> parcelables are just chains of values, but start by printing the constructor java class name that would be used to reassemble them on the other side. that class will contain the serializing and deserializing code, so the android source is the best place to see what you need to write. | 11:58 |
| rinigus | @abranson: that's right. so, for ims we don't really have sources and I have smali decompiled apk instead. and I can on SFOS side read them nicely (well, not super convenient, but OK) | 12:01 |
| rinigus | but writing parcelable is more complicated if you have strings in it. suddenly I can't just use gbinder_writer_append_parcelable with the struct, but have to compose elements into buffer myself | 12:02 |
| rinigus | which is something I guess the writer is doing. so, hence the question - is there a way to compose such dynamic struct via writing its elements and then add as parcelable to "real" writer | 12:02 |
| mal | manually writing parcelable as values is simple, my aidl codes have plenty of example | 12:03 |
| rinigus | mal: do you pre-calculate the size then? | 12:04 |
| mal | rinigus: check my codes in various places, ofono-binder-plugin or any other, I overwrite the size after writing everything | 12:05 |
| rinigus | example struct to hangup int, int, string, CallFailCauseResponse, bool | 12:05 |
| rinigus | mal: that's the way android is doing as well. will look for it, thanks! | 12:05 |
| mal | rinigus: https://github.com/mer-hybris/ofono-binder-plugin/blob/master/src/binder_network.c#L1337 | 12:06 |
| mal | that even has comments where it writes dummy size and where it overwrites the size at the end | 12:08 |
| mal | I do in few cases precalculate size if it's just basic types like a couple of integers etc | 12:10 |
| mal | but for anything more complex I usually replace the size | 12:10 |
| rinigus | thank you very much! its exactly what's needed | 12:10 |
| rinigus | mal: do you also have to correct values of many constants when going from hidl to aidl ims? quite a few are shifted by one in my case | 12:12 |
| mal | that is a bit problematic | 12:13 |
| mal | there were some conversion things in the apk | 12:13 |
| rinigus | I may have missed the conversions. which one do you keep in mind? | 12:14 |
| rinigus | in my case, for example, CallType voice was 0 in hidl and 1 in aidl | 12:16 |
| mal | there is is that CallType defined nicely in one java file | 12:18 |
| rinigus | mal: yes, that's where I took AIDL value from | 12:19 |
| mal | same for the others also | 12:19 |
| rinigus | I just wonder how it worked for HIDL before. and as you have working hidl code, I wonder if you had to make similar changes for aidl | 12:20 |
| mal | yeah, need to convert things, well depends on how you are doing the changes | 12:20 |
| mal | if you do completely new plugin or add to existing one | 12:21 |
| rinigus | mal: right now, dropping hidl and going for aidl only. later will discuss with ofono-binder-plugin-ext-qti devs on how to merge it. | 12:21 |
| rinigus | I do wonder where do they hang out... | 12:21 |
| rinigus | as for now, trying to get it working first | 12:22 |
| mal | I'm trying to debug that video playback issue on devices using c2 codecs | 12:22 |
| mal | I want that to be working before enabling video recording on fp5 | 12:22 |
| rinigus | well, video recording is handy even if there is issue with playback. btw, in browser on nagara that recorded video plays just fine | 12:36 |
| mal | same on fp5, very odd | 12:39 |
| mal | well, it plays better but not great | 12:40 |
| mal | still hangs sometimes | 12:40 |
| rinigus | fingers crossed you fix it - we will surely all benefit. | 13:18 |
| rinigus | mal: in hangup call, do you fill connUri or does it work without it just fine? will test without soon - just was curious if you had to specify it | 13:19 |
| rinigus | (cutting corners by asking you) | 13:19 |
| mal | well I haven't been able to test my changes properly yet since I can't get registration to happen | 13:20 |
| rinigus | mal: hmm, weird. for me registration works fine. do you want to test with OSS plugin? aidl branch at https://github.com/rinigus/ofono-binder-plugin-ext-qti should register, support the calling to it, and accepting calls | 13:23 |
| mal | yeah, I could try with that | 13:25 |
| mal | not right now but a bit later today, need to take a break | 13:26 |
| rinigus | enjoy the break! | 13:29 |
| mal | rinigus: btw, could you rebase that aidl branch, it had some changes missing, the removal of libhybris build requirement | 15:14 |
| rinigus | mal: strange, will check | 15:46 |
| rinigus | mal: indeed - done and force pushed | 15:49 |
| mal | rinigus: I haven't had luck getting ims registered yet, even with your code | 15:54 |
| mal | must be some issue in the device | 15:54 |
| mal | ims:imsradio0: QtiRadioRegInfo state:2 radiotech:16 error_code:0 datasz: 32 | 15:54 |
| rinigus | or some difference in ims. | 15:54 |
| mal | some android side issue probably | 15:55 |
| rinigus | mal: does it work on sodp? | 15:55 |
| mal | I had trouble even there | 15:55 |
| mal | maybe something is missing in the aidl stuff there | 15:56 |
| rinigus | then no wonder its failing on sfos | 15:56 |
| rinigus | issue in their repo? | 15:56 |
| mal | I reported it directly via other way | 15:57 |
| rinigus | let's hope they will fix it | 15:58 |
| mal | yeah | 15:59 |
| mal | fp6 lineage is not yet ready so that limits a bit getting that running | 15:59 |
| mal | fun that there are no errors in logs about ims | 16:11 |
| rinigus | errors are minimal, indeed. not getting any errors on calling hangup either + nothing happens there too. | 16:36 |
| mal | I'll go back to video debugging | 16:38 |
| rinigus | good luck! | 16:40 |
| mal | something odd in the QoS things during playback | 17:55 |
| Mister_Magister | odd is my mce pr not being merged yet | 17:59 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!