| *** frinring_ is now known as frinring | 02:57 | |
| dcaliste | Hello chriadam_, how are you ? Thanks for staging the correction in QMF. | 08:02 |
|---|---|---|
| chriadam_ | dcaliste: doing ok, better than the last two days (neck issues). sorry for not being available on Tuesday. | 08:03 |
| chriadam_ | no problem, thank you for spotting that and fixing it :-) | 08:03 |
| dcaliste | No problem, I was testing the full stack before leaving for vacation and notice that sent email was not acting properly any more. So many packages are involved that I didn't notice the regression. | 08:04 |
| chriadam_ | :-) | 08:05 |
| dcaliste | I'm now testing the packaging of latest QMF in mer-core, see https://git.merproject.org/mer-core/messagingframework/merge_requests/18 Compilation is almost finished. I'll then copy and install packages on device and test. | 08:07 |
| chriadam_ | sounds good :-) | 08:08 |
| dcaliste | About the threading issues in nemo-qml-plugin-email, the deep-copy looks not so "deep" after all. The attachment are created as LongString(filename) which do not map the attchment content into memory as long as the content is not needed. | 08:09 |
| dcaliste | So first deep copy (before running the thread) is light. | 08:09 |
| dcaliste | The second deep copy (returning from thread after signature process) will have the attchment content into memory though. | 08:10 |
| dcaliste | But this content is necessary for the signature process anyway. | 08:10 |
| chriadam_ | right | 08:14 |
| chriadam_ | well, which attachment content? | 08:14 |
| chriadam_ | just the new signature data (as a new attachment)? or all the existing attachments (e.g. if images are there, could be expensive) | 08:15 |
| dcaliste | The signature is done for attchment also, to guarantee that attchments are pristine. | 08:15 |
| dcaliste | Well, in fact we can sign just the text part if we want, but the common behaviour is to sign all parts. | 08:15 |
| chriadam_ | but it shouldn't need to _modify_ the attachments, should it? it just calculates a signature for that data? | 08:15 |
| dcaliste | Including attchments like images. | 08:16 |
| chriadam_ | so a deep copy shouldn't be required in that case, since nothing is being modified? or maybe I'm misunderstanding | 08:16 |
| dcaliste | Yes, the attchments are not modified. | 08:16 |
| dcaliste | What is modified is the structure of the mail… | 08:16 |
| chriadam_ | ah | 08:17 |
| dcaliste | You come with {multipart/mixed 1. body 2. image1 3. image2} and should go out with {multipart/signed 1.{multipart/mixed …} 2. signature data}. | 08:17 |
| chriadam_ | I see | 08:17 |
| dcaliste | So the QMailMessage is indeed in/out in the process. | 08:18 |
| chriadam_ | I still wonder if that will cause a deep copy of the actual attachment data, or just the QMailMessage object | 08:18 |
| chriadam_ | if it's the latter, the cost is negligible | 08:18 |
| chriadam__ | sorry, my internet has been flaky | 08:20 |
| chriadam__ | dcaliste: it's fine in any case. let's not get too concerned about it until it proves a problem in practice | 08:21 |
| dcaliste | I'm looking into longstring.cpp in QMF to see how the deep copy affects mapped files. | 08:21 |
| dcaliste | Indeed, the copy operator will create a new private structure which will setup the filename without actually copying the data. | 08:25 |
| chriadam__ | brilliant | 08:26 |
| dcaliste | chriadam__: From my understanding, deep copying QMailMessage with attchments should not copy the actual content of attchments even when already mapped to memory, but just copy the filenames. | 08:26 |
| dcaliste | Which looks great for our case. | 08:26 |
| chriadam__ | yep, perfect | 08:26 |
| chriadam__ | thanks for checking that one | 08:27 |
| dcaliste | So thank you for pointing me the possible threading issue. Now verification and singnature processes should be properly independant of main thread behaviour. | 08:28 |
| dcaliste | This will be particularly relevant with S/MIME which is much slower than OpenPGP. | 08:28 |
| chriadam__ | great | 08:30 |
| chriadam__ | thanks for fixing the signal connection race issue in secrets too! | 08:31 |
| chriadam__ | (had a comment there regarding the commit message, if possible to fix that one) | 08:31 |
| chriadam__ | but that was a very good catch | 08:31 |
| dcaliste | I've corrected the commit message and added the bug id. | 08:31 |
| dcaliste | Well, I didn't know about QtConcurrent, so when you suggested it for nemo-qml-plugin-email, I read the doc and look at how it was used in secrets. | 08:32 |
| dcaliste | chriadam__: ok, mer-core packaging of latest QMF is working as expected when signing and verifying OpenPGP emails, tested on device with the full stack in email app. | 08:40 |
| chriadam__ | somehow I managed to miss the doc about signal connection race ;-) thanks for pointing that one out | 08:40 |
| chriadam__ | nice one | 08:40 |
| * chriadam__ heads home - will merge the secrets PR tomorrow | 08:45 | |
| chriadam__ | let me know if there's anything else which is blocked waiting for my action :-) | 08:45 |
| dcaliste | chriadam__: sure thanks. Have a nice evening. | 08:45 |
| chriadam__ | you too, thanks again | 08:45 |
| dcaliste | chriadam__, you or pvuorela should approve https://git.merproject.org/mer-core/messagingframework/merge_requests/18 if you think it's fine like that. | 08:46 |
| chriadam__ | pvuorela_: ^^ I can check that one tomorrow also. need to test that jolla-email still works without any changes I guess / existing accounts etc. | 08:47 |
| dcaliste | chriadam__: yes, we can continue this discussion tomorrow. | 08:48 |
| chriadam__ | thanks :-) gnight | 08:49 |
| pvuorela_ | dcaliste: yea, appears ok to me, but i haven't been looking at the full set of changes that much. | 08:51 |
| dcaliste | pvuorela_: thanks for the previous MR, cleaning up a bit the account patch. I've rebased mine on this and I'm now using git formatted patch. | 08:51 |
| pvuorela_ | good good. | 08:52 |
| pvuorela_ | hey, i also did some small adjustment to your eigen packaging and removed the eigen2 parts from git history: https://git.merproject.org/pvuorela/eigen3 | 08:52 |
| pvuorela_ | need to bug people to create mer repo etc. | 08:53 |
| dcaliste | ;) great ! | 08:54 |
| dcaliste | I'll go back to work on Calligra more often when PGP stuff are in. | 08:54 |
| dcaliste | But I'll give a look indeed to your eigen3 stuff. When it's officially in, I'll update the calligra-bundle spec file. | 08:55 |
| dcaliste | Besides, I fully agree that switching to git format patch should be nicer there also… | 08:55 |
| dcaliste | I'll follow also your advice to use #fidef instead of comments to remove unsupported parts from Calligra sources. | 08:56 |
| pvuorela_ | good :) | 08:56 |
| martinst11 | Hi all. I'm currently writing a sailfish-app and having some trouble (I'm too stupid for QML...). What I would like to have as an initial page is a Page that looks like a dialog. But where I can open a dialog by swiping to the left (adding a new filter to a search-query) and swipe right for moving forward (triggering the search with all filters). Somehow I can't figure out how to do that. A dialog as an initial page seems not | 10:34 |
| r0kk3rz | yeah you need to have a backing page for a dialog | 10:47 |
| leszek | martinst11: never saw a dialog as initial page. You need a page object as "initial page" :) | 10:47 |
| martinst11 | It should only "look like" a Dialog. But I maybe could push a Dialog-object on the stack in front of the initial page. And then re-add a new one after the current dialog closed | 10:49 |
| martinst11 | Hm, there doesn't seem to be a clean way to do this (there is no insert-function for the pagestack). OK, maybe I have to resort to a button for opening the dialog (would have been nice without one though) | 11:01 |
| kimmoli | sailfish-communi does something like this, it starts showing a dialog where it asks which servers to connect | 11:16 |
| martinst11 | Had a quick look into that. I'm afraid what they are doing is a bit out of my league ;) | 11:31 |
| Mister_Magister | sooo can we block calls or this super advanced option didnt arrived to sfos yet | 13:06 |
| Mister_Magister | did they just… updated aliendalvik to 8.1? | 16:34 |
| leszek | Mister_Magister: plan to update AD on XA2 to 8.1 | 16:43 |
| Mister_Magister | hmmm | 16:44 |
| leszek | it won't be backported to X or earlier devices as it needs restructioring | 16:44 |
| * Mister_Magister just watching video | 16:44 | |
| Mister_Magister | kinda sucks | 16:44 |
| Mister_Magister | they could just go for anbox | 16:44 |
| leszek | that would mean start at level 0 again. But yeah open and free software I also would prefer for this. However we don't know how much they paid for AD | 16:45 |
| Mister_Magister | but free trial is nice | 16:45 |
| Mister_Magister | my friend with xperia x compact will be able to update sfos | 16:45 |
| Mister_Magister | leszek: i just sent sami a congrats SMS :P | 17:02 |
| leszek | :) | 17:06 |
| * Mister_Magister wonders if he still has this number its finland one so i suppose | 17:07 | |
| leszek | pushAttached is broken for me. It does nothing when I pop from a page that had an attachedPage | 17:17 |
| Mister_Magister | leszek: whatcha mean | 17:20 |
| Mister_Magister | pushattached stays attached only when you push further | 17:21 |
| leszek | Mister_Magister: this does not work when return from the video player page: https://github.com/llelectronics/videoPlayer/blob/master/qml/pages/fileman/OpenDialog.qml#L47 | 17:22 |
| Mister_Magister | leszek: pushAttached stays attached only when you push further iirc | 17:22 |
| Mister_Magister | test behaviour in components qt5 | 17:23 |
| leszek | Mister_Magister: I don't see an error in my code | 17:23 |
| Mister_Magister | leszek: just check behaviour | 17:23 |
| Mister_Magister | if its supposed to stay | 17:23 |
| Mister_Magister | or whatcha mean | 17:23 |
| Mister_Magister | leszek: you mean its not pushed? | 17:25 |
| leszek | thats what I mean | 17:26 |
| Mister_Magister | do debug like webdev | 17:26 |
| leszek | it isn't pushed and it should be pushed | 17:26 |
| Mister_Magister | put console.log next to it | 17:26 |
| Mister_Magister | check if its even running | 17:26 |
| leszek | it is running | 17:26 |
| leszek | it is jumping into the if | 17:26 |
| Mister_Magister | well shit | 17:27 |
| leszek | yeah I fear it has something to do that I pop a page that has its own attachedPage | 17:28 |
| Mister_Magister | Welcome to JavaScript world | 17:29 |
| leszek | :P | 17:29 |
| Mister_Magister | leszek: i would do super simple app with one page and pushing page like that to just check if its supposed to work | 17:30 |
| leszek | pushAttached in general is working | 17:30 |
| leszek | and also in webcat this exact function is working | 17:31 |
| leszek | the only difference is that I am now popping from a page which has an attached page | 17:31 |
| Mister_Magister | leszek: i mean app for this behaviour | 17:31 |
| Mister_Magister | pushing attached page when going back from page with attached page | 17:31 |
| Mister_Magister | simple app to test it thats what i would du | 17:32 |
| Mister_Magister | do* | 17:32 |
| Mister_Magister | but thats just me | 17:32 |
| leszek | my lazyness is trying to fix it somehow with strange workarounds | 17:39 |
| leszek | oh god damn it found the error. Mister_Magister actually I am just stupid as fuck :P | 17:51 |
| Mister_Magister | leszek: hmm? | 17:52 |
| * Mister_Magister no he isnt updatig every port to 3.0 nao | 17:52 | |
| leszek | Mister_Magister: https://github.com/llelectronics/videoPlayer/blob/master/qml/pages/videoPlayer.qml#L90 | 17:53 |
| Mister_Magister | und? | 17:53 |
| leszek | that gets called and removes my pushAttached page | 17:54 |
| Mister_Magister | you just pop before leave | 17:54 |
| Mister_Magister | thats rather obvious thing to do but i would check if it werks without doing it | 17:54 |
| Mister_Magister | but das just me | 17:55 |
| leszek | Mister_Magister: it works after removing it. Though a bit strange. It shows the popped Page from the videoPlayer :P | 17:56 |
| Mister_Magister | dunno whatcha mean but okay | 17:56 |
| leszek | I am confused | 17:59 |
| martonmiklos | hi all! | 21:28 |
| martonmiklos | I am working on this QML plugin | 21:28 |
| martonmiklos | https://github.com/martonmiklos/harbour-sms-share-plugin/tree/master/vcardserializer | 21:28 |
| martonmiklos | but I cannot get it use in QML any way | 21:28 |
| martonmiklos | I got Cannot assign to non-existent property "vCardSerializer" | 21:28 |
| martonmiklos | when I declare an item from it with vCardSerializer { id: id_vCardSerializer } | 21:29 |
| martonmiklos | in QML | 21:29 |
| martonmiklos | the plugin's registerTypes and initializeEngine got called | 21:29 |
| martonmiklos | so I think my library file is in the correct place | 21:29 |
| martonmiklos | any idea would be welcome | 21:30 |
| jef91 | I'm using the pre release of SailfishX on my Xperia and since upgrading my audio and video are desynced on android apps like YouTube and Hulu | 23:23 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!