*** zbenjamin_ is now known as zbenjamin | 01:46 | |
*** frinring_ is now known as frinring | 02:06 | |
*** Renault_ is now known as Renault | 05:26 | |
chriadam | dcaliste: sorry I'm late, am in meeting with jpetrell and lost trakc of time | 07:16 |
---|---|---|
dcaliste | Hello chriadam: no problem I understand you can be busy! | 07:17 |
chriadam | I hope your week went well! | 07:17 |
chriadam | saw that you investigated already the exdate issue - thanks for that. I haven't had a chance to review your PR yet | 07:17 |
dcaliste | Your investigations about the storage of rdates were right, the date should not be saved with a time zone. | 07:18 |
dcaliste | I've explained in the MR discussion why it is currently like that. It's not that trivial. | 07:19 |
dcaliste | The correction can be done in two places: | 07:19 |
dcaliste | * in nemo-qml-plugin-calendar, just before calling addExDateTime(recid), by expurging recid of its timezone when the incidence is full day; | 07:20 |
dcaliste | * or in mkcal when saving exdatetimes by removing the time zone also under the same circumstances. | 07:20 |
dcaliste | I'm proposing the later, because like that if it happens somewhere ezlse that addExDateTime() is called with a timezone, it is catched anyway, but the patch itself is ugly in mkcal. | 07:21 |
chriadam | I see | 07:28 |
chriadam | I guess we (pvuorela and I) need to investigate this in more detail | 07:29 |
chriadam | but I agree that the more general solution is probably correct | 07:29 |
chriadam | I wonder if there are use-cases where you definitely DO want to store the tz for an all-day exdate? hmm. | 07:30 |
chriadam | e.g. show some all-day event in all timezones except some specific timezone (e.g. to handle some regional holiday exemption or something) | 07:30 |
dcaliste | A full-day event with a time zone would mean that this event is schedule at a specific time and thus is fuill-day only for this tz. In that case, it is not a full-day event in the sense of date only, but an event that starts at 00:00+xx and finishes at 23:59:59+xx | 07:32 |
dcaliste | I think, it's easier to think in term of iCal format. | 07:32 |
dcaliste | In iCal a full-day event is given by DTSTART:20190625 with no time. | 07:33 |
dcaliste | So a full-day event would not appends at the same time depending on your tz, but only at the same date. | 07:34 |
chriadam | right, I agree. just wondering how you might say "this recurring holiday occurs every year on day XYZ, but if you're in timezone ABC don't show it in calendar". I guess that's not exdates anyway, so I'm probably just confusing the issue. | 07:34 |
chriadam | I poked jpetrell about your jolla-settings-accounts PR for email folder sync again | 07:36 |
chriadam | he said that he's super busy this week with contract discussions, and then goes on vacation for two weeks, so no promises that he will get a chance to look at that one before he gets back from vacation | 07:36 |
chriadam | but definitely when he gets back we'll get that one properly reviewed and integrated. sorry for the delay there | 07:37 |
dcaliste | About the folder sync MR, thank you. It's not in a hurry, no problem. | 07:37 |
dcaliste | I've more or less the same time schedule. I'll be here next Tuesday, but after that I'm leaving for summer vacation for three weeks. | 07:38 |
chriadam | ok, sounds good :-) I hope you have a great vacation | 07:38 |
chriadam | hopefully we can get your mkcal PR integrated by next week | 07:39 |
chriadam | and can discuss again the trigger-sync-per-account one with pekka | 07:39 |
dcaliste | Ah nice! | 07:39 |
dcaliste | About the small fix for GPG missing public key you merged last week, do you plan to push it in a upgrade-3.1 branch? | 07:40 |
chriadam | dcaliste: did I not already? | 07:42 |
chriadam | let me double check | 07:42 |
chriadam | it's in 3.1.0.56 devel | 07:43 |
chriadam | I guess I webhooked it without creating an upgrade-3.1.0 branch, but it's definitely in the appropriate 3.1.0 release | 07:43 |
dcaliste | Ah good, I didn't see the upgrade something branch, that's why. Thank you very much indeed. | 07:44 |
dcaliste | I have one question also about this TJC bug: https://together.jolla.com/question/208236/bug-e-mail-no-recipient-on-reply-after-editing/ it is related to an issue in sailfish-contacts RecipientField.qml | 07:45 |
dcaliste | The summary property is not updated before there is a focus out, which makes typed in addresses not taken into account when pulling down. | 07:46 |
chriadam | ah | 07:46 |
dcaliste | pvuorela dealed with such PR in jolla-email recently I think, but it was not considered a proper fix but just a work around. | 07:46 |
dcaliste | see https://bitbucket.org/jolla/ui-jolla-email/pull-requests/440 | 07:47 |
chriadam | we should fix that properly, by emitting change signals when appropriate etc | 07:47 |
dcaliste | May I get access to sailfish-component-contacts so I can give a look to this? | 07:48 |
dcaliste | I think that the fix indeed should go to RecipientField.qml and not be a work around in jolla-email. | 07:49 |
chriadam | dcaliste: I think so, please ping jpetrell about that one | 07:49 |
dcaliste | Ok, as soon as I can find him around. I know he's super busy! | 07:50 |
chriadam | I asked him in my other meeting, but he might not get around to that tonight | 07:50 |
dcaliste | Sure, thank you. | 07:51 |
chriadam | not sure if anyone has had a chance to check your sailfish-office change yet either | 07:55 |
chriadam | again I suspect that one might have to wait until jpetrell gets back from vacation, unfortunately | 07:55 |
dcaliste | jpetrell indeed looked at the small MR in office and he agreed. But it was not merged already, maybe waiting for pvuorela agreement also. | 07:59 |
chriadam | ah true | 08:00 |
chriadam | cool | 08:00 |
chriadam | were there any other PRs outstanding which we need to review or discuss? | 08:00 |
chriadam | obviously there is the caldav ones which are in my queue | 08:00 |
chriadam | but won't get a chance to look at those this week unfortunately | 08:01 |
dcaliste | No, it's ok, I'm still working on the KF5 move. The fact that QDateTime is not storing anymore ClockTime makes many things to change. | 08:01 |
chriadam | true, no doubt lots of parts affected | 08:03 |
chriadam | is QDateTime sufficient, according to your current understanding? | 08:03 |
chriadam | does it support e.g. the ClockTime spec from KDateTime? | 08:04 |
dcaliste | Indeed no, but KCalCore has switched to QDateTime so I'm reading how they handle this. | 08:05 |
chriadam | ok, I'm interested to know that also | 08:05 |
chriadam | thanks for your effort again to help with this work | 08:05 |
chriadam | and indeed drive it | 08:06 |
dcaliste | I'm going to try to add tests corresponding to flypig md document also. I need to discuss a bit with him to understand exactly some point of his investigations. | 08:07 |
dcaliste | But it's a good job he did, quite many interesting corner cases indeed ;) | 08:07 |
chriadam | :-) | 08:13 |
chriadam | ok, I had nothing else - is there anythign else you'd like to discuss? | 08:14 |
dcaliste | No that's great. Have a good week. | 08:15 |
chriadam | thanks - you too :-) | 08:15 |
*** vals_ is now known as tango_ | 14:17 | |
bionade24 | Does someone know the right way to import a TLS/SSL cert. I tried two ways but none worked and I don't know what I did wrong https://blog.jupyter.org/ros-jupyter-b7e82b5e1202 | 15:04 |
bionade24 | Sorry, URL mistake, I ment this TJC thread: https://together.jolla.com/question/208387/proper-way-to-add-certs/ | 15:05 |
kimmoli | do you want it to work with what? browser? | 16:08 |
kimmoli | bionade24: ^ | 16:09 |
bionade24 | kimmoli: With the IRC App from Thaodan. He said it uses System's certificate storage | 18:33 |
kimmoli | https://pastebin.com/QwWjEFPr | 18:36 |
kimmoli | that was what i used to get it working with my app and browser. it is a selfsigned root ca | 18:37 |
bionade24 | kimmoli: Thanks, will try it. | 18:45 |
bionade24 | kimmoli: I alread tried this method, but I have a simple .pem cert. Does it work with those, too? | 18:53 |
kimmoli | dunno, i have the ss root ca which against my server cert is signed | 19:04 |
bionade24 | kimmoli: Do I have to reboot to get it working? | 19:17 |
bionade24 | kimmoli: The cert isn't listed in the settings, is it? | 19:22 |
bionade24 | As I said, the method kimmoli mentioned didn't work for me. The IRC Client and curl are both not recognizing the cert. | 19:47 |
kimmoli | my ca is listed in settings | 19:54 |
bionade24 | kimmoli: Mine isn't so I`ll maybe doing something wrong. http://paste.debian.net/1089222/ | 20:02 |
bionade24 | Has anyone other ideas? What do I wrong or is this caused by the cert? The openssl test just works fine. | 20:31 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!