| *** Konsieur is now known as Kabouik- | 00:50 | |
| *** zbenjamin is now known as Guest22262 | 01:25 | |
| *** zbenjamin_ is now known as zbenjamin | 01:25 | |
| dcaliste | Hello chriadam, how are you ? Would you mind if we start a bit earlier today ? | 06:45 |
|---|---|---|
| chriadam | hi dcaliste, sure no problem | 06:46 |
| chriadam | I'm well thanks, how are you? | 06:46 |
| dcaliste | I'm ok, thank you. Thanks a lot for all the accepted MRs recently, to pvuorela and flypig also. | 06:46 |
| chriadam | glad we could finally get many of those in :-) | 06:47 |
| dcaliste | Yeh, almost none remains, cool. Today will be quick I guess ! | 06:47 |
| chriadam | :-) | 06:48 |
| dcaliste | So let's start with a simple one : https://git.sailfishos.org/mer-core/messagingframework/merge_requests/39 | 06:48 |
| dcaliste | Just about silencing warning messages when inquiring for a mail account from account number and the account does not exist. | 06:49 |
| chriadam | I vaguely remember this one. were there any open questions or concerns about it? ISTR that I had originally thought that it shouldn't be an edit of the existing patch, but pvuorela said he actually prefers that, so that shouldn't block. | 06:50 |
| chriadam | but I don't remember if there was anything else to consider | 06:51 |
| dcaliste | flypig asked me to add %autosetup to avoid calling all patches by hand. It's now done. | 06:52 |
| chriadam | looking at the diff, there seem to be some code changes (e.g. around 2124). is that just that gitlab isn't displayign it properly? | 06:52 |
| chriadam | also e.g. 1675 | 06:52 |
| chriadam | to me it seems like the "actual" change is line 1488 and 1492, returning Success instead of Failure if the account doesn't exist | 06:53 |
| chriadam | ah, I see. the "other" changes are just coloured mostly wrongly by gitlab - it was just enclosing string in QLatin1String() etc, and removing a whitespace | 06:54 |
| chriadam | although lin 986 looks a bit strange, might just be gitlab rendering the indentation wrongly | 06:55 |
| dcaliste | Looking at it again, yes, there is an empty line change and a QLatin1String. I don't remember why I let these pass inside... | 06:58 |
| chriadam | well, doesn't matter about those. but I do wonder about line 986 | 06:58 |
| dcaliste | Looking at it. | 06:58 |
| dcaliste | Looking at the after MR version of the patch, it looks consistent, but I cannot figure out why there is this diff. | 07:04 |
| dcaliste | I'm going to generate the real code diff, before old patch applied and after new patch. Give me a minute. | 07:04 |
| chriadam | sure, thanks | 07:05 |
| dcaliste | I've created a branch 'old' in QMF/upstream, set it to origin/master and applied with 'git am' the patch 0004. | 07:11 |
| dcaliste | Then, I've checked out the master branch and applied the new patch 0004. | 07:12 |
| dcaliste | I've just sent you by email the diff of the two branches. | 07:12 |
| chriadam | cheers | 07:13 |
| dcaliste | I've no idea how all these diffs are coming from in the diff of the two 0004 patches. | 07:13 |
| chriadam | well, that realDiff looks clean and simple enough ;-) | 07:14 |
| chriadam | ok, LGTM unless pvuorela or flypig have some comments on that (messagingframework#39) | 07:14 |
| chriadam | I briefly discussed the libcommhistory change with Bea - she mentioned that there currently is inheritance used to share code, in a case where it's not strictly an "IS-A" relationship, was wondering if that shared code could be refactored out somehow so it could be shared without requiring inheritance | 07:15 |
| dcaliste | Well, I'm wondering if we're not actually in the "IS-A" case indeed: | 07:17 |
| dcaliste | (let me open those files again) | 07:17 |
| dcaliste | - the leaf class is SingleContactEventModel, which is a | 07:18 |
| dcaliste | - RecipientEventModel also (added by the patch, but can be skipped), which is a | 07:19 |
| dcaliste | - EventModel which itself is a | 07:19 |
| dcaliste | - QAbstractItemModel | 07:19 |
| chriadam | oh, I see she already commented on the bug, and you discussed with her a bit | 07:19 |
| chriadam | ok, in that case I guess there is only the api function naming to be discussed. I wonder if pvuorela has some more comments about that or not | 07:20 |
| chriadam | I don't have strong feelings either way | 07:20 |
| dcaliste | I guess the main issue is that the leaf class (single contact) is having already an API with Recipient as argument. | 07:20 |
| dcaliste | So adding the intermediate recipient class with a logical Recipient API is shadowed by this already existing API. | 07:21 |
| dcaliste | And then in the QML bindings, we're dealing with instance of the leaf class only to save memory since a single contact model is also a recipient model. | 07:22 |
| dcaliste | And when we want to make this instance behave actually like a recipient model and not like a single contact model, then, we need to poke the parent method explicitly because of the shadowing. | 07:23 |
| dcaliste | This last call makes us wonder if the inheritence is indeed the right way. | 07:24 |
| dcaliste | I'm far from being an expert in C++, so I don't have strong feeling about this. | 07:25 |
| chriadam | I added a comment, hopefully I didn't misunderstand the context | 07:28 |
| chriadam | but I personally am fine with the current PR so long as the semantics are clearly documented so that it can be maintained and modified in future etc. | 07:28 |
| chriadam | but I haven't had anything to do with libhcommhistory really, so blam and pvuorela are better ot review :-/ | 07:28 |
| chriadam | I will poke Pekka about it later this week :-) | 07:29 |
| chriadam | thank you for the in-depth explanation | 07:29 |
| dcaliste | Ok, thank you chriadam. | 07:29 |
| chriadam | did you have anything else to discuss this week? | 07:30 |
| dcaliste | I will add a comment in the QML call if we decide to keep it like that to explain why we need to actually call the parent method explicitely. | 07:30 |
| dcaliste | About the timezone renaming we discussed last week, I forgot to do it, so I will this week. | 07:31 |
| dcaliste | Even today, I guess. | 07:31 |
| chriadam | no worries, no rush, thanks | 07:31 |
| dcaliste | Then, it will remain a blocker in the UI part in the timezone component. | 07:31 |
| chriadam | I believe that Pekka was hoping to merge those this week, but will double check | 07:32 |
| dcaliste | When using the search and clearing it, the items are scrolled up, which is very ugly. | 07:32 |
| dcaliste | I'm discussing it with pvuorela on bitbucket, but I cannot find a solution. | 07:32 |
| dcaliste | The problem comes from the fact that the header of the QML List is changing height. | 07:32 |
| chriadam | which PR? I will ping Bea as well | 07:33 |
| dcaliste | In that case, the header is scrolled upward to keep the items on position. | 07:33 |
| dcaliste | it's !38 in component timezone. | 07:33 |
| chriadam | thanks | 07:34 |
| dcaliste | The problem is that I'm packing conceptually two items (UTC and no time zone) in the header, because they don't belong to the time zone model. | 07:34 |
| dcaliste | After that, just remains !264 in calendar repo, about renaming the time labels for multi day events. | 07:36 |
| chriadam | yeah, I saw that. I pinged Martin about it, Pekka said that he had shown Martin. I'm not sure whether he had given green light here or not, or what is happening | 07:37 |
| chriadam | will poke again :-) | 07:37 |
| dcaliste | Ok, it's in the pipes. So far so good ! | 07:37 |
| dcaliste | Thank you for caring also. | 07:37 |
| dcaliste | I think that's all for today. Thanks for the discussion and your mentoring work. | 07:38 |
| chriadam | thanks for your hard work - really great to have you contribute these improvements. | 07:38 |
| chriadam | thanks again, and have a great week! | 07:38 |
| dcaliste | Have a nice week too. | 07:38 |
| OutBackDingo | cant install aptoid ... is it a known issue ? | 08:53 |
| *** vilpan is now known as Guest53345 | 09:04 | |
| OutBackDingo | odd seems no Adroid Support showing on my phone in jolla store for purchased rom | 09:10 |
| OutBackDingo | how can i fix | 09:10 |
| r0kk3rz | OutBackDingo: used same jolla account? | 09:11 |
| *** Guest53345 is now known as vilpan | 09:11 | |
| OutBackDingo | yes | 09:40 |
| r0kk3rz | maybe pketo can check it for you | 09:41 |
| OutBackDingo | opened a ticket, seems i bought a license for Xperia 10 but phone is XA2 Plus, they will fix | 09:41 |
| r0kk3rz | oh yeah, that will do it | 09:41 |
| OutBackDingo | at least its resolvable | 09:41 |
| OutBackDingo | have to say, sailfish is pretty nice, be nicer once i get whatsapp and zalo install from aptoid | 09:42 |
| *** frinring_ is now known as frinring | 10:13 | |
| Dingo007 | wow acrually works | 12:06 |
| piggz | attah: great job on 0.5.2 | 17:31 |
| attah | piggz: thanks, hope that was the worst of it | 17:33 |
| piggz | attah: well, you could add all sorts of properties, different margins for each side, duplex ... :D | 17:36 |
| attah | hey! xD | 17:37 |
| piggz | attah: oh, and in answer to you question, my printer does claim to support urf-raster | 17:41 |
| piggz | s/pwg-raster | 17:42 |
| piggz | urf, jpeg and octet-stream | 17:42 |
| attah | I have forgotten exactly why i was wondering :P but i have a bit of poor coverage on testing pwg raster, as my good printer only supports urf | 17:44 |
| attah | and generally i'm curious how resizing to raster works with borderless | 17:44 |
| attah | but no hurry, just remember i'm interested in feedback | 17:45 |
| attah | Currently my cheapo printer prints slightly corrupted on both raster formats, but i'm sure it worked before, and both the good printer and "rasterview" has no issues | 17:47 |
| attah | abranson: there are rumors that you still have trouble printing... anything in particular, or altogether? | 17:54 |
| abranson | attah: haven't had chance to look into it sorry. i always get a failure unless i have the media-col forced, but then it seems to think it's successful, the printer wakes up and shows 'printing' for a moment, but nothing happens and it goes back to standby | 18:08 |
| attah | Hmm, okay... that's to bad. No worries tho, write an issue or reopen something when/if you have more logs, time etc. | 18:11 |
| attah | I don't have much in the way of trouble shooting hints, but a super brief description of ipptool can eb fond via this issue https://github.com/attah/harbour-seaprint/issues/26 | 18:12 |
| attah | And this is for printing images as jpegs, or in general? | 18:13 |
| abranson | i thought it was everything, but i think just jpegs | 18:47 |
| abranson | from a quick console watch it looks like pdfs fail conversion | 18:47 |
| attah | and you have poppler-utils i assume? | 18:48 |
| attah | well, it shouldn't allow you to proceed if you don't, but still | 18:48 |
| abranson | yeah | 18:52 |
| attah | mind pasting the logs? | 18:52 |
| abranson | https://pastebin.com/Mp32qS7b | 18:56 |
| attah | thanks | 18:56 |
| attah | conveinient with a googlable document, so i can test here too | 18:58 |
| attah | I see, it has mixed page sizes... this will be interestng, i only did one such test | 19:00 |
| attah | Yeah, seems i have some ways left to go with coercing mixed-size pdfs to be more uniform :/ | 19:08 |
| piggz | abranson: perhaps try something simpler :D | 20:25 |
| abranson | piggz: that was all I had on my phone :) | 20:31 |
| attah | i must have printed 30 copies of the schedule for day one of 35c3 by now... "1.pdf" | 20:32 |
| attah | Here are the 2019 schedules https://fahrplan.events.ccc.de/congress/2019/Fahrplan/ | 20:33 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!