Tuesday, 2021-12-28

riniguspiggz: notification was added to that PR. hopefully, it is OK now :)09:37
*** ggabriel is now known as Guest946611:25
riniguspiggz: I'll revise tokens injection - it fails to build as it is15:00
rinigusalso need to extend support for multiple gitlab instances15:00
piggzrinigus: evening17:02
riniguspiggz: evening!17:02
rinigusjust replied to your comment at github17:03
piggzrinigus: ok ... what aboue hiding categories that are empty?17:07
riniguspiggz: possible, but would require some scanning of all packages. then probably we need to shift category model to C++ and generate it there17:08
rinigusalternative is to grow the store and fill it up in all categories :)17:09
piggzrinigus: ok, lets leave as-is for now, maybe if it bugs me we can change it17:09
riniguspiggz: we could revise categories according to the apps we have or expect to have. accessibility is rather small in the official store - maybe it should go17:11
rinigusI guess we will get better idea when packages get updated and put into categories17:11
piggzyeah ... i feel we should release soon now, and start getting submissions with the metadata17:12
riniguspiggz: have the same feeling. I am now on tokens and gitlab multiple instances support and maybe we should polish just a bit. fix about page, add icon to cover page, and maybe we could fix listing of packages (issue #26).17:14
rinigusbut 26 could take a bit of time. gitlab/tokens I plan to fix soon (today probably)17:15
riniguspiggz: but we can release earlier as well. just tokens are critical as we need it to get build working on OBS.17:18
riniguspiggz: tokens/gitlab are ready for submission. should I merge categories, rebase tokens/gitlab and submit PR?17:22
piggzrinigus: yes, add other too17:22
riniguspiggz: right, will do. will have a break for ~1h and then will add others, merge, and make PR for tokens/gitlab handling. should all land in <2h17:25
piggzrinigus: i think some strings need added18:22
riniguspiggz: not sure I follow. let me submit token/gitlab PR and I can try to understand what you mean18:24
piggzrinigus: here, man pages shows "chum-categories" and "chum-available-apps"18:24
riniguspiggz: hmm, I'll take a look. I wonder if I messed it up as there were some strange warnings on some point from lupdate18:28
piggzrinigus: there are a number of validation failures if you were interested in getting it into the main store18:33
riniguspiggz: I suspect we will fail on leaving chum repo installed after removal of the app as we will not be allowed to run cleanup postun scripts for store. kind of hard to break that without exceptions from Jolla18:35
piggzrinigus: wil also fail on linking packagekit, yaml, ssu, sandboxing and privilieges file18:36
piggzso, will just have to put on openrepos18:37
riniguspiggz: submitted PR that should fix building at OBS with tokens.18:38
rinigusas for openrepos, sure, we can add it there18:38
riniguspiggz: reproduced your issue with strings18:40
piggzrinigus: also the category strings..18:40
riniguspiggz: I have only category strings and one missing on main page - chum-categories.18:41
rinigusspoke too soon - several others in addition18:41
riniguspiggz: to update strings, run "touch src/*.cpp qml/*qml qml/*/*qml" and rebuild after that. our TS was newer than the code and was not rebuilt due to that18:47
rinigusthere are few places where we specified strings without IDs, I'll fix that as well to have it all uniform.18:48
piggzrinigus: yeah, i just built the gitlab-2 branch and now strings are working18:49
piggzrinigus: wondering if you think search box should hve focus by default?19:28
piggzalso, ive never used this ID based translation19:29
piggzmaybe i should start19:29
riniguspiggz: re translations - haven't done that either. unfortunately, I don't know why it is so much better - more to write in the code19:31
riniguspiggz:  re search by default: hard to say. if there are many packages, it makes sense. for small number not so much...19:32
piggzmaybe default in the all-apps page then?19:33
riniguspiggz: yes, maybe we should do that. I wonder if we should enable based on number of packages or hard code it for some pages19:34
riniguspiggz: looking at https://build.sailfishos.org/package/show/sailfishos:chum:testing/sailfishos-chum-gui . I think yaml-cpp has to be fixed before we can release.19:37
rinigusother issues less critical for the next release. although manual repo setting is of great interest to cbeta, as you explained19:37
piggzrinigus: im off for a swim (like an 8km fell run wasnt enough today :D ) ... ill try to look at some issues when i get back19:39
piggzyaml-cpp is a tough one19:39
piggzwe could build it in chum for <= 3.3, but that wont help us really19:39
riniguspiggz: I'll finish soon.19:40
rinigusif we build yaml-cpp for older sfos I think we should be fine19:40
riniguslooks like 3.4 is the last missing one19:41
riniguspiggz: why don't you think it will not help?19:41
riniguspiggz: https://github.com/sailfishos/yaml-cpp should work, I guess. will add it to chum:testing and disable for all versions except older ones19:42
piggz[m]rinigus: because there is a catch-22, where, the GUI is responsible for adding the repo ... i guess we could give users of older versions instructions on adding the repo the old way21:36
riniguspiggz: we have that page from which users can download gui directly. I think it is even automatically figures out rpm version of gui21:41
piggz[m]rinigus: sure, but without the repo, the gui wont work21:43
piggz[m]so, if we remove the dep for the repo rpm from the GUI, you cant just install the GUI and have it work21:43
riniguspiggz: why? It should now as gui adds repo by itself via ssu21:47
piggzrinigus: ah, yaml-cpp is static?21:48
piggzin that case, should be fine21:48
riniguspiggz: ahh, forgot about yaml... Have to check21:49
riniguspiggz: Nope, it is a dependency after build, judging by 3.4 build. We could bundle it then for old sfos versions :)21:52
piggz[m]rinigus: i was reading ... default is for it to build a static lib, so maybe we can just static link if that version is built on current releases21:53
riniguspiggz: static could be good as well. I am off to sleep, will catch up tomorrow.21:55

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!