| rinigus | piggz: notification was added to that PR. hopefully, it is OK now :) | 09:37 |
|---|---|---|
| *** ggabriel is now known as Guest9466 | 11:25 | |
| rinigus | piggz: I'll revise tokens injection - it fails to build as it is | 15:00 |
| rinigus | also need to extend support for multiple gitlab instances | 15:00 |
| piggz | rinigus: evening | 17:02 |
| rinigus | piggz: evening! | 17:02 |
| rinigus | just replied to your comment at github | 17:03 |
| piggz | rinigus: ok ... what aboue hiding categories that are empty? | 17:07 |
| rinigus | piggz: possible, but would require some scanning of all packages. then probably we need to shift category model to C++ and generate it there | 17:08 |
| rinigus | alternative is to grow the store and fill it up in all categories :) | 17:09 |
| piggz | rinigus: ok, lets leave as-is for now, maybe if it bugs me we can change it | 17:09 |
| rinigus | piggz: we could revise categories according to the apps we have or expect to have. accessibility is rather small in the official store - maybe it should go | 17:11 |
| rinigus | I guess we will get better idea when packages get updated and put into categories | 17:11 |
| piggz | yeah ... i feel we should release soon now, and start getting submissions with the metadata | 17:12 |
| rinigus | piggz: have the same feeling. I am now on tokens and gitlab multiple instances support and maybe we should polish just a bit. fix about page, add icon to cover page, and maybe we could fix listing of packages (issue #26). | 17:14 |
| rinigus | but 26 could take a bit of time. gitlab/tokens I plan to fix soon (today probably) | 17:15 |
| rinigus | piggz: but we can release earlier as well. just tokens are critical as we need it to get build working on OBS. | 17:18 |
| rinigus | piggz: tokens/gitlab are ready for submission. should I merge categories, rebase tokens/gitlab and submit PR? | 17:22 |
| piggz | rinigus: yes, add other too | 17:22 |
| rinigus | piggz: right, will do. will have a break for ~1h and then will add others, merge, and make PR for tokens/gitlab handling. should all land in <2h | 17:25 |
| piggz | rinigus: i think some strings need added | 18:22 |
| rinigus | piggz: not sure I follow. let me submit token/gitlab PR and I can try to understand what you mean | 18:24 |
| piggz | rinigus: here, man pages shows "chum-categories" and "chum-available-apps" | 18:24 |
| piggz | s/main | 18:27 |
| rinigus | piggz: hmm, I'll take a look. I wonder if I messed it up as there were some strange warnings on some point from lupdate | 18:28 |
| piggz | rinigus: there are a number of validation failures if you were interested in getting it into the main store | 18:33 |
| rinigus | piggz: I suspect we will fail on leaving chum repo installed after removal of the app as we will not be allowed to run cleanup postun scripts for store. kind of hard to break that without exceptions from Jolla | 18:35 |
| piggz | rinigus: wil also fail on linking packagekit, yaml, ssu, sandboxing and privilieges file | 18:36 |
| piggz | so, will just have to put on openrepos | 18:37 |
| rinigus | piggz: submitted PR that should fix building at OBS with tokens. | 18:38 |
| rinigus | as for openrepos, sure, we can add it there | 18:38 |
| rinigus | piggz: reproduced your issue with strings | 18:40 |
| piggz | rinigus: also the category strings.. | 18:40 |
| rinigus | piggz: I have only category strings and one missing on main page - chum-categories. | 18:41 |
| rinigus | spoke too soon - several others in addition | 18:41 |
| rinigus | piggz: to update strings, run "touch src/*.cpp qml/*qml qml/*/*qml" and rebuild after that. our TS was newer than the code and was not rebuilt due to that | 18:47 |
| rinigus | there are few places where we specified strings without IDs, I'll fix that as well to have it all uniform. | 18:48 |
| piggz | rinigus: yeah, i just built the gitlab-2 branch and now strings are working | 18:49 |
| piggz | rinigus: wondering if you think search box should hve focus by default? | 19:28 |
| piggz | also, ive never used this ID based translation | 19:29 |
| piggz | maybe i should start | 19:29 |
| rinigus | piggz: re translations - haven't done that either. unfortunately, I don't know why it is so much better - more to write in the code | 19:31 |
| rinigus | piggz: re search by default: hard to say. if there are many packages, it makes sense. for small number not so much... | 19:32 |
| piggz | maybe default in the all-apps page then? | 19:33 |
| rinigus | piggz: yes, maybe we should do that. I wonder if we should enable based on number of packages or hard code it for some pages | 19:34 |
| rinigus | piggz: looking at https://build.sailfishos.org/package/show/sailfishos:chum:testing/sailfishos-chum-gui . I think yaml-cpp has to be fixed before we can release. | 19:37 |
| rinigus | other issues less critical for the next release. although manual repo setting is of great interest to cbeta, as you explained | 19:37 |
| piggz | rinigus: im off for a swim (like an 8km fell run wasnt enough today :D ) ... ill try to look at some issues when i get back | 19:39 |
| piggz | yaml-cpp is a tough one | 19:39 |
| piggz | we could build it in chum for <= 3.3, but that wont help us really | 19:39 |
| rinigus | piggz: I'll finish soon. | 19:40 |
| rinigus | if we build yaml-cpp for older sfos I think we should be fine | 19:40 |
| rinigus | looks like 3.4 is the last missing one | 19:41 |
| rinigus | piggz: why don't you think it will not help? | 19:41 |
| rinigus | piggz: https://github.com/sailfishos/yaml-cpp should work, I guess. will add it to chum:testing and disable for all versions except older ones | 19:42 |
| piggz[m] | rinigus: because there is a catch-22, where, the GUI is responsible for adding the repo ... i guess we could give users of older versions instructions on adding the repo the old way | 21:36 |
| rinigus | piggz: we have that page from which users can download gui directly. I think it is even automatically figures out rpm version of gui | 21:41 |
| piggz[m] | rinigus: sure, but without the repo, the gui wont work | 21:43 |
| piggz[m] | so, if we remove the dep for the repo rpm from the GUI, you cant just install the GUI and have it work | 21:43 |
| rinigus | piggz: why? It should now as gui adds repo by itself via ssu | 21:47 |
| piggz | rinigus: ah, yaml-cpp is static? | 21:48 |
| piggz | in that case, should be fine | 21:48 |
| rinigus | piggz: ahh, forgot about yaml... Have to check | 21:49 |
| rinigus | piggz: Nope, it is a dependency after build, judging by 3.4 build. We could bundle it then for old sfos versions :) | 21:52 |
| piggz[m] | rinigus: i was reading ... default is for it to build a static lib, so maybe we can just static link if that version is built on current releases | 21:53 |
| rinigus | piggz: static could be good as well. I am off to sleep, will catch up tomorrow. | 21:55 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!