Wednesday, 2021-12-29

piggzrinigus:looked at the yaml-cpp .spec and it specifies to build the shared version13:42
riniguspiggz: no wonder, as it is by Jolla. do you think it is a problem to bundle yaml-cpp lib, as I did in PR?13:44
piggzrinigus: i probably missed the PR ... you might not get much out of me for a few days, my brother and fmily are visiitng13:44
riniguspiggz: no problem - I will look into open issues and let's see how I can proceed. so far, many of them look to be possible to fix in parallel13:46
piggzrinigus: ive started on the manual version setting13:46
piggzrinigus: why all the this-> additions in  that PR?13:46
riniguspiggz: otherwise old C++ compiler starts complaining that this method is not accessible.13:47
riniguspiggz: got idea from
piggzrinigus: so, you end up with /usr/share/sailfishos-chum-gui/lib/ .... does the linker find it there?13:53
riniguspiggz: yes. and it is a good question. will have to test, just a minute13:54
piggzive nothing that old!13:55
Thaodanpiggz: if you set -rpath properly it does13:56
riniguspiggz: me neither.13:56
piggzThaodan: yeah, i was wondering if we would need to add that to the binary13:56
Thaodanhowever I wouldn't bundle if for newer version13:56
rinigusThaodan: how can I check rpath, if you remember from the top of your head13:57
ThaodanThat's how its done for libsailfishapp13:57
rinigusThaodan: re not bundling - you are right, I better add check for SFOS version and do that for older versions only. piggz, will work on that PR a bit and send you new message when ready13:58
piggzah, so we should be ok, we link sailfishapp13:58
riniguspiggz: but we use cmake :( . not sure it fixes rpath. I'll check in pure maps cmake code to see how it was added14:00
riniguspiggz and Thaodan: for cmake projects, rpath is set via cmake command. as in
riniguschecked before and after with readelf and ldd. result was as expected.14:15
rinigusnow would have to add check for SFOS version and bundle for older ones only14:16
Thaodanrinigus: Yeah libsailfishapp  has no cmake module so far14:53
riniguspiggz: PR should be ready now. had to include rpmlint config as well as otherwise errors were triggered on rpmlint stage15:31
riniguspiggz: thanks!18:56
piggzrinigus: crap, while working on PR, i hir ctrl-I on chum.cpp :/21:10
riniguspiggz: what does it do? (depends on editor, I presume)22:03
piggzrinigus: does all the auto-indenting...22:05
piggzi fixed it by doing a diff ignoring white space, then reverting, and applying the diff22:06
riniguspiggz: nasty22:06
riniguspiggz: I remember collectd switched to auto formatting for each commit using clang. that avoided such issues22:07
piggzrinigus: yes, its fair to say that chum.cpp is not intended the way qtcreator expects :D22:07
rinigusbut it does require some setup and I don't know how well it would work for qml22:08
riniguspiggz: I wouldn't mind re-formatting it and the rest to be as qtcreator expects. constantly have to adjust and it sometimes slipps22:08
piggzrinigus: yeah, im quite used to just hitting ctrl-a ctrl-i to fix all my formatting ... but only works if file is formatted like that initially22:09
riniguspiggz: we could run that auto-format of yours after PRs are done. just have to make it when we are both aware of it22:11
rinigusas-is, all my work is submitted now22:11
piggzrinigus: my PR is almost ready22:12
riniguspiggz: excellent! I will read it tomorrow morning. Already closed pc and going to sleep. We can merge those current PRs and then auto format whole project.22:21
rinigusWhat do you think?22:21
piggzrinigus: sure ... give it a good read ... seems to work ok for me22:21

Generated by 2.17.1 by Marius Gedminas - find it at!