Tuesday, 2022-01-25

* WoC G'Night07:17
dcalisteGood morning pvuorela, how are you ? Thank you for having merged the status PRs.07:51
pvuoreladcaliste: good morning!08:00
pvuoreladcaliste: the status thing was a nice improvement!08:00
dcalisteYes, could you review the Caldav associated PR ? It fiwes a problem I accidentaly introduced some commit ago and that I noticed when I received a cancellation (and thus worked on the status), see https://github.com/sailfishos/buteo-sync-plugin-caldav/pull/908:01
pvuorelasure. i'll try to get it reviewed, either myself or if flypig has any capacity.08:03
dcalisteIt's very simple : before the PR, cancelled events were deleted on sync. Now, the code to delete them is removed completely since we can display cancelled event. The bug was in the deletion code, so by removing it, we correct the bug ;)08:04
pvuorelayep, doesn't look like a big PR08:04
dcalisteThere is no issue with alarms for cancelled events since mKCal is already filtering out cancelled events when setting up alarms.08:05
pvuorelasee you got into adjusting mkcal like we discussed last time. briefly looking seems very nice.08:06
dcalisteYes, I still would like to check that there is no regression in timing, but besides that, you can already start looking at the changes when you have the time. I tried to limit as much as possible to expose sqlite3 objects between sqlitestorage and sqliteformat.08:07
dcalisteThe purpose (beside making API simpler) is to make functions in sqliteformat that are with minimal side effect. So later on we can rework the database schemes locally.08:09
dcalisteSpeaking about database, I need to document myself if creating additional tables for lists for a given entry (like alarms for instance : one component can have several alarms) and fetching them with several call to sqlite3_step in the list table is still the modern way of doing this kind of data layout.08:10
dcalisteAbout the DST MR in jolla-calendar (#298), I've finally opted for the trick to go backward one day to be able to play with time without the interference of the DST.08:19
dcalisteI think this MR is ready for a final review when jpetrell or yourself will have the time to.08:19
pvuorelasure. good.08:21
dcalisteThank you. I forgot to mention that upstream for KCalendarCore, they may agree with the change when listing occurrence disregarding the status, see https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/84#note_38192808:23
dcalisteI'm still a bit reluctant to push changes there that may affect KOrganizer without a clear "go ahead" !08:24
pvuorelaah, they woke up too :)08:24
dcalisteAnd I'm not that motivated to dive into KOrganizer code itself to apply the same changes we made in Sailfish…08:24
pvuorelawell, feels like they done a bad fix anyhow and maybe even the behavior is slightly wrong.08:27
dcalisteYep. I think I'll reply that I'm going to merge the PR if they don't oppose, and also to ping me if people from KOrganizer get issues from this patch.08:28
dcalisteWhen in, I'll update the packaging in SailfishOS.08:29
dcalisteHere is the message upstream telling I'll merge on Thursday if they don't oppose to it : https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/84#note_38507708:35
dcalisteOk, thank you pvuorela, I think that's all for today. I'll try to finish the corrections jpetrell asked on the sync issue resolution various PRs this week.08:37
dcalisteThank you for your comment on the DST PR, I'm updating it accordingly.08:40
pvuoreladcaliste: thank you too!08:43
*** Mikaela is now known as Guest57618:40

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!