Tuesday, 2022-02-22

dcalisteGood morning, pvuorela. How are you ?08:00
pvuoreladcaliste: hi, i'm good. hope you had a nice vacation.08:02
dcalisteIt was great, thanks. Thanks for your comments on https://github.com/sailfishos/buteo-sync-plugin-caldav/pull/1008:03
dcalisteI've capitalised the globals, and rework the incidenceHrefUri() routine.08:04
dcalisteAs commented there, the latter required to rework some of the code path logic in the delta calculation.08:04
pvuorelagood, i'll need to check that again. the nemo-calendar side seemed good08:04
dcalisteHopefully, I've done it right, but I need to test it abit further.08:04
dcalisteI'll address your comments in jolla-calendar#312 later today or tomorrow, I think. I agree that overwrite should be clearer than reset.08:07
dcalisteI spoke to you last time that I wanted to replace the structure duplication from nemo-qml-plugin-calendar by using directly KCalendarCore::Incidence as a storage structure.08:08
dcalisteDoing so, I notice some possible changes that could be done disregarding storage structure that could simplify the code.08:09
dcalisteThe first PR is this one : https://github.com/sailfishos/nemo-qml-plugin-calendar/pull/2508:09
dcalisteIt is factorising and providing a base interface for structures that share Event characteristics.08:10
dcalisteWhat do you think of the intent ?08:10
pvuorelathat's so new i only managed to superficially check it. but at least no objections so far :)08:11
dcalisteSure, I'm not asking for full review already !08:14
dcalisteI'm preparing another change in nemo-qml-plugin-calendar about the replaceOccurrence() from EventModification(). It is doing some async calls at the moment, requiring some code to get the recurringId when done and propagate it to the query in the UI.08:16
dcalisteAfter analysing it, I think it can be simplified. The blocking part is the save part, but not the dissociateSingleOccurrence part.08:16
dcalisteSo the dissociation could be done first and in sync, which would give the recurringId immediately. And the save() can be done by the normal save() routine with minimal changes.08:17
dcalisteThis is also closer to the spirit of how it was designed in KCalendarCore and would simplify the transition to KCalendarCore strutures.08:18
dcalisteI think I'll make the PR later today or tomorrow. I need to check various things further.08:19
dcalisteIt is breaking the API though :/ and will require a minor change in the UI part (simplification in fact because there is no async fetch of recurringId anymore).08:20
pvuorelasure, but no api stability promises here.08:21
dcalisteDo you know if Martin had time to make progress on calendar UI adjustments for weekview ?08:26
dcalisteNo pressure intented, I understand there are may other things he has to work on !08:27
pvuorelaat some point he got back to it for a while but then had to again switch to different things.08:27
Mister_Magisterrinigus: ping08:28
pvuorelaand at this moment i know he's still busy with stuff :/08:28
dcalisteWell, that's good already that he gave some thoughts on the matter. It's the kind of thing that can work well in the background of the mind and work better then when you come back to it.08:30
dcalisteI think that's it for today. Thank you pvuorela for the discussion and your reviews and comments on PRs.08:36
pvuoreladcaliste: cheers :)08:37
*** v3r3mitz is now known as veremitz15:51
Mister_Magisterrinigus: man i need ya16:10
rinigusMister_Magister: evening16:14
Mister_Magisterrinigus: i was driving with puremaps and i have an issue. While puremaps gets the gps signal and shows my position, it keeps displaying the position as unknown and the navigation is not following my position16:15
rinigusMister_Magister: what's the error for position estimate? in meters?16:15
rinigussounds like it doesn't lock fully16:15
Mister_Magisterrinigus: i mean it updates the position perfectly fine, idk what error is i'm not sure how to check it even16:16
Mister_Magisterlike, if i update position manually it calculates it from my position16:17
Mister_Magisterbut then it doesn't update it16:17
rinigusMister_Magister: when you don't navigate, it will show the error (uncertainty) on the top right.16:17
riniguswhen UI elements overlay the map16:18
Mister_Magisteri will try16:18
riniguswhat do you mean by "if i update position manually". what kind of GPS is that where you enter position manually?16:18
Mister_Magisterrinigus: em when i reroute manually i mean16:21
rinigusplease check if it is locked. you could also check with gpsinfo app - it will show error as well16:24
rinigusMister_Magister: ^16:24
Mister_Magisteri mean if it wasn't locked it wouldn't update the position i imagine16:24
Mister_Magisterbut will do16:25
rinigusMister_Magister:  It is hard to judge whether it was updating with good precision (default is for under 15m, can be changed in settings) or it is something else. please check16:32
Mister_Magisterrinigus: will do17:09
Mister_Magisterrinigus: i'm happy to annouince that there is no precision18:35
rinigusMister_Magister: can you be specific and clear. which program was used to determined precision, what was a readout in that program. if you mean that there is no GPS lock, then state so.18:39
Mister_Magisterno like i said couple times already i have gps lock18:39
Mister_Magisterthere's no precision18:39
Mister_Magisterits not being reported18:39
Mister_Magisterneither in gps info, neither in puremaps18:39
rinigusMister_Magister: thanks, getting clearer now. part of getting GPS lock is getting estimation of precision. how many satellites does GPSInfo report as "locked"?18:41
Mister_Magisterthere is lock, position is being updated, both in gpsinfo and in puremaps, puremaps follows the position but doesn't update it in route and precision in both apps is not being reported at all18:41
Mister_Magisterif i didn't have lock the position wouldn't be updated18:41
Mister_Magisterand the gps icon turns from flashing to solid18:41
Mister_Magisterrinigus: pretty sure the gps has the precision its just not being reported back18:42
rinigusMister_Magister:  this 4 is in "use" and then are some more are in "view", right? using gpsinfo terms over here18:43
Mister_Magister20 in view 4 in use18:43
rinigusand "horizontal accuracy" is "-"?18:43
riniguswhat about "last update", does that get updated constantly?18:44
Mister_Magisterlike i said it has lock, position is being updated18:44
Mister_Magisterhecc puremaps follows the position18:44
rinigusthen you have to contact your porter. you know, it maybe Mister_Magister :)18:44
riniguswhich device is it?18:45
Mister_Magistermotorola moto g218:45
Mister_Magisterit's quite old and old base18:45
rinigusyour port, isn't it?18:45
Mister_Magisterrinigus: https://www.youtube.com/watch?v=1LVt49l6aP818:45
rinigusexactly :)18:46
Mister_Magisterrinigus: couldn't you just… not use the accuracy18:46
rinigushaven't had such issue and don't remember hearing about it. can you fix the port?18:46
Mister_Magisteri don't think port is broken18:47
Mister_Magistergps is perfectly fine, always has been18:47
rinigusaccuracy is needed - otherwise I cannot judge how far you are from the route. GPS is not fine without precision info18:47
rinigusif you wish, you can hack pure maps on your device and overwrite accuracy info18:48
Mister_Magisterwas fine till now huh18:48
Mister_Magisterill have a look18:48
Mister_Magisterbut if it requires me to update base, i'm not doing it18:48
rinigusno, I don't think that you need to update the base. I had it working also on older devices - pretty sure on onyx it was fine. mako - don't remember18:49
Mister_Magisterold device != old base18:50
riniguswhat's g2 base?18:51
rinigusMister_Magister: same as onyx18:54
rinigusMister_Magister: not porting info, so giving it here. as I had to wrap Qt positioning source in C++, it is not easy to overwrite from QML GPS precision info in pure maps. you would have to compile your own version if you need it. hopefully you can fix the port19:05
* Mister_Magister *grumble grumble* but the port is not broken *grumble grumble*19:05
Mister_Magisterrinigus: imo you should ignore precision if its null19:06
rinigusMister_Magister: no, I cannot. as soon as you enter a tunnel or data is not as clean as before it would play a role in navigation. pure maps has to figure out whether you have to be rerouted, whether you reached your intermediate destination and it can be chalked off the list. so, no - the precision is a part of the data that is needed19:08
* Mister_Magister *grumble grumble* previously it wasn't needed19:08
Mister_Magisterrinigus: https://github.com/mer-hybris/geoclue-providers-hybris/blob/master/hal/hallocationbackend.cpp#L6919:19
Mister_Magisteraccuracy is optional19:19
Mister_Magisterit's not mandatory nor required19:19
Mister_Magisteryou should not require accuracy19:19
rinigusMister_Magister: see my reply above. for navigation it is needed19:24
Mister_Magisternot really19:24
Mister_Magisterif it was needed it wouldn't be optional19:24
Mister_Magisterandroid navigations somehow work without it19:25
piggzits optional, if you dont want navigation19:25
Mister_Magisterno… it's optional with navigation19:25
Mister_Magisterandroid navigation apps work without it just fine19:25
Mister_Magisterpiggz: rinigus: https://developer.android.com/reference/android/location/Location#getAccuracy()19:30
Mister_MagisterIt's O P T I O N A L19:30
Mister_Magisterever since beginning of android navigation api19:30
rinigusMister_Magister: then check in android if you get precision from GPS. I am sure you do19:31
Mister_Magistermy android base literally doesn't report it, there is nothing to fix other than puremaps's code19:31
rinigusif user_id == Mister_Magister : set precision to 10m ?19:32
Mister_Magisterno? if precision is optional == don't use it?19:32
Mister_Magisterit's not "me" problem19:32
piggzMister_Magister: patch the plugin to fake the accuracy?19:33
Mister_Magisterpiggz: that's stupid. Don't fix symptoms, fix the source19:34
Mister_Magisterthe issue is puremaps doing something wrong19:34
Mister_Magisternot my device not having something that is optional19:34
rinigusMister_Magister: it is the first time I hear about device which does not report precision. usually, GPS starts reporting location which is very imprecise, then precision improves, then you get full lock.19:34
rinigusnow, if I return your statement - you should fix it in your source. :)19:35
rinigusas for android not reporting it - have you checked that your android base does not report GPS precision?19:35
Mister_Magisteri literally gave you link to android documentation stating that it's optional19:38
Mister_Magisterhere's sfos's code stating its optional19:38
Mister_Magisterif you are requiring something that is optional, you are doing mistake19:40
rinigusMister_Magister: it can be optional on Android or SFOS level, as people can use their device just to tag location. I don't think it is optional for navigation software. As for reasons, those are explained earlier19:40
piggzMister_Magister: it also says "All locations generated by the LocationManager include horizontal accuracy."19:40
Mister_Magisterbut it is optional for navigation software19:40
Mister_Magisternavigation software works just fine without it19:41
Mister_Magisterpiggz: true, it does19:41
rinigusMister_Magister: which navigation software works fine? does it have intermediate destinations, for example?19:42
Mister_Magisterinstalled the same base as the sfos uses19:55
Mister_Magisterif i get the accuracy in android then something is broken somewhere on sfos side19:55
Mister_Magisterrinigus: i got accuracy on 14.1 base19:56
Mister_Magisterso the gps CAN report it19:56
rinigusMister_Magister: but your base was 12.1, wasn't it?19:57
Mister_Magisteryep hence i'ms aying19:57
Mister_Magister[20:55] <Mister_Magister> installed the same base as the sfos uses19:58
Mister_Magisteras in im in process of checking19:58
rinigus(I am pretty sure all GPS do report accuracy) good luck with the check!19:58
Mister_Magistergood old cyanogenmod19:59
Mister_Magistergot the gps app, lets see20:01
Mister_Magisteralso there's no accuracy before fix20:01
rinigusMister_Magister: so, got the fix? what about precision?20:28
Mister_Magisterrinigus: its still getting the fix20:29
Mister_Magistergimme minute20:29
rinigus28 already given, one minute wouldn't hurt20:29
Mister_Magisterforgot android lacks multitasking and it doesn't get gps when screen is off20:30
Mister_Magisteri *might* not be able to get fix20:32
Mister_Magisterits been sitting on 4 satellites since like 5 mins20:33
Mister_Magisterrinigus: and the answer of the year is yes, it does have accuracy20:41
Mister_Magisterit's like 200m20:41
Mister_Magisterso ye geoclue is fing me20:42
Mister_Magisterill debug it some other day20:46
rinigusGood luck with it!20:51

Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!