*** amccarthy is now known as Guest4925 | 01:46 | |
*** amccarthy_ is now known as amccarthy | 01:46 | |
Miikasd | Is Tuesday some common day for Jolla to check the apps submitted to the harbour? Or just coincidence that two of my uploads has been checked in Tuesday :P | 07:55 |
---|---|---|
ViGe | It's just coincidence | 08:59 |
Miikasd | Ok. Thanks for clearing the queue before your vacation. I wish great vacation to whole team :) | 09:02 |
ViGe | thanks | 09:02 |
ViGe | now I realize that I should have written in the post that I will check the queue also tomorrow... I'll add an comment there. In case someone has some almost finished changes almost ready to be published | 09:03 |
attah | /home/mersdk/.mb2/wrappers/sailfish-boost/patch: Unsupported: Patch spans across git submodules :( | 09:13 |
poetaster | attah, you black magic practioniers. some of us rarely descend to the depths of sfdk, let alone mb2 ! | 09:19 |
attah | that is from a plain "sfdk prepare" | 09:20 |
poetaster | ah. shit | 09:20 |
attah | Which is about where my knowledge ends | 09:20 |
poetaster | well, maybe I can ask a question. I just fixed a build (badly) with target_link_directories(harbour-vipiano PUBLIC "${DEPS_DIR}/lib64") | 09:20 |
poetaster | what's the 'correct way to get the library suffix for cmake? | 09:21 |
ViGe | attah: There's this comment on the sources: "No submodule handling here - patches spanning multiple submodules are clearly a bad practice and as such completely unsupported!" | 09:22 |
attah | poetaster: does this help at all? https://github.com/sailfishos/calligra/commit/6fdd5ade1233f48c3421f29ae1b796962f7ab2ee | 09:22 |
attah | ViGe: uh-huh... but what does that mean for getting it building? | 09:23 |
ViGe | attah: I *think* it means that you need to split the patches so that you only patch one submodule per patch. Do you have the sources you are trying to build available somewhere, so I could try myself? | 09:24 |
attah | Just building latest Boost for SFOS, so i can update Poppler | 09:24 |
attah | Not even trying to update Boost (: | 09:25 |
poetaster | attah, thanks! | 09:25 |
ViGe | attah: why would you have to build it in order to update poppler? Boost is... well, challenging | 09:28 |
attah | artificially bumped requirement from upstream | 09:29 |
attah | the previous version in SFOS was.... "vintage" | 09:29 |
attah | But i guess i can just submit something that works with temporary changes (w.r.t. boost version), and leave final build to the pros | 09:32 |
ViGe | oh, we haven't made a sailfish os release since we updated boost | 09:38 |
attah | easy fix... just release more often ;) | 09:39 |
attah | https://github.com/sailfishos/poppler/pull/3 | 09:40 |
attah | I'm not so sure we actually use Splash though, and thus not see any gain from Boost | 09:42 |
attah | And they use like *one* class. I'd not pull in all that crap if it was my project... but i guess it really does matter for performance in some cases | 09:43 |
ViGe | attah: At least your poppler PR builds. How could I test that it actually works? | 09:53 |
attah | Install the packages, and open a PDF in office, and perhaps print one too | 09:53 |
attah | (that being poppler, poppler-glib, and poppler-qt5) | 09:55 |
ViGe | I don't currently have any devel devices at hand.. I need to flash one. But let's see if I manage to do that before my vacation starts :-P | 09:55 |
attah | I really meant to save work... bit it appears i might have done the opposite | 09:58 |
ViGe | Oh, I was mistaken, I *do* have my Xperia 10 II on devel, so this isn't actually that much work | 10:01 |
ViGe | attah: seems to be working | 10:07 |
attah | ViGe: Jaaay! | 10:08 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!