*** rainemak_ is now known as rainemak | 07:03 | |
mal | poetaster: hi, are you around? | 08:59 |
---|---|---|
poetaster | mal, yes. | 09:10 |
poetaster | just noted that ffmpeg won't build with --enable-libharfbuzz investigating. | 09:10 |
mal | poetaster: 6.1 introduced the harfbuzz option | 09:11 |
mal | we still have 5.1.x | 09:11 |
poetaster | mal, ah, nice to know the ffmpeg docs are uptodate. sigh. | 09:13 |
poetaster | mal, but isn't harfbuzz still required for drawtext? | 09:14 |
mal | https://github.com/FFmpeg/FFmpeg/commit/1eeb59a2099479eeead8cdc0d4586443fb301a8a | 09:14 |
poetaster | ok. back I go! Thanks! | 09:15 |
mal | poetaster: looking at that it working without it and harfbuzz is used to improve some things in it | 09:15 |
poetaster | mal, yes, it shouldn't be necessary for my use cases. If subpixel alignment stuff is required, it's probably not a job for the phone. | 09:16 |
mal | poetaster: check the other options related to that to see if anything else is useful | 09:16 |
mal | fribidi does something with drawtext also, no idea what | 09:17 |
poetaster | mal, I'd missed libfontconfig the first time, which I've added now. for font fallbacks. fribidi allows you to reshape fonts, I think. | 09:17 |
poetaster | text_shaping | 09:18 |
mal | we can enable harfbuzz once we update ffmpeg, I will probably have a look at that at somepoint, biggest annoyance is patching gecko to support new ffmpeg, usually just backporting but still | 09:20 |
poetaster | ah, I'd imagine gecko would be a pita. | 09:25 |
poetaster | mal, I'll drop the old PR and make a new one after getting a compile, or? Cleaner? | 09:26 |
mal | poetaster: you can just force push | 09:26 |
mal | no need to make a new PR | 09:26 |
poetaster | I did. Ok. | 09:26 |
mal | poetaster: did you mess up something, it still has the harfbuzz in the PR? | 09:28 |
poetaster | ah, reset head and now I think I need a new pr. | 09:28 |
mal | poetaster: no need | 09:28 |
mal | you can pick the changes from git reflog | 09:28 |
poetaster | I'm not sure how that works in the case where I've already force pushd ? | 09:29 |
poetaster | sorry, I think I did something else. odd. | 09:30 |
mal | ? | 09:31 |
mal | not sure what the problem is | 09:31 |
poetaster | he. well, it would help if I actually commit the change before getting all ... | 09:32 |
poetaster | there now. I'll test on obs. | 09:33 |
mal | I wonder if we should have --enable-libfontconfig if we have that as dependency? | 09:33 |
mal | probably will be automatically detected though | 09:33 |
poetaster | yeah, but, you're right. It doesn't hurt to do it explicitly. | 09:33 |
*** Venemo_ is now known as Venemo | 09:34 | |
mal | poetaster: thanks for fixing the PR, this was a good reminder to do test builds :) | 09:51 |
poetaster | heh :) thanks for looking at it! | 09:52 |
poetaster | mal, shouldn't be a biggy, but, I have 4.5.0.18 in the generic Meta on obs. | 09:54 |
mal | I built that in devel already :) | 09:55 |
poetaster | very good. I'm going to test on device and see if I have subtitles & text overlays ... | 09:56 |
mal | I'll wait for that test before merging | 10:01 |
poetaster | mal. Works! I have subtitles and generic text overlays. | 10:06 |
mal | cool | 10:09 |
poetaster | mal, and found the next bug ;-( | 10:09 |
mal | what is it? | 10:09 |
poetaster | mal, in videoworks, burn in method. Quick fix. Not ffmpeg. | 10:10 |
poetaster | mal, it's just the parameter passing. | 10:10 |
poetaster | mal, I recently pushd lame 3.100 to chum. do you think we could include --enable-libmp3lame for ffmpeg? I don't really have a need for it, but people still ask. | 14:42 |
mal | it there some benefit from that? | 14:43 |
mal | looks like mp3 encoding? | 14:44 |
poetaster | yes. lame, works, but not in the sailjail context. | 15:31 |
poetaster | mal, I'm trying to keep as close to the norm while still using ffmpeg. | 15:32 |
poetaster | mal, I'm looking at moving video/audioworks to pyav https://github.com/PyAV-Org/PyAV | 18:00 |
Generated by irclog2html.py 2.17.1 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!